From nobody Tue Feb 10 21:19:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1507336066500597.2250717006992; Fri, 6 Oct 2017 17:27:46 -0700 (PDT) Received: from localhost ([::1]:47735 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0cxy-0005Ho-LC for importer@patchew.org; Fri, 06 Oct 2017 20:27:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0cQI-0000Gc-Th for qemu-devel@nongnu.org; Fri, 06 Oct 2017 19:52:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0cQH-0006CH-J2 for qemu-devel@nongnu.org; Fri, 06 Oct 2017 19:52:54 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:34139) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0cQH-0006C3-DL; Fri, 06 Oct 2017 19:52:53 -0400 Received: by mail-qk0-x241.google.com with SMTP id b124so10272086qke.1; Fri, 06 Oct 2017 16:52:53 -0700 (PDT) Received: from yoga.lan ([181.93.89.178]) by smtp.gmail.com with ESMTPSA id g1sm1705226qta.95.2017.10.06.16.52.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Oct 2017 16:52:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v0c03LlLVTDKRVqufvOxdy1EDAej4sFIE2Oul3BvDZY=; b=Ou8mQxrrgN5cojJbYRpPHGyLOuKczBaAlYIqXzSGIhC76OOigZXEdZGoOzGikWYmPq 3dglgmCeimhhmY5YFnK9Xb8kl7/b0wWqBFwa5qAgNfupXZY3Rv/WGZoMWMS1i/6vHRRx rtSAN2fC4HJ7sLGLKngNIGTUu1ADlyjWplrmKnzOaro71IO7wsVJXEV19GkVkXV6syz1 RnNEdrZV8IlFL7Fp6YEXqFdnh36cHxmj8T/pv4Ecv7Gy19VA2yJXG1tblZPudaUcpbMx w4GQuee2BDC8dm/+VmyB3nkxwbFa55d1wvLl/yr5fptU6DA5klFwa3nM/80ILzUvmRou stYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=v0c03LlLVTDKRVqufvOxdy1EDAej4sFIE2Oul3BvDZY=; b=fVPjyqnEjJ6rKdHg0VIbF65sH33sMtQeSIcK5WmxKdEHSiaO8BmdfuHr4cuFDFT+8B uU7PB3p3a2uehnqa6ORicVNJ0QyocoWaLkY8cY2R3XcIe39T4zPMTHnvybuif2WTAqT+ Va4Cw7YU0l0mHoiz+rRau+uSlBkcYTwe7jWCAIcShCONbbHukSmlwyPFtcNSDz0NtzXS PUOQTA92rL1exIrA4aiNDFugXR7787V0Cf5y3bL7f7NnX4c0xaGEgy8OXxAhgfC75JWc QAor3XAUmSpwpimcwSPGrm33s/qz6YLNMC6/ruAqyv0KaCq4HTUMAdQKE98CKJRkd9Gz Twxg== X-Gm-Message-State: AMCzsaXsoXVYqnIAXblUa6/9o48yyGpCf4DnEI5F5OIEKc/tWa0lv8nb 70FGbNxk7gF5xn3vU8QliuI= X-Google-Smtp-Source: AOwi7QDZcy43WjUTBdCfZNXWJfbcPdewDhbhQOEP00Jgx5i/sk0TW2r6dvlhzUeDXbP4CWhWVUx4og== X-Received: by 10.55.122.130 with SMTP id v124mr698157qkc.209.1507333972818; Fri, 06 Oct 2017 16:52:52 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Markus Armbruster , Eric Blake , Stefano Stabellini , Anthony Perard , "Aneesh Kumar K.V" , Greg Kurz , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" Date: Fri, 6 Oct 2017 20:49:35 -0300 Message-Id: <20171006235023.11952-41-f4bug@amsat.org> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171006235023.11952-1-f4bug@amsat.org> References: <20171006235023.11952-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH 40/88] hw/xen: use g_new() family of functions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu trival , qemu-devel@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Marc-Andr=C3=A9 Lureau Signed-off-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Philippe Mathieu-Daud=C3=A9 [PMD: replaced g_new0() -> g_new() in xen_remap_bucket() (no bzero required= ), renamed X86 -> hw/xen and few other changes] Reviewed-by: Anthony PERARD --- hw/9pfs/xen-9p-backend.c | 2 +- hw/display/xenfb.c | 4 ++-- hw/i386/xen/xen-hvm.c | 10 +++++----- hw/i386/xen/xen-mapcache.c | 14 +++++++------- hw/xen/xen_pvdev.c | 2 +- 5 files changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c index ee87f08926..d76fa0df8e 100644 --- a/hw/9pfs/xen-9p-backend.c +++ b/hw/9pfs/xen-9p-backend.c @@ -365,7 +365,7 @@ static int xen_9pfs_connect(struct XenDevice *xendev) return -1; } =20 - xen_9pdev->rings =3D g_malloc0(xen_9pdev->num_rings * sizeof(Xen9pfsRi= ng)); + xen_9pdev->rings =3D g_new0(Xen9pfsRing, xen_9pdev->num_rings); for (i =3D 0; i < xen_9pdev->num_rings; i++) { char *str; int ring_order; diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index 8e2547ac05..5b5fa34131 100644 --- a/hw/display/xenfb.c +++ b/hw/display/xenfb.c @@ -479,8 +479,8 @@ static int xenfb_map_fb(struct XenFB *xenfb) n_fbdirs =3D xenfb->fbpages * mode / 8; n_fbdirs =3D DIV_ROUND_UP(n_fbdirs, XC_PAGE_SIZE); =20 - pgmfns =3D g_malloc0(sizeof(xen_pfn_t) * n_fbdirs); - fbmfns =3D g_malloc0(sizeof(xen_pfn_t) * xenfb->fbpages); + pgmfns =3D g_new0(xen_pfn_t, n_fbdirs); + fbmfns =3D g_new0(xen_pfn_t, xenfb->fbpages); =20 xenfb_copy_mfns(mode, n_fbdirs, pgmfns, pd); map =3D xenforeignmemory_map(xen_fmem, xenfb->c.xendev.dom, diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index d9ccd5d0d6..37a4e1cd6c 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -376,7 +376,7 @@ go_physmap: =20 mr_name =3D memory_region_name(mr); =20 - physmap =3D g_malloc(sizeof(XenPhysmap)); + physmap =3D g_new(XenPhysmap, 1); =20 physmap->start_addr =3D start_addr; physmap->size =3D size; @@ -1188,7 +1188,7 @@ static void xen_read_physmap(XenIOState *state) return; =20 for (i =3D 0; i < num; i++) { - physmap =3D g_malloc(sizeof (XenPhysmap)); + physmap =3D g_new(XenPhysmap, 1); physmap->phys_offset =3D strtoull(entries[i], NULL, 16); snprintf(path, sizeof(path), "/local/domain/0/device-model/%d/physmap/%s/start_addr", @@ -1240,7 +1240,7 @@ void xen_hvm_init(PCMachineState *pcms, MemoryRegion = **ram_memory) evtchn_port_t bufioreq_evtchn; XenIOState *state; =20 - state =3D g_malloc0(sizeof (XenIOState)); + state =3D g_new0(XenIOState, 1); =20 state->xce_handle =3D xenevtchn_open(NULL, 0); if (state->xce_handle =3D=3D NULL) { @@ -1321,7 +1321,7 @@ void xen_hvm_init(PCMachineState *pcms, MemoryRegion = **ram_memory) } =20 /* Note: cpus is empty at this point in init */ - state->cpu_by_vcpu_id =3D g_malloc0(max_cpus * sizeof(CPUState *)); + state->cpu_by_vcpu_id =3D g_new0(CPUState *, max_cpus); =20 rc =3D xen_set_ioreq_server_state(xen_domid, state->ioservid, true); if (rc < 0) { @@ -1330,7 +1330,7 @@ void xen_hvm_init(PCMachineState *pcms, MemoryRegion = **ram_memory) goto err; } =20 - state->ioreq_local_port =3D g_malloc0(max_cpus * sizeof (evtchn_port_t= )); + state->ioreq_local_port =3D g_new0(evtchn_port_t, max_cpus); =20 /* FIXME: how about if we overflow the page here? */ for (i =3D 0; i < max_cpus; i++) { diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c index baab93b614..93cba7fb83 100644 --- a/hw/i386/xen/xen-mapcache.c +++ b/hw/i386/xen/xen-mapcache.c @@ -109,7 +109,7 @@ void xen_map_cache_init(phys_offset_to_gaddr_t f, void = *opaque) unsigned long size; struct rlimit rlimit_as; =20 - mapcache =3D g_malloc0(sizeof (MapCache)); + mapcache =3D g_new0(MapCache, 1); =20 mapcache->phys_offset_to_gaddr =3D f; mapcache->opaque =3D opaque; @@ -165,8 +165,7 @@ static void xen_remap_bucket(MapCacheEntry *entry, =20 trace_xen_remap_bucket(address_index); =20 - pfns =3D g_malloc0(nb_pfn * sizeof (xen_pfn_t)); - err =3D g_malloc0(nb_pfn * sizeof (int)); + err =3D g_new0(int, nb_pfn); =20 if (entry->vaddr_base !=3D NULL) { if (!(entry->flags & XEN_MAPCACHE_ENTRY_DUMMY)) { @@ -180,6 +179,7 @@ static void xen_remap_bucket(MapCacheEntry *entry, g_free(entry->valid_mapping); entry->valid_mapping =3D NULL; =20 + pfns =3D g_new(xen_pfn_t, nb_pfn); for (i =3D 0; i < nb_pfn; i++) { pfns[i] =3D (address_index << (MCACHE_BUCKET_SHIFT-XC_PAGE_SHIFT))= + i; } @@ -212,8 +212,8 @@ static void xen_remap_bucket(MapCacheEntry *entry, entry->vaddr_base =3D vaddr_base; entry->paddr_index =3D address_index; entry->size =3D size; - entry->valid_mapping =3D (unsigned long *) g_malloc0(sizeof(unsigned l= ong) * - BITS_TO_LONGS(size >> XC_PAGE_SHIFT)); + entry->valid_mapping =3D g_new0(unsigned long, + BITS_TO_LONGS(size >> XC_PAGE_SHIFT)); =20 if (dummy) { entry->flags |=3D XEN_MAPCACHE_ENTRY_DUMMY; @@ -300,7 +300,7 @@ tryagain: pentry =3D free_pentry; } if (!entry) { - entry =3D g_malloc0(sizeof (MapCacheEntry)); + entry =3D g_new0(MapCacheEntry, 1); pentry->next =3D entry; xen_remap_bucket(entry, NULL, cache_size, address_index, dummy); } else if (!entry->lock) { @@ -334,7 +334,7 @@ tryagain: =20 mapcache->last_entry =3D entry; if (lock) { - MapCacheRev *reventry =3D g_malloc0(sizeof(MapCacheRev)); + MapCacheRev *reventry =3D g_new0(MapCacheRev, 1); entry->lock++; reventry->dma =3D dma; reventry->vaddr_req =3D mapcache->last_entry->vaddr_base + address= _offset; diff --git a/hw/xen/xen_pvdev.c b/hw/xen/xen_pvdev.c index aed783e844..8c1c14fb60 100644 --- a/hw/xen/xen_pvdev.c +++ b/hw/xen/xen_pvdev.c @@ -43,7 +43,7 @@ static void xenstore_cleanup_dir(char *dir) { struct xs_dirs *d; =20 - d =3D g_malloc(sizeof(*d)); + d =3D g_new(struct xs_dirs, 1); d->xs_dir =3D dir; QTAILQ_INSERT_TAIL(&xs_cleanup, d, list); } --=20 2.14.2