From nobody Tue Feb 10 22:17:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1507214583448699.98199291831; Thu, 5 Oct 2017 07:43:03 -0700 (PDT) Received: from localhost ([::1]:40218 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e07Mc-0007Y4-Op for importer@patchew.org; Thu, 05 Oct 2017 10:43:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e07Fy-0002Fx-L8 for qemu-devel@nongnu.org; Thu, 05 Oct 2017 10:36:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e07Fx-0001v6-Nj for qemu-devel@nongnu.org; Thu, 05 Oct 2017 10:36:10 -0400 Received: from mail-qt0-x22c.google.com ([2607:f8b0:400d:c0d::22c]:49147) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e07Fx-0001uQ-J5 for qemu-devel@nongnu.org; Thu, 05 Oct 2017 10:36:09 -0400 Received: by mail-qt0-x22c.google.com with SMTP id d13so25048010qta.5 for ; Thu, 05 Oct 2017 07:36:09 -0700 (PDT) Received: from bigtime.twiddle.net.com ([2606:a000:7a4a:b100::1b]) by smtp.gmail.com with ESMTPSA id c13sm8277148ywm.101.2017.10.05.07.36.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Oct 2017 07:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IlVJtg7jsV6bcBya3yYGZw68nCz70QiaFT1rPAbZNd4=; b=ZnIDtrm1myVKLWbRmdbYNqnvJCku+75vtiKCZp8xT0OC878JRmc5lhBdQ46Il4yJ1+ bmTP+nsonYDrB5cM7OZ64aAo37/zDRnRLBapjWBKvIOStbdPrEg3aVRco++hNLlB2Fdo h4pmgSiqV2Tly6sLF0SEYDEszaRUShNNVjVrc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IlVJtg7jsV6bcBya3yYGZw68nCz70QiaFT1rPAbZNd4=; b=Fn2VzsGw0Qb1c+eJfY58rt3FiUkT0nfTifCuOXzN0Ask95YPKcgrq0B/PMYLGj7N5h A7AposUDXmaQwn0FUeT70Awg4eDeHM+1biFi4YYSm6vyvAof1wDqiwr7VzdgTJsX9e8D UbHJivKo6Hs8fSzpvQI2bGUNzikKIPTTPf5uLrtECaHEjjRIAnezvZwyvXseFXdEvz/g 3aUKukFKps7bQojDmfUzGYKV70DGQWoFi+TWwUFujeRwJ4p+BF77mQA+WvEnZPu3+A2A wxUEpNqSwePVMcI/3nSiTtIVy84Cp8vbXnnQdW5wUjCEYQ+QfwcKWc3dmkZavLbroeSf +OQg== X-Gm-Message-State: AHPjjUjp6LUFxeuJUjMFAFQ9jhSCfm5Hx2rG6cNP8Er5mpQ5kMcL39a0 Wos07VUd3vNjZL736AYPL9dDu5wYpTs= X-Google-Smtp-Source: AOwi7QDTae0+LD7WbN5d6jOx2PAcZp+TVh/3l2sF0eKgug881cvhKT9KJ/3zA2BE1fW1K/XSL1Fgvw== X-Received: by 10.129.121.4 with SMTP id u4mr19889241ywc.71.1507214168693; Thu, 05 Oct 2017 07:36:08 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 5 Oct 2017 10:35:59 -0400 Message-Id: <20171005143601.21584-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171005143601.21584-1-richard.henderson@linaro.org> References: <20171005143601.21584-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::22c Subject: [Qemu-devel] [PATCH v2 2/4] tcg: Fix off-by-one in assert in page_set_flags X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, riku.voipio@iki.fi, Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Richard Henderson Most of the users of page_set_flags offset (page, page + len) as the end points. One might consider this an error, since the other users do supply an endpoint as the last byte of the region. However, the first thing that page_set_flags does is round end UP to the start of the next page. Which means computing page + len - 1 is in the end pointless. Therefore, accept this usage and do not assert when given the exact size of the vm as the endpoint. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20170708025030.15845-2-rth@twiddle.net> --- accel/tcg/translate-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 2d1ed06065..ebfc2e7024 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -2090,7 +2090,7 @@ void page_set_flags(target_ulong start, target_ulong = end, int flags) guest address space. If this assert fires, it probably indicates a missing call to h2g_valid. */ #if TARGET_ABI_BITS > L1_MAP_ADDR_SPACE_BITS - assert(end < ((target_ulong)1 << L1_MAP_ADDR_SPACE_BITS)); + assert(end <=3D ((target_ulong)1 << L1_MAP_ADDR_SPACE_BITS)); #endif assert(start < end); assert_memory_lock(); --=20 2.13.6