From nobody Mon Feb 9 18:59:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1507131853099935.9607538037554; Wed, 4 Oct 2017 08:44:13 -0700 (PDT) Received: from localhost ([::1]:35713 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzlq6-0003RC-7y for importer@patchew.org; Wed, 04 Oct 2017 11:44:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzloA-00026j-Fv for qemu-devel@nongnu.org; Wed, 04 Oct 2017 11:42:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzlo6-0003K4-NN for qemu-devel@nongnu.org; Wed, 04 Oct 2017 11:42:02 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:44164 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dzlo6-0003J6-Hb for qemu-devel@nongnu.org; Wed, 04 Oct 2017 11:41:58 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v94FdKfh112324 for ; Wed, 4 Oct 2017 11:41:56 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0b-001b2d01.pphosted.com with ESMTP id 2dcxvfe6cd-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 04 Oct 2017 11:41:56 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 4 Oct 2017 16:41:54 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 4 Oct 2017 16:41:53 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v94FfqAu14024866; Wed, 4 Oct 2017 15:41:52 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 84B564C040; Wed, 4 Oct 2017 16:37:58 +0100 (BST) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 519724C044; Wed, 4 Oct 2017 16:37:58 +0100 (BST) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 4 Oct 2017 16:37:58 +0100 (BST) From: Halil Pasic To: Cornelia Huck , "Dong Jia Shi" Date: Wed, 4 Oct 2017 17:41:40 +0200 X-Mailer: git-send-email 2.13.5 In-Reply-To: <20171004154144.88995-1-pasic@linux.vnet.ibm.com> References: <20171004154144.88995-1-pasic@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 17100415-0012-0000-0000-0000057E6D13 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17100415-0013-0000-0000-000018F7DC4D Message-Id: <20171004154144.88995-5-pasic@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-10-04_07:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710040220 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.158.5 Subject: [Qemu-devel] [PATCH v2 4/8] s390x: refactor error handling for XSCH handler X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Halil Pasic , Pierre Morel , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Simplify the error handling of the XSCH. Let the code detecting the condition tell (in a less ambiguous way) how it's to be handled. No changes in behavior. Signed-off-by: Halil Pasic --- hw/s390x/css.c | 17 +++++------------ include/hw/s390x/css.h | 2 +- target/s390x/ioinst.c | 23 ++++------------------- 3 files changed, 10 insertions(+), 32 deletions(-) diff --git a/hw/s390x/css.c b/hw/s390x/css.c index b2978c3bae..175624d1c8 100644 --- a/hw/s390x/css.c +++ b/hw/s390x/css.c @@ -1223,20 +1223,17 @@ out: return ret; } =20 -int css_do_xsch(SubchDev *sch) +IOInstEnding css_do_xsch(SubchDev *sch) { SCSW *s =3D &sch->curr_status.scsw; PMCW *p =3D &sch->curr_status.pmcw; - int ret; =20 if (~(p->flags) & (PMCW_FLAGS_MASK_DNV | PMCW_FLAGS_MASK_ENA)) { - ret =3D -ENODEV; - goto out; + return (IOInstEnding){.cc =3D 3}; } =20 if (s->ctrl & SCSW_CTRL_MASK_STCTL) { - ret =3D -EINPROGRESS; - goto out; + return (IOInstEnding){.cc =3D 1}; } =20 if (!(s->ctrl & SCSW_CTRL_MASK_FCTL) || @@ -1244,8 +1241,7 @@ int css_do_xsch(SubchDev *sch) (!(s->ctrl & (SCSW_ACTL_RESUME_PEND | SCSW_ACTL_START_PEND | SCSW_ACTL_SUSP)= )) || (s->ctrl & SCSW_ACTL_SUBCH_ACTIVE)) { - ret =3D -EBUSY; - goto out; + return (IOInstEnding){.cc =3D 2}; } =20 /* Cancel the current operation. */ @@ -1257,10 +1253,7 @@ int css_do_xsch(SubchDev *sch) sch->last_cmd_valid =3D false; s->dstat =3D 0; s->cstat =3D 0; - ret =3D 0; - -out: - return ret; + return (IOInstEnding){.cc =3D 0}; } =20 int css_do_csch(SubchDev *sch) diff --git a/include/hw/s390x/css.h b/include/hw/s390x/css.h index 2116c6b3c7..4c89d77893 100644 --- a/include/hw/s390x/css.h +++ b/include/hw/s390x/css.h @@ -212,7 +212,7 @@ void css_conditional_io_interrupt(SubchDev *sch); int css_do_stsch(SubchDev *sch, SCHIB *schib); bool css_schid_final(int m, uint8_t cssid, uint8_t ssid, uint16_t schid); int css_do_msch(SubchDev *sch, const SCHIB *schib); -int css_do_xsch(SubchDev *sch); +IOInstEnding css_do_xsch(SubchDev *sch); int css_do_csch(SubchDev *sch); int css_do_hsch(SubchDev *sch); IOInstEnding css_do_ssch(SubchDev *sch, ORB *orb); diff --git a/target/s390x/ioinst.c b/target/s390x/ioinst.c index 582287ff6c..85f5be6ca3 100644 --- a/target/s390x/ioinst.c +++ b/target/s390x/ioinst.c @@ -42,8 +42,6 @@ void ioinst_handle_xsch(S390CPU *cpu, uint64_t reg1) { int cssid, ssid, schid, m; SubchDev *sch; - int ret =3D -ENODEV; - int cc; =20 if (ioinst_disassemble_sch_ident(reg1, &m, &cssid, &ssid, &schid)) { program_interrupt(&cpu->env, PGM_OPERAND, 4); @@ -51,24 +49,11 @@ void ioinst_handle_xsch(S390CPU *cpu, uint64_t reg1) } trace_ioinst_sch_id("xsch", cssid, ssid, schid); sch =3D css_find_subch(m, cssid, ssid, schid); - if (sch && css_subch_visible(sch)) { - ret =3D css_do_xsch(sch); - } - switch (ret) { - case -ENODEV: - cc =3D 3; - break; - case -EBUSY: - cc =3D 2; - break; - case 0: - cc =3D 0; - break; - default: - cc =3D 1; - break; + if (!sch || !css_subch_visible(sch)) { + setcc(cpu, 3); + return; } - setcc(cpu, cc); + setcc(cpu, css_do_xsch(sch).cc); } =20 void ioinst_handle_csch(S390CPU *cpu, uint64_t reg1) --=20 2.13.5