From nobody Mon Feb 9 08:55:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@gnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@gnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1506631684361722.5667119652271; Thu, 28 Sep 2017 13:48:04 -0700 (PDT) Received: from localhost ([::1]:60813 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxfiw-000472-GD for importer@patchew.org; Thu, 28 Sep 2017 16:47:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxfYz-0003u1-IP for qemu-devel@nongnu.org; Thu, 28 Sep 2017 16:37:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxfYy-0003AU-SI for qemu-devel@nongnu.org; Thu, 28 Sep 2017 16:37:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52008) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dxfYy-0003A3-M5 for qemu-devel@nongnu.org; Thu, 28 Sep 2017 16:37:40 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B27B137E68; Thu, 28 Sep 2017 20:37:39 +0000 (UTC) Received: from t460s.redhat.com (ovpn-116-18.ams2.redhat.com [10.36.116.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 995056E506; Thu, 28 Sep 2017 20:37:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B27B137E68 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=david@redhat.com From: David Hildenbrand To: qemu-devel@nongnu.org Date: Thu, 28 Sep 2017 22:36:49 +0200 Message-Id: <20170928203708.9376-12-david@redhat.com> In-Reply-To: <20170928203708.9376-1-david@redhat.com> References: <20170928203708.9376-1-david@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 28 Sep 2017 20:37:39 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 11/30] s390x/kvm: pass ipb directly into handle_sigp() X-BeenThere: qemu-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, David Hildenbrand , cohuck@redhat.com, Richard Henderson , Alexander Graf , Christian Borntraeger Errors-To: qemu-devel-bounces+importer=patchew.org@gnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" No need to pass kvm_run. Pass parameters alphabetically ordered. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/kvm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c index 8dc82fbb59..43f8f7331a 100644 --- a/target/s390x/kvm.c +++ b/target/s390x/kvm.c @@ -1876,7 +1876,7 @@ static int sigp_set_architecture(S390CPU *cpu, uint32= _t param, return SIGP_CC_STATUS_STORED; } =20 -static int handle_sigp(S390CPU *cpu, struct kvm_run *run, uint8_t ipa1) +static int handle_sigp(S390CPU *cpu, uint8_t ipa1, uint32_t ipb) { CPUS390XState *env =3D &cpu->env; const uint8_t r1 =3D ipa1 >> 4; @@ -1890,7 +1890,7 @@ static int handle_sigp(S390CPU *cpu, struct kvm_run *= run, uint8_t ipa1) cpu_synchronize_state(CPU(cpu)); =20 /* get order code */ - order =3D decode_basedisp_rs(env, run->s390_sieic.ipb, NULL) + order =3D decode_basedisp_rs(env, ipb, NULL) & SIGP_ORDER_MASK; status_reg =3D &env->regs[r1]; param =3D (r1 % 2) ? env->regs[r1] : env->regs[r1 + 1]; @@ -1948,7 +1948,7 @@ static int handle_instruction(S390CPU *cpu, struct kv= m_run *run) r =3D handle_diag(cpu, run, run->s390_sieic.ipb); break; case IPA0_SIGP: - r =3D handle_sigp(cpu, run, ipa1); + r =3D handle_sigp(cpu, ipa1, run->s390_sieic.ipb); break; } =20 --=20 2.13.5