From nobody Mon Feb 9 01:16:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1506545001739195.7691302274302; Wed, 27 Sep 2017 13:43:21 -0700 (PDT) Received: from localhost ([::1]:56275 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxJAk-0001OO-0P for importer@patchew.org; Wed, 27 Sep 2017 16:43:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxJ9X-0000m2-Px for qemu-devel@nongnu.org; Wed, 27 Sep 2017 16:41:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxJ9X-0004DI-1b for qemu-devel@nongnu.org; Wed, 27 Sep 2017 16:41:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58782) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dxJ9W-0004Cv-RL for qemu-devel@nongnu.org; Wed, 27 Sep 2017 16:41:54 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D5EE613D9E8 for ; Wed, 27 Sep 2017 20:41:53 +0000 (UTC) Received: from localhost (ovpn-116-18.gru2.redhat.com [10.97.116.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 70AC37F92B; Wed, 27 Sep 2017 20:41:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D5EE613D9E8 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=ehabkost@redhat.com From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Wed, 27 Sep 2017 17:41:48 -0300 Message-Id: <20170927204148.2311-3-ehabkost@redhat.com> In-Reply-To: <20170927204148.2311-1-ehabkost@redhat.com> References: <20170927204148.2311-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 27 Sep 2017 20:41:53 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v3 2/2] vl: Print warning when a default config file is loaded X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" In case there were options set in the default config file, print a warning so users can update their scripts. If somebody wants to keep the config file as-is, avoid the warning and use a command-line that will work in future QEMU versions, they can use: $QEMU -no-user-config -readconfig /etc/qemu/qemu.conf I was going to add an additional message suggesting it as a solution, but I thought it could make it more confusing. The solution can be documented in the QEMU 2.11 ChangeLog. Reviewed-by: Markus Armbruster Signed-off-by: Eduardo Habkost --- Changes v2 -> v3: * Rebase (no code changes) * Commit message update: suggest -no-user-config --- vl.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/vl.c b/vl.c index 4fd01fda91..888649bbd1 100644 --- a/vl.c +++ b/vl.c @@ -3048,6 +3048,12 @@ static int qemu_read_default_config_file(void) return ret; } =20 + if (ret > 0) { + loc_set_none(); + error_report("Warning: Future QEMU versions won't load %s automati= cally", + CONFIG_QEMU_CONFDIR "/qemu.conf"); + } + return 0; } =20 --=20 2.13.5