From nobody Mon Nov 3 20:07:52 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505983994359266.41632134292865; Thu, 21 Sep 2017 01:53:14 -0700 (PDT) Received: from localhost ([::1]:52426 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duxEP-0006Ar-64 for importer@patchew.org; Thu, 21 Sep 2017 04:53:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duxCf-0004zI-N7 for qemu-devel@nongnu.org; Thu, 21 Sep 2017 04:51:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duxCe-0001Co-Q8 for qemu-devel@nongnu.org; Thu, 21 Sep 2017 04:51:25 -0400 Received: from ozlabs.ru ([107.173.13.209]:54112) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duxCe-0001CA-KD for qemu-devel@nongnu.org; Thu, 21 Sep 2017 04:51:24 -0400 Received: from vpl1.ozlabs.ibm.com (localhost [IPv6:::1]) by ozlabs.ru (Postfix) with ESMTP id 42EFD3A6004B; Thu, 21 Sep 2017 04:52:40 -0400 (EDT) From: Alexey Kardashevskiy To: qemu-devel@nongnu.org Date: Thu, 21 Sep 2017 18:50:55 +1000 Message-Id: <20170921085110.25598-4-aik@ozlabs.ru> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170921085110.25598-1-aik@ozlabs.ru> References: <20170921085110.25598-1-aik@ozlabs.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 107.173.13.209 Subject: [Qemu-devel] [PATCH qemu v5 03/18] memory: Move FlatView allocation to a helper X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexey Kardashevskiy , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This moves a FlatView allocation and initialization to a helper. While we are nere, replace g_new with g_new0 to not to bother if we add new fields in the future. This should cause no behavioural change. Signed-off-by: Alexey Kardashevskiy --- Changes: v3: * s/flatview_alloc/flatview_new/ --- memory.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/memory.c b/memory.c index 101d5f4d60..9babd7d423 100644 --- a/memory.c +++ b/memory.c @@ -258,12 +258,14 @@ static bool flatrange_equal(FlatRange *a, FlatRange *= b) && a->readonly =3D=3D b->readonly; } =20 -static void flatview_init(FlatView *view) +static FlatView *flatview_new(void) { + FlatView *view; + + view =3D g_new0(FlatView, 1); view->ref =3D 1; - view->ranges =3D NULL; - view->nr =3D 0; - view->nr_allocated =3D 0; + + return view; } =20 /* Insert a range into a given position. Caller is responsible for mainta= ining @@ -706,8 +708,7 @@ static FlatView *generate_memory_topology(MemoryRegion = *mr) { FlatView *view; =20 - view =3D g_new(FlatView, 1); - flatview_init(view); + view =3D flatview_new(); =20 if (mr) { render_memory_region(view, mr, int128_zero(), @@ -2624,8 +2625,7 @@ void address_space_init(AddressSpace *as, MemoryRegio= n *root, const char *name) as->ref_count =3D 1; as->root =3D root; as->malloced =3D false; - as->current_map =3D g_new(FlatView, 1); - flatview_init(as->current_map); + as->current_map =3D flatview_new(); as->ioeventfd_nb =3D 0; as->ioeventfds =3D NULL; QTAILQ_INIT(&as->listeners); --=20 2.11.0