From nobody Tue Feb 10 05:10:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505937230589414.9183811811906; Wed, 20 Sep 2017 12:53:50 -0700 (PDT) Received: from localhost ([::1]:50399 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dul49-00074C-Em for importer@patchew.org; Wed, 20 Sep 2017 15:53:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dul0R-0004GF-QE for qemu-devel@nongnu.org; Wed, 20 Sep 2017 15:50:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dul0P-00080s-VZ for qemu-devel@nongnu.org; Wed, 20 Sep 2017 15:49:59 -0400 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:37841) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dul0P-00080K-RK for qemu-devel@nongnu.org; Wed, 20 Sep 2017 15:49:57 -0400 Received: by mail-qk0-x243.google.com with SMTP id r66so2330044qke.4 for ; Wed, 20 Sep 2017 12:49:57 -0700 (PDT) Received: from yoga.offpageads.com ([181.93.89.178]) by smtp.gmail.com with ESMTPSA id i84sm1952792qkh.17.2017.09.20.12.49.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Sep 2017 12:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NH8TvAzvRl3fTHfE/31Bx3YX3regwTO6EcNX9WiRiOQ=; b=MOSzoF63mI1+Re9z4jz3qVekHL6IlLFzlVjZVNlGqTQ37IqHODt7tM9wOnBuDBwAh3 nh9mRkfJIW5Y2SmW8FBGGIYYpqhCQScam/8OFlleJMLY4a6P6y+AzY+lNtgQSHHqibRG h+guxeTnJs9G0j5yR1eRSmQnEWZ3Osl4KmCzoNngItFsaDm7C14w/OglG1/hZI0JRW0y ueXGtZmcXVi0HU9jCIedPLGr54I9dzj43xxS7tlxnIxjRzvdLX82qHspCWH/8M2FWutd HM01ffd5rkI2LhV2VkYeG23d9BS1PcviqJYE4EaU/PAYm5H81pc3bZXEjZOHxYfY23Ob eOVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=NH8TvAzvRl3fTHfE/31Bx3YX3regwTO6EcNX9WiRiOQ=; b=kB16iotOEkL0YXqbkZfnIpFFJLWIhs6vxS+XLFUmV7q+GYBMj2+gqL3F46TB0LdSiC IU5+GyiEXOrZO8375+ZVpQKdxp9XyKfIHaLYjvmRPu+iDMgYeKZnMGW0dJHustK+kHzq FagT/VxASnXWO2QAPeHfTem6yPjN2NK+8kAcYW48ZVl2oxZRAWe3c4kdWKNWtZiOrj+Q dmoakS81lWzXHDwxQ4an1phiIQ+YogtIDH2EERZGNESXk/nUuTYEE9vSz9+Nh3PcHWvv e9FQP2WIgr6SBN0aekYfUhEWv6Ug3ibUarSnIZ11eKlDUJmba8HtX+Kg2bh2tUuOnh+Z BFQQ== X-Gm-Message-State: AHPjjUh73qdZP0mPbmGaQ8vkEoPk7ZPzXiL71uk4S4zbzb/6iaScfSGp g/F9qs3rJR0TsgJmkIUsJuU= X-Google-Smtp-Source: AOwi7QBgHWKy6V5Ta59+1DLEcCf8s2Dbq/1IXAO7QduAU61CoKG6B3uRijIDdIq6shWIooybG4X3Yg== X-Received: by 10.55.154.2 with SMTP id c2mr8925622qke.4.1505936997346; Wed, 20 Sep 2017 12:49:57 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Igor Mammedov , Eduardo Habkost , Aurelien Jarno , Yongbok Kim , Marcel Apfelbaum Date: Wed, 20 Sep 2017 16:49:32 -0300 Message-Id: <20170920194934.23071-5-f4bug@amsat.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170920194934.23071-1-f4bug@amsat.org> References: <20170920194934.23071-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::243 Subject: [Qemu-devel] [PATCH v4 4/6] mips: call cpu_mips_realize_env() from mips_cpu_realizefn() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , James Hogan , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 This changes the order between cpu_mips_realize_env() and cpu_exec_initfn(), but cpu_exec_initfn() don't have anything that depends on cpu_mips_realize_env() being called first. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Igor Mammedov Tested-by: James Hogan Reviewed-by: Eduardo Habkost --- target/mips/cpu.c | 3 +++ target/mips/translate.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/mips/cpu.c b/target/mips/cpu.c index 68bf423e9d..e3ef835599 100644 --- a/target/mips/cpu.c +++ b/target/mips/cpu.c @@ -123,6 +123,7 @@ static void mips_cpu_disas_set_info(CPUState *s, disass= emble_info *info) { static void mips_cpu_realizefn(DeviceState *dev, Error **errp) { CPUState *cs =3D CPU(dev); + MIPSCPU *cpu =3D MIPS_CPU(dev); MIPSCPUClass *mcc =3D MIPS_CPU_GET_CLASS(dev); Error *local_err =3D NULL; =20 @@ -132,6 +133,8 @@ static void mips_cpu_realizefn(DeviceState *dev, Error = **errp) return; } =20 + cpu_mips_realize_env(&cpu->env); + cpu_reset(cs); qemu_init_vcpu(cs); =20 diff --git a/target/mips/translate.c b/target/mips/translate.c index 5fc7979ac5..94c38e8755 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -20535,7 +20535,6 @@ MIPSCPU *cpu_mips_init(const char *cpu_model) cpu =3D MIPS_CPU(object_new(TYPE_MIPS_CPU)); env =3D &cpu->env; env->cpu_model =3D def; - cpu_mips_realize_env(env); =20 object_property_set_bool(OBJECT(cpu), true, "realized", NULL); =20 --=20 2.14.1