From nobody Mon Feb 9 15:45:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505920206878602.3610126025536; Wed, 20 Sep 2017 08:10:06 -0700 (PDT) Received: from localhost ([::1]:48721 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dugdZ-00067S-Ta for importer@patchew.org; Wed, 20 Sep 2017 11:10:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dufmj-00042W-VN for qemu-devel@nongnu.org; Wed, 20 Sep 2017 10:15:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dufme-0005Mr-MX for qemu-devel@nongnu.org; Wed, 20 Sep 2017 10:15:29 -0400 Received: from ozlabs.ru ([107.173.13.209]:59844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dufme-0005M0-BF for qemu-devel@nongnu.org; Wed, 20 Sep 2017 10:15:24 -0400 Received: from vpl1.ozlabs.ibm.com (localhost [IPv6:::1]) by ozlabs.ru (Postfix) with ESMTP id 2C8ED3A60061; Wed, 20 Sep 2017 07:48:17 -0400 (EDT) From: Alexey Kardashevskiy To: qemu-devel@nongnu.org Date: Wed, 20 Sep 2017 21:46:37 +1000 Message-Id: <20170920114637.42004-19-aik@ozlabs.ru> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170920114637.42004-1-aik@ozlabs.ru> References: <20170920114637.42004-1-aik@ozlabs.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 107.173.13.209 Subject: [Qemu-devel] [PATCH qemu v4 18/18] memory: Give memory_region_transaction_commit a hint X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexey Kardashevskiy , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This extends memory_region_transaction_commit() to receive a MR as if it is a root MR or its topmost parent is, then we can only rebuild its FlatView and update it for address spaces sharing it. The optimization gets disabled though if there is full update about to commit. memory_region_set_enabled() is a special case here, it does not use a hint when MR is being disabled. On POWER8 with 255 CPUs, 255 virtio-net, 40 PCI bridges guest this brings down the boot time from 20s to 12s, the total memory footprint goes down (17G -> 8G). Signed-off-by: Alexey Kardashevskiy --- This is an RFC patch, I suppose. If memory_region_set_enabled() uses the hint all the time (like others), then 12s become 9s and memory use is about 4.4G but make check-qtest fails (no idea why): GTESTER check-qtest-ppc64 ** ERROR:/home/aik/p/qemu-kvm/tests/boot-order-test.c:40:test_a_boot_order: as= sertion failed (actual =3D=3D expected_boot): (0x0 0000000 =3D=3D 0x00000063) --- memory.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++------------= ---- 1 file changed, 51 insertions(+), 16 deletions(-) diff --git a/memory.c b/memory.c index d3b3581990..81a0962844 100644 --- a/memory.c +++ b/memory.c @@ -38,6 +38,7 @@ =20 static unsigned memory_region_transaction_depth; static bool memory_region_update_pending; +static bool memory_region_full_update_pending; static bool ioeventfd_update_pending; static bool global_dirty_log =3D false; =20 @@ -1040,7 +1041,30 @@ void memory_region_transaction_begin(void) ++memory_region_transaction_depth; } =20 -void memory_region_transaction_commit(void) +static bool memory_region_transaction_fast_commit(MemoryRegion *mr) +{ + FlatView *old_view, *new_view; + MemoryRegion *physmr; + + while (mr->container) { + mr =3D mr->container; + } + + physmr =3D memory_region_get_flatview_root(mr); + + flatviews_init(); + old_view =3D g_hash_table_lookup(flat_views, physmr); + if (!old_view) { + return false; + } + + new_view =3D generate_memory_topology(physmr); + g_hash_table_replace(flat_views, physmr, new_view); + + return true; +} + +static void memory_region_transaction_commit_mr(MemoryRegion *mr) { AddressSpace *as; =20 @@ -1050,7 +1074,10 @@ void memory_region_transaction_commit(void) --memory_region_transaction_depth; if (!memory_region_transaction_depth) { if (memory_region_update_pending) { - flatviews_reset(); + if (memory_region_full_update_pending || !mr || + !memory_region_transaction_fast_commit(mr)) { + flatviews_reset(); + } =20 MEMORY_LISTENER_CALL_GLOBAL(begin, Forward); =20 @@ -1060,6 +1087,8 @@ void memory_region_transaction_commit(void) } memory_region_update_pending =3D false; MEMORY_LISTENER_CALL_GLOBAL(commit, Forward); + memory_region_full_update_pending =3D false; + } else if (ioeventfd_update_pending) { QTAILQ_FOREACH(as, &address_spaces, address_spaces_link) { address_space_update_ioeventfds(as); @@ -1069,6 +1098,12 @@ void memory_region_transaction_commit(void) } } =20 +void memory_region_transaction_commit(void) +{ + memory_region_full_update_pending =3D true; + memory_region_transaction_commit_mr(NULL); +} + static void memory_region_destructor_none(MemoryRegion *mr) { } @@ -1678,7 +1713,7 @@ static void memory_region_finalize(Object *obj) MemoryRegion *subregion =3D QTAILQ_FIRST(&mr->subregions); memory_region_del_subregion(mr, subregion); } - memory_region_transaction_commit(); + memory_region_transaction_commit_mr(mr); =20 mr->destructor(mr); memory_region_clear_coalescing(mr); @@ -1903,7 +1938,7 @@ void memory_region_set_log(MemoryRegion *mr, bool log= , unsigned client) memory_region_transaction_begin(); mr->dirty_log_mask =3D (mr->dirty_log_mask & ~mask) | (log * mask); memory_region_update_pending |=3D mr->enabled; - memory_region_transaction_commit(); + memory_region_transaction_commit_mr(mr); } =20 bool memory_region_get_dirty(MemoryRegion *mr, hwaddr addr, @@ -1983,7 +2018,7 @@ void memory_region_set_readonly(MemoryRegion *mr, boo= l readonly) memory_region_transaction_begin(); mr->readonly =3D readonly; memory_region_update_pending |=3D mr->enabled; - memory_region_transaction_commit(); + memory_region_transaction_commit_mr(mr); } } =20 @@ -1993,7 +2028,7 @@ void memory_region_rom_device_set_romd(MemoryRegion *= mr, bool romd_mode) memory_region_transaction_begin(); mr->romd_mode =3D romd_mode; memory_region_update_pending |=3D mr->enabled; - memory_region_transaction_commit(); + memory_region_transaction_commit_mr(mr); } } =20 @@ -2208,7 +2243,7 @@ void memory_region_add_eventfd(MemoryRegion *mr, sizeof(*mr->ioeventfds) * (mr->ioeventfd_nb-1 - i)); mr->ioeventfds[i] =3D mrfd; ioeventfd_update_pending |=3D mr->enabled; - memory_region_transaction_commit(); + memory_region_transaction_commit_mr(mr); } =20 void memory_region_del_eventfd(MemoryRegion *mr, @@ -2243,7 +2278,7 @@ void memory_region_del_eventfd(MemoryRegion *mr, mr->ioeventfds =3D g_realloc(mr->ioeventfds, sizeof(*mr->ioeventfds)*mr->ioeventfd_nb= + 1); ioeventfd_update_pending |=3D mr->enabled; - memory_region_transaction_commit(); + memory_region_transaction_commit_mr(mr); } =20 static void memory_region_update_container_subregions(MemoryRegion *subreg= ion) @@ -2263,7 +2298,7 @@ static void memory_region_update_container_subregions= (MemoryRegion *subregion) QTAILQ_INSERT_TAIL(&mr->subregions, subregion, subregions_link); done: memory_region_update_pending |=3D mr->enabled && subregion->enabled; - memory_region_transaction_commit(); + memory_region_transaction_commit_mr(mr); } =20 static void memory_region_add_subregion_common(MemoryRegion *mr, @@ -2302,7 +2337,7 @@ void memory_region_del_subregion(MemoryRegion *mr, QTAILQ_REMOVE(&mr->subregions, subregion, subregions_link); memory_region_unref(subregion); memory_region_update_pending |=3D mr->enabled && subregion->enabled; - memory_region_transaction_commit(); + memory_region_transaction_commit_mr(mr); } =20 void memory_region_set_enabled(MemoryRegion *mr, bool enabled) @@ -2313,7 +2348,7 @@ void memory_region_set_enabled(MemoryRegion *mr, bool= enabled) memory_region_transaction_begin(); mr->enabled =3D enabled; memory_region_update_pending =3D true; - memory_region_transaction_commit(); + memory_region_transaction_commit_mr(enabled ? mr : NULL); } =20 void memory_region_set_size(MemoryRegion *mr, uint64_t size) @@ -2329,7 +2364,7 @@ void memory_region_set_size(MemoryRegion *mr, uint64_= t size) memory_region_transaction_begin(); mr->size =3D s; memory_region_update_pending =3D true; - memory_region_transaction_commit(); + memory_region_transaction_commit_mr(mr); } =20 static void memory_region_readd_subregion(MemoryRegion *mr) @@ -2343,7 +2378,7 @@ static void memory_region_readd_subregion(MemoryRegio= n *mr) mr->container =3D container; memory_region_update_container_subregions(mr); memory_region_unref(mr); - memory_region_transaction_commit(); + memory_region_transaction_commit_mr(mr); } } =20 @@ -2366,7 +2401,7 @@ void memory_region_set_alias_offset(MemoryRegion *mr,= hwaddr offset) memory_region_transaction_begin(); mr->alias_offset =3D offset; memory_region_update_pending |=3D mr->enabled; - memory_region_transaction_commit(); + memory_region_transaction_commit_mr(mr); } =20 uint64_t memory_region_get_alignment(const MemoryRegion *mr) @@ -2654,7 +2689,7 @@ bool memory_region_request_mmio_ptr(MemoryRegion *mr,= hwaddr addr) host =3D mr->ops->request_ptr(mr->opaque, addr - mr->addr, &size, &off= set); =20 if (!host || !size) { - memory_region_transaction_commit(); + memory_region_transaction_commit_mr(mr); return false; } =20 @@ -2666,7 +2701,7 @@ bool memory_region_request_mmio_ptr(MemoryRegion *mr,= hwaddr addr) qdev_prop_set_ptr(DEVICE(new_interface), "subregion", mr); object_property_set_bool(OBJECT(new_interface), true, "realized", NULL= ); =20 - memory_region_transaction_commit(); + memory_region_transaction_commit_mr(mr); return true; } =20 --=20 2.11.0