From nobody Wed Nov 5 05:32:30 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505764705836500.9176878386286; Mon, 18 Sep 2017 12:58:25 -0700 (PDT) Received: from localhost ([::1]:38652 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1du2BU-0004B0-VP for importer@patchew.org; Mon, 18 Sep 2017 15:58:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1du24q-0006lA-O2 for qemu-devel@nongnu.org; Mon, 18 Sep 2017 15:51:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1du24q-0006GO-2q for qemu-devel@nongnu.org; Mon, 18 Sep 2017 15:51:32 -0400 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:33825) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1du24m-0006Eb-Ij; Mon, 18 Sep 2017 15:51:28 -0400 Received: by mail-pg0-x244.google.com with SMTP id u18so658558pgo.1; Mon, 18 Sep 2017 12:51:28 -0700 (PDT) Received: from squirtle.westlake.spaceflightindustries.com ([173.226.206.194]) by smtp.gmail.com with ESMTPSA id d186sm200791pfd.117.2017.09.18.12.51.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Sep 2017 12:51:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xH4PDlbQmfZ4+FLF/gb6b2Wyr7awmkrKNjYJcWTOOC8=; b=OU4QQxIV3zWdJ5OqvtItfVSwJFDst4W9eFoPkP9T8DXH82t7AlFmXnt+Sn3tSnMsM2 TSg8YfoHUlYe/NOZmHlNikGENC199D2+/Eu/7EcMnRQ48bG60qyArShWmnh4/N5pD/Uf /9CsHQq2m21Qa/B0Bupw55oWNvOs8Jcu0h/1h4LZKNRgmGssj6yHUnz+jYAc1Xi5l7ci ANm1xT4Wt6ALvrIAq7h89OEb9MuvSGr5c1zepEMaHGwPbm8gnXREt2db7tDXgENjqK1Z tD1eIqD9MXo+EIqxW8nSVdhkyHexoBOQcFoOzZ00BZzikpW7Tf6VB8Jga+1Pl2V+TIjp BWuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xH4PDlbQmfZ4+FLF/gb6b2Wyr7awmkrKNjYJcWTOOC8=; b=SwIjjzD4Csq4OsIDZQ+axltxO7O/TWcWCPaVnBhEoPBlYmqdyT8GIfHp++hDtdG90H WPa5XwmsaR0Z9ldQdRbE1bMLNwkuxDrxdSuw+mnwsgwAlNmoN7cy5vtlh+ALbY7lu/9e WybBRcNUCfvwRKfyYRMF2kkU4jfpCnJO7oFYlhxTw2DTZSVmpQxPTkdi7SLpTzhczUR8 lQfQ0ka1GaL+EBT1GJ2TU/GPYsSBs74LWheQpGFV2KDLfPcG/hNf8+3iE9C1UNxchc9I bfm8FLtEili4E9jlkMOyTjzRuBCpFW5j1yFT2YakK2mZ7atyHaPx8sbmn+H/FczZch0M 7ljw== X-Gm-Message-State: AHPjjUjlGbEGCRqORSTX8Es2x9UGHgZx6vXheSyd1m6Re+ORk347INWO +JFMGCBubgSWEsNm0rs= X-Google-Smtp-Source: AOwi7QAj2+AKeKbC3j3N2UB4nmAcKUSKo53DDZ+tE1ygJcI8TUb9qGQWJLhi43tVIyTJdJR0a5IO7w== X-Received: by 10.84.128.73 with SMTP id 67mr2244306pla.128.1505764287338; Mon, 18 Sep 2017 12:51:27 -0700 (PDT) From: Andrey Smirnov To: qemu-arm@nongnu.org Date: Mon, 18 Sep 2017 12:50:46 -0700 Message-Id: <20170918195100.17593-4-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20170918195100.17593-1-andrew.smirnov@gmail.com> References: <20170918195100.17593-1-andrew.smirnov@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::244 Subject: [Qemu-devel] [PATCH 03/17] imx_fec: Refactor imx_eth_enable_rx() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Peter Maydell , Jason Wang , qemu-devel@nongnu.org, yurovsky@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Refactor imx_eth_enable_rx() to have more meaningfull variable name than 'tmp' and to reduce number of logical negations done. Cc: Peter Maydell Cc: Jason Wang Cc: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org Cc: yurovsky@gmail.com Signed-off-by: Andrey Smirnov Reviewed-by: Peter Maydell --- hw/net/imx_fec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index 75822344fc..84085afe09 100644 --- a/hw/net/imx_fec.c +++ b/hw/net/imx_fec.c @@ -536,19 +536,19 @@ static void imx_eth_do_tx(IMXFECState *s) static void imx_eth_enable_rx(IMXFECState *s) { IMXFECBufDesc bd; - bool tmp; + bool rx_ring_full; =20 imx_fec_read_bd(&bd, s->rx_descriptor); =20 - tmp =3D ((bd.flags & ENET_BD_E) !=3D 0); + rx_ring_full =3D !(bd.flags & ENET_BD_E); =20 - if (!tmp) { + if (rx_ring_full) { FEC_PRINTF("RX buffer full\n"); } else if (!s->regs[ENET_RDAR]) { qemu_flush_queued_packets(qemu_get_queue(s->nic)); } =20 - s->regs[ENET_RDAR] =3D tmp ? ENET_RDAR_RDAR : 0; + s->regs[ENET_RDAR] =3D rx_ring_full ? 0 : ENET_RDAR_RDAR; } =20 static void imx_eth_reset(DeviceState *d) --=20 2.13.5