From nobody Wed Nov 5 05:32:30 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505764422043108.23356520873278; Mon, 18 Sep 2017 12:53:42 -0700 (PDT) Received: from localhost ([::1]:38621 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1du26t-0008Lm-4i for importer@patchew.org; Mon, 18 Sep 2017 15:53:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1du24q-0006lF-UO for qemu-devel@nongnu.org; Mon, 18 Sep 2017 15:51:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1du24q-0006GU-63 for qemu-devel@nongnu.org; Mon, 18 Sep 2017 15:51:33 -0400 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]:38190) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1du24m-0006EG-LT; Mon, 18 Sep 2017 15:51:28 -0400 Received: by mail-pg0-x242.google.com with SMTP id m30so769240pgn.5; Mon, 18 Sep 2017 12:51:27 -0700 (PDT) Received: from squirtle.westlake.spaceflightindustries.com ([173.226.206.194]) by smtp.gmail.com with ESMTPSA id d186sm200791pfd.117.2017.09.18.12.51.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Sep 2017 12:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fqyxREB/kyB4rLmYAfwHoD8/bcback+XMLXwJhswt3g=; b=XcViKd/ix2EM8U4XBY3NPtSSicRXCejfizUgbfEFhjK+53/fD609VCeuG5N5KQhNr2 HfXJ02Yaa9eUk8piYrgWX0i+FbDlTSi7/pAs65bO0gYWRhIL0XPZQW/2TBOe5GtUXjb5 +Dkei8H0j/hSgpplXky9ZWFZkxyF7FxXimBGwhUmrAPfUjJpvcqrZgGu3BRDrXOT4UQJ nZu4h/C47Hh7LSGHrjl7ZFBe9s4F98mE0FZe57IZA3Y3urvhUGtJO+OvIUKHvE0TV2Ms CD+K8Ei0MQmniSrLUIG0tXIgBLxmcQB78lVOK5RbV2mPmbqrijwAv1lTxObcR8g2Qzor YGoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fqyxREB/kyB4rLmYAfwHoD8/bcback+XMLXwJhswt3g=; b=a33+2n7ReqvK12YICxff9QmdGXWarJOJLM5EzRbm1JnyszFE4ogM/TmVxVYrfbFiC5 0rrqynC0rSkFMN+ZqsYoJmsk+YfgWs/VpKGWtwOlaV3S7MU/vVW6+QQDhbly2DfT3i16 lTO2Lapa+x4DJ8aaWBl94DuyPN4imVxFSnx3WWTR5Qt1ppzf43hDuSjeazumIk0A60BA r2tLhQEOqqyXbE245aLEX8dTq5Uw/3onQfqaGrquofLSNk5D9yGe4rYf9dNgyGEooL2Y YyqGMnYqApwtPTsYpGubpwTxIdBhcD0C6zWLDM4rssadrSXKwRojyBsjnujpX9m5WPWe 9EgQ== X-Gm-Message-State: AHPjjUgBSsV2Ym/N0u7Ml7lw3gn63oCbTkggMRemIj3A0hH1AUFHBluf Q5zjstUpPQSye40gN0s= X-Google-Smtp-Source: ADKCNb4qmc7gVXVS1qu693uWcLRpCSSs/4iax0kO7frxyEwN3OnGiEwviLwzCHQwb4bCnbgG99OquA== X-Received: by 10.84.129.193 with SMTP id b59mr36843429plb.147.1505764286313; Mon, 18 Sep 2017 12:51:26 -0700 (PDT) From: Andrey Smirnov To: qemu-arm@nongnu.org Date: Mon, 18 Sep 2017 12:50:45 -0700 Message-Id: <20170918195100.17593-3-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20170918195100.17593-1-andrew.smirnov@gmail.com> References: <20170918195100.17593-1-andrew.smirnov@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::242 Subject: [Qemu-devel] [PATCH 02/17] imx_fec: Do not calculate FEC X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Peter Maydell , Jason Wang , qemu-devel@nongnu.org, yurovsky@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Save some computation time and avoid calculating CRC's frame Cc: Peter Maydell Cc: Jason Wang Cc: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org Cc: yurovsky@gmail.com Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index 88b4b049d7..75822344fc 100644 --- a/hw/net/imx_fec.c +++ b/hw/net/imx_fec.c @@ -1032,9 +1032,7 @@ static ssize_t imx_enet_receive(NetClientState *nc, c= onst uint8_t *buf, IMXENETBufDesc bd; uint32_t flags =3D 0; uint32_t addr; - uint32_t crc; uint32_t buf_addr; - uint8_t *crc_ptr; unsigned int buf_len; size_t size =3D len; =20 @@ -1048,8 +1046,6 @@ static ssize_t imx_enet_receive(NetClientState *nc, c= onst uint8_t *buf, =20 /* 4 bytes for the CRC. */ size +=3D 4; - crc =3D cpu_to_be32(crc32(~0, buf, size)); - crc_ptr =3D (uint8_t *) &crc; =20 /* Huge frames are truncted. */ if (size > ENET_MAX_FRAME_SIZE) { @@ -1090,9 +1086,10 @@ static ssize_t imx_enet_receive(NetClientState *nc, = const uint8_t *buf, dma_memory_write(&address_space_memory, buf_addr, buf, buf_len); buf +=3D buf_len; if (size < 4) { + const uint8_t zeros[4] =3D { 0 }; + dma_memory_write(&address_space_memory, buf_addr + buf_len, - crc_ptr, 4 - size); - crc_ptr +=3D 4 - size; + zeros, 4 - size); } bd.flags &=3D ~ENET_BD_E; if (size =3D=3D 0) { --=20 2.13.5