From nobody Wed Feb 11 02:07:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505690659156939.0778175284782; Sun, 17 Sep 2017 16:24:19 -0700 (PDT) Received: from localhost ([::1]:33972 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtivC-0005xe-Fy for importer@patchew.org; Sun, 17 Sep 2017 19:24:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtirj-0003Oc-8x for qemu-devel@nongnu.org; Sun, 17 Sep 2017 19:20:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dtiri-0007aq-19 for qemu-devel@nongnu.org; Sun, 17 Sep 2017 19:20:43 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:37109) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dtirh-0007aW-KC for qemu-devel@nongnu.org; Sun, 17 Sep 2017 19:20:41 -0400 Received: by mail-qt0-x244.google.com with SMTP id u48so4698816qtc.4 for ; Sun, 17 Sep 2017 16:20:41 -0700 (PDT) Received: from yoga.offpageads.com ([181.93.89.178]) by smtp.gmail.com with ESMTPSA id z75sm4132114qkb.71.2017.09.17.16.20.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Sep 2017 16:20:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NH8TvAzvRl3fTHfE/31Bx3YX3regwTO6EcNX9WiRiOQ=; b=ZUM1vmY+/rEYG9RVpHHjskygse4CXNb8Z8Tp/45hQ2q8tjdN/Aq7W9xWHOj5vujfYZ FeFxHHhJiQumcZ44gGrnRqNTY/IcynlQVX/s6PJQWIMUk1EPuahG5ja4LIRG+HKCN0WV pMkeXMgx9JLNRScqj8oT/Ns1dZlm+QYpQZdG5rUj4F5b3WFxnjA6ykk+5pPPjjDZQG7t Lt9TW24UWkace+j77qndMuzDdq3Xeo53P0E8tjjMHlKB8NyZGMKuC8aNSx6Ax8daGvU5 jDYvc04JSxYrXz4FGdeVQq6SnOfpktWYZsca4jo/s5h3jYKRWYEsa7M637q7/yQ1IUXs JruQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=NH8TvAzvRl3fTHfE/31Bx3YX3regwTO6EcNX9WiRiOQ=; b=uVdIBlldGINOrbYQGZPDZiqmM9IOQY+7wdmJ63EZznWhaBj9tvDggJtY5armJ2Fmj+ xrALekfnglc/i3jtE9AHUsIulTGGCbd9VHKtQlTV8SOIsADDqwa3obHCdXxQxmNZbU1n nc1mp67qhgwPV8MTPZAxeqIqPNj45jle2oMNDY4b/8x+hdut7C5qabOBa0AAq9JA1tC0 Muz72iejrQJ++G/cQZxOyJ2eSWd1ElLpVVAk1DiXargCKjyVeigYm3UIepYgiQ/jvTdb XCmVIdaiYjCXjsRPU51+4MO6MraCODf/WRseGHU2cnDsrH2CK+HhEt0f30os7Sx/gde2 JCzg== X-Gm-Message-State: AHPjjUjC7A2jGgW3RZXNdsRx9Rc31041MMqdOhsFg7D2XVehxjaYoU8t I6NFpBzUm38SZQ== X-Google-Smtp-Source: AOwi7QCnMAKyQP9OMjQd8PYD8gSHTtIJXYGp7lqooYMrtvvL3cC4hnbog8qvXC4pm/qbFxAjoDO8aA== X-Received: by 10.200.41.232 with SMTP id 37mr415073qtt.47.1505690441171; Sun, 17 Sep 2017 16:20:41 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Igor Mammedov , Eduardo Habkost , Aurelien Jarno , Yongbok Kim , Marcel Apfelbaum Date: Sun, 17 Sep 2017 20:20:08 -0300 Message-Id: <20170917232010.14183-5-f4bug@amsat.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170917232010.14183-1-f4bug@amsat.org> References: <20170917232010.14183-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH v3 4/6] mips: call cpu_mips_realize_env() from mips_cpu_realizefn() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , James Hogan , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 This changes the order between cpu_mips_realize_env() and cpu_exec_initfn(), but cpu_exec_initfn() don't have anything that depends on cpu_mips_realize_env() being called first. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Igor Mammedov Tested-by: James Hogan Reviewed-by: Eduardo Habkost --- target/mips/cpu.c | 3 +++ target/mips/translate.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/mips/cpu.c b/target/mips/cpu.c index 68bf423e9d..e3ef835599 100644 --- a/target/mips/cpu.c +++ b/target/mips/cpu.c @@ -123,6 +123,7 @@ static void mips_cpu_disas_set_info(CPUState *s, disass= emble_info *info) { static void mips_cpu_realizefn(DeviceState *dev, Error **errp) { CPUState *cs =3D CPU(dev); + MIPSCPU *cpu =3D MIPS_CPU(dev); MIPSCPUClass *mcc =3D MIPS_CPU_GET_CLASS(dev); Error *local_err =3D NULL; =20 @@ -132,6 +133,8 @@ static void mips_cpu_realizefn(DeviceState *dev, Error = **errp) return; } =20 + cpu_mips_realize_env(&cpu->env); + cpu_reset(cs); qemu_init_vcpu(cs); =20 diff --git a/target/mips/translate.c b/target/mips/translate.c index 5fc7979ac5..94c38e8755 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -20535,7 +20535,6 @@ MIPSCPU *cpu_mips_init(const char *cpu_model) cpu =3D MIPS_CPU(object_new(TYPE_MIPS_CPU)); env =3D &cpu->env; env->cpu_model =3D def; - cpu_mips_realize_env(env); =20 object_property_set_bool(OBJECT(cpu), true, "realized", NULL); =20 --=20 2.14.1