From nobody Wed Apr 24 22:04:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505465263020355.6654661285911; Fri, 15 Sep 2017 01:47:43 -0700 (PDT) Received: from localhost ([::1]:51981 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsmHl-000650-Bz for importer@patchew.org; Fri, 15 Sep 2017 04:47:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsmCd-0000d0-DR for qemu-devel@nongnu.org; Fri, 15 Sep 2017 04:42:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsmCc-0003Hj-AD for qemu-devel@nongnu.org; Fri, 15 Sep 2017 04:42:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44568) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dsmCc-0003HF-4Q for qemu-devel@nongnu.org; Fri, 15 Sep 2017 04:42:22 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 344C281DEA; Fri, 15 Sep 2017 08:42:21 +0000 (UTC) Received: from vader.redhat.com (ovpn-117-68.ams2.redhat.com [10.36.117.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 51D5566829; Fri, 15 Sep 2017 08:42:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 344C281DEA Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=otubo@redhat.com From: Eduardo Otubo To: qemu-devel@nongnu.org Date: Fri, 15 Sep 2017 10:41:39 +0200 Message-Id: <20170915084139.4481-7-otubo@redhat.com> In-Reply-To: <20170915084139.4481-1-otubo@redhat.com> References: <20170915084139.4481-1-otubo@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 15 Sep 2017 08:42:21 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 06/06] buildsys: Move seccomp cflags/libs to per object X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Fam Zheng Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Fam Zheng Like many other libraries, libseccomp cflags and libs should only apply to the building of necessary objects. Do so in the usual way with the help of per object variables. Signed-off-by: Fam Zheng Acked-by: Eduardo Otubo --- Makefile.objs | 2 ++ configure | 6 ++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 24a4ea08b8..d9cf7ad791 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -70,6 +70,8 @@ common-obj-y +=3D backends/ common-obj-y +=3D chardev/ =20 common-obj-$(CONFIG_SECCOMP) +=3D qemu-seccomp.o +qemu-seccomp.o-cflags :=3D $(SECCOMP_CFLAGS) +qemu-seccomp.o-libs :=3D $(SECCOMP_LIBS) =20 common-obj-$(CONFIG_FDT) +=3D device_tree.o =20 diff --git a/configure b/configure index 9ee4559b54..94db2d103e 100755 --- a/configure +++ b/configure @@ -2035,8 +2035,8 @@ if test "$seccomp" !=3D "no" ; then =20 if test "$libseccomp_minver" !=3D "" && $pkg_config --atleast-version=3D$libseccomp_minver libseccomp ; then - libs_softmmu=3D"$libs_softmmu $($pkg_config --libs libseccomp)" - QEMU_CFLAGS=3D"$QEMU_CFLAGS $($pkg_config --cflags libseccomp)" + seccomp_cflags=3D"$($pkg_config --cflags libseccomp)" + seccomp_libs=3D"$($pkg_config --libs libseccomp)" seccomp=3D"yes" else if test "$seccomp" =3D "yes" ; then @@ -5829,6 +5829,8 @@ fi =20 if test "$seccomp" =3D "yes"; then echo "CONFIG_SECCOMP=3Dy" >> $config_host_mak + echo "SECCOMP_CFLAGS=3D$seccomp_cflags" >> $config_host_mak + echo "SECCOMP_LIBS=3D$seccomp_libs" >> $config_host_mak fi =20 # XXX: suppress that --=20 2.13.5