From nobody Mon Feb 9 10:48:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505400660576271.94789710859106; Thu, 14 Sep 2017 07:51:00 -0700 (PDT) Received: from localhost ([::1]:48225 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsVTm-0007bD-Qc for importer@patchew.org; Thu, 14 Sep 2017 10:50:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsVK3-0005YS-5x for qemu-devel@nongnu.org; Thu, 14 Sep 2017 10:40:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsVJw-0002KK-S5 for qemu-devel@nongnu.org; Thu, 14 Sep 2017 10:40:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47614) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dsVJt-0002Gm-Nw; Thu, 14 Sep 2017 10:40:45 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B6628C04B32E; Thu, 14 Sep 2017 14:40:44 +0000 (UTC) Received: from red.redhat.com (ovpn-123-70.rdu2.redhat.com [10.10.123.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id 149C617AC7; Thu, 14 Sep 2017 14:40:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B6628C04B32E Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=eblake@redhat.com From: Eric Blake To: qemu-devel@nongnu.org Date: Thu, 14 Sep 2017 09:40:14 -0500 Message-Id: <20170914144032.14945-3-eblake@redhat.com> In-Reply-To: <20170914144032.14945-1-eblake@redhat.com> References: <20170914144032.14945-1-eblake@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 14 Sep 2017 14:40:44 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v3 02/20] block: Switch passthrough drivers to .bdrv_co_block_status() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org, Jeff Cody , Max Reitz , Stefan Hajnoczi , jsnow@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We are gradually moving away from sector-based interfaces, towards byte-based. Update the generic helpers, and all passthrough clients (blkdebug, commit, mirror, throttle) accordingly. Signed-off-by: Eric Blake --- v3: rebase to addition of throttle driver v2: rebase to master, retitle while merging blkdebug, commit, and mirror --- include/block/block_int.h | 26 ++++++++++++++------------ block/io.c | 30 ++++++++++++++++-------------- block/blkdebug.c | 19 ++++++++++--------- block/commit.c | 2 +- block/mirror.c | 2 +- block/throttle.c | 2 +- 6 files changed, 43 insertions(+), 38 deletions(-) diff --git a/include/block/block_int.h b/include/block/block_int.h index 0ba57dc35c..ba5c2f9f1f 100644 --- a/include/block/block_int.h +++ b/include/block/block_int.h @@ -1004,23 +1004,25 @@ void bdrv_format_default_perms(BlockDriverState *bs= , BdrvChild *c, uint64_t *nperm, uint64_t *nshared); /* - * Default implementation for drivers to pass bdrv_co_get_block_status() to + * Default implementation for drivers to pass bdrv_co_block_status() to * their file. */ -int64_t coroutine_fn bdrv_co_get_block_status_from_file(BlockDriverState *= bs, - int64_t sector_num, - int nb_sectors, - int *pnum, - BlockDriverState *= *file); +int64_t coroutine_fn bdrv_co_block_status_from_file(BlockDriverState *bs, + bool mapping, + int64_t offset, + int64_t bytes, + int64_t *pnum, + BlockDriverState **fil= e); /* - * Default implementation for drivers to pass bdrv_co_get_block_status() to + * Default implementation for drivers to pass bdrv_co_block_status() to * their backing file. */ -int64_t coroutine_fn bdrv_co_get_block_status_from_backing(BlockDriverStat= e *bs, - int64_t sector_= num, - int nb_sectors, - int *pnum, - BlockDriverStat= e **file); +int64_t coroutine_fn bdrv_co_block_status_from_backing(BlockDriverState *b= s, + bool mapping, + int64_t offset, + int64_t bytes, + int64_t *pnum, + BlockDriverState **= file); const char *bdrv_get_parent_name(const BlockDriverState *bs); void blk_dev_change_media_cb(BlockBackend *blk, bool load, Error **errp); bool blk_dev_has_removable_media(BlockBackend *blk); diff --git a/block/io.c b/block/io.c index 4fb544d25c..85c01b2800 100644 --- a/block/io.c +++ b/block/io.c @@ -1708,30 +1708,32 @@ typedef struct BdrvCoBlockStatusData { bool done; } BdrvCoBlockStatusData; -int64_t coroutine_fn bdrv_co_get_block_status_from_file(BlockDriverState *= bs, - int64_t sector_num, - int nb_sectors, - int *pnum, - BlockDriverState *= *file) +int64_t coroutine_fn bdrv_co_block_status_from_file(BlockDriverState *bs, + bool mapping, + int64_t offset, + int64_t bytes, + int64_t *pnum, + BlockDriverState **fil= e) { assert(bs->file && bs->file->bs); - *pnum =3D nb_sectors; + *pnum =3D bytes; *file =3D bs->file->bs; return BDRV_BLOCK_RAW | BDRV_BLOCK_OFFSET_VALID | - (sector_num << BDRV_SECTOR_BITS); + (offset & BDRV_BLOCK_OFFSET_MASK); } -int64_t coroutine_fn bdrv_co_get_block_status_from_backing(BlockDriverStat= e *bs, - int64_t sector_= num, - int nb_sectors, - int *pnum, - BlockDriverStat= e **file) +int64_t coroutine_fn bdrv_co_block_status_from_backing(BlockDriverState *b= s, + bool mapping, + int64_t offset, + int64_t bytes, + int64_t *pnum, + BlockDriverState **= file) { assert(bs->backing && bs->backing->bs); - *pnum =3D nb_sectors; + *pnum =3D bytes; *file =3D bs->backing->bs; return BDRV_BLOCK_RAW | BDRV_BLOCK_OFFSET_VALID | - (sector_num << BDRV_SECTOR_BITS); + (offset & BDRV_BLOCK_OFFSET_MASK); } /* diff --git a/block/blkdebug.c b/block/blkdebug.c index f54fe33cae..2458912175 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -628,15 +628,16 @@ static int coroutine_fn blkdebug_co_pdiscard(BlockDri= verState *bs, return bdrv_co_pdiscard(bs->file->bs, offset, bytes); } -static int64_t coroutine_fn blkdebug_co_get_block_status( - BlockDriverState *bs, int64_t sector_num, int nb_sectors, int *pnum, - BlockDriverState **file) +static int64_t coroutine_fn blkdebug_co_block_status(BlockDriverState *bs, + bool mapping, + int64_t offset, + int64_t bytes, + int64_t *pnum, + BlockDriverState **fi= le) { - assert(QEMU_IS_ALIGNED(sector_num | nb_sectors, - DIV_ROUND_UP(bs->bl.request_alignment, - BDRV_SECTOR_SIZE))); - return bdrv_co_get_block_status_from_file(bs, sector_num, nb_sectors, - pnum, file); + assert(QEMU_IS_ALIGNED(offset | bytes, bs->bl.request_alignment)); + return bdrv_co_block_status_from_file(bs, mapping, offset, bytes, + pnum, file); } static void blkdebug_close(BlockDriverState *bs) @@ -908,7 +909,7 @@ static BlockDriver bdrv_blkdebug =3D { .bdrv_co_flush_to_disk =3D blkdebug_co_flush, .bdrv_co_pwrite_zeroes =3D blkdebug_co_pwrite_zeroes, .bdrv_co_pdiscard =3D blkdebug_co_pdiscard, - .bdrv_co_get_block_status =3D blkdebug_co_get_block_status, + .bdrv_co_block_status =3D blkdebug_co_block_status, .bdrv_debug_event =3D blkdebug_debug_event, .bdrv_debug_breakpoint =3D blkdebug_debug_breakpoint, diff --git a/block/commit.c b/block/commit.c index 898d91f653..5516df1a6e 100644 --- a/block/commit.c +++ b/block/commit.c @@ -269,7 +269,7 @@ static void bdrv_commit_top_child_perm(BlockDriverState= *bs, BdrvChild *c, static BlockDriver bdrv_commit_top =3D { .format_name =3D "commit_top", .bdrv_co_preadv =3D bdrv_commit_top_preadv, - .bdrv_co_get_block_status =3D bdrv_co_get_block_status_from_backing, + .bdrv_co_block_status =3D bdrv_co_block_status_from_backing, .bdrv_refresh_filename =3D bdrv_commit_top_refresh_filename, .bdrv_close =3D bdrv_commit_top_close, .bdrv_child_perm =3D bdrv_commit_top_child_perm, diff --git a/block/mirror.c b/block/mirror.c index fab59739c5..bada3be20a 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1084,7 +1084,7 @@ static BlockDriver bdrv_mirror_top =3D { .bdrv_co_pwrite_zeroes =3D bdrv_mirror_top_pwrite_zeroes, .bdrv_co_pdiscard =3D bdrv_mirror_top_pdiscard, .bdrv_co_flush =3D bdrv_mirror_top_flush, - .bdrv_co_get_block_status =3D bdrv_co_get_block_status_from_backing, + .bdrv_co_block_status =3D bdrv_co_block_status_from_backing, .bdrv_refresh_filename =3D bdrv_mirror_top_refresh_filename, .bdrv_close =3D bdrv_mirror_top_close, .bdrv_child_perm =3D bdrv_mirror_top_child_perm, diff --git a/block/throttle.c b/block/throttle.c index 5bca76300f..76cd963a8c 100644 --- a/block/throttle.c +++ b/block/throttle.c @@ -224,7 +224,7 @@ static BlockDriver bdrv_throttle =3D { .bdrv_reopen_prepare =3D throttle_reopen_prepare, .bdrv_reopen_commit =3D throttle_reopen_commit, .bdrv_reopen_abort =3D throttle_reopen_abort, - .bdrv_co_get_block_status =3D bdrv_co_get_block_status_fro= m_file, + .bdrv_co_block_status =3D bdrv_co_block_status_from_fi= le, .is_filter =3D true, }; --=20 2.13.5