From nobody Mon Feb 9 09:53:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505319460130477.5526717130707; Wed, 13 Sep 2017 09:17:40 -0700 (PDT) Received: from localhost ([::1]:43423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsAM5-0007yM-3O for importer@patchew.org; Wed, 13 Sep 2017 12:17:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsAAF-0002oz-6f for qemu-devel@nongnu.org; Wed, 13 Sep 2017 12:05:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsAAA-0006pv-G0 for qemu-devel@nongnu.org; Wed, 13 Sep 2017 12:05:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54222) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dsA9x-0006ag-Eg; Wed, 13 Sep 2017 12:05:05 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7ED257EA87; Wed, 13 Sep 2017 16:05:04 +0000 (UTC) Received: from red.redhat.com (ovpn-120-201.rdu2.redhat.com [10.10.120.201]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5A04669FBC; Wed, 13 Sep 2017 16:04:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7ED257EA87 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=eblake@redhat.com From: Eric Blake To: qemu-devel@nongnu.org Date: Wed, 13 Sep 2017 11:03:30 -0500 Message-Id: <20170913160333.23622-21-eblake@redhat.com> In-Reply-To: <20170913160333.23622-1-eblake@redhat.com> References: <20170913160333.23622-1-eblake@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 13 Sep 2017 16:05:04 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v4 20/23] qemu-img: Change img_compare() to be byte-based X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, jsnow@redhat.com, famz@redhat.com, qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" In the continuing quest to make more things byte-based, change the internal iteration of img_compare(). We can finally drop the TODO assertion added earlier, now that the entire algorithm is byte-based and no longer has to shift from bytes to sectors. Most of the change is mechanical ('total_sectors' becomes 'total_size', 'sector_num' becomes 'offset', 'nb_sectors' becomes 'chunk', 'progress_base' goes from sectors to bytes); some of it is also a cleanup (sectors_to_bytes() is now unused, loss of variable 'count' added earlier in commit 51b0a488). Signed-off-by: Eric Blake Reviewed-by: John Snow --- v3: new patch --- qemu-img.c | 119 ++++++++++++++++++++++++---------------------------------= ---- 1 file changed, 46 insertions(+), 73 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 028c34a2cc..ef7062649d 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1185,11 +1185,6 @@ static int compare_buffers(const uint8_t *buf1, cons= t uint8_t *buf2, #define IO_BUF_SIZE (2 * 1024 * 1024) -static int64_t sectors_to_bytes(int64_t sectors) -{ - return sectors << BDRV_SECTOR_BITS; -} - /* * Check if passed sectors are empty (not allocated or contain only 0 byte= s) * @@ -1240,7 +1235,7 @@ static int img_compare(int argc, char **argv) const char *fmt1 =3D NULL, *fmt2 =3D NULL, *cache, *filename1, *filena= me2; BlockBackend *blk1, *blk2; BlockDriverState *bs1, *bs2; - int64_t total_sectors1, total_sectors2; + int64_t total_size1, total_size2; uint8_t *buf1 =3D NULL, *buf2 =3D NULL; int64_t pnum1, pnum2; int allocated1, allocated2; @@ -1248,9 +1243,9 @@ static int img_compare(int argc, char **argv) bool progress =3D false, quiet =3D false, strict =3D false; int flags; bool writethrough; - int64_t total_sectors; - int64_t sector_num =3D 0; - int64_t nb_sectors; + int64_t total_size; + int64_t offset =3D 0; + int64_t chunk; int c; uint64_t progress_base; bool image_opts =3D false; @@ -1364,39 +1359,36 @@ static int img_compare(int argc, char **argv) buf1 =3D blk_blockalign(blk1, IO_BUF_SIZE); buf2 =3D blk_blockalign(blk2, IO_BUF_SIZE); - total_sectors1 =3D blk_nb_sectors(blk1); - if (total_sectors1 < 0) { + total_size1 =3D blk_getlength(blk1); + if (total_size1 < 0) { error_report("Can't get size of %s: %s", - filename1, strerror(-total_sectors1)); + filename1, strerror(-total_size1)); ret =3D 4; goto out; } - total_sectors2 =3D blk_nb_sectors(blk2); - if (total_sectors2 < 0) { + total_size2 =3D blk_getlength(blk2); + if (total_size2 < 0) { error_report("Can't get size of %s: %s", - filename2, strerror(-total_sectors2)); + filename2, strerror(-total_size2)); ret =3D 4; goto out; } - total_sectors =3D MIN(total_sectors1, total_sectors2); - progress_base =3D MAX(total_sectors1, total_sectors2); + total_size =3D MIN(total_size1, total_size2); + progress_base =3D MAX(total_size1, total_size2); qemu_progress_print(0, 100); - if (strict && total_sectors1 !=3D total_sectors2) { + if (strict && total_size1 !=3D total_size2) { ret =3D 1; qprintf(quiet, "Strict mode: Image size mismatch!\n"); goto out; } - while (sector_num < total_sectors) { + while (offset < total_size) { int64_t status1, status2; - status1 =3D bdrv_block_status_above(bs1, NULL, - sector_num * BDRV_SECTOR_SIZE, - (total_sectors1 - sector_num) * - BDRV_SECTOR_SIZE, - &pnum1, NULL); + status1 =3D bdrv_block_status_above(bs1, NULL, offset, + total_size1 - offset, &pnum1, NU= LL); if (status1 < 0) { ret =3D 3; error_report("Sector allocation test failed for %s", filename1= ); @@ -1404,11 +1396,8 @@ static int img_compare(int argc, char **argv) } allocated1 =3D status1 & BDRV_BLOCK_ALLOCATED; - status2 =3D bdrv_block_status_above(bs2, NULL, - sector_num * BDRV_SECTOR_SIZE, - (total_sectors2 - sector_num) * - BDRV_SECTOR_SIZE, - &pnum2, NULL); + status2 =3D bdrv_block_status_above(bs2, NULL, offset, + total_size2 - offset, &pnum2, NU= LL); if (status2 < 0) { ret =3D 3; error_report("Sector allocation test failed for %s", filename2= ); @@ -1417,15 +1406,14 @@ static int img_compare(int argc, char **argv) allocated2 =3D status2 & BDRV_BLOCK_ALLOCATED; assert(pnum1 && pnum2); - nb_sectors =3D DIV_ROUND_UP(MIN(pnum1, pnum2), BDRV_SECTOR_SIZE); + chunk =3D MIN(pnum1, pnum2); if (strict) { if ((status1 & ~BDRV_BLOCK_OFFSET_MASK) !=3D (status2 & ~BDRV_BLOCK_OFFSET_MASK)) { ret =3D 1; qprintf(quiet, "Strict mode: Offset %" PRId64 - " block status mismatch!\n", - sectors_to_bytes(sector_num)); + " block status mismatch!\n", offset); goto out; } } @@ -1435,59 +1423,54 @@ static int img_compare(int argc, char **argv) if (allocated1) { int64_t pnum; - nb_sectors =3D MIN(nb_sectors, IO_BUF_SIZE >> BDRV_SECTOR_= BITS); - ret =3D blk_pread(blk1, sector_num << BDRV_SECTOR_BITS, bu= f1, - nb_sectors << BDRV_SECTOR_BITS); + chunk =3D MIN(chunk, IO_BUF_SIZE); + ret =3D blk_pread(blk1, offset, buf1, chunk); if (ret < 0) { - error_report("Error while reading offset %" PRId64 " o= f %s:" - " %s", sectors_to_bytes(sector_num), file= name1, - strerror(-ret)); + error_report("Error while reading offset %" PRId64 + " of %s: %s", + offset, filename1, strerror(-ret)); ret =3D 4; goto out; } - ret =3D blk_pread(blk2, sector_num << BDRV_SECTOR_BITS, bu= f2, - nb_sectors << BDRV_SECTOR_BITS); + ret =3D blk_pread(blk2, offset, buf2, chunk); if (ret < 0) { error_report("Error while reading offset %" PRId64 - " of %s: %s", sectors_to_bytes(sector_num= ), - filename2, strerror(-ret)); + " of %s: %s", + offset, filename2, strerror(-ret)); ret =3D 4; goto out; } - ret =3D compare_buffers(buf1, buf2, - nb_sectors * BDRV_SECTOR_SIZE, &pnum= ); - if (ret || pnum !=3D nb_sectors * BDRV_SECTOR_SIZE) { + ret =3D compare_buffers(buf1, buf2, chunk, &pnum); + if (ret || pnum !=3D chunk) { qprintf(quiet, "Content mismatch at offset %" PRId64 "= !\n", - sectors_to_bytes(sector_num) + (ret ? 0 : pnum= )); + offset + (ret ? 0 : pnum)); ret =3D 1; goto out; } } } else { - nb_sectors =3D MIN(nb_sectors, IO_BUF_SIZE >> BDRV_SECTOR_BITS= ); + chunk =3D MIN(chunk, IO_BUF_SIZE); if (allocated1) { - ret =3D check_empty_sectors(blk1, sector_num * BDRV_SECTOR= _SIZE, - nb_sectors * BDRV_SECTOR_SIZE, + ret =3D check_empty_sectors(blk1, offset, chunk, filename1, buf1, quiet); } else { - ret =3D check_empty_sectors(blk2, sector_num * BDRV_SECTOR= _SIZE, - nb_sectors * BDRV_SECTOR_SIZE, + ret =3D check_empty_sectors(blk2, offset, chunk, filename2, buf1, quiet); } if (ret) { goto out; } } - sector_num +=3D nb_sectors; - qemu_progress_print(((float) nb_sectors / progress_base)*100, 100); + offset +=3D chunk; + qemu_progress_print(((float) chunk / progress_base) * 100, 100); } - if (total_sectors1 !=3D total_sectors2) { + if (total_size1 !=3D total_size2) { BlockBackend *blk_over; const char *filename_over; qprintf(quiet, "Warning: Image size mismatch!\n"); - if (total_sectors1 > total_sectors2) { + if (total_size1 > total_size2) { blk_over =3D blk1; filename_over =3D filename1; } else { @@ -1495,14 +1478,10 @@ static int img_compare(int argc, char **argv) filename_over =3D filename2; } - while (sector_num < progress_base) { - int64_t count; - - ret =3D bdrv_block_status_above(blk_bs(blk_over), NULL, - sector_num * BDRV_SECTOR_SIZE, - (progress_base - sector_num) * - BDRV_SECTOR_SIZE, - &count, NULL); + while (offset < progress_base) { + ret =3D bdrv_block_status_above(blk_bs(blk_over), NULL, offset, + progress_base - offset, &chunk, + NULL); if (ret < 0) { ret =3D 3; error_report("Sector allocation test failed for %s", @@ -1510,22 +1489,16 @@ static int img_compare(int argc, char **argv) goto out; } - /* TODO relax this once bdrv_block_status_above does not enfor= ce - * sector alignment */ - assert(QEMU_IS_ALIGNED(count, BDRV_SECTOR_SIZE)); - nb_sectors =3D count >> BDRV_SECTOR_BITS; if (ret & BDRV_BLOCK_ALLOCATED && !(ret & BDRV_BLOCK_ZERO)) { - nb_sectors =3D MIN(nb_sectors, IO_BUF_SIZE >> BDRV_SECTOR_= BITS); - ret =3D check_empty_sectors(blk_over, - sector_num * BDRV_SECTOR_SIZE, - nb_sectors * BDRV_SECTOR_SIZE, + chunk =3D MIN(chunk, IO_BUF_SIZE); + ret =3D check_empty_sectors(blk_over, offset, chunk, filename_over, buf1, quiet); if (ret) { goto out; } } - sector_num +=3D nb_sectors; - qemu_progress_print(((float) nb_sectors / progress_base)*100, = 100); + offset +=3D chunk; + qemu_progress_print(((float) chunk / progress_base) * 100, 100= ); } } --=20 2.13.5