From nobody Sun May 5 16:37:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505292150061260.8534955399025; Wed, 13 Sep 2017 01:42:30 -0700 (PDT) Received: from localhost ([::1]:40934 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ds3Fd-000716-9D for importer@patchew.org; Wed, 13 Sep 2017 04:42:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ds3EF-0006Ck-PZ for qemu-devel@nongnu.org; Wed, 13 Sep 2017 04:41:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ds3E7-0000tg-4p for qemu-devel@nongnu.org; Wed, 13 Sep 2017 04:40:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51756) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ds3E6-0000sy-Sz for qemu-devel@nongnu.org; Wed, 13 Sep 2017 04:40:55 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EB703101702 for ; Wed, 13 Sep 2017 08:40:53 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-117-51.ams2.redhat.com [10.36.117.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id BEF8A17509; Wed, 13 Sep 2017 08:40:52 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id D6B2927A; Wed, 13 Sep 2017 10:40:51 +0200 (CEST) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EB703101702 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=kraxel@redhat.com From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Wed, 13 Sep 2017 10:40:48 +0200 Message-Id: <20170913084051.21378-2-kraxel@redhat.com> In-Reply-To: <20170913084051.21378-1-kraxel@redhat.com> References: <20170913084051.21378-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 13 Sep 2017 08:40:54 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 1/4] pixman: drop submodule X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Drop pixman submodule and support for the "internal" pixman build. pixman should be reasonably well established meanwhile so we don't need the fallback submodule any more. While being at it also drop some #ifdefs for pixman versions older than what we require in configure anyway. Signed-off-by: Gerd Hoffmann Message-id: 20170905140116.28181-2-kraxel@redhat.com --- configure | 20 ++------------------ Makefile | 10 ---------- ui/qemu-pixman.c | 4 ---- .gitmodules | 3 --- pixman | 1 - 5 files changed, 2 insertions(+), 36 deletions(-) delete mode 160000 pixman diff --git a/configure b/configure index fd7e3a5e81..ee32ad0530 100755 --- a/configure +++ b/configure @@ -925,8 +925,6 @@ for opt do ;; --with-system-pixman) pixman=3D"system" ;; - --without-system-pixman) pixman=3D"internal" - ;; --without-pixman) pixman=3D"none" ;; --disable-sdl) sdl=3D"no" @@ -3300,8 +3298,6 @@ if test "$pixman" =3D ""; then pixman=3D"none" elif $pkg_config --atleast-version=3D0.21.8 pixman-1 > /dev/null 2>&1; t= hen pixman=3D"system" - else - pixman=3D"internal" fi fi if test "$pixman" =3D "none"; then @@ -3318,16 +3314,8 @@ elif test "$pixman" =3D "system"; then pixman_cflags=3D$($pkg_config --cflags pixman-1) pixman_libs=3D$($pkg_config --libs pixman-1) else - if test ! -d ${source_path}/pixman/pixman; then - error_exit "pixman >=3D 0.21.8 not present. Your options:" \ - " (1) Preferred: Install the pixman devel package (any recent" \ - " distro should have packages as Xorg needs pixman too)." \ - " (2) Fetch the pixman submodule, using:" \ - " git submodule update --init pixman" - fi - mkdir -p pixman/pixman - pixman_cflags=3D"-I\$(SRC_PATH)/pixman/pixman -I\$(BUILD_DIR)/pixman/pix= man" - pixman_libs=3D"-L\$(BUILD_DIR)/pixman/pixman/.libs -lpixman-1" + error_exit "pixman >=3D 0.21.8 not present." \ + "Please install the pixman devel package." fi =20 ########################################## @@ -6529,10 +6517,6 @@ echo "QEMU_CFLAGS+=3D$cflags" >> $config_target_mak =20 done # for target in $targets =20 -if [ "$pixman" =3D "internal" ]; then - echo "config-host.h: subdir-pixman" >> $config_host_mak -fi - if [ "$dtc_internal" =3D "yes" ]; then echo "config-host.h: subdir-dtc" >> $config_host_mak fi diff --git a/Makefile b/Makefile index 337a1f6f9b..b53fc69a60 100644 --- a/Makefile +++ b/Makefile @@ -325,15 +325,6 @@ $(SOFTMMU_SUBDIR_RULES): config-all-devices.mak subdir-%: $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $* V=3D"$(V)" TARGET_= DIR=3D"$*/" all,) =20 -subdir-pixman: pixman/Makefile - $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C pixman V=3D"$(V)" all= ,) - -pixman/Makefile: $(SRC_PATH)/pixman/configure - (cd pixman; CFLAGS=3D"$(CFLAGS) -fPIC $(extra_cflags) $(extra_ldflags)" $= (SRC_PATH)/pixman/configure $(AUTOCONF_HOST) --disable-gtk --disable-shared= --enable-static) - -$(SRC_PATH)/pixman/configure: - (cd $(SRC_PATH)/pixman; autoreconf -v --install) - DTC_MAKE_ARGS=3D-I$(SRC_PATH)/dtc VPATH=3D$(SRC_PATH)/dtc -C dtc V=3D"$(V)= " LIBFDT_srcdir=3D$(SRC_PATH)/dtc/libfdt DTC_CFLAGS=3D$(CFLAGS) $(QEMU_CFLAGS) DTC_CPPFLAGS=3D-I$(BUILD_DIR)/dtc -I$(SRC_PATH)/dtc -I$(SRC_PATH)/dtc/libf= dt @@ -541,7 +532,6 @@ distclean: clean rm -rf $$d || exit 1 ; \ done rm -Rf .sdk - if test -f pixman/config.log; then $(MAKE) -C pixman distclean; fi if test -f dtc/version_gen.h; then $(MAKE) $(DTC_MAKE_ARGS) clean; fi =20 KEYMAPS=3Dda en-gb et fr fr-ch is lt modifiers no pt-br sv= \ diff --git a/ui/qemu-pixman.c b/ui/qemu-pixman.c index 6e8b83add6..6e591ab821 100644 --- a/ui/qemu-pixman.c +++ b/ui/qemu-pixman.c @@ -96,17 +96,13 @@ int qemu_pixman_get_type(int rshift, int gshift, int bs= hift) if (bshift =3D=3D 0) { type =3D PIXMAN_TYPE_ARGB; } else { -#if PIXMAN_VERSION >=3D PIXMAN_VERSION_ENCODE(0, 21, 8) type =3D PIXMAN_TYPE_RGBA; -#endif } } else if (rshift < gshift && gshift < bshift) { if (rshift =3D=3D 0) { type =3D PIXMAN_TYPE_ABGR; } else { -#if PIXMAN_VERSION >=3D PIXMAN_VERSION_ENCODE(0, 16, 0) type =3D PIXMAN_TYPE_BGRA; -#endif } } return type; diff --git a/.gitmodules b/.gitmodules index 5b0c212622..84c54cdc49 100644 --- a/.gitmodules +++ b/.gitmodules @@ -22,9 +22,6 @@ [submodule "roms/sgabios"] path =3D roms/sgabios url =3D git://git.qemu-project.org/sgabios.git -[submodule "pixman"] - path =3D pixman - url =3D git://anongit.freedesktop.org/pixman [submodule "dtc"] path =3D dtc url =3D git://git.qemu-project.org/dtc.git diff --git a/pixman b/pixman deleted file mode 160000 index 87eea99e44..0000000000 --- a/pixman +++ /dev/null @@ -1 +0,0 @@ -Subproject commit 87eea99e443b389c978cf37efc52788bf03a0ee0 --=20 2.9.3 From nobody Sun May 5 16:37:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505292270611812.2230451912702; Wed, 13 Sep 2017 01:44:30 -0700 (PDT) Received: from localhost ([::1]:40942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ds3HZ-0000MI-Q8 for importer@patchew.org; Wed, 13 Sep 2017 04:44:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ds3EG-0006Cm-Aj for qemu-devel@nongnu.org; Wed, 13 Sep 2017 04:41:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ds3E6-0000t4-Dr for qemu-devel@nongnu.org; Wed, 13 Sep 2017 04:41:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51724) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ds3E6-0000sD-8S for qemu-devel@nongnu.org; Wed, 13 Sep 2017 04:40:54 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 37050101709 for ; Wed, 13 Sep 2017 08:40:53 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-117-51.ams2.redhat.com [10.36.117.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id B51B260C16; Wed, 13 Sep 2017 08:40:52 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id DEC923F10D; Wed, 13 Sep 2017 10:40:51 +0200 (CEST) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 37050101709 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=kraxel@redhat.com From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Wed, 13 Sep 2017 10:40:49 +0200 Message-Id: <20170913084051.21378-3-kraxel@redhat.com> In-Reply-To: <20170913084051.21378-1-kraxel@redhat.com> References: <20170913084051.21378-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 13 Sep 2017 08:40:53 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 2/4] pixman: drop configure switches X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Remove pixman switches from configure, should not be needed any more, configure can figure by itself whenever pixman is needed or not. Signed-off-by: Gerd Hoffmann Message-id: 20170905140116.28181-3-kraxel@redhat.com --- configure | 24 ++---------------------- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/configure b/configure index ee32ad0530..7ea9cb3247 100755 --- a/configure +++ b/configure @@ -287,7 +287,6 @@ curses=3D"" docs=3D"" fdt=3D"" netmap=3D"no" -pixman=3D"" sdl=3D"" sdlabi=3D"" virtfs=3D"" @@ -923,10 +922,6 @@ for opt do # configure to be used by RPM and similar macros that set # lots of directory switches by default. ;; - --with-system-pixman) pixman=3D"system" - ;; - --without-pixman) pixman=3D"none" - ;; --disable-sdl) sdl=3D"no" ;; --enable-sdl) sdl=3D"yes" @@ -3293,24 +3288,10 @@ fi ########################################## # pixman support probe =20 -if test "$pixman" =3D ""; then - if test "$want_tools" =3D "no" -a "$softmmu" =3D "no"; then - pixman=3D"none" - elif $pkg_config --atleast-version=3D0.21.8 pixman-1 > /dev/null 2>&1; t= hen - pixman=3D"system" - fi -fi -if test "$pixman" =3D "none"; then - if test "$want_tools" !=3D "no" -o "$softmmu" !=3D "no"; then - error_exit "pixman disabled but system emulation or tools build" \ - "enabled. You can turn off pixman only if you also" \ - "disable all system emulation targets and the tools" \ - "build with '--disable-tools --disable-system'." - fi +if test "$want_tools" =3D "no" -a "$softmmu" =3D "no"; then pixman_cflags=3D pixman_libs=3D -elif test "$pixman" =3D "system"; then - # pixman version has been checked above +elif $pkg_config --atleast-version=3D0.21.8 pixman-1 > /dev/null 2>&1; then pixman_cflags=3D$($pkg_config --cflags pixman-1) pixman_libs=3D$($pkg_config --libs pixman-1) else @@ -5288,7 +5269,6 @@ echo "static build $static" if test "$darwin" =3D "yes" ; then echo "Cocoa support $cocoa" fi -echo "pixman $pixman" echo "SDL support $sdl $(echo_version $sdl $sdlversion)" echo "GTK support $gtk $(echo_version $gtk $gtk_version)" echo "GTK GL support $gtk_gl" --=20 2.9.3 From nobody Sun May 5 16:37:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505292340292428.81444679347385; Wed, 13 Sep 2017 01:45:40 -0700 (PDT) Received: from localhost ([::1]:40953 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ds3Ig-0001Gt-V4 for importer@patchew.org; Wed, 13 Sep 2017 04:45:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ds3EG-0006Cl-A5 for qemu-devel@nongnu.org; Wed, 13 Sep 2017 04:41:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ds3E6-0000tL-Rs for qemu-devel@nongnu.org; Wed, 13 Sep 2017 04:41:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43332) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ds3E6-0000sV-MS for qemu-devel@nongnu.org; Wed, 13 Sep 2017 04:40:54 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0B013C0587F2 for ; Wed, 13 Sep 2017 08:40:53 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-117-51.ams2.redhat.com [10.36.117.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id BE2085D976; Wed, 13 Sep 2017 08:40:52 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id E64D73F10E; Wed, 13 Sep 2017 10:40:51 +0200 (CEST) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0B013C0587F2 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=kraxel@redhat.com From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Wed, 13 Sep 2017 10:40:50 +0200 Message-Id: <20170913084051.21378-4-kraxel@redhat.com> In-Reply-To: <20170913084051.21378-1-kraxel@redhat.com> References: <20170913084051.21378-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 13 Sep 2017 08:40:53 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 3/4] console: fix dpy_gfx_replace_surface assert X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" virtio-gpu can trigger the assert added by commit "6905b93447 console: add same surface replace pre-condition" in multihead setups (where surface can be NULL for secondary displays). Allow surface being NULL. Fixes: 6905b93447a42e606dfd126b90f75f4cd3c6fe94 Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-Andr=C3=A9 Lureau Message-id: 20170906142109.2685-1-kraxel@redhat.com --- ui/console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/console.c b/ui/console.c index d2d3534c49..f0292d7820 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1540,7 +1540,7 @@ void dpy_gfx_replace_surface(QemuConsole *con, DisplaySurface *old_surface =3D con->surface; DisplayChangeListener *dcl; =20 - assert(old_surface !=3D surface); + assert(old_surface !=3D surface || surface =3D=3D NULL); =20 con->surface =3D surface; QLIST_FOREACH(dcl, &s->listeners, next) { --=20 2.9.3 From nobody Sun May 5 16:37:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505292407236242.2248047749821; Wed, 13 Sep 2017 01:46:47 -0700 (PDT) Received: from localhost ([::1]:40955 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ds3Jm-00022q-Ix for importer@patchew.org; Wed, 13 Sep 2017 04:46:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ds3EF-0006Cb-22 for qemu-devel@nongnu.org; Wed, 13 Sep 2017 04:41:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ds3E6-0000sp-AR for qemu-devel@nongnu.org; Wed, 13 Sep 2017 04:40:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54012) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ds3E6-0000s1-4q for qemu-devel@nongnu.org; Wed, 13 Sep 2017 04:40:54 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 295F87F772; Wed, 13 Sep 2017 08:40:53 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-117-51.ams2.redhat.com [10.36.117.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id BEB7160C17; Wed, 13 Sep 2017 08:40:52 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id EDD4F31FC8; Wed, 13 Sep 2017 10:40:51 +0200 (CEST) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 295F87F772 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=kraxel@redhat.com From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Wed, 13 Sep 2017 10:40:51 +0200 Message-Id: <20170913084051.21378-5-kraxel@redhat.com> In-Reply-To: <20170913084051.21378-1-kraxel@redhat.com> References: <20170913084051.21378-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 13 Sep 2017 08:40:53 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 4/4] console: add question-mark escape operator X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexander Graf , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Alexander Graf Some termcaps (found using SLES11SP1) use [? sequences. According to man console_codes (http://linux.die.net/man/4/console_codes) the question mark is a nop and should simply be ignored. This patch does exactly that, rendering screen output readable when outputting guest serial consoles to the graphical console emulator. Signed-off-by: Alexander Graf Message-id: 20170829113818.42482-1-agraf@suse.de Signed-off-by: Gerd Hoffmann --- ui/console.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/console.c b/ui/console.c index f0292d7820..b82c27960a 100644 --- a/ui/console.c +++ b/ui/console.c @@ -880,8 +880,9 @@ static void console_putchar(QemuConsole *s, int ch) } else { if (s->nb_esc_params < MAX_ESC_PARAMS) s->nb_esc_params++; - if (ch =3D=3D ';') + if (ch =3D=3D ';' || ch =3D=3D '?') { break; + } trace_console_putchar_csi(s->esc_params[0], s->esc_params[1], ch, s->nb_esc_params); s->state =3D TTY_STATE_NORM; --=20 2.9.3