From nobody Wed Nov 5 05:32:52 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505163046343172.9113163033055; Mon, 11 Sep 2017 13:50:46 -0700 (PDT) Received: from localhost ([::1]:60482 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drVfI-0005R9-Or for importer@patchew.org; Mon, 11 Sep 2017 16:50:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drVeQ-00051L-Vz for qemu-devel@nongnu.org; Mon, 11 Sep 2017 16:49:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drVeN-0004J1-Tw for qemu-devel@nongnu.org; Mon, 11 Sep 2017 16:49:51 -0400 Received: from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a]:38211) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1drVeN-0004Is-Pj for qemu-devel@nongnu.org; Mon, 11 Sep 2017 16:49:47 -0400 Received: by mail-qk0-x22a.google.com with SMTP id a128so21261633qkc.5 for ; Mon, 11 Sep 2017 13:49:47 -0700 (PDT) Received: from yoga.offpageads.com ([181.93.89.178]) by smtp.gmail.com with ESMTPSA id p57sm6804807qtc.97.2017.09.11.13.49.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Sep 2017 13:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OWBcQ7UR8+5kyIvLHReOdxJ1zqAO0cevIfo8aeOrFTM=; b=JJfsX5HEL8hyGYFUsa8jFZgwSIyLth68IvIr8xytglymUlfp6ZnHVQAjvSxttTD0uV vWTV20QD/6yVRkgzdd/uNlBsEZPWHsnFYtL5KwCN4fDisjPcGicUTs5CjxM8TkMlIZ8s tu9uqkmkgL7PO/7+8NINaSYoEiB2KPy+z9t/0rGuER695hClW5tRH4oeSuTFtopO9E1B fakxp8TZ+wFcWYRYSfokeUGuG9uNxT0QLRyn1I9Kzr+F3ZzXfFcDO6cCcIPI1+JkrL68 6PpYku7op7ipja7PIzMghMeDDLyPY5dYB/dXqjOwyCz2dt4xjUgrlO7PDogjzP3nFT7B 5nVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=OWBcQ7UR8+5kyIvLHReOdxJ1zqAO0cevIfo8aeOrFTM=; b=UERKriReEArUk1i4VpWtqlnuBMEVLt4rcC7olZnl+R+MzYJEeR0SA9WKv+erCDoWdP z/r3kYs1WXH4Gt1+FN+xGhKjeNXspu/8dBwHKtKgRNVoaRG1X4+/qhp/jr4pID+YZJZx rrYKLEb2ammGyEc1tNjeaEXuDkDl49vO3tRXYtUFs7s8Xi8SJFz35S8hUMPTHXLY2RI2 u7oRF02jiglj+AR4SmK/s6eFdW38lAr4suJ2qJ8ts8PnYBfaS3BRSDCJOPQNbcdmJtMg dIXhOoP5Yz4Iw+pL7Ceuawul9VfBmpu0aVXve/K9wp9IpviP4xw9s7SSJf18pmFHMaLr rhaQ== X-Gm-Message-State: AHPjjUjJgl8F7t6LtS6tDH6EvGbHBLwzCq3nLo9iaDGfYuNBfDk6Ln21 6mstVFweA7DDBQ== X-Google-Smtp-Source: AOwi7QAxUATUbVYFyHIlkLCj2vdtZb16U/7RLv47tIStkW9pGHIVGX3Y2KpKYSoGuF9CCvkWgy2fJw== X-Received: by 10.55.41.82 with SMTP id p79mr11477723qkh.109.1505162987131; Mon, 11 Sep 2017 13:49:47 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Richard Henderson , Peter Maydell Date: Mon, 11 Sep 2017 17:49:36 -0300 Message-Id: <20170911204936.5020-1-f4bug@amsat.org> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::22a Subject: [Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c): qemu/tcg/ppc/tcg-target.inc.c: In function 'tb_target_set_jmp_target': qemu/include/qemu/compiler.h:86:30: error: static assertion failed: "not = expecting: sizeof(*(uint64_t *)jmp_addr) > ATOMIC_REG_SIZE" QEMU_BUILD_BUG_ON(sizeof(*ptr) > ATOMIC_REG_SIZE); \ ^ qemu/tcg/ppc/tcg-target.inc.c:1377:9: note: in expansion of macro 'atomic= _set' atomic_set((uint64_t *)jmp_addr, pair); ^ Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- This fixes Shippable builds, see: https://app.shippable.com/github/qemu/qemu/runs/434/10/console tcg/ppc/tcg-target.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/ppc/tcg-target.inc.c b/tcg/ppc/tcg-target.inc.c index 21d764c102..0417901289 100644 --- a/tcg/ppc/tcg-target.inc.c +++ b/tcg/ppc/tcg-target.inc.c @@ -1374,7 +1374,7 @@ void tb_target_set_jmp_target(uintptr_t tc_ptr, uintp= tr_t jmp_addr, pair =3D (uint64_t)i2 << 32 | i1; #endif =20 - atomic_set((uint64_t *)jmp_addr, pair); + atomic_set__nocheck((uint64_t *)jmp_addr, pair); flush_icache_range(jmp_addr, jmp_addr + 8); } else { intptr_t diff =3D addr - jmp_addr; --=20 2.14.1