From nobody Tue Feb 10 00:40:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1504867884859125.7866195742755; Fri, 8 Sep 2017 03:51:24 -0700 (PDT) Received: from localhost ([::1]:44520 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqGsc-0007X5-Hu for importer@patchew.org; Fri, 08 Sep 2017 06:51:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqGe7-0002AG-2Y for qemu-devel@nongnu.org; Fri, 08 Sep 2017 06:36:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqGdx-0003AD-4s for qemu-devel@nongnu.org; Fri, 08 Sep 2017 06:36:23 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:34305) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dqGdw-000385-Qz; Fri, 08 Sep 2017 06:36:13 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 3xpYdJ1zlQz9t16; Fri, 8 Sep 2017 20:36:03 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1504866964; bh=dulp9xhCXh/F5i9mI+/NWugEB3u077Zpa1DLEDRAtv8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f30qOJDnRBaNy+NPn4ZanrvF4ZIhgfNBLo7ETn8lkYP/i3Z3CsVCcxn5shXFjjZ73 Fsud3Rxj2sKd+bxlzjP89xIjfQqw88f2koyirlZLhwufXf1rSQoltiJtSQ33kTpN5B dj9rNo5JTD7AR93xuUGjChXe4mJ7xmoHR6sWBhHU= From: David Gibson To: peter.maydell@linaro.org Date: Fri, 8 Sep 2017 20:35:24 +1000 Message-Id: <20170908103558.31632-7-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20170908103558.31632-1-david@gibson.dropbear.id.au> References: <20170908103558.31632-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 06/40] spapr_drc: use g_strdup_printf() instead of snprintf() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, aik@ozlabs.ru, agraf@suse.de, mdroth@linux.vnet.ibm.com, Greg Kurz , qemu-ppc@nongnu.org, imammedo@redhat.com, sam.bobroff@au1.ibm.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Greg Kurz Passing a stack allocated buffer of arbitrary length to snprintf() without checking the return value can cause the resultant strings to be silently truncated. Signed-off-by: Greg Kurz Signed-off-by: David Gibson --- hw/ppc/spapr_drc.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index 85c999d9cb..644a6fffaf 100644 --- a/hw/ppc/spapr_drc.c +++ b/hw/ppc/spapr_drc.c @@ -492,7 +492,7 @@ static void realize(DeviceState *d, Error **errp) { sPAPRDRConnector *drc =3D SPAPR_DR_CONNECTOR(d); Object *root_container; - char link_name[256]; + gchar *link_name; gchar *child_name; Error *err =3D NULL; =20 @@ -505,12 +505,13 @@ static void realize(DeviceState *d, Error **errp) * existing in the composition tree */ root_container =3D container_get(object_get_root(), DRC_CONTAINER_PATH= ); - snprintf(link_name, sizeof(link_name), "%x", spapr_drc_index(drc)); + link_name =3D g_strdup_printf("%x", spapr_drc_index(drc)); child_name =3D object_get_canonical_path_component(OBJECT(drc)); trace_spapr_drc_realize_child(spapr_drc_index(drc), child_name); object_property_add_alias(root_container, link_name, drc->owner, child_name, &err); g_free(child_name); + g_free(link_name); if (err) { error_propagate(errp, err); return; @@ -525,14 +526,15 @@ static void unrealize(DeviceState *d, Error **errp) { sPAPRDRConnector *drc =3D SPAPR_DR_CONNECTOR(d); Object *root_container; - char name[256]; + gchar *name; =20 trace_spapr_drc_unrealize(spapr_drc_index(drc)); qemu_unregister_reset(drc_reset, drc); vmstate_unregister(DEVICE(drc), &vmstate_spapr_drc, drc); root_container =3D container_get(object_get_root(), DRC_CONTAINER_PATH= ); - snprintf(name, sizeof(name), "%x", spapr_drc_index(drc)); + name =3D g_strdup_printf("%x", spapr_drc_index(drc)); object_property_del(root_container, name, errp); + g_free(name); } =20 sPAPRDRConnector *spapr_dr_connector_new(Object *owner, const char *type, @@ -730,10 +732,11 @@ static const TypeInfo spapr_drc_lmb_info =3D { sPAPRDRConnector *spapr_drc_by_index(uint32_t index) { Object *obj; - char name[256]; + gchar *name; =20 - snprintf(name, sizeof(name), "%s/%x", DRC_CONTAINER_PATH, index); + name =3D g_strdup_printf("%s/%x", DRC_CONTAINER_PATH, index); obj =3D object_resolve_path(name, NULL); + g_free(name); =20 return !obj ? NULL : SPAPR_DR_CONNECTOR(obj); } --=20 2.13.5