From nobody Tue Feb 10 01:35:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1504868293210280.5359660923766; Fri, 8 Sep 2017 03:58:13 -0700 (PDT) Received: from localhost ([::1]:44553 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqGzD-0004d3-Tm for importer@patchew.org; Fri, 08 Sep 2017 06:58:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqGeD-0002FG-M5 for qemu-devel@nongnu.org; Fri, 08 Sep 2017 06:36:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqGe5-0003KX-7s for qemu-devel@nongnu.org; Fri, 08 Sep 2017 06:36:27 -0400 Received: from ozlabs.org ([103.22.144.67]:34501) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dqGe4-0003GF-Te; Fri, 08 Sep 2017 06:36:21 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 3xpYdP3BFxz9t50; Fri, 8 Sep 2017 20:36:07 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1504866969; bh=tttS4riyRynnoj0Z31ZeZKZNpn8k9NG7Vg/R+pOKujE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nwO3JiXBMiV3PK+BOgma2KD7nRyjNVmgq+ErD+XqbdUDxIEaVD+Y6n5BbaiAm+ICm RAY27aHJY1DkpdYpRIbRSFc38aMpQxyrTVNlGjXqAlsaUbzdyNrTRtBZvXHSXdLg0l eTmNMQNdQL+3UXFT9zOczgVB8z7pk5goDcjjHPoE= From: David Gibson To: peter.maydell@linaro.org Date: Fri, 8 Sep 2017 20:35:47 +1000 Message-Id: <20170908103558.31632-30-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20170908103558.31632-1-david@gibson.dropbear.id.au> References: <20170908103558.31632-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 103.22.144.67 Subject: [Qemu-devel] [PULL 29/40] hw/nvram/spapr_nvram: Device can not be created by the users X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, aik@ozlabs.ru, agraf@suse.de, mdroth@linux.vnet.ibm.com, qemu-ppc@nongnu.org, Thomas Huth , imammedo@redhat.com, sam.bobroff@au1.ibm.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Trying to add a spapr-nvram device currently aborts QEMU like this: $ ppc64-softmmu/qemu-system-ppc64 -device spapr-nvram qemu-system-ppc64: hw/ppc/spapr_rtas.c:407: spapr_rtas_register: Assertion `!rtas_table[token].name' failed. Aborted (core dumped) This NVRAM device registers RTAS calls during its realize function and thus can only be used once - and that's internally from spapr.c. So let's mark the device with user_creatable =3D false to avoid that the users can crash their QEMU this way. Signed-off-by: Thomas Huth Signed-off-by: David Gibson --- hw/nvram/spapr_nvram.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/nvram/spapr_nvram.c b/hw/nvram/spapr_nvram.c index bc355a4348..4a0aec8e1d 100644 --- a/hw/nvram/spapr_nvram.c +++ b/hw/nvram/spapr_nvram.c @@ -264,6 +264,8 @@ static void spapr_nvram_class_init(ObjectClass *klass, = void *data) set_bit(DEVICE_CATEGORY_MISC, dc->categories); dc->props =3D spapr_nvram_properties; dc->vmsd =3D &vmstate_spapr_nvram; + /* Reason: Internal device only, uses spapr_rtas_register() in realize= () */ + dc->user_creatable =3D false; } =20 static const TypeInfo spapr_nvram_type_info =3D { --=20 2.13.5