From nobody Tue Feb 10 06:58:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1504715947215913.9436129868382; Wed, 6 Sep 2017 09:39:07 -0700 (PDT) Received: from localhost ([::1]:37105 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpdM2-0001ft-35 for importer@patchew.org; Wed, 06 Sep 2017 12:39:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpcqy-0000bM-Oq for qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:07:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpcqu-00037Y-02 for qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:07:00 -0400 Received: from mail-pf0-x22a.google.com ([2607:f8b0:400e:c00::22a]:34785) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dpcqt-00032z-Pc for qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:06:55 -0400 Received: by mail-pf0-x22a.google.com with SMTP id m1so13486478pfk.1 for ; Wed, 06 Sep 2017 09:06:55 -0700 (PDT) Received: from bigtime.twiddle.net (97-126-108-236.tukw.qwest.net. [97.126.108.236]) by smtp.gmail.com with ESMTPSA id t65sm262863pfk.59.2017.09.06.09.06.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Sep 2017 09:06:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FaKvXHHGiYR75jbxerCmzlpe42rCvutIo5e8u1b0PMw=; b=Kic5+E7N7vpQER4GVCBTf0GZvBmRq4YrkTVLov5upn1+R2IyNEMYA2Qyt0gGn/FYtz fkAxmJRyD4gs66YqfqIIyTz9wA2L7yeZ5OtxhjqThbUpxzLbt1etouzaBL1wMIMm7nxJ ehk8NJ3EW93uxweCixsp4BNSG0Dnt+jaidMdI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FaKvXHHGiYR75jbxerCmzlpe42rCvutIo5e8u1b0PMw=; b=qXjxI+EHWbDDwDjbxe9xWKPxj1NzTqyTia0spSEVxjNOsFB1ZNO/TB7x/S0x+Vx7/9 evKSmwFeDuw25A6zV78LhprsvZbj+jhRg0QRktAi3fYPKwrMPL/wfD4SFH6MDAcwFpHb 1K3YPMZUmvXAEzSc5hSuOcYBUY8DbFFQc0fhMbyZb/BdLGgotjLtybZtRPi201/nQ74U j7XERSH2unn4uV41C6pQUMbM5vBr0lH3DnDF+mI1PhWTp2YQ+2UaT8HWGtPYHnFelZKK lDjcmKsWBG3zMmZNVrr4EUsTq+4KbeRjefqFbffKfEC2xaLasItGwBpjSvZoHISeb90z /MKA== X-Gm-Message-State: AHPjjUhePp3Pr5CL4IRkqA9tuYbSVvNgAUs4pRQnuHY5loXC3+tQ2n4A muG9xLhsFjgxTjCa3RiFJw== X-Google-Smtp-Source: ADKCNb5Lorwg+INXciyLUKwAJQXs4kg+VoBPUlKNKso5xHoQ/Of9fIsDxEsBqtX0y+XKbr5Oc+hzPA== X-Received: by 10.84.210.45 with SMTP id z42mr8814641plh.178.1504714014598; Wed, 06 Sep 2017 09:06:54 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 6 Sep 2017 09:06:10 -0700 Message-Id: <20170906160612.22769-31-richard.henderson@linaro.org> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20170906160612.22769-1-richard.henderson@linaro.org> References: <20170906160612.22769-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::22a Subject: [Qemu-devel] [PULL 30/32] target/arm: Move ss check to init_disas_context X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Richard Henderson We can check for single-step just once. Reviewed-by: Emilio G. Cota Reviewed-by: Llu=C3=ADs Vilanova Signed-off-by: Richard Henderson --- target/arm/translate.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index dabd5eb89a..0dd24aad90 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -11883,6 +11883,11 @@ static int arm_tr_init_disas_context(DisasContextB= ase *dcbase, dc->next_page_start =3D (dc->base.pc_first & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE; =20 + /* If architectural single step active, limit to 1. */ + if (is_singlestepping(dc)) { + max_insns =3D 1; + } + cpu_F0s =3D tcg_temp_new_i32(); cpu_F1s =3D tcg_temp_new_i32(); cpu_F0d =3D tcg_temp_new_i64(); @@ -12037,11 +12042,9 @@ static void arm_tr_translate_insn(DisasContextBase= *dcbase, CPUState *cpu) * Also stop translation when a page boundary is reached. This * ensures prefetch aborts occur at the right place. */ =20 - if (is_singlestepping(dc)) { - dc->base.is_jmp =3D DISAS_TOO_MANY; - } else if ((dc->pc >=3D dc->next_page_start) || - ((dc->pc >=3D dc->next_page_start - 3) && - insn_crosses_page(env, dc))) { + if (dc->pc >=3D dc->next_page_start || + (dc->pc >=3D dc->next_page_start - 3 && + insn_crosses_page(env, dc))) { /* We want to stop the TB if the next insn starts in a new pag= e, * or if it spans between this page and the next. This means t= hat * if we're looking at the last halfword in the page we need to --=20 2.13.5