From nobody Mon Apr 29 14:37:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1504634851086142.13163365477635; Tue, 5 Sep 2017 11:07:31 -0700 (PDT) Received: from localhost ([::1]:60484 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpIG1-0006O5-C7 for importer@patchew.org; Tue, 05 Sep 2017 14:07:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpIEq-0005vV-Un for qemu-devel@nongnu.org; Tue, 05 Sep 2017 14:06:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpIEm-0007Pz-5H for qemu-devel@nongnu.org; Tue, 05 Sep 2017 14:06:16 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:33577) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dpIEm-0007Pj-0C for qemu-devel@nongnu.org; Tue, 05 Sep 2017 14:06:12 -0400 Received: by mail-qt0-x241.google.com with SMTP id h15so2639841qta.0 for ; Tue, 05 Sep 2017 11:06:11 -0700 (PDT) Received: from yoga.offpageads.com ([181.93.89.178]) by smtp.gmail.com with ESMTPSA id s124sm782491qkc.8.2017.09.05.11.06.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Sep 2017 11:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=N5j0U81rQ3sN7EMgfYC6FynumKCqT8JEeQacYZPmqmg=; b=efxzNFLjRRyjr8k4aWFOTkOODzERpq/oWBm01dLRnM3ef7DJu2wy1ETNs95vCjY7hO lNh7841hPbCifFXFQ36lvCiOnNJCkwoPEHfH8Ys9nGe+tYIDiuQBpyNXGrtG2i124fJU bOZYgH5mjoRbcPD1FAPyKNKvj8LTKLp/vB6KLEj3KkjiuSeCThclrvPjyXaXqY2ipxBr /SzgJKsSs6f0rrI0CIoyt6M30vnZdeHSb15coMP2Wfl9D+jLW/UTjZMpwhPFX0KV32C8 vdBayodYH89taZOjtCvRioz570SHa8QWBNda9FhVwxcS3QokccvBY6IS2gw46KFOFJZx ANyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=N5j0U81rQ3sN7EMgfYC6FynumKCqT8JEeQacYZPmqmg=; b=PbLRTZfKhxFTTUL0p8N6LzrQRRVJPB6SjjybeSojsqiVi+lMAPB/eQmtBz/RSzXHiY 24RikWCz89sj13OqVJDT1jW2cWnoCtNp9k0Q1qDUb0xvfVPC49pXOK2TrH9es+b22YjE RuL9OWN3Hpm2m3lhTtSHgGFIW1SGNWjQskE0RSIjLS5OYWqEvQ76KZDlYGKN6mTvHBa4 edU82fPIvqAsPWtCOYVa3rdKE32meiVOdMgsOAyktioLHRl0Re9TXftSlM0ZP7aQnVU8 d67xfmQD1oqg9gvji4IkhsSBF/d8b8kr5gKcKNszafrYGVPrX1WYTssJVEGDhSjC0JRg eiFA== X-Gm-Message-State: AHPjjUhZ3eMtcX1zL9XQSffXp/v8cRgR5POjgOAMmcrZCk+TG/AW1vAD TCq+EB6425QU8A== X-Google-Smtp-Source: ADKCNb7ESdLAqy/GXdqti9VeUQIBELvpNkVMerMiR2Tn9AG0DGmqtVur7SYII5L1NSxA5Ka78QBEMQ== X-Received: by 10.200.38.154 with SMTP id 26mr6391105qto.188.1504634771322; Tue, 05 Sep 2017 11:06:11 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , "Daniel P . Berrange" Date: Tue, 5 Sep 2017 15:06:02 -0300 Message-Id: <20170905180602.28698-1-f4bug@amsat.org> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH v3] vhost-user: disable the *broken* subprocess tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 tests/vhost-user-test keeps failing on build-system since Aug 15: ERROR:tests/vhost-user-test.c:835:test_flags_mismatch: child process (/i3= 86/vhost-user/flags-mismatch/subprocess [4836]) failed unexpectedly ... ERROR:tests/vhost-user-test.c:807:test_connect_fail: child process (/x86_= 64/vhost-user/connect-fail/subprocess [58910]) failed unexpectedly Suggested-by: Peter Maydell Suggested-by: Daniel P. Berrange Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v3: only disable tests using glib subprocess, migrate/multiqueue/guest-mem are still tested. v2: remove unuseful warning tests/vhost-user-test.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index d4da09f147..4b98018478 100644 --- a/tests/vhost-user-test.c +++ b/tests/vhost-user-test.c @@ -31,6 +31,8 @@ #include #include =20 +#define VHOST_USER_NET_TESTS_WORKING 0 /* broken as of 2.10.0 */ + /* GLIB version compatibility flags */ #if !GLIB_CHECK_VERSION(2, 26, 0) #define G_TIME_SPAN_SECOND (G_GINT64_CONSTANT(1000000)) @@ -472,11 +474,6 @@ static void test_server_listen(TestServer *server) test_server_create_chr(server, ",server,nowait"); } =20 -static inline void test_server_connect(TestServer *server) -{ - test_server_create_chr(server, ",reconnect=3D1"); -} - #define GET_QEMU_CMD(s) \ g_strdup_printf(QEMU_CMD, 512, 512, (root), (s)->chr_name, \ (s)->socket_path, "", (s)->chr_name) @@ -722,7 +719,12 @@ static void wait_for_rings_started(TestServer *s, size= _t count) g_mutex_unlock(&s->data_mutex); } =20 -#ifdef CONFIG_HAS_GLIB_SUBPROCESS_TESTS +#if VHOST_USER_NET_TESTS_WORKING && defined(CONFIG_HAS_GLIB_SUBPROCESS_TES= TS) +static inline void test_server_connect(TestServer *server) +{ + test_server_create_chr(server, ",reconnect=3D1"); +} + static gboolean reconnect_cb(gpointer user_data) { @@ -962,7 +964,8 @@ int main(int argc, char **argv) qtest_add_data_func("/vhost-user/read-guest-mem", server, read_guest_m= em); qtest_add_func("/vhost-user/migrate", test_migrate); qtest_add_func("/vhost-user/multiqueue", test_multiqueue); -#ifdef CONFIG_HAS_GLIB_SUBPROCESS_TESTS + +#if VHOST_USER_NET_TESTS_WORKING && defined(CONFIG_HAS_GLIB_SUBPROCESS_TES= TS) qtest_add_func("/vhost-user/reconnect/subprocess", test_reconnect_subprocess); qtest_add_func("/vhost-user/reconnect", test_reconnect); --=20 2.14.1