From nobody Tue Nov 4 08:20:28 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1504264154493260.63517917532795; Fri, 1 Sep 2017 04:09:14 -0700 (PDT) Received: from localhost ([::1]:35471 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnjp3-0000lA-81 for importer@patchew.org; Fri, 01 Sep 2017 07:09:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnjnN-0007wp-K5 for qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:07:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnjnI-0005BC-UI for qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:07:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57686) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dnjn9-00058b-1V; Fri, 01 Sep 2017 07:07:15 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 299DF461FB; Fri, 1 Sep 2017 11:07:14 +0000 (UTC) Received: from vader.redhat.com (ovpn-117-156.ams2.redhat.com [10.36.117.156]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0EE2871C48; Fri, 1 Sep 2017 11:07:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 299DF461FB Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=otubo@redhat.com From: Eduardo Otubo To: qemu-devel@nongnu.org Date: Fri, 1 Sep 2017 13:07:06 +0200 Message-Id: <20170901110706.429-1-otubo@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 01 Sep 2017 11:07:14 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] isa-fdc: assert replaced by proper error exit X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, jsnow@redhat.com, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When not available, isa-fdc falls into assert instead of proper error exit. This patch fixes this behavior. Signed-off-by: Eduardo Otubo Reviewed-by: Thomas Huth --- hw/block/fdc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index 401129073b..0b6def4e1d 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -2699,11 +2699,15 @@ static void isabus_fdc_realize(DeviceState *dev, Er= ror **errp) fdctrl->dma_chann =3D isa->dma; if (fdctrl->dma_chann !=3D -1) { fdctrl->dma =3D isa_get_dma(isa_bus_from_device(isadev), isa->dma); - assert(fdctrl->dma); + if (!fdctrl->dma) { + error_setg(errp, "isa-fdc not supported"); + goto error; + } } =20 qdev_set_legacy_instance_id(dev, isa->iobase, 2); fdctrl_realize_common(dev, fdctrl, &err); +error: if (err !=3D NULL) { error_propagate(errp, err); return; --=20 2.13.5