From nobody Tue Nov 4 08:28:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1504151703674467.2966699177864; Wed, 30 Aug 2017 20:55:03 -0700 (PDT) Received: from localhost ([::1]:53787 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnGZJ-0001Sl-J6 for importer@patchew.org; Wed, 30 Aug 2017 23:55:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnGXf-0000dz-N8 for qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnGXd-0006Xb-L9 for qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:19 -0400 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:33891) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dnGXd-0006XR-Gq for qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:17 -0400 Received: by mail-qk0-x242.google.com with SMTP id a77so6862277qkb.1 for ; Wed, 30 Aug 2017 20:53:17 -0700 (PDT) Received: from yoga.offpageads.com ([181.93.89.178]) by smtp.gmail.com with ESMTPSA id x20sm5072398qtb.5.2017.08.30.20.53.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Aug 2017 20:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M5Y6XpYE3ancXSqx2zLPj7PPgxbZL9MQ3G62xkjg7B8=; b=Ku6mZG1QjPZHbIGQGIqe9GGA4ItifSPj7I4T476El0QR6Dbxw24zIPy+jPwVQ739XB uMNFUX0s5phntFXno5rfyaZ1Wzo/2Q8ELxEa+yMYAlD+YEFetl7nbWY2h6J7JPpE5CNr g6b+UXfUpY3hDwwujn5J+md0ven2bZveAPnOwZ+JR8TqtxE7BILSZLLgNxW5LVBeLOGz /Xh7t+Vkvx0ljz7epYP//K8TCuVUqGhRRjNRmVuFT6m0x73zY7YbqZZme4Say2gViGjp S52oPC5DwD0bvgJkoNIpHsACCurNVnPGw46xYpcOLnpPSI4bogM01G13KxjJVMs8gOWl KLCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=M5Y6XpYE3ancXSqx2zLPj7PPgxbZL9MQ3G62xkjg7B8=; b=DD20VD4JJK/PpgCFoptSmUTxhTvVGMBEmqjXazJsNlIWnxEkFA/P15RzO91f2pBN5L 7ntLalxnxOSrI6uj0oD2f6yaS/rW/5RqQX7EKtPCv/4suGN0t5fqAWvBbZjVnh9Iid5J igJPgxEMbkyP1J6bU8tlqi+ABtY6P39380MednsvmJzGPVTGTiOf+VK847ypxHd0l+AY cFBPjPE7RUcGkuFp4zlResWN3C3FM8/6fwOnnC5eZwCdbk7uDuIY0kW4XifVNfNIOtUU d2n1j4DGpu4j/MmFzTsPl3y8l4lmgisIF1SHQ2JbMMrjA1EthtPYeMEGkY2DFWO9lf9C vnUQ== X-Gm-Message-State: AHYfb5iqnnYfEUH9eiiqQjyzCWwl5z2Vddm88ErZECBC+P9d7vX+v3/D vmOwmfSyC978FC2YlRjpTA== X-Received: by 10.55.200.131 with SMTP id t3mr2023908qkl.18.1504151596957; Wed, 30 Aug 2017 20:53:16 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , Peter Maydell , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Thomas Huth Date: Thu, 31 Aug 2017 00:53:00 -0300 Message-Id: <20170831035306.29170-2-f4bug@amsat.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170831035306.29170-1-f4bug@amsat.org> References: <20170831035306.29170-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to use the null backend when none provided X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/char/serial.h | 1 + hw/char/serial.c | 13 +++++++++++++ 2 files changed, 14 insertions(+) diff --git a/include/hw/char/serial.h b/include/hw/char/serial.h index c4daf11a14..96bccb39e1 100644 --- a/include/hw/char/serial.h +++ b/include/hw/char/serial.h @@ -93,6 +93,7 @@ SerialState *serial_mm_init(MemoryRegion *address_space, hwaddr base, int it_shift, qemu_irq irq, int baudbase, Chardev *chr, enum device_endian end); +Chardev *serial_chr_nonnull(Chardev *chr); =20 /* serial-isa.c */ #define TYPE_ISA_SERIAL "isa-serial" diff --git a/hw/char/serial.c b/hw/char/serial.c index 9aec6c60d8..7a100db107 100644 --- a/hw/char/serial.c +++ b/hw/char/serial.c @@ -1025,6 +1025,19 @@ static const MemoryRegionOps serial_mm_ops[3] =3D { }, }; =20 +Chardev *serial_chr_nonnull(Chardev *chr) +{ + static int serial_id; + char *label; + + label =3D g_strdup_printf("discarding-serial%d", serial_id++); + chr =3D qemu_chr_new(label, "null"); + assert(chr); + g_free(label); + + return chr; +} + SerialState *serial_mm_init(MemoryRegion *address_space, hwaddr base, int it_shift, qemu_irq irq, int baudbase, --=20 2.14.1 From nobody Tue Nov 4 08:28:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1504151845495415.80314629190195; Wed, 30 Aug 2017 20:57:25 -0700 (PDT) Received: from localhost ([::1]:53800 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnGbb-0003xH-Cr for importer@patchew.org; Wed, 30 Aug 2017 23:57:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnGXh-0000eB-IS for qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnGXg-0006Yr-QU for qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:21 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:35343) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dnGXg-0006Ye-MV for qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:20 -0400 Received: by mail-qt0-x244.google.com with SMTP id u11so6733763qtu.2 for ; Wed, 30 Aug 2017 20:53:20 -0700 (PDT) Received: from yoga.offpageads.com ([181.93.89.178]) by smtp.gmail.com with ESMTPSA id x20sm5072398qtb.5.2017.08.30.20.53.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Aug 2017 20:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fozbPzCoeQcIPahCw/iaBKzzN4VMrhFuXj6ZFHmqJEE=; b=J2q57TqRTnjvDWV55ft3iYFwI34F3ZyyPdIYZ8NvIaLfj0Gh6hAm4YxmyopVmSntYi LOI2NuCprqNtTLku6lg1mUQSA6KJaVrUMI/CxltqCAWeWcK0L5dysae1IEjCEWx4tF8v imiy64kFsY7yhkl4+qAwsyhGLIj1AJvKBGPoKBlu3ZLbRDRvRXQT4i5yUETX/SAj4CAh a4l3UtFtGhI9Raihl+W8RWIJfkiFbzcMGkGOfBj9lSioSQ3YY/fVbS4edaq6RDGuwjc1 Tf9qxudHcIekQQW+11sw5lySbRSurS7aGPWHGsaDCmzrMstlzpPtJ3k3mT3B9+rmHXwA Yurg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=fozbPzCoeQcIPahCw/iaBKzzN4VMrhFuXj6ZFHmqJEE=; b=S808wTZDXQVh1YvJye8lyfdnao5WjCO2u0uKab/hPSiqjx+6pVjN5mPxx2e7HuhM96 Vvnn3yItYRV56JMwKnILXLE2So3lGxCYk3TAwro6h6fL9PbFe2LPRjRi4mGmnREag+4n ngq50BDKhtGIz7qfm1hAX3rH/p3EqvNqr8lWDaz9nEBHLNaK/c9F/P/C/v0iHzIDZEFl osn4O3ITlqjD7YyvWlWLnYs1ElLahAroBYwIY+5aCR4a2T4dJLAI0bUAu/zWEd7zeZEv MirHC0YnwGxWd/Fcoz33dFCqeSca0FWU1Jf6mTRnwzVvDPDsNA+U//t7tmaC364qSiNS F8VQ== X-Gm-Message-State: AHPjjUjTMdLfKK0ZAxx7QTrRKRfgrZhm4DQVPtWjGJuXSC7OLkNn0wq0 CqPQf1ICvr2imw== X-Received: by 10.200.40.82 with SMTP id 18mr5118194qtr.152.1504151600164; Wed, 30 Aug 2017 20:53:20 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , Peter Maydell , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Thomas Huth Date: Thu, 31 Aug 2017 00:53:01 -0300 Message-Id: <20170831035306.29170-3-f4bug@amsat.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170831035306.29170-1-f4bug@amsat.org> References: <20170831035306.29170-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH 2/7] serial: use serial_chr_nonnull() in serial_mm_init() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/char/serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/serial.c b/hw/char/serial.c index e4c38dc250..57e89468b4 100644 --- a/hw/char/serial.c +++ b/hw/char/serial.c @@ -1050,7 +1050,7 @@ SerialState *serial_mm_init(MemoryRegion *address_spa= ce, s->it_shift =3D it_shift; s->irq =3D irq; s->baudbase =3D baudbase; - qemu_chr_fe_init(&s->chr, chr, &error_abort); + qemu_chr_fe_init(&s->chr, serial_chr_nonnull(chr), &error_abort); =20 serial_realize_core(s, &error_fatal); vmstate_register(NULL, base, &vmstate_serial, s); --=20 2.14.1 From nobody Tue Nov 4 08:28:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 15041518423641004.0990233157162; Wed, 30 Aug 2017 20:57:22 -0700 (PDT) Received: from localhost ([::1]:53799 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnGbX-0003vS-W8 for importer@patchew.org; Wed, 30 Aug 2017 23:57:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnGXk-0000gN-BW for qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnGXj-0006ZR-EI for qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:24 -0400 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:37251) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dnGXj-0006ZH-Ao; Wed, 30 Aug 2017 23:53:23 -0400 Received: by mail-qt0-x243.google.com with SMTP id g13so6737605qta.4; Wed, 30 Aug 2017 20:53:23 -0700 (PDT) Received: from yoga.offpageads.com ([181.93.89.178]) by smtp.gmail.com with ESMTPSA id x20sm5072398qtb.5.2017.08.30.20.53.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Aug 2017 20:53:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ptbb2tioMzNVHjabPeB1RPen2CnJsOp8RPHysN7rXAc=; b=D/FvpPx4CfFnNugnyZi/97vBkjNc6rNSELPe5B3VhwIMQm6SyMVP4v/qzvK2oPM4K7 gIvtCQFYdiMzOFfidBr3BsVFWuDdLXekLUFLdAPCAhE1Zyv3Y4pNx36GRlOmk1puk+s5 gv4gBPanHoPzexehEVGv0mwqWjEv53np5gdARKanj4XVm205gC2fuA6tjTZn2vzyEK5r GZs2UbABcmfStiM5vk/wYX+sKiFBWXyWroC5wPnhOSzGPCyePjjMtgyCithr1UMMJ7LI 44QXyjZxW5I284hMh8c9edn9MVisE1lG5iW2BVgWzrHRVSK7niggrYi482p/vOXYoeY4 8J6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Ptbb2tioMzNVHjabPeB1RPen2CnJsOp8RPHysN7rXAc=; b=qXqmaUKBdPisXE0RJytBTpIGe4CrbWEukE/bfGlf3q2C/DpoUelIgWRnfe+DUi5Ov6 y20Hk3eA5KOplJX+YkD6NwyritBWC0Q5+0nrqAtkzaLUNXrYpVaROHE0ZDAzpU9Zt+Kl 0+g0ibz3R3z90CsQFqFRw7JC1WXecHnrs8qEfllJF2icUiVyn5Yi+pw3D8gfj7JZ6Tdo Gr6w1q4p61F30rf6F/vVLCHpAJYmoIgMZmXsw8qDx7OWor2dGRnII3cM4hhN+2r7mEcQ hfmnOdMdbwuJXcIOy01p8nyHXYJYkPCvpPGeQvxhqxhmY730Tlu/BNBbvDMIu8keKNPO QpiA== X-Gm-Message-State: AHYfb5jSDvMZT9n1Db0+qlqn4lTWKM0+nPMFb+BUp8W23w4Iy6sMposU W1A7E6FYb0BiEw== X-Received: by 10.200.45.243 with SMTP id q48mr5097763qta.133.1504151602740; Wed, 30 Aug 2017 20:53:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , Peter Maydell , Peter Chubb Date: Thu, 31 Aug 2017 00:53:02 -0300 Message-Id: <20170831035306.29170-4-f4bug@amsat.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170831035306.29170-1-f4bug@amsat.org> References: <20170831035306.29170-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH 3/7] hw/arm/fsl_imx*: use serial_chr_nonnull() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/char/imx_serial.h | 1 + hw/arm/fsl-imx25.c | 9 +-------- hw/arm/fsl-imx31.c | 9 +-------- hw/arm/fsl-imx6.c | 10 +--------- 4 files changed, 4 insertions(+), 25 deletions(-) diff --git a/include/hw/char/imx_serial.h b/include/hw/char/imx_serial.h index baeec3183f..55139dc6ec 100644 --- a/include/hw/char/imx_serial.h +++ b/include/hw/char/imx_serial.h @@ -20,6 +20,7 @@ =20 #include "hw/sysbus.h" #include "chardev/char-fe.h" +#include "hw/char/serial.h" =20 #define TYPE_IMX_SERIAL "imx.serial" #define IMX_SERIAL(obj) OBJECT_CHECK(IMXSerialState, (obj), TYPE_IMX_SERIA= L) diff --git a/hw/arm/fsl-imx25.c b/hw/arm/fsl-imx25.c index 3b97eceb3c..425a9edc36 100644 --- a/hw/arm/fsl-imx25.c +++ b/hw/arm/fsl-imx25.c @@ -120,14 +120,7 @@ static void fsl_imx25_realize(DeviceState *dev, Error = **errp) if (i < MAX_SERIAL_PORTS) { Chardev *chr; =20 - chr =3D serial_hds[i]; - - if (!chr) { - char label[20]; - snprintf(label, sizeof(label), "imx31.uart%d", i); - chr =3D qemu_chr_new(label, "null"); - } - + chr =3D serial_chr_nonnull(serial_hds[i]); qdev_prop_set_chr(DEVICE(&s->uart[i]), "chardev", chr); } =20 diff --git a/hw/arm/fsl-imx31.c b/hw/arm/fsl-imx31.c index 0f2ebe8161..8d4535a536 100644 --- a/hw/arm/fsl-imx31.c +++ b/hw/arm/fsl-imx31.c @@ -109,14 +109,7 @@ static void fsl_imx31_realize(DeviceState *dev, Error = **errp) if (i < MAX_SERIAL_PORTS) { Chardev *chr; =20 - chr =3D serial_hds[i]; - - if (!chr) { - char label[20]; - snprintf(label, sizeof(label), "imx31.uart%d", i); - chr =3D qemu_chr_new(label, "null"); - } - + chr =3D serial_chr_nonnull(serial_hds[i]); qdev_prop_set_chr(DEVICE(&s->uart[i]), "chardev", chr); } =20 diff --git a/hw/arm/fsl-imx6.c b/hw/arm/fsl-imx6.c index 26fd214004..7bc1aa1fbe 100644 --- a/hw/arm/fsl-imx6.c +++ b/hw/arm/fsl-imx6.c @@ -189,15 +189,7 @@ static void fsl_imx6_realize(DeviceState *dev, Error *= *errp) if (i < MAX_SERIAL_PORTS) { Chardev *chr; =20 - chr =3D serial_hds[i]; - - if (!chr) { - char *label =3D g_strdup_printf("imx6.uart%d", i + 1); - chr =3D qemu_chr_new(label, "null"); - g_free(label); - serial_hds[i] =3D chr; - } - + chr =3D serial_chr_nonnull(serial_hds[i]); qdev_prop_set_chr(DEVICE(&s->uart[i]), "chardev", chr); } =20 --=20 2.14.1 From nobody Tue Nov 4 08:28:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1504151718378103.5320879145238; Wed, 30 Aug 2017 20:55:18 -0700 (PDT) Received: from localhost ([::1]:53788 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnGZY-0001dW-5I for importer@patchew.org; Wed, 30 Aug 2017 23:55:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnGXq-0000kT-E1 for qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnGXm-0006aN-6E for qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:30 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:33082) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dnGXm-0006aA-2D for qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:26 -0400 Received: by mail-qk0-x241.google.com with SMTP id k126so3514674qkb.0 for ; Wed, 30 Aug 2017 20:53:25 -0700 (PDT) Received: from yoga.offpageads.com ([181.93.89.178]) by smtp.gmail.com with ESMTPSA id x20sm5072398qtb.5.2017.08.30.20.53.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Aug 2017 20:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5DQdd00AJTXwPFuImthUxG3CuA9Qds7GlB6RWCDBigg=; b=C4h+kC2ZY/FEviwakq99b70n0ZlZPd9K7iv2KoToShDFwakUL2w5FzDNo0NzOINskQ VMQcGFD9Bu6N2HGbnO/v2rmHf2bfjomr9qHlmxAgqu3D26PsYOxLvhcqwgKaKu05HYmi A0J+KDpZhem9YU8oV5DUx1kDspNX+LroZlVnIEeVapxiEjwjqSbu+EImJW2wZlbvxtaa c4TgBS3lFiMiKvRlAE7Gux4o5lZ5kZncVLN4kIKfmJrOJHlSch6MQFExuIKiBGMu1ZHT xX03tagVxIvtxzH4fG9neKINhpAxIFk0h4MYtas4P0HwPSalUZOCinyGCGxd9b96Ht/v vaLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=5DQdd00AJTXwPFuImthUxG3CuA9Qds7GlB6RWCDBigg=; b=dshokUXV0JqNs2EKTE4eYVNnW+GLyWVoY7Lmsz5tTpkGN/j511WwX+QPNUAmksGYAp PgeYgm6WZjK5KXhgs5yakEBB7f6Z4uPWA4QPe0hJ72I37fRQr/+GfM13QYy/ZB+FHTOC SbdE51PrAkOGgreyV5aspxh06hqOYNr4VEkVB2IOsqAL+/zLypzU8Sr94T9m6+L3RPd2 ggbPb06GarXrSmqc0rSCgt21PeXPmAun4DATgIVoUqfsWakQySvek79//ia1luBaNeJ0 j3pqaUo40wZQLdvFQqzJeeZ5P0AAw2EzSHRgfJwdyGkU82zdO1od8R7eFO3auJ+vzAav iwwQ== X-Gm-Message-State: AHPjjUiV+MTkCaL9Gw6sW8Guaqq0EtJJV0MSj7Ntt/Vcf5BltHEBwYal ym79F454EsPvWw== X-Received: by 10.55.71.130 with SMTP id u124mr1928391qka.159.1504151605510; Wed, 30 Aug 2017 20:53:25 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , Peter Maydell , Aurelien Jarno , Yongbok Kim Date: Thu, 31 Aug 2017 00:53:03 -0300 Message-Id: <20170831035306.29170-5-f4bug@amsat.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170831035306.29170-1-f4bug@amsat.org> References: <20170831035306.29170-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH 4/7] hw/mips/malta: use serial_chr_nonnull() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/mips/mips_malta.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c index af678f5784..8620e9c42c 100644 --- a/hw/mips/mips_malta.c +++ b/hw/mips/mips_malta.c @@ -1035,11 +1035,7 @@ void mips_malta_init(MachineState *machine) =20 /* Make sure the first 3 serial ports are associated with a device. */ for(i =3D 0; i < 3; i++) { - if (!serial_hds[i]) { - char label[32]; - snprintf(label, sizeof(label), "serial%d", i); - serial_hds[i] =3D qemu_chr_new(label, "null"); - } + serial_hds[i] =3D serial_chr_nonnull(serial_hds[i]); } =20 /* create CPU */ --=20 2.14.1 From nobody Tue Nov 4 08:28:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 15041520624791011.7470419981097; Wed, 30 Aug 2017 21:01:02 -0700 (PDT) Received: from localhost ([::1]:53818 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnGf5-0006VH-TI for importer@patchew.org; Thu, 31 Aug 2017 00:00:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnGXq-0000kU-E8 for qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnGXo-0006ay-Uo for qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:30 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:34960) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dnGXo-0006aq-QC; Wed, 30 Aug 2017 23:53:28 -0400 Received: by mail-qk0-x244.google.com with SMTP id p67so6720135qkd.2; Wed, 30 Aug 2017 20:53:28 -0700 (PDT) Received: from yoga.offpageads.com ([181.93.89.178]) by smtp.gmail.com with ESMTPSA id x20sm5072398qtb.5.2017.08.30.20.53.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Aug 2017 20:53:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uAZVgqVk/IJrL2WN49KZ/EeyKG6Gdk+6kpmck+4Aqas=; b=jpPwTEQ7gcwxj2aCwXoWc9p+BSuoa+Lv92dlf3cZ2Ol4tnh/ILR4bM/k60MzB2SjCB gvRVMsPLitzlVTLoopVXN2/7EEbA/A+5nbp2tbVw2SF/fD+oPho0HHR1zpgnxTgLHzt1 2YtOwj6zJag/1bCh+ekxeuWrO/zVy5sE6lkaqAtx8gx6EOivXxln8xOYEOo9AodhKf2k rOkXyih6RSGMIkC0K4y0CO0kxCDf2TF00h1VrTRnkFDePMtxf/j98ADkJ2KB8LkxJg7o zUWDO8q/HiAPDsFUdG8ZjdBLcXF8HFM1JC2bjAsbGbtTB5SfmsKPixfUzGflRTWSVLRO DWpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=uAZVgqVk/IJrL2WN49KZ/EeyKG6Gdk+6kpmck+4Aqas=; b=sKg274HwBU8IJp+jjAWZf2BDdwE4F9zI09o13jLO1AsckQfQ30s7sl1dyvRQpNYptt 8Im8VkvVh1zt7oMkCRQG35WC4BqE4K05+sFRs82Ve+TiGBlTu2t2BrQQ4MbRC3WxRmLR IyaLOUU2axCtbbXNPpJUhnGnstNQT8XBic6q4WOf8AL2wFMwyH7Q0bbewupfaddvaFO0 3/thU2mLQ44N0f5o6BaUsISn0whdkz6Di+mMNH1HtfSdjwBrg83DvTfesqWTFFE8U4J0 e7YosOYocBHvRcWW5wS4NF3Dh3y5Pc/+xJO5oarsc7IWda9bviPKn9Oo82TX1KDSgufx LkVg== X-Gm-Message-State: AHPjjUh1D70nq8VldbuOsRcU6r0ivJFb/cbtnvoQYhwKJkwYqNtX/38l A+B9mchJ5m22SQ== X-Received: by 10.55.4.1 with SMTP id 1mr1983512qke.325.1504151608268; Wed, 30 Aug 2017 20:53:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , Peter Maydell , Igor Mitsyanko Date: Thu, 31 Aug 2017 00:53:04 -0300 Message-Id: <20170831035306.29170-6-f4bug@amsat.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170831035306.29170-1-f4bug@amsat.org> References: <20170831035306.29170-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH 5/7] hw/char/exynos4210_uart: use serial_chr_nonnull() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- This ARRAY_SIZE() first surprised me but was valid :) hw/char/exynos4210_uart.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/hw/char/exynos4210_uart.c b/hw/char/exynos4210_uart.c index 3957e78abf..b6cdfc3006 100644 --- a/hw/char/exynos4210_uart.c +++ b/hw/char/exynos4210_uart.c @@ -27,6 +27,7 @@ #include "chardev/char-serial.h" =20 #include "hw/arm/exynos4210.h" +#include "hw/char/serial.h" =20 #undef DEBUG_UART #undef DEBUG_UART_EXTEND @@ -589,9 +590,6 @@ DeviceState *exynos4210_uart_create(hwaddr addr, DeviceState *dev; SysBusDevice *bus; =20 - const char chr_name[] =3D "serial"; - char label[ARRAY_SIZE(chr_name) + 1]; - dev =3D qdev_create(NULL, TYPE_EXYNOS4210_UART); =20 if (!chr) { @@ -600,15 +598,7 @@ DeviceState *exynos4210_uart_create(hwaddr addr, MAX_SERIAL_PORTS); exit(1); } - chr =3D serial_hds[channel]; - if (!chr) { - snprintf(label, ARRAY_SIZE(label), "%s%d", chr_name, channel); - chr =3D qemu_chr_new(label, "null"); - if (!(chr)) { - error_report("Can't assign serial port to UART%d", channel= ); - exit(1); - } - } + chr =3D serial_chr_nonnull(serial_hds[channel]); } =20 qdev_prop_set_chr(dev, "chardev", chr); --=20 2.14.1 From nobody Tue Nov 4 08:28:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1504151986550577.9351846544267; Wed, 30 Aug 2017 20:59:46 -0700 (PDT) Received: from localhost ([::1]:53810 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnGds-0005jr-LB for importer@patchew.org; Wed, 30 Aug 2017 23:59:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnGXs-0000lf-2m for qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnGXr-0006bn-7h for qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:32 -0400 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:33896) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dnGXr-0006bf-3k; Wed, 30 Aug 2017 23:53:31 -0400 Received: by mail-qk0-x242.google.com with SMTP id a77so6862452qkb.1; Wed, 30 Aug 2017 20:53:30 -0700 (PDT) Received: from yoga.offpageads.com ([181.93.89.178]) by smtp.gmail.com with ESMTPSA id x20sm5072398qtb.5.2017.08.30.20.53.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Aug 2017 20:53:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KIodJgPfyDNKVJDKXwpUl9qXpUSHSusQbEpLvuy+wCM=; b=AUz8fd82/Y7Bmt9Cs5c6V4dHbIBAtchd8VzAHpA46xMEeYOTMqstyjlwww1DPyHxS2 CC/oNb9z9PVJPb8HUBFj+b8QvBcW3/Toj9MjLd+/ofDyr9p5joLH/GNrZw1UCD5eJMak 9vtqS9kjd7YCJx2B2HNO4w7qXuN2jrSXHANJk99P930E7Ns0I1TLdMposb+ifK+X4s/3 fkQMGZjZzwH6MiK2sZylstHisdVhjBMc5okkpg0A2eWiqJLBGgJX0TVHAwJWsMudvS9W VUZ5fQAaGL1lw5DksmJQqRPTGfdN9SKiO0g+lDggMQB4N2zn/3Kk1T7oytIbCdwKImeV e2Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=KIodJgPfyDNKVJDKXwpUl9qXpUSHSusQbEpLvuy+wCM=; b=nHyX4g98meCY2XhrWUws/Pp+kIW+11YnstD9waf+6P5eA0u3FVD7JZYxxJq4H3FRGK 8DRkazZOSdIOD1upqSzknaKTTSbdmvzT57GBUiuY/bHhXE8ypZxRwvA6rVeVGSDH1KW9 Y6J/ZLOKOg0yYiLCzcR0vRZRmvtYhLIhgruVh0D4tDaR5IjBHaSeUEqJiBrW6mEm26QK r+grfq/F2g0KfHAo4/iHZzHCXhvd/sbhFgH49bh/RgvNBzmrCcat/aRUGRNbCFGNIBVx C68Pq2VPXVGXYs4+cM6eCLhzX2uI3UF73aP8Fc2Y4lqpeZupzOCTIQBsoT4RemKKh/72 k/XQ== X-Gm-Message-State: AHYfb5iE2nHsqyqkHKBRKLraeRtOPV2YWZPbAxOw7KIu2smahFy4ETwF mzrYC7yY9Syog/nxqftG0w== X-Received: by 10.55.74.194 with SMTP id x185mr1965505qka.237.1504151610556; Wed, 30 Aug 2017 20:53:30 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , Peter Maydell Date: Thu, 31 Aug 2017 00:53:05 -0300 Message-Id: <20170831035306.29170-7-f4bug@amsat.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170831035306.29170-1-f4bug@amsat.org> References: <20170831035306.29170-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH 6/7] hw/char/omap_uart: serial_mm_init() already check for null chr X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/char/omap_uart.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/char/omap_uart.c b/hw/char/omap_uart.c index 6fd1b9cf6b..1f0ac0a053 100644 --- a/hw/char/omap_uart.c +++ b/hw/char/omap_uart.c @@ -63,8 +63,7 @@ struct omap_uart_s *omap_uart_init(hwaddr base, s->irq =3D irq; s->serial =3D serial_mm_init(get_system_memory(), base, 2, irq, omap_clk_getrate(fclk)/16, - chr ?: qemu_chr_new(label, "null"), - DEVICE_NATIVE_ENDIAN); + chr, DEVICE_NATIVE_ENDIAN); return s; } =20 @@ -183,6 +182,5 @@ void omap_uart_attach(struct omap_uart_s *s, Chardev *c= hr) /* TODO: Should reuse or destroy current s->serial */ s->serial =3D serial_mm_init(get_system_memory(), s->base, 2, s->irq, omap_clk_getrate(s->fclk) / 16, - chr ?: qemu_chr_new("null", "null"), - DEVICE_NATIVE_ENDIAN); + chr, DEVICE_NATIVE_ENDIAN); } --=20 2.14.1 From nobody Tue Nov 4 08:28:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 150415187683314.55199936162785; Wed, 30 Aug 2017 20:57:56 -0700 (PDT) Received: from localhost ([::1]:53803 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnGc6-0004Fy-Qm for importer@patchew.org; Wed, 30 Aug 2017 23:57:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnGXu-0000o8-IT for qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnGXt-0006cj-IB for qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:34 -0400 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:37215) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dnGXt-0006cW-EL for qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:33 -0400 Received: by mail-qk0-x242.google.com with SMTP id a21so24332qkg.4 for ; Wed, 30 Aug 2017 20:53:33 -0700 (PDT) Received: from yoga.offpageads.com ([181.93.89.178]) by smtp.gmail.com with ESMTPSA id x20sm5072398qtb.5.2017.08.30.20.53.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Aug 2017 20:53:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VWpx4VAn+V+H7Td+8qmumLGf4KCoYe0j7GppFOQo3Rs=; b=BCUYxlXG7AjHRVbWgewZzsvY2fpAaxkgAhXIHlsOubt3nlIGJOAfvB4Y8EiF0d9shw +8aQ2qU6MFZ6wQBXY1ZGjzGosT7651kMBiGXS2r86RyCT8m5VldGYTm4iG7A0wCpGhYe vHe0lygl2hQLl1nazxbeijI8hwrKHbRJFIPIyxThfvuBRnW32/DkxN5EfkWfwvYhpv+K GuRDpAZhSlvFNju9WGAXbUtu59ouAHmWBVjAuzAibKH59IzguEXyds1qGD95BJHVHEeH rqTFwUfss4xNqE+UDZjiBFnN0jG74ubWFYiMAnVtJXc+WEznjl7r1waFa6NkDNvwcO8p 4lPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=VWpx4VAn+V+H7Td+8qmumLGf4KCoYe0j7GppFOQo3Rs=; b=ai06ygCCrCTftBw1PwJUjkz7dQux4k1YBVsq2d7wWPg1oBUQkFBqeMUNNrXQ1PzqNj Bz5CdkAo9EOBkijOuYX4k960WPuU/6sSLz9GTJGdtm/voZPnlqUZd7K2CHnN2+0wdkIQ n635yi238xs5jb/Y4YdrUIIvDnvJ/+Pd7I+DhPjwr9omo2rLOjcQZ2E+JxXZ5SJ4WvBK mdk3AIXMztNgqXij859K9Rqp4iwIaAMMSL1jbbt7UcAOeIVcrjSeDpjnunce+kPco/X4 xYDFGaehjHY/oK49IegACteMNVQVKnQvyxoGZWQTAr1W9I6DOSouJvVeY/PtxDyMOl0Y MFlA== X-Gm-Message-State: AHYfb5j4M0QCKt1eaQHdlcMcDLRl3H4XeX2zDmk1rA/V7FOOMDLKjPV9 Na0g4qspjzKGlA== X-Received: by 10.55.73.213 with SMTP id w204mr1902779qka.231.1504151612953; Wed, 30 Aug 2017 20:53:32 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , Peter Maydell , Max Filippov Date: Thu, 31 Aug 2017 00:53:06 -0300 Message-Id: <20170831035306.29170-8-f4bug@amsat.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170831035306.29170-1-f4bug@amsat.org> References: <20170831035306.29170-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH 7/7] hw/xtensa: serial_mm_init() already check for null chr X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/xtensa/xtfpga.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c index 635a4d4ec3..223f396902 100644 --- a/hw/xtensa/xtfpga.c +++ b/hw/xtensa/xtfpga.c @@ -263,10 +263,6 @@ static void lx_init(const LxBoardDesc *board, MachineS= tate *machine) xtensa_get_extint(env, 1), nd_table); } =20 - if (!serial_hds[0]) { - serial_hds[0] =3D qemu_chr_new("serial0", "null"); - } - serial_mm_init(system_io, 0x0d050020, 2, xtensa_get_extint(env, 0), 115200, serial_hds[0], DEVICE_NATIVE_ENDIAN); =20 --=20 2.14.1