From nobody Wed Nov 5 08:32:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1504114648918355.26494614782723; Wed, 30 Aug 2017 10:37:28 -0700 (PDT) Received: from localhost ([::1]:51831 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dn6vd-00005m-Hy for importer@patchew.org; Wed, 30 Aug 2017 13:37:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dn6HZ-0004Lw-Sa for qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:56:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dn6HY-0006Cq-Nd for qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:56:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40364) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dn6HY-0006Bc-FL for qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:56:00 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5B1A25F7BD; Wed, 30 Aug 2017 16:55:59 +0000 (UTC) Received: from localhost (ovpn-116-210.ams2.redhat.com [10.36.116.210]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DB59287FA8; Wed, 30 Aug 2017 16:55:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5B1A25F7BD Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=cohuck@redhat.com From: Cornelia Huck To: peter.maydell@linaro.org Date: Wed, 30 Aug 2017 18:52:49 +0200 Message-Id: <20170830165252.13421-42-cohuck@redhat.com> In-Reply-To: <20170830165252.13421-1-cohuck@redhat.com> References: <20170830165252.13421-1-cohuck@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 30 Aug 2017 16:55:59 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 41/44] s390x/s390-stattrib: Mark the storage attribute as not user_creatable X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, david@redhat.com, Cornelia Huck , agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Thomas Huth The storage attribute devices are only meant to be instantiated one time, internally. They can not be used by the user, so mark them with user_creatable =3D false. Suggested-by: Claudio Imbrenda Signed-off-by: Thomas Huth Message-Id: <1503576029-24264-1-git-send-email-thuth@redhat.com> Reviewed-by: Claudio Imbrenda Reviewed-by: Halil Pasic Signed-off-by: Cornelia Huck --- hw/s390x/s390-stattrib-kvm.c | 4 ++++ hw/s390x/s390-stattrib.c | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/hw/s390x/s390-stattrib-kvm.c b/hw/s390x/s390-stattrib-kvm.c index ed95d13c68..41770a7dec 100644 --- a/hw/s390x/s390-stattrib-kvm.c +++ b/hw/s390x/s390-stattrib-kvm.c @@ -164,6 +164,7 @@ static int kvm_s390_stattrib_get_active(S390StAttribSta= te *sa) static void kvm_s390_stattrib_class_init(ObjectClass *oc, void *data) { S390StAttribClass *sac =3D S390_STATTRIB_CLASS(oc); + DeviceClass *dc =3D DEVICE_CLASS(oc); =20 sac->get_stattr =3D kvm_s390_stattrib_get_stattr; sac->peek_stattr =3D kvm_s390_stattrib_peek_stattr; @@ -172,6 +173,9 @@ static void kvm_s390_stattrib_class_init(ObjectClass *o= c, void *data) sac->get_dirtycount =3D kvm_s390_stattrib_get_dirtycount; sac->synchronize =3D kvm_s390_stattrib_synchronize; sac->get_active =3D kvm_s390_stattrib_get_active; + + /* Reason: Can only be instantiated one time (internally) */ + dc->user_creatable =3D false; } =20 static const TypeInfo kvm_s390_stattrib_info =3D { diff --git a/hw/s390x/s390-stattrib.c b/hw/s390x/s390-stattrib.c index 14a02711a2..2902f54f11 100644 --- a/hw/s390x/s390-stattrib.c +++ b/hw/s390x/s390-stattrib.c @@ -306,6 +306,7 @@ static int qemu_s390_get_active(S390StAttribState *sa) static void qemu_s390_stattrib_class_init(ObjectClass *oc, void *data) { S390StAttribClass *sa_cl =3D S390_STATTRIB_CLASS(oc); + DeviceClass *dc =3D DEVICE_CLASS(oc); =20 sa_cl->synchronize =3D qemu_s390_synchronize_stub; sa_cl->get_stattr =3D qemu_s390_get_stattr_stub; @@ -314,6 +315,9 @@ static void qemu_s390_stattrib_class_init(ObjectClass *= oc, void *data) sa_cl->set_migrationmode =3D qemu_s390_set_migrationmode_stub; sa_cl->get_dirtycount =3D qemu_s390_get_dirtycount_stub; sa_cl->get_active =3D qemu_s390_get_active; + + /* Reason: Can only be instantiated one time (internally) */ + dc->user_creatable =3D false; } =20 static const TypeInfo qemu_s390_stattrib_info =3D { --=20 2.13.5