From nobody Sun Feb 8 19:59:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1503885749007375.0851250804178; Sun, 27 Aug 2017 19:02:29 -0700 (PDT) Received: from localhost ([::1]:36519 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dm9Nj-0000Aq-Nj for importer@patchew.org; Sun, 27 Aug 2017 22:02:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dm9JD-00054a-Vb for qemu-devel@nongnu.org; Sun, 27 Aug 2017 21:57:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dm9JB-0001EZ-O4 for qemu-devel@nongnu.org; Sun, 27 Aug 2017 21:57:48 -0400 Received: from mail-ua0-x241.google.com ([2607:f8b0:400c:c08::241]:34979) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dm9JB-0001EF-Hc for qemu-devel@nongnu.org; Sun, 27 Aug 2017 21:57:45 -0400 Received: by mail-ua0-x241.google.com with SMTP id j45so2016921uaf.2 for ; Sun, 27 Aug 2017 18:57:45 -0700 (PDT) Received: from localhost.localdomain ([191.109.6.191]) by smtp.gmail.com with ESMTPSA id y12sm2696824uad.22.2017.08.27.18.57.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 27 Aug 2017 18:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fsRabrrOpRm5eKki328wcGEqUVd9MpvL3rHbTO5POG0=; b=VKHnlbNI8YYS+1v2kylCGDYhWL15k/UAa3Dli4qmXkb5utt00t0TYPXeDdOesMaLts hR920Ahg5wZzSAkknxhgQiqxBov+kRzi43FZGYLkfCCDRnHfQbMciobG3qgQ24PVgewC zllo3JplbtBe5ydGsXlOTiOwp4Pe5+I2NLi7/ai8ZqKerdytubab4wUCzB/ebOd/0ant bhmIXILUWaXN+hMf3GM0Lrxbax3XKkE+M0Rk6ZqKz3hB3MvCUGLhjoOYHaMa8FctUqPE /O4kWRJCQ7ZxcnhXs1CQEzpOg2fkCZbtsyTUr/AK8qLDZyyb+navmyFQPSt72NLnVZtB wFFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fsRabrrOpRm5eKki328wcGEqUVd9MpvL3rHbTO5POG0=; b=GvKvtu77q7rFZu8I5Q4cog3edpVa73gxw4+3bl188ZkVJ9tSnEL/7TAHgPFn5CMLI8 XvdEnOfsRa2riol5uzL+/N2Q54WARMapDbz27tUFuHZZLqFXVNWfFio7b/E6bQn/Hu2e ECcF8hO/unB6mEK/8MO+Dj7DutI6nRCHpPhCIGQlZVyOR1EW4caDnMRFXkc7RxC7V3Du f/wSODhNxFc52Q51Yq64zBsNxrlfX4bE/Gz8+DZ2PZ4kkpHXczKK8XsSk2jjMYUwF/4m ltMbJqgbE8+ioSB9aAddrxYMG3e1AYrx020x8wTWYNT2atwAht+jdxPf3WQDN3vSfMiY sIMA== X-Gm-Message-State: AHYfb5hD++TUYpNdDWZafUetCcH0MljqyuOCEBWe0o0WbOtiH1aObyAF y1pLoyXfLUkP1IyW X-Received: by 10.176.89.133 with SMTP id g5mr4189223uad.39.1503885464622; Sun, 27 Aug 2017 18:57:44 -0700 (PDT) From: Sergio Andres Gomez Del Real X-Google-Original-From: Sergio Andres Gomez Del Real To: qemu-devel@nongnu.org Date: Sun, 27 Aug 2017 20:56:50 -0500 Message-Id: <20170828015654.2530-11-Sergio.G.DelReal@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170828015654.2530-1-Sergio.G.DelReal@gmail.com> References: <20170828015654.2530-1-Sergio.G.DelReal@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400c:c08::241 Subject: [Qemu-devel] [PATCH 10/14] hvf: refactor cpuid code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sergio Andres Gomez Del Real Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This commit adds code to request the cpuid features supported by the host and hvf; it calls hvf_get_supported_cpuid if hvf is compiled with QEMU and enabled. Signed-off-by: Sergio Andres Gomez Del Real --- cpus.c | 2 + include/qom/cpu.h | 6 +-- include/sysemu/hvf.h | 18 ++++++--- target/i386/cpu-qom.h | 4 +- target/i386/cpu.c | 108 ++++++++++++++++++++++++++++++++++++++++------= ---- target/i386/hvf-all.c | 20 +++++----- 6 files changed, 113 insertions(+), 45 deletions(-) diff --git a/cpus.c b/cpus.c index 6754ce17cc..2411dfcd3f 100644 --- a/cpus.c +++ b/cpus.c @@ -37,7 +37,9 @@ #include "sysemu/hw_accel.h" #include "sysemu/kvm.h" #include "sysemu/hax.h" +#ifdef CONFIG_HVF #include "sysemu/hvf.h" +#endif #include "qmp-commands.h" #include "exec/exec-all.h" =20 diff --git a/include/qom/cpu.h b/include/qom/cpu.h index c46eb61240..ef74c2ce3c 100644 --- a/include/qom/cpu.h +++ b/include/qom/cpu.h @@ -408,13 +408,9 @@ struct CPUState { */ uint16_t pending_tlb_flush; =20 - // HVF bool hvf_vcpu_dirty; uint64_t hvf_fd; // fd of vcpu created by HVF - // Supporting data structures for VMCS capabilities - // and x86 emulation state - struct hvf_vcpu_caps* hvf_caps; - struct hvf_x86_state* hvf_x86; + struct hvf_x86_state *hvf_x86; }; =20 QTAILQ_HEAD(CPUTailQ, CPUState); diff --git a/include/sysemu/hvf.h b/include/sysemu/hvf.h index f9a5a9c5d3..5b92769b16 100644 --- a/include/sysemu/hvf.h +++ b/include/sysemu/hvf.h @@ -34,12 +34,6 @@ typedef struct hvf_slot { int slot_id; } hvf_slot; =20 -typedef struct HVFState { - AccelState parent; - hvf_slot slots[32]; - int num_slots; -} HVFState; - struct hvf_vcpu_caps { uint64_t vmx_cap_pinbased; uint64_t vmx_cap_procbased; @@ -49,6 +43,15 @@ struct hvf_vcpu_caps { uint64_t vmx_cap_preemption_timer; }; =20 +typedef struct HVFState { + AccelState parent; + hvf_slot slots[32]; + int num_slots; + + struct hvf_vcpu_caps *hvf_caps; +} HVFState; +extern HVFState *hvf_state; + void hvf_set_phys_mem(MemoryRegionSection *, bool); void hvf_handle_io(CPUArchState *, uint16_t, void *, int, int, int); @@ -87,6 +90,9 @@ void update_apic_tpr(CPUState *); int hvf_put_registers(CPUState *); void vmx_clear_int_window_exiting(CPUState *cpu); =20 +uint32_t hvf_get_supported_cpuid(uint32_t func, uint32_t idx, + int reg); + #define TYPE_HVF_ACCEL ACCEL_CLASS_NAME("hvf") =20 #define HVF_STATE(obj) \ diff --git a/target/i386/cpu-qom.h b/target/i386/cpu-qom.h index c2205e6077..22f95eb3a4 100644 --- a/target/i386/cpu-qom.h +++ b/target/i386/cpu-qom.h @@ -47,7 +47,7 @@ typedef struct X86CPUDefinition X86CPUDefinition; /** * X86CPUClass: * @cpu_def: CPU model definition - * @kvm_required: Whether CPU model requires KVM to be enabled. + * @host_cpuid_required: Whether CPU model requires cpuid from host. * @ordering: Ordering on the "-cpu help" CPU model list. * @migration_safe: See CpuDefinitionInfo::migration_safe * @static_model: See CpuDefinitionInfo::static @@ -66,7 +66,7 @@ typedef struct X86CPUClass { */ X86CPUDefinition *cpu_def; =20 - bool kvm_required; + bool host_cpuid_required; int ordering; bool migration_safe; bool static_model; diff --git a/target/i386/cpu.c b/target/i386/cpu.c index ddc45abd70..8c531a0ffa 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -22,6 +22,9 @@ #include "cpu.h" #include "exec/exec-all.h" #include "sysemu/kvm.h" +#ifdef CONFIG_HVF +#include "sysemu/hvf.h" +#endif #include "sysemu/cpus.h" #include "kvm_i386.h" =20 @@ -613,6 +616,23 @@ static uint32_t xsave_area_size(uint64_t mask) return ret; } =20 +static inline bool accel_uses_host_cpuid(void) +{ + bool enabled; +#if defined(CONFIG_KVM) + enabled =3D kvm_enabled(); +#elif defined(CONFIG_HVF) + enabled =3D hvf_enabled(); +#else + enabled =3D 0; +#endif + if (enabled) { + return true; + } else { + return false; + } +} + static inline uint64_t x86_cpu_xsave_components(X86CPU *cpu) { return ((uint64_t)cpu->env.features[FEAT_XSAVE_COMP_HI]) << 32 | @@ -1643,10 +1663,15 @@ static void max_x86_cpu_initfn(Object *obj) */ cpu->max_features =3D true; =20 - if (kvm_enabled()) { + if (accel_uses_host_cpuid()) { char vendor[CPUID_VENDOR_SZ + 1] =3D { 0 }; char model_id[CPUID_MODEL_ID_SZ + 1] =3D { 0 }; int family, model, stepping; + X86CPUDefinition host_cpudef =3D { }; + uint32_t eax =3D 0, ebx =3D 0, ecx =3D 0, edx =3D 0; + + host_cpuid(0x0, 0, &eax, &ebx, &ecx, &edx); + x86_cpu_vendor_words2str(host_cpudef.vendor, ebx, edx, ecx); =20 host_vendor_fms(vendor, &family, &model, &stepping); =20 @@ -1660,12 +1685,23 @@ static void max_x86_cpu_initfn(Object *obj) object_property_set_str(OBJECT(cpu), model_id, "model-id", &error_abort); =20 - env->cpuid_min_level =3D - kvm_arch_get_supported_cpuid(s, 0x0, 0, R_EAX); - env->cpuid_min_xlevel =3D - kvm_arch_get_supported_cpuid(s, 0x80000000, 0, R_EAX); - env->cpuid_min_xlevel2 =3D - kvm_arch_get_supported_cpuid(s, 0xC0000000, 0, R_EAX); + if (kvm_enabled()) { + env->cpuid_min_level =3D + kvm_arch_get_supported_cpuid(s, 0x0, 0, R_EAX); + env->cpuid_min_xlevel =3D + kvm_arch_get_supported_cpuid(s, 0x80000000, 0, R_EAX); + env->cpuid_min_xlevel2 =3D + kvm_arch_get_supported_cpuid(s, 0xC0000000, 0, R_EAX); + } else { +#if defined(CONFIG_HVF) + env->cpuid_min_level =3D + hvf_get_supported_cpuid(0x0, 0, R_EAX); + env->cpuid_min_xlevel =3D + hvf_get_supported_cpuid(0x80000000, 0, R_EAX); + env->cpuid_min_xlevel2 =3D + hvf_get_supported_cpuid(0xC0000000, 0, R_EAX); +#endif + } =20 if (lmce_supported()) { object_property_set_bool(OBJECT(cpu), true, "lmce", &error_abo= rt); @@ -1691,18 +1727,25 @@ static const TypeInfo max_x86_cpu_type_info =3D { .class_init =3D max_x86_cpu_class_init, }; =20 -#ifdef CONFIG_KVM - +#if defined(CONFIG_KVM) || defined(CONFIG_HVF) static void host_x86_cpu_class_init(ObjectClass *oc, void *data) { X86CPUClass *xcc =3D X86_CPU_CLASS(oc); =20 - xcc->kvm_required =3D true; + xcc->host_cpuid_required =3D true; xcc->ordering =3D 8; =20 - xcc->model_description =3D - "KVM processor with all supported host features " - "(only available in KVM mode)"; +#if defined(CONFIG_KVM) + if (kvm_enabled()) { + xcc->model_description =3D + "KVM processor with all supported host features "; + }=20 +#elif defined(CONFIG_HVF) + if (hvf_enabled()) { + xcc->model_description =3D + "HVF processor with all supported host features "; + } +#endif } =20 static const TypeInfo host_x86_cpu_type_info =3D { @@ -1724,7 +1767,7 @@ static void report_unavailable_features(FeatureWord w= , uint32_t mask) assert(reg); fprintf(stderr, "warning: %s doesn't support requested feature= : " "CPUID.%02XH:%s%s%s [bit %d]\n", - kvm_enabled() ? "host" : "TCG", + accel_uses_host_cpuid() ? "host" : "TCG", f->cpuid_eax, reg, f->feat_names[i] ? "." : "", f->feat_names[i] ? f->feat_names[i] : "", i); @@ -2175,7 +2218,7 @@ static void x86_cpu_class_check_missing_features(X86C= PUClass *xcc, Error *err =3D NULL; strList **next =3D missing_feats; =20 - if (xcc->kvm_required && !kvm_enabled()) { + if (xcc->host_cpuid_required && !accel_uses_host_cpuid()) { strList *new =3D g_new0(strList, 1); new->value =3D g_strdup("kvm");; *missing_feats =3D new; @@ -2337,7 +2380,15 @@ static uint32_t x86_cpu_get_supported_feature_word(F= eatureWord w, r =3D kvm_arch_get_supported_cpuid(kvm_state, wi->cpuid_eax, wi->cpuid_ecx, wi->cpuid_reg); - } else if (tcg_enabled()) { + } +#if defined(CONFIG_HVF) + else if (hvf_enabled()) { + r =3D hvf_get_supported_cpuid(wi->cpuid_eax, + wi->cpuid_ecx, + wi->cpuid_reg); + } +#endif + else if (tcg_enabled()) { r =3D wi->tcg_features; } else { return ~0; @@ -2396,6 +2447,7 @@ static void x86_cpu_load_def(X86CPU *cpu, X86CPUDefin= ition *def, Error **errp) } =20 /* Special cases not set in the X86CPUDefinition structs: */ + /* TODO: implement for hvf */ if (kvm_enabled()) { if (!kvm_irqchip_in_kernel()) { x86_cpu_change_kvm_default("x2apic", "off"); @@ -2416,7 +2468,7 @@ static void x86_cpu_load_def(X86CPU *cpu, X86CPUDefin= ition *def, Error **errp) * when doing cross vendor migration */ vendor =3D def->vendor; - if (kvm_enabled()) { + if (accel_uses_host_cpuid()) { uint32_t ebx =3D 0, ecx =3D 0, edx =3D 0; host_cpuid(0, 0, NULL, &ebx, &ecx, &edx); x86_cpu_vendor_words2str(host_vendor, ebx, edx, ecx); @@ -2872,7 +2924,16 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index,= uint32_t count, *ebx =3D kvm_arch_get_supported_cpuid(s, 0xA, count, R_EBX); *ecx =3D kvm_arch_get_supported_cpuid(s, 0xA, count, R_ECX); *edx =3D kvm_arch_get_supported_cpuid(s, 0xA, count, R_EDX); - } else { + } +#if defined(CONFIG_HVF) + else if (hvf_enabled() && cpu->enable_pmu) { + *eax =3D hvf_get_supported_cpuid(0xA, count, R_EAX); + *ebx =3D hvf_get_supported_cpuid(0xA, count, R_EBX); + *ecx =3D hvf_get_supported_cpuid(0xA, count, R_ECX); + *edx =3D hvf_get_supported_cpuid(0xA, count, R_EDX); + } +#endif + else { *eax =3D 0; *ebx =3D 0; *ecx =3D 0; @@ -3220,6 +3281,7 @@ static void x86_cpu_reset(CPUState *s) =20 s->halted =3D !cpu_is_bsp(cpu); =20 + /* TODO: implement for hvf */ if (kvm_enabled()) { kvm_arch_reset_vcpu(cpu); } @@ -3262,6 +3324,7 @@ APICCommonClass *apic_get_class(void) { const char *apic_type =3D "apic"; =20 + /* TODO: implement for hvf */ if (kvm_apic_in_kernel()) { apic_type =3D "kvm-apic"; } else if (xen_enabled()) { @@ -3492,6 +3555,7 @@ static void x86_cpu_expand_features(X86CPU *cpu, Erro= r **errp) } } =20 + /* TODO: implement for hvf */ if (!kvm_enabled() || !cpu->expose_kvm) { env->features[FEAT_KVM] =3D 0; } @@ -3575,7 +3639,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error= **errp) Error *local_err =3D NULL; static bool ht_warned; =20 - if (xcc->kvm_required && !kvm_enabled()) { + if (xcc->host_cpuid_required && !accel_uses_host_cpuid()) { char *name =3D x86_cpu_class_get_model_name(xcc); error_setg(&local_err, "CPU model '%s' requires KVM", name); g_free(name); @@ -3597,7 +3661,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error= **errp) x86_cpu_report_filtered_features(cpu); if (cpu->enforce_cpuid) { error_setg(&local_err, - kvm_enabled() ? + accel_uses_host_cpuid() ? "Host doesn't support requested features" : "TCG doesn't support requested features"); goto out; @@ -3620,7 +3684,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error= **errp) * consumer AMD devices but nothing else. */ if (env->features[FEAT_8000_0001_EDX] & CPUID_EXT2_LM) { - if (kvm_enabled()) { + if (accel_uses_host_cpuid()) { uint32_t host_phys_bits =3D x86_host_phys_bits(); static bool warned; =20 @@ -4207,7 +4271,7 @@ static void x86_cpu_register_types(void) } type_register_static(&max_x86_cpu_type_info); type_register_static(&x86_base_cpu_type_info); -#ifdef CONFIG_KVM +#if defined(CONFIG_KVM) || defined(CONFIG_HVF) type_register_static(&host_x86_cpu_type_info); #endif } diff --git a/target/i386/hvf-all.c b/target/i386/hvf-all.c index 88b5281975..11d20671f7 100644 --- a/target/i386/hvf-all.c +++ b/target/i386/hvf-all.c @@ -604,7 +604,7 @@ int hvf_init_vcpu(CPUState *cpu) init_decoder(cpu); init_cpuid(cpu); =20 - cpu->hvf_caps =3D (struct hvf_vcpu_caps *)g_malloc0(sizeof(struct hvf_= vcpu_caps)); + hvf_state->hvf_caps =3D (struct hvf_vcpu_caps *)g_malloc0(sizeof(struc= t hvf_vcpu_caps)); cpu->hvf_x86 =3D (struct hvf_x86_state *)g_malloc0(sizeof(struct hvf_x= 86_state)); =20 r =3D hv_vcpu_create((hv_vcpuid_t *)&cpu->hvf_fd, HV_VCPU_DEFAULT); @@ -612,37 +612,37 @@ int hvf_init_vcpu(CPUState *cpu) assert_hvf_ok(r); =20 if (hv_vmx_read_capability(HV_VMX_CAP_PINBASED, - &cpu->hvf_caps->vmx_cap_pinbased)) { + &hvf_state->hvf_caps->vmx_cap_pinbased)) { abort(); } if (hv_vmx_read_capability(HV_VMX_CAP_PROCBASED, - &cpu->hvf_caps->vmx_cap_procbased)) { + &hvf_state->hvf_caps->vmx_cap_procbased)) { abort(); } if (hv_vmx_read_capability(HV_VMX_CAP_PROCBASED2, - &cpu->hvf_caps->vmx_cap_procbased2)) { + &hvf_state->hvf_caps->vmx_cap_procbased2)) { abort(); } if (hv_vmx_read_capability(HV_VMX_CAP_ENTRY, - &cpu->hvf_caps->vmx_cap_entry)) { + &hvf_state->hvf_caps->vmx_cap_entry)) { abort(); } =20 /* set VMCS control fields */ wvmcs(cpu->hvf_fd, VMCS_PIN_BASED_CTLS, - cap2ctrl(cpu->hvf_caps->vmx_cap_pinbased, 0)); + cap2ctrl(hvf_state->hvf_caps->vmx_cap_pinbased, 0)); wvmcs(cpu->hvf_fd, VMCS_PRI_PROC_BASED_CTLS, - cap2ctrl(cpu->hvf_caps->vmx_cap_procbased, + cap2ctrl(hvf_state->hvf_caps->vmx_cap_procbased, VMCS_PRI_PROC_BASED_CTLS_HLT | VMCS_PRI_PROC_BASED_CTLS_MWAIT | VMCS_PRI_PROC_BASED_CTLS_TSC_OFFSET | VMCS_PRI_PROC_BASED_CTLS_TPR_SHADOW) | VMCS_PRI_PROC_BASED_CTLS_SEC_CONTROL); wvmcs(cpu->hvf_fd, VMCS_SEC_PROC_BASED_CTLS, - cap2ctrl(cpu->hvf_caps->vmx_cap_procbased2, + cap2ctrl(hvf_state->hvf_caps->vmx_cap_procbased2, VMCS_PRI_PROC_BASED2_CTLS_APIC_ACCESSES)); =20 - wvmcs(cpu->hvf_fd, VMCS_ENTRY_CTLS, cap2ctrl(cpu->hvf_caps->vmx_cap_en= try, + wvmcs(cpu->hvf_fd, VMCS_ENTRY_CTLS, cap2ctrl(hvf_state->hvf_caps->vmx_= cap_entry, 0)); wvmcs(cpu->hvf_fd, VMCS_EXCEPTION_BITMAP, 0); /* Double fault */ =20 @@ -829,7 +829,7 @@ int hvf_vcpu_exec(CPUState *cpu) uint32_t rcx =3D (uint32_t)rreg(cpu->hvf_fd, HV_X86_RCX); uint32_t rdx =3D (uint32_t)rreg(cpu->hvf_fd, HV_X86_RDX); =20 - cpu_x86_cpuid(cpu, rax, rcx, &rax, &rbx, &rcx, &rdx); + cpu_x86_cpuid(env, rax, rcx, &rax, &rbx, &rcx, &rdx); =20 wreg(cpu->hvf_fd, HV_X86_RAX, rax); wreg(cpu->hvf_fd, HV_X86_RBX, rbx); --=20 2.14.1