From nobody Sat May 4 19:25:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 15034784219141001.9575138899373; Wed, 23 Aug 2017 01:53:41 -0700 (PDT) Received: from localhost ([::1]:42525 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkRPu-00030M-AX for importer@patchew.org; Wed, 23 Aug 2017 04:53:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkRL5-0008Nd-4j for qemu-devel@nongnu.org; Wed, 23 Aug 2017 04:48:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkRL2-0003M7-2b for qemu-devel@nongnu.org; Wed, 23 Aug 2017 04:48:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34492) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dkRL1-0003Lu-T4 for qemu-devel@nongnu.org; Wed, 23 Aug 2017 04:48:36 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AC4D9C04B310 for ; Wed, 23 Aug 2017 08:39:08 +0000 (UTC) Received: from secure.mitica (ovpn-117-155.ams2.redhat.com [10.36.117.155]) by smtp.corp.redhat.com (Postfix) with ESMTP id 04680704A9; Wed, 23 Aug 2017 08:39:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AC4D9C04B310 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=quintela@redhat.com From: Juan Quintela To: qemu-devel@nongnu.org Date: Wed, 23 Aug 2017 10:39:00 +0200 Message-Id: <20170823083901.852-2-quintela@redhat.com> In-Reply-To: <20170823083901.852-1-quintela@redhat.com> References: <20170823083901.852-1-quintela@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 23 Aug 2017 08:39:08 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 1/2] tests: Use real size for iov tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, pbonzini@redhat.com, dgilbert@redhat.com, peterx@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We were using -1 instead of the real size because the functions check what is bigger, size in bytes or the size of the iov. Recent gcc's barf at this. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- tests/test-iov.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/test-iov.c b/tests/test-iov.c index a22d71fd2c..819c410a51 100644 --- a/tests/test-iov.c +++ b/tests/test-iov.c @@ -81,17 +81,17 @@ static void test_to_from_buf_1(void) * skip whole vector and process exactly 0 bytes */ =20 /* first set bytes [i..sz) to some "random" value */ - n =3D iov_memset(iov, niov, 0, 0xff, -1); + n =3D iov_memset(iov, niov, 0, 0xff, sz); g_assert(n =3D=3D sz); =20 /* next copy bytes [i..sz) from ibuf to iovec */ - n =3D iov_from_buf(iov, niov, i, ibuf + i, -1); + n =3D iov_from_buf(iov, niov, i, ibuf + i, sz - i); g_assert(n =3D=3D sz - i); =20 /* clear part of obuf */ memset(obuf + i, 0, sz - i); /* and set this part of obuf to values from iovec */ - n =3D iov_to_buf(iov, niov, i, obuf + i, -1); + n =3D iov_to_buf(iov, niov, i, obuf + i, sz - i); g_assert(n =3D=3D sz - i); =20 /* now compare resulting buffers */ @@ -109,7 +109,7 @@ static void test_to_from_buf_1(void) * with j in [i..sz]. */ =20 /* clear iovec */ - n =3D iov_memset(iov, niov, 0, 0xff, -1); + n =3D iov_memset(iov, niov, 0, 0xff, sz); g_assert(n =3D=3D sz); =20 /* copy bytes [i..j) from ibuf to iovec */ --=20 2.13.5 From nobody Sat May 4 19:25:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1503478060297108.14451726466382; Wed, 23 Aug 2017 01:47:40 -0700 (PDT) Received: from localhost ([::1]:42492 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkRK7-0007E4-2K for importer@patchew.org; Wed, 23 Aug 2017 04:47:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkRIn-0006hF-Vn for qemu-devel@nongnu.org; Wed, 23 Aug 2017 04:46:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkRIk-0001vb-UK for qemu-devel@nongnu.org; Wed, 23 Aug 2017 04:46:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60290) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dkRIk-0001uz-OV for qemu-devel@nongnu.org; Wed, 23 Aug 2017 04:46:14 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BF9957E43E for ; Wed, 23 Aug 2017 08:39:12 +0000 (UTC) Received: from secure.mitica (ovpn-117-155.ams2.redhat.com [10.36.117.155]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0DB86600C6; Wed, 23 Aug 2017 08:39:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BF9957E43E Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=quintela@redhat.com From: Juan Quintela To: qemu-devel@nongnu.org Date: Wed, 23 Aug 2017 10:39:01 +0200 Message-Id: <20170823083901.852-3-quintela@redhat.com> In-Reply-To: <20170823083901.852-1-quintela@redhat.com> References: <20170823083901.852-1-quintela@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 23 Aug 2017 08:39:12 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 2/2] tests: Make acpid test compile X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, pbonzini@redhat.com, dgilbert@redhat.com, peterx@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Compiler gets confused with the size of the struct, so move form g_new0() to g_malloc0(). I *think* that the problem is in gcc (or glib for that matter), but the documentation of the g_new0 states that 1sts first argument is an struct type, and uint32_t is not an struct type. Signed-off-by: Juan Quintela --- tests/vmgenid-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vmgenid-test.c b/tests/vmgenid-test.c index 3d5c1c3615..032e1d465a 100644 --- a/tests/vmgenid-test.c +++ b/tests/vmgenid-test.c @@ -67,7 +67,7 @@ static uint32_t acpi_find_vgia(void) g_assert_cmpint(tables_nr, >, 0); =20 /* get the addresses of the tables pointed by rsdt */ - tables =3D g_new0(uint32_t, tables_nr); + tables =3D g_malloc0(sizeof(uint32_t) * tables_nr); ACPI_READ_ARRAY_PTR(tables, tables_nr, rsdt); =20 for (i =3D 0; i < tables_nr; i++) { --=20 2.13.5