From nobody Mon Feb 9 20:31:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1503376280939106.93934054237525; Mon, 21 Aug 2017 21:31:20 -0700 (PDT) Received: from localhost ([::1]:35716 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dk0qV-0006YB-Oz for importer@patchew.org; Tue, 22 Aug 2017 00:31:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dk0ju-0000vt-Dn for qemu-devel@nongnu.org; Tue, 22 Aug 2017 00:24:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dk0jt-00088n-GY for qemu-devel@nongnu.org; Tue, 22 Aug 2017 00:24:30 -0400 Received: from ozlabs.org ([103.22.144.67]:34601) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dk0jt-00080h-4r; Tue, 22 Aug 2017 00:24:29 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 3xbyBF0RCKz9t3B; Tue, 22 Aug 2017 14:24:20 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1503375861; bh=Mah/vUqCLhcItaqBu28Ul1ertpxLOOUO2VC0ZSUEdlE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GcNY5Vw63pq1Ib2syRMwqDNXKfbM5BzeE4EIXT0g/rJc2cVaUTn6O+z0zBueIGISP sPsBJzDdkGwKszUmyTH6CIfnJoxeypDI54D5GgwA6M2JROoM/d98n4DcNurEhSWgY6 4lHooy0Kb3nMkeLmm/S17R0wlJYORDnIOZPDhsD0= From: David Gibson To: peter.maydell@linaro.org Date: Tue, 22 Aug 2017 14:24:16 +1000 Message-Id: <20170822042416.26758-8-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20170822042416.26758-1-david@gibson.dropbear.id.au> References: <20170822042416.26758-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 103.22.144.67 Subject: [Qemu-devel] [PULL 7/7] hw/ppc/spapr_iommu: Fix crash when removing the "spapr-tce-table" device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, thuth@redhat.com, mdroth@linux.vnet.ibm.com, cohuck@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, qemu-ppc@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Thomas Huth QEMU currently aborts unexpectedly when the user tries to add and remove a "spapr-tce-table" device: $ qemu-system-ppc64 -nographic -S -nodefaults -monitor stdio QEMU 2.9.92 monitor - type 'help' for more information (qemu) device_add spapr-tce-table,id=3Dx (qemu) device_del x ** ERROR:qemu/qdev-monitor.c:872:qdev_unplug: assertion failed: (hotplug_ctrl) Aborted (core dumped) The device should not be accessable for the users at all, it's just used internally, so mark it with user_creatable =3D false. Signed-off-by: Thomas Huth Signed-off-by: David Gibson --- hw/ppc/spapr_iommu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c index e614621a83..ed2d53559a 100644 --- a/hw/ppc/spapr_iommu.c +++ b/hw/ppc/spapr_iommu.c @@ -618,6 +618,8 @@ static void spapr_tce_table_class_init(ObjectClass *kla= ss, void *data) dc->init =3D spapr_tce_table_realize; dc->reset =3D spapr_tce_reset; dc->unrealize =3D spapr_tce_table_unrealize; + /* Reason: This is just an internal device for handling the hypercalls= */ + dc->user_creatable =3D false; =20 QLIST_INIT(&spapr_tce_tables); =20 --=20 2.13.5