From nobody Wed Feb 11 03:43:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1502262514428710.9375805888968; Wed, 9 Aug 2017 00:08:34 -0700 (PDT) Received: from localhost ([::1]:46015 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dfL6X-0001Hw-3F for importer@patchew.org; Wed, 09 Aug 2017 03:08:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46706) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dfL2W-0006Dl-7w for qemu-devel@nongnu.org; Wed, 09 Aug 2017 03:04:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dfL2V-00040q-95 for qemu-devel@nongnu.org; Wed, 09 Aug 2017 03:04:24 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:39643) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dfL2U-0003zd-Tt; Wed, 09 Aug 2017 03:04:23 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 3xS2Lh39J2z9sRm; Wed, 9 Aug 2017 17:04:12 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1502262252; bh=PmJVRH5FDLSvTzPtTPg/Q8/OGgGQ6OvGmsKY0xo13tg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WJ0ptX/j+QQkY6Wsiq/1taD72zf2qcry6ta5dM7yqGSJBCqSyW31ANTuScoXOvLGe vhsO1K2B1rPOd3tCxUol7sWdUfXh8Dlxv5FjEXWniGlDZxcTHnAOMTWDzoVMn+fDBy 4ghZIN2RDEsvA2/6tCYDHUOwbq8ZbHpVWz9my1jY= From: David Gibson To: peter.maydell@linaro.org Date: Wed, 9 Aug 2017 17:03:56 +1000 Message-Id: <20170809070357.28723-6-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.13.4 In-Reply-To: <20170809070357.28723-1-david@gibson.dropbear.id.au> References: <20170809070357.28723-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 5/6] spapr_drc: abort if object_property_add_child() fails X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de, groug@kaod.org, qemu-ppc@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Greg Kurz object_property_add_child() can only fail in two cases: - the child already has a parent, which shouldn't happen since the DRC was allocated a few lines above - the parent already has a child with the same name, which would mean the caller tries to create a DRC that already exists In both case, this is a QEMU bug and we should abort. Signed-off-by: Greg Kurz Signed-off-by: David Gibson --- hw/ppc/spapr_drc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index 47d94e782a..5260b5d363 100644 --- a/hw/ppc/spapr_drc.c +++ b/hw/ppc/spapr_drc.c @@ -541,7 +541,7 @@ sPAPRDRConnector *spapr_dr_connector_new(Object *owner,= const char *type, drc->owner =3D owner; prop_name =3D g_strdup_printf("dr-connector[%"PRIu32"]", spapr_drc_index(drc)); - object_property_add_child(owner, prop_name, OBJECT(drc), NULL); + object_property_add_child(owner, prop_name, OBJECT(drc), &error_abort); object_property_set_bool(OBJECT(drc), true, "realized", NULL); g_free(prop_name); =20 --=20 2.13.4