From nobody Wed Feb 11 03:02:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 150149147495899.96290764601554; Mon, 31 Jul 2017 01:57:54 -0700 (PDT) Received: from localhost ([::1]:58185 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dc6WP-0002IC-4Z for importer@patchew.org; Mon, 31 Jul 2017 04:57:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dc6RF-0006S0-01 for qemu-devel@nongnu.org; Mon, 31 Jul 2017 04:52:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dc6RD-0000gv-P2 for qemu-devel@nongnu.org; Mon, 31 Jul 2017 04:52:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40628) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dc6RD-0000g2-FK for qemu-devel@nongnu.org; Mon, 31 Jul 2017 04:52:31 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 62A86107D94; Mon, 31 Jul 2017 08:52:30 +0000 (UTC) Received: from t460p.pahim.org.com (ovpn-204-234.brq.redhat.com [10.40.204.234]) by smtp.corp.redhat.com (Postfix) with ESMTP id D1C5E8AD67; Mon, 31 Jul 2017 08:52:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 62A86107D94 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=apahim@redhat.com From: Amador Pahim To: qemu-devel@nongnu.org Date: Mon, 31 Jul 2017 10:51:10 +0200 Message-Id: <20170731085110.1050-8-apahim@redhat.com> In-Reply-To: <20170731085110.1050-1-apahim@redhat.com> References: <20170731085110.1050-1-apahim@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 31 Jul 2017 08:52:30 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v6 7/7] qemu.py: include debug information on launch error X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, ldoktor@redhat.com, famz@redhat.com, ehabkost@redhat.com, stefanha@gmail.com, Amador Pahim , armbru@redhat.com, mreitz@redhat.com, crosa@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When launching a VM, if an exception happens and the VM is not initiated, it is useful to see the qemu command line that was executed and the output of that command. Before this patch: >>> import qemu >>> vm =3D qemu.QEMUMachine('qemu-system-aarch64', debug=3DTrue) >>> vm.launch() Traceback (most recent call last): File "", line 1, in File "qemu.py", line 175, in launch self._launch() File "qemu.py", line 189, in _launch self._post_launch() File "qemu.py", line 154, in _post_launch self._qmp.accept() File "qmp/qmp.py", line 145, in accept self.__sock, _ =3D self.__sock.accept() File "/usr/lib64/python2.7/socket.py", line 206, in accept sock, addr =3D self._sock.accept() socket.timeout: timed out >>> After this patch: >>> import qemu >>> vm =3D qemu.QEMUMachine('qemu-system-aarch64', debug=3DTrue) >>> vm.launch() DEBUG:qemu:Error launching VM. Command: 'qemu-system-aarch64 -chardev socket,id=3Dmon,path=3D/var/tmp/qemu-5298-monitor.sock -mon chardev=3Dmon,mode=3Dcontrol -display none -vga none'. Output: 'qemu-system-aarch64: No machine specified, and there is no default\nUse -machine help to list supported machines\n'. Traceback (most recent call last): File "", line 1, in File "qemu.py", line 175, in launch self._launch() File "qemu.py", line 189, in _launch self._post_launch() File "qemu.py", line 154, in _post_launch self._qmp.accept() File "qmp/qmp.py", line 145, in accept self.__sock, _ =3D self.__sock.accept() File "/usr/lib64/python2.7/socket.py", line 206, in accept sock, addr =3D self._sock.accept() socket.timeout: timed out >>> Signed-off-by: Amador Pahim --- scripts/qemu.py | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/scripts/qemu.py b/scripts/qemu.py index e9a3a96d13..43fd0b072c 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -158,7 +158,10 @@ class QEMUMachine(object): self._remove_if_exists(self._created_files.pop()) =20 def launch(self): - '''Launch the VM and establish a QMP connection''' + ''' + Try to launch the VM and make sure we cleanup and expose the + command line/output in case of exception. + ''' =20 if self.is_running(): raise QEMULaunchError('VM already running.') @@ -169,6 +172,7 @@ class QEMUMachine(object): 'before launching again.') =20 try: + self._iolog =3D None self._qemu_full_args =3D None self._qemu_full_args =3D (self._wrapper + [self._binary] + self._base_args() + self._args) @@ -176,9 +180,15 @@ class QEMUMachine(object): self._pending_shutdown =3D True except: self.shutdown() + LOG.debug('Error launching VM.%s%s', + ' Command: %r.' % ' '.join(self._qemu_full_args) + if self._qemu_full_args else '', + ' Output: %r.' % self._iolog + if self._iolog else '') raise =20 def _launch(self): + '''Launch the VM and establish a QMP connection.''' self._pre_launch() devnull =3D open(os.path.devnull, 'rb') self._popen =3D subprocess.Popen(self._qemu_full_args, --=20 2.13.3