From nobody Tue Feb 10 20:14:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1501124019190481.99326360612486; Wed, 26 Jul 2017 19:53:39 -0700 (PDT) Received: from localhost ([::1]:40909 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daYvh-0006xk-KH for importer@patchew.org; Wed, 26 Jul 2017 22:53:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daYlj-0005lg-96 for qemu-devel@nongnu.org; Wed, 26 Jul 2017 22:43:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daYli-0008BI-FH for qemu-devel@nongnu.org; Wed, 26 Jul 2017 22:43:19 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:37554) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1daYli-0008B9-BB; Wed, 26 Jul 2017 22:43:18 -0400 Received: by mail-qt0-x241.google.com with SMTP id d10so7551975qtb.4; Wed, 26 Jul 2017 19:43:18 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id g27sm13221147qtg.84.2017.07.26.19.43.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Jul 2017 19:43:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aboSAXbLM3RFrT0NbLrX1Bi6xcmP5uJ8po8xpKKm3oU=; b=ftr6cSvT6TjI4v5Tlmw+RXp2QUxQXYPTzkRu6I9qo2TLk7laL1rupZZLmiRzx0IbiA tso4XeqvLABi6vefG+/Lo/TtMqIQEIBxmXukl/DXhbtyWbBrZI3i4pDUdz+05lK4J62g /C/2utR++YCy1Bg6SBqn7UWBmFW4X3ckxrC9tG9cgUfe3cPykjhAW2X2ZjgVsEsOcDNK 5UVKUTUrc8aBlHb5aPyAfJ9yfHvD+mO1ijQbYF2oblJiYGRrCu8HeYBdpD9Kho5LFVSp w1CHMFRtXde1UxvWfFbkW1x90m21JaP3YJ0SQ6OKhfrANt40Scg6W81alNrXJsBfCfKP A52A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=aboSAXbLM3RFrT0NbLrX1Bi6xcmP5uJ8po8xpKKm3oU=; b=Nj4IpeOX+sLY3IvB3fCYT7y3wmdc8BezF/k01cmWH9+53EbNHVDjLH67oTklpYrx0H Ra2wfjatXxl4enb7MLrkNb4GGw6leBqPcPUs9EfEigIcHAD6ue1pLYO2NR9PR14x3yNr t2XqRvByYFDHizv96gB1av7tRSxN0GJUTkX+RbIF41RDBFA08WaDFneVxztQBLJpa8wA WOkyT5RbMN/xg4wEnHhQFOs8pwI0LdD/QMHgkFJgKD/NUTdQujt9bLndrMnebLQ8sJ16 fPXi3ItmaurwpyPy3XMmJhkivaL8SIQ4i8fbIGRqYXNVZIzMGyF/95Ipe2QpzcoL9hfM GanQ== X-Gm-Message-State: AIVw111hmZfOyhSX3dgRWT9WifX3TN4ZQaYRz0o7zZGsFROVfG1AFyGk h3y0cTQolIwKOQ== X-Received: by 10.200.3.135 with SMTP id t7mr3932309qtg.216.1501123397839; Wed, 26 Jul 2017 19:43:17 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Eric Blake , Riku Voipio , Laurent Vivier Date: Wed, 26 Jul 2017 23:42:19 -0300 Message-Id: <20170727024224.22900-15-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170727024224.22900-1-f4bug@amsat.org> References: <20170727024224.22900-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH for 2.10 v2 14/20] syscall: check inotify() and eventfd() return value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 linux-user/syscall.c:555:25: warning: Out of bound memory access (accessed = memory precedes memory block) target_fd_trans[fd] =3D trans; ~~~~~~~~~~~~~~~~~~~~^~~~~~~ Reported-by: Clang Static Analyzer Suggested-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier --- linux-user/syscall.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 81f52f7483..dfc1301e63 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -11742,7 +11742,9 @@ abi_long do_syscall(void *cpu_env, int num, abi_lon= g arg1, #if defined(TARGET_NR_inotify_init) && defined(__NR_inotify_init) case TARGET_NR_inotify_init: ret =3D get_errno(sys_inotify_init()); - fd_trans_register(ret, &target_inotify_trans); + if (ret >=3D 0) { + fd_trans_register(ret, &target_inotify_trans); + } break; #endif #ifdef CONFIG_INOTIFY1 @@ -11750,7 +11752,9 @@ abi_long do_syscall(void *cpu_env, int num, abi_lon= g arg1, case TARGET_NR_inotify_init1: ret =3D get_errno(sys_inotify_init1(target_to_host_bitmask(arg1, fcntl_flags_tbl))); - fd_trans_register(ret, &target_inotify_trans); + if (ret >=3D 0) { + fd_trans_register(ret, &target_inotify_trans); + } break; #endif #endif @@ -11916,7 +11920,9 @@ abi_long do_syscall(void *cpu_env, int num, abi_lon= g arg1, #if defined(TARGET_NR_eventfd) case TARGET_NR_eventfd: ret =3D get_errno(eventfd(arg1, 0)); - fd_trans_register(ret, &target_eventfd_trans); + if (ret >=3D 0) { + fd_trans_register(ret, &target_eventfd_trans); + } break; #endif #if defined(TARGET_NR_eventfd2) @@ -11930,7 +11936,9 @@ abi_long do_syscall(void *cpu_env, int num, abi_lon= g arg1, host_flags |=3D O_CLOEXEC; } ret =3D get_errno(eventfd(arg1, host_flags)); - fd_trans_register(ret, &target_eventfd_trans); + if (ret >=3D 0) { + fd_trans_register(ret, &target_eventfd_trans); + } break; } #endif --=20 2.13.3