From nobody Tue Feb 10 20:14:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1501124079587232.55192947622254; Wed, 26 Jul 2017 19:54:39 -0700 (PDT) Received: from localhost ([::1]:40913 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daYwg-00087J-4X for importer@patchew.org; Wed, 26 Jul 2017 22:54:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daYlg-0005jI-RG for qemu-devel@nongnu.org; Wed, 26 Jul 2017 22:43:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daYle-00088a-UI for qemu-devel@nongnu.org; Wed, 26 Jul 2017 22:43:16 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:35840) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1daYle-00088R-PV; Wed, 26 Jul 2017 22:43:14 -0400 Received: by mail-qt0-x241.google.com with SMTP id c15so3483513qta.3; Wed, 26 Jul 2017 19:43:14 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id g27sm13221147qtg.84.2017.07.26.19.43.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Jul 2017 19:43:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cLrqu4rahS0olIV1A73338Pv0g+NkbJ8cRUvsbimbyk=; b=fknPEmPfTwmDzLDZ+GR+KPlbLhXLIyqNgZX6kfwk9mJuwr1V1WqOLwMvnFvRS8UaVy j7phGdxHBhjFTvHAI5WTPv3NmBXR1eY1OvtjJbK3HlPlgZt6Nq1MxmzWWSB1XNxzkASu Nn0vyWXnc6giXqeItVG7JwX0yzu2/tuCyHze5urZn5mLYYo8k+9rt7BFwzYafbrbj7vP bJ8lL90zy0nwZdx1AfO32q5c6MuWojAisajCOnPznOvfqmUubgFJehGET4tSnWDc3JIj TzaRodWJIueLZK2hyicUbgM9ZWhj50JnOPg6/vFRddx0IyUJcRilpO6Na5XJqPCD/lha tmxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=cLrqu4rahS0olIV1A73338Pv0g+NkbJ8cRUvsbimbyk=; b=WPH/qemrBfOT0flhl9oZCeAAgxPjq5tIdfSPcDQDvJBk7rOHxnXNsSR+z/Et3194lp MGAC62clpcNYKxY55D7ro1//tTMMGNr/enJljKBifZN67jKWRW/xBCTpGOGHA8Cp+BST uN0GFVj2UjeofULXp2CZyNT37hr37NVBoGRWsCDcAl1esMls/wrijaJvEgyYA/wccd3v DrQAWUGZSs5PuLDOgczp/FmDHguJ6rc4fjTwRfZbh8jV3s+5YdLZLNmaCruwYuJQ7sEo 6+qesuSK50Gy6b+qfnAufsRZcjxnV8WqzgybplEgAF4E+s72L5UFCV5RbwbqpCbWeDrv rIuw== X-Gm-Message-State: AIVw110cniYBGYZ3XRqfkLC0eaNMSowv/xy05r0/BB5Otoj1+LLhHhrE OUf5mLzcqMLT10HrIr67rA== X-Received: by 10.200.40.210 with SMTP id j18mr4277331qtj.172.1501123394301; Wed, 26 Jul 2017 19:43:14 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Eric Blake Date: Wed, 26 Jul 2017 23:42:18 -0300 Message-Id: <20170727024224.22900-14-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170727024224.22900-1-f4bug@amsat.org> References: <20170727024224.22900-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH for 2.10 v2 13/20] syscall: fix use of uninitialized values X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 linux-user/syscall.c:1627:35: warning: 1st function call argument is an uni= nitialized value target_saddr->sa_family =3D tswap16(addr->sa_family); ^~~~~~~~~~~~~~~~~~~~~~~~ linux-user/syscall.c:1629:25: warning: The left operand of '=3D=3D' is a ga= rbage value if (addr->sa_family =3D=3D AF_NETLINK && len >=3D sizeof(struct sockadd= r_nl)) { ~~~~~~~~~~~~~~~ ^ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 71d45a9963..81f52f7483 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -1622,6 +1622,7 @@ static inline abi_long host_to_target_sockaddr(abi_ul= ong target_addr, if (len =3D=3D 0) { return 0; } + assert(addr); =20 target_saddr =3D lock_user(VERIFY_WRITE, target_addr, len, 0); if (!target_saddr) --=20 2.13.3