From nobody Tue Feb 10 20:14:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1501124081989773.0970226376106; Wed, 26 Jul 2017 19:54:41 -0700 (PDT) Received: from localhost ([::1]:40914 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daYwi-0008Cl-KE for importer@patchew.org; Wed, 26 Jul 2017 22:54:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daYlc-0005fX-J5 for qemu-devel@nongnu.org; Wed, 26 Jul 2017 22:43:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daYlb-000862-SU for qemu-devel@nongnu.org; Wed, 26 Jul 2017 22:43:12 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:35747) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1daYlb-00085w-Oq; Wed, 26 Jul 2017 22:43:11 -0400 Received: by mail-qk0-x244.google.com with SMTP id k2so9706707qkf.2; Wed, 26 Jul 2017 19:43:11 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id g27sm13221147qtg.84.2017.07.26.19.43.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Jul 2017 19:43:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Jm9KVQN1EQgrWTyjd2EVOLfIC9IQy/8UySAlPsFv75U=; b=CTLRlVDaPjRJYEcyNzzeRZQm6LmA4kqVdzY9YefmZpFw/ePeVcTkVK5zRqRunItNPQ 0kYg782/ZyIDPiFMLKHnA5Bzc7axnyWHWdlSP5PsDxLBsXoFDbAVuXvYBmb+idUIJhv+ DKGRr/Ni3HP1TttVm93XK6zMpMMHnPQcyWQSimYSmGe8IPKwiyA83UyljAdM5DUZvrB7 yYN4FS0E8NCs5HTbGo2mPWX/Mjhngs9ZwA19PMXN23cu2tak1fTM7bUZ6BVgpar8bQtT +TyuRE9BUy2fvoaHM5jC+55OkHOewJuE5urbKuhbG6CSRXDbU5ZWQ9SuG/8UY/o0qvBo hdRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Jm9KVQN1EQgrWTyjd2EVOLfIC9IQy/8UySAlPsFv75U=; b=AyiR942hjOMBVkxGhDwnpZ9rv1I26NSWFRl+Gnj50agduD9ZbfxXtQlgrS57NPYXek vgaNL8IvDHB/3e+CgC90gUuZtgRroYTAdyvcIGcFPkeO+KS9SsgkCWu3HAFBTaK5IZeL XdP3JucrulIRbbwWKs0+XrQ6cgc35XMMNHoswqBvlaxKZWzOtph6tJROcBBnKagFXF8w zLnjwNX1QLyUxgJFR3WbikSXOR/rH6ut2lTxSiLtoRgWVlzr9PUHPT8tlDjLdZ/haLM7 eD3AyaSNzkIVnjyA+ovq35D8ALy0l//KM7pAK0uoxbSoGUPSvomimqMtexBKuV7RPMA8 +8LQ== X-Gm-Message-State: AIVw110Dmp/u0I4g/n/+UCdiuwMNxs9oRQEcyEd0yDaiLr7nzB3GxQXI vZgYTrrXgmdA+JpDTkk/DQ== X-Received: by 10.55.167.211 with SMTP id q202mr3818651qke.77.1501123391208; Wed, 26 Jul 2017 19:43:11 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Eric Blake , Riku Voipio , Laurent Vivier Date: Wed, 26 Jul 2017 23:42:17 -0300 Message-Id: <20170727024224.22900-13-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170727024224.22900-1-f4bug@amsat.org> References: <20170727024224.22900-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH for 2.10 v2 12/20] syscall: fix dereference of undefined pointer X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 linux-user/syscall.c:5581:9: warning: Dereference of undefined pointer value if (*host_rt_dev_ptr !=3D 0) { ^~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Suggested-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 003943b736..71d45a9963 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -5573,6 +5573,7 @@ static abi_long do_ioctl_rt(const IOCTLEntry *ie, uin= t8_t *buf_temp, field_types, THUNK_HOST); } unlock_user(argptr, arg, 0); + assert(host_rt_dev_ptr); =20 ret =3D get_errno(safe_ioctl(fd, ie->host_cmd, buf_temp)); if (*host_rt_dev_ptr !=3D 0) { --=20 2.13.3