From nobody Tue Feb 10 20:14:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1501123837877214.39523577263208; Wed, 26 Jul 2017 19:50:37 -0700 (PDT) Received: from localhost ([::1]:40893 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daYsl-0004he-Da for importer@patchew.org; Wed, 26 Jul 2017 22:50:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daYlR-0005VP-VM for qemu-devel@nongnu.org; Wed, 26 Jul 2017 22:43:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daYlR-0007xK-79 for qemu-devel@nongnu.org; Wed, 26 Jul 2017 22:43:02 -0400 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:33265) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1daYlR-0007wi-3X; Wed, 26 Jul 2017 22:43:01 -0400 Received: by mail-qk0-x242.google.com with SMTP id d145so14634290qkc.0; Wed, 26 Jul 2017 19:43:00 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id g27sm13221147qtg.84.2017.07.26.19.42.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Jul 2017 19:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H23FVpCid9feWmXmb1T5ujJgbQv1GZZHSHDMEKnXeao=; b=iaMyEI9TNPviiXHLXDgUP8W+8hqRz42yKEK84Yi7QUutoc26tGY2gBXF700gsoQEsF 33g8hbgvHFOa7J/7EnBjr9iwEA8h/a66r5TxLCCb05fLrWnPRbnVdBXyvEqsKgMBV4Xx Ynz8OcZ0qgAEV1WvNgxHqiQNcnnCFWYfNl2pCDDDw1t2HhcMMGFvroxrgyskoSDrFGPs WWPcQyFdYBGhg1oaP5qSwN8oP97aLBDj4SwbAatBsez00SYpVcTgl81j8ZaqG5a9ArYl SQyzOMJtpo5j1zO+zmBOJWH1XNbJtnMqNtTezQEzFJ4lCA+hLkdJMz0lkTTk3XiBgV4F r7fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=H23FVpCid9feWmXmb1T5ujJgbQv1GZZHSHDMEKnXeao=; b=HXzCcssrrKnjRm04yifLVvsOIvPlwVXp2Lhfy6j3/Km+60IRNd0n+bScl8TLla62J+ jKdIJP5oSZ9r1Exgga1St5jysk9t14hRL2J/TNCf01SXqboOqQBng7aP+ZlIfaUax/om 9c6A8j8QScvul2ycr4xCHEMs9qv+WOTISqKODZVXLXm7TC/U1slklGjBc3raT2axiwvh vucvEiIXSN8w3kT872NRKOUsUwyJy7U4+lDKsFQggbae03pR5sq+bFWJpZeDFknrR/BZ lemxgzI318zI6V2Z9wHb5CZqo2UWiqZ5EH4+hCFsc34G/ctrQ+YcLqKguEK65002KJUU KDIw== X-Gm-Message-State: AIVw113NLSmSVYjn4jKl87bvIaGYIxs0Gh3mT+IiYCDncxYtKA2gLHAS xwP+WVZF/Ii++w== X-Received: by 10.55.146.133 with SMTP id u127mr3771975qkd.17.1501123380615; Wed, 26 Jul 2017 19:43:00 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Eric Blake Date: Wed, 26 Jul 2017 23:42:14 -0300 Message-Id: <20170727024224.22900-10-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170727024224.22900-1-f4bug@amsat.org> References: <20170727024224.22900-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH for 2.10 v2 09/20] vfio/pci: fix use of freed memory X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 hw/vfio/pci.c:308:29: warning: Use of memory after it is freed qemu_set_fd_handler(*pfd, NULL, NULL, vdev); ^~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Paolo Bonzini --- hw/vfio/pci.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index d4051cb951..31e1edf447 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -257,7 +257,7 @@ static void vfio_intx_update(PCIDevice *pdev) static int vfio_intx_enable(VFIOPCIDevice *vdev, Error **errp) { uint8_t pin =3D vfio_pci_read_config(&vdev->pdev, PCI_INTERRUPT_PIN, 1= ); - int ret, argsz; + int ret, argsz, retval =3D 0; struct vfio_irq_set *irq_set; int32_t *pfd; Error *err =3D NULL; @@ -302,12 +302,12 @@ static int vfio_intx_enable(VFIOPCIDevice *vdev, Erro= r **errp) qemu_set_fd_handler(*pfd, vfio_intx_interrupt, NULL, vdev); =20 ret =3D ioctl(vdev->vbasedev.fd, VFIO_DEVICE_SET_IRQS, irq_set); - g_free(irq_set); if (ret) { error_setg_errno(errp, -ret, "failed to setup INTx fd"); qemu_set_fd_handler(*pfd, NULL, NULL, vdev); event_notifier_cleanup(&vdev->intx.interrupt); - return -errno; + retval =3D -errno; + goto cleanup; } =20 vfio_intx_enable_kvm(vdev, &err); @@ -319,7 +319,10 @@ static int vfio_intx_enable(VFIOPCIDevice *vdev, Error= **errp) =20 trace_vfio_intx_enable(vdev->vbasedev.name); =20 - return 0; +cleanup: + g_free(irq_set); + + return retval; } =20 static void vfio_intx_disable(VFIOPCIDevice *vdev) --=20 2.13.3