From nobody Wed Nov 5 02:12:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500961609355927.0527506017346; Mon, 24 Jul 2017 22:46:49 -0700 (PDT) Received: from localhost ([::1]:58565 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZsgB-0001P8-TB for importer@patchew.org; Tue, 25 Jul 2017 01:46:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZsep-0000Xk-89 for qemu-devel@nongnu.org; Tue, 25 Jul 2017 01:45:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZseo-0006Fo-Cr for qemu-devel@nongnu.org; Tue, 25 Jul 2017 01:45:23 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:44791) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dZseo-0006Ei-1O; Tue, 25 Jul 2017 01:45:22 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 3xGnJb01bnz9rxj; Tue, 25 Jul 2017 15:45:18 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1500961519; bh=ePysrWyqbwq+dwq5rUvD1x2xlkDsR97g/TWOJ94H5BI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I5BRVb94kmZFCXVBcMNfr1QbmhQGt2SlgrrRwd3xcqGL/SofoCQEiyuTpiK1scWS3 CKxk/7Xpfg0NI/3Lw7aJXR8jzpZ0FeuJwMW8BLvjZLolxAG7drAoKlRrT4jlVCMZXO POaEQJZ/ZMblfqmXN98nYwONT97ySYzeJMEJOtIM= From: David Gibson To: peter.maydell@linaro.org Date: Tue, 25 Jul 2017 15:45:08 +1000 Message-Id: <20170725054510.15177-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170725054510.15177-1-david@gibson.dropbear.id.au> References: <20170725054510.15177-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 2/4] spapr/htab: fix savevm X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org, aik@ozlabs.ru, agraf@suse.de, groug@kaod.org, qemu-ppc@nongnu.org, bharata@linux.vnet.ibm.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Laurent Vivier Commit 3a38429 ("spapr: Add a "no HPT" encoding to HTAB migration stream") allows to migrate an empty HPT, but doesn't mark correctly the end of the migration stream. The end condition (value returned by htab_save_iterate()) should be 1, whereas in 3a38429 it returns 0. The problem can be reproduced with QEMU monitor command "savevm": the command never stops and the disk image grows without limit. Fixes: 3a38429748aa4f74abaecf16c4c087e8a325e12a Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth Signed-off-by: David Gibson --- hw/ppc/spapr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 970093e6b5..1cb09e7c64 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1827,7 +1827,7 @@ static int htab_save_iterate(QEMUFile *f, void *opaqu= e) /* Iteration header */ if (!spapr->htab_shift) { qemu_put_be32(f, -1); - return 0; + return 1; } else { qemu_put_be32(f, 0); } --=20 2.13.3