From nobody Mon Feb 9 11:06:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500929164868993.3390887969621; Mon, 24 Jul 2017 13:46:04 -0700 (PDT) Received: from localhost ([::1]:56901 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZkEt-0000pw-FN for importer@patchew.org; Mon, 24 Jul 2017 16:46:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZjyH-0003nS-Nd for qemu-devel@nongnu.org; Mon, 24 Jul 2017 16:28:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZjyG-0001wt-S3 for qemu-devel@nongnu.org; Mon, 24 Jul 2017 16:28:53 -0400 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:34516) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZjyG-0001wH-Mx for qemu-devel@nongnu.org; Mon, 24 Jul 2017 16:28:52 -0400 Received: by mail-qk0-x242.google.com with SMTP id q66so10950767qki.1 for ; Mon, 24 Jul 2017 13:28:52 -0700 (PDT) Received: from bigtime.com ([71.217.194.233]) by smtp.gmail.com with ESMTPSA id p52sm9196808qtc.74.2017.07.24.13.28.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Jul 2017 13:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/TFokTVpKp0Xl68UmEZmPP5yoJ7a5PH+kRrUV/ZxSu0=; b=gVihI4LsL+530D3KMS9XYHBLg8+TymJOOkJpKaJa+6rAw8+d3mnh3fmSN6n3mWGv1v u55sACcIGcNuj9szHvYBWbp5LRhQHs68RJpHRNIInFiOIvHiPlHWpbNPiyIL0dcv5h/b bSWDPtjgEEiWyliSE+lDXUkp94XQ3JNqUuK8pvmkgvoBjlh/sS1PGTjh74Gete5IhWTd z+Bd97vEJ9xfMYLIFgkmOZGac7+ilr7bidg5vwi+UQTDRtmruqyUwANkvYIZ7uwX3Sfo v+6ortj7rrr/03ojNq0LKOjDD2rJZg41J9MJ6duJTjds5+9ZBLgUjvpbqpdZTNR0oEov SWDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=/TFokTVpKp0Xl68UmEZmPP5yoJ7a5PH+kRrUV/ZxSu0=; b=aIzpVLwIDcBoK/hCxk290pnuhVIe4Bd8MQ+YGAFcyFfkS3rww6/dQcmB94oBRDmavA liiikP6SjUZQ/RYpA1MiPzxz8KHSyDcQfRS0uWBoLSlixwKv8kXy1cTVoKsRQJwMZT+H D/dRrrmQoTa8T1/a7XsOpgrw+kSEFhlF/7DUUQrSCETiulwaWZENWKPEO4vdbPUxH1JR hzo6/m03a8nCf9UasD8HduFJpwakvsevYulzJ2cdqvEun4uzFhPQnCa6OAYs0cOdNoHY 1UJWk7TALLIec+zFbgeim+w1qyVUu4/LEMcK8RNE0p+ZmK69Voo4utJtWuDwR0u02Unx jnNQ== X-Gm-Message-State: AIVw111BabRU676CNp0BxbznFhJeD6pXP6zxy6mdZs0F19fCbfIuxs1M jnsiR3mRdltxjm6dTrU= X-Received: by 10.55.21.28 with SMTP id f28mr12571796qkh.220.1500928131952; Mon, 24 Jul 2017 13:28:51 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 24 Jul 2017 13:27:26 -0700 Message-Id: <20170724202728.25960-31-rth@twiddle.net> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724202728.25960-1-rth@twiddle.net> References: <20170724202728.25960-1-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH v15 30/32] target/arm: Move ss check to init_disas_context X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cota@braap.org, vilanova@ac.upc.edu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 We can check for single-step just once. Reviewed-by: Emilio G. Cota Reviewed-by: Llu=C3=ADs Vilanova Signed-off-by: Richard Henderson --- target/arm/translate.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 5991422695..cdf2917cef 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -11853,6 +11853,11 @@ static int arm_tr_init_disas_context(DisasContextB= ase *dcbase, dc->next_page_start =3D (dc->base.pc_first & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE; =20 + /* If architectural single step active, limit to 1. */ + if (is_singlestepping(dc)) { + max_insns =3D 1; + } + cpu_F0s =3D tcg_temp_new_i32(); cpu_F1s =3D tcg_temp_new_i32(); cpu_F0d =3D tcg_temp_new_i64(); @@ -12007,11 +12012,9 @@ static void arm_tr_translate_insn(DisasContextBase= *dcbase, CPUState *cpu) * Also stop translation when a page boundary is reached. This * ensures prefetch aborts occur at the right place. */ =20 - if (is_singlestepping(dc)) { - dc->base.is_jmp =3D DISAS_TOO_MANY; - } else if ((dc->pc >=3D dc->next_page_start) || - ((dc->pc >=3D dc->next_page_start - 3) && - insn_crosses_page(env, dc))) { + if (dc->pc >=3D dc->next_page_start || + (dc->pc >=3D dc->next_page_start - 3 && + insn_crosses_page(env, dc))) { /* We want to stop the TB if the next insn starts in a new pag= e, * or if it spans between this page and the next. This means t= hat * if we're looking at the last halfword in the page we need to --=20 2.13.3