From nobody Mon Feb 9 19:53:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500929324881645.2423763781628; Mon, 24 Jul 2017 13:48:44 -0700 (PDT) Received: from localhost ([::1]:56918 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZkHT-0002tH-7L for importer@patchew.org; Mon, 24 Jul 2017 16:48:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZjyG-0003n8-H4 for qemu-devel@nongnu.org; Mon, 24 Jul 2017 16:28:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZjyF-0001uf-9G for qemu-devel@nongnu.org; Mon, 24 Jul 2017 16:28:52 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:33475) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZjyF-0001uF-4L for qemu-devel@nongnu.org; Mon, 24 Jul 2017 16:28:51 -0400 Received: by mail-qk0-x241.google.com with SMTP id d145so8411740qkc.0 for ; Mon, 24 Jul 2017 13:28:51 -0700 (PDT) Received: from bigtime.com ([71.217.194.233]) by smtp.gmail.com with ESMTPSA id p52sm9196808qtc.74.2017.07.24.13.28.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Jul 2017 13:28:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=dTn2cvQQGr+e3wU+m4ntv6Dnw953RHH6xePaNXCG3lE=; b=AF95Q+uMLZWNcPs6wRdQ1GYrcm2PAaIen/tYUiCjr3nyof5nQOQ8gbYZq9SL5igObf w7NnJlSBy38mDBdjjnoJglWa0mJUviiq7LOEXthnm8ms1AFq9TpOURfBowH+dWlB5Rqb AW2k20e7RlCzWNebby0RgM6f02yKZdjAQoO+CiAUv+cRRC/tRKnzqLQhCZpRQHCW4ADd RLlSvYG/DtO52LDnCu/ktDZCAsXoAzM2xwANXg7lYQ3G8R6aiONFYCRkclS+zFWoB8I3 IW9YpQrEnmC/pbwcvi2HZrYyfZKNqjpm+IJdQHcG5mFXrL2AsRHdiMlJjdAz5cTNYWNq mS1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=dTn2cvQQGr+e3wU+m4ntv6Dnw953RHH6xePaNXCG3lE=; b=hbCiStLvzntAFwx4YjlhaCYNpBSpZ8Z9OZfQ0IbSP1UajTtfIR5kXM9JicRlw2am9j iWn99XXhlpTauLk3gYGs/aLVv5ATFLTMHngyz94Mw0gTRMaQFfxtEHmVCwySAQuT9wwy ggxRbKaObp2DfAbevUM7Vn3z/92Lk9KwM4My0f1FxxT/PXTQr3GM/CinsQhcLATjBB/D pM7fsZF9Nc+nhtYConvIGoEeFUHKS9EDoc7U1tTG5EdJpgCDsN5ku8WdGY0nXlyGM/4O ZXHVMDeVeIiW3q/1f0vW85vq+YlOK0zpVEKUQIx0NhL8Fb2ZD4sW0X6rZPLIbuDYxpXG 9cgg== X-Gm-Message-State: AIVw112+Be7rowWQZf0AHFF9Q9WietePQIa+s2KYYkGXzJU1mSkCMwIQ 82kMwZ3w3LbnkQVFh8g= X-Received: by 10.55.27.83 with SMTP id b80mr20206547qkb.148.1500928130272; Mon, 24 Jul 2017 13:28:50 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 24 Jul 2017 13:27:25 -0700 Message-Id: <20170724202728.25960-30-rth@twiddle.net> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724202728.25960-1-rth@twiddle.net> References: <20170724202728.25960-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH v15 29/32] target/arm: [a64] Move page and ss checks to init_disas_context X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cota@braap.org, vilanova@ac.upc.edu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Since AArch64 uses a fixed-width ISA, we can pre-compute the number of insns remaining on the page. Also, we can check for single-step once. Reviewed-by: Emilio G. Cota Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 9093b8ac17..b577a58e04 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -11185,6 +11185,7 @@ static int aarch64_tr_init_disas_context(DisasConte= xtBase *dcbase, DisasContext *dc =3D container_of(dcbase, DisasContext, base); CPUARMState *env =3D cpu->env_ptr; ARMCPU *arm_cpu =3D arm_env_get_cpu(env); + int bound; =20 dc->pc =3D dc->base.pc_first; dc->condjmp =3D 0; @@ -11233,8 +11234,14 @@ static int aarch64_tr_init_disas_context(DisasCont= extBase *dcbase, dc->is_ldex =3D false; dc->ss_same_el =3D (arm_debug_target_el(env) =3D=3D dc->current_el); =20 - dc->next_page_start =3D - (dc->base.pc_first & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE; + /* Bound the number of insns to execute to those left on the page. */ + bound =3D -(dc->base.pc_first | TARGET_PAGE_MASK) / 4; + + /* If architectural single step active, limit to 1. */ + if (dc->ss_active) { + bound =3D 1; + } + max_insns =3D MIN(max_insns, bound); =20 init_tmp_a64_array(dc); =20 @@ -11302,12 +11309,6 @@ static void aarch64_tr_translate_insn(DisasContext= Base *dcbase, CPUState *cpu) disas_a64_insn(env, dc); } =20 - if (dc->base.is_jmp =3D=3D DISAS_NEXT) { - if (dc->ss_active || dc->pc >=3D dc->next_page_start) { - dc->base.is_jmp =3D DISAS_TOO_MANY; - } - } - dc->base.pc_next =3D dc->pc; translator_loop_temp_check(&dc->base); } --=20 2.13.3