From nobody Thu Oct 30 16:32:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921335832122.71739830553418; Mon, 24 Jul 2017 11:35:35 -0700 (PDT) Received: from localhost ([::1]:56347 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiCb-0005tD-5Q for importer@patchew.org; Mon, 24 Jul 2017 14:35:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi5s-0008SF-1i for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi5r-0004nt-9A for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:36 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:37797) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi5r-0004nj-40; Mon, 24 Jul 2017 14:28:35 -0400 Received: by mail-qk0-x244.google.com with SMTP id q130so10663473qka.4; Mon, 24 Jul 2017 11:28:35 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1YRdkNwqoguRAYwqKV9yS5uo8kBBb/VJVwiVO0tuvzo=; b=LaPnFQ+IIzOChHfwgsNXDslKFzp6P6jNQcVWyjAx/OHCYm4vZW0XdBXq9RRHX/Y7To cl9qP+PbIvexP5wvhTWjwuAe4YMZBkBWY26049LFimFZJtN29ttIlSzmYhx6Ts0Q3jFx atN882cN2OKn1kGG9T8+K5+SbaFYqrCQn03Tocd98ugp8w4lCln0qO5XMQh3b6CUgjuw hlYNhnwmLBXhydo3+UJlAucNXPQL3melkcyR/wggLw75seonQJPZBAraP0Dux6GU/Bzt 0WErYdL6oAaN80KzW0HBQLuycXLYRtlXavBsduFTolwrWrA4LijWPw0B80M7kJaOBMbd U9yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=1YRdkNwqoguRAYwqKV9yS5uo8kBBb/VJVwiVO0tuvzo=; b=o3J7gdRHpqA2KcCLAD3MQaPTlv+A3JcghshvQLJuM0Kvl3RMeMfNBNzJutpUusbfv6 0e5FGt+g1WISgxlMgrTMj0En2HJs6/3g3UwWFpXvDUU5NDKokG2fcKHaAiPHQcLHL7i8 o9wqeGxcWV138xkM2Pr0Phqow2a/1nJJQEPPt2Vklha999BI9XD2FvIU5PjXg4dpGUQy 4Fsw1gsW4B/p2covdXqoNgJpSj5GcagiFGEWbPXob4A8tosruq270Dl3le6QF9uQSaml DPf3JeCRT4z3iL8UilGrtu1e5BE7dgNwedyDVKyFnCn50OCBZB4CGXvy5vD0Hopzh/04 2qHw== X-Gm-Message-State: AIVw112VIpRihycgh0RuI03u9rG9ikKTyeEDowILydAH1VvwKcgYuXsC ROwXQgkU3bJ/2A== X-Received: by 10.55.64.81 with SMTP id n78mr20321939qka.36.1500920914476; Mon, 24 Jul 2017 11:28:34 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Kevin Wolf , Max Reitz Date: Mon, 24 Jul 2017 15:27:24 -0300 Message-Id: <20170724182751.18261-9-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH for 2.10 08/35] qcow2: fix null pointer dereference X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-block@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 It seems this assert() was somehow misplaced. block/qcow2-refcount.c:2193:42: warning: Array access (from variable 'on_di= sk_reftable') results in a null pointer dereference on_disk_reftable[refblock_index] =3D refblock_offset; ~~~~~~~~~~~~~~~~ ^ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Eric Blake --- block/qcow2-refcount.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index c9b0dcb4f3..168fc32e7b 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -2189,6 +2189,8 @@ write_refblocks: * this will leak that range, but we can easily fix that by ru= nning * a leak-fixing check after this rebuild operation */ reftable_offset =3D -1; + } else { + assert(on_disk_reftable); } on_disk_reftable[refblock_index] =3D refblock_offset; =20 @@ -2258,8 +2260,6 @@ write_refblocks: goto write_refblocks; } =20 - assert(on_disk_reftable); - for (refblock_index =3D 0; refblock_index < reftable_size; refblock_in= dex++) { cpu_to_be64s(&on_disk_reftable[refblock_index]); } --=20 2.13.3