From nobody Thu Oct 30 16:33:18 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 150092131830472.60417455037816; Mon, 24 Jul 2017 11:35:18 -0700 (PDT) Received: from localhost ([::1]:56339 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiCJ-0005cX-9J for importer@patchew.org; Mon, 24 Jul 2017 14:35:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi5l-0008JV-NK for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi5l-0004m3-2x for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:29 -0400 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:36227) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi5k-0004lv-Uv; Mon, 24 Jul 2017 14:28:29 -0400 Received: by mail-qt0-x243.google.com with SMTP id l55so12883333qtl.3; Mon, 24 Jul 2017 11:28:28 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oC29Xthh5htKicMmTdacTWVlYUt0HacjYrnWbEybAyU=; b=B1SoFQBIxILsSvlNIlj09hcY4MJWmMXE9KT0po20l0iIgp9xuy42YcjGluHqsH0OHb HFuAJyPR2iotNmPTKXb0t7z4Yw82VMux+ERNHS+8tSwaqGmA+7QMynSFM/raKf3/Tduz 0X5Gr+KqgmCffgKaYaZR5NZ1tVtKrmQt5H45ls8oeYq7i0sRJN5Xap+WtgtdV/GrJVHK riPz8IzImNOmm+FlzIL8o6p0PZFMIpzEIcpK1pxbWF79f+i00RIK76aN8ldswIbwUv9Y fRQlN3Pwn5HW3ucNgHpwIRfeu0raADBLZWlFKNSFeQyr7ydrP6gY4bn4wtrzE25aqmMz 6bqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=oC29Xthh5htKicMmTdacTWVlYUt0HacjYrnWbEybAyU=; b=tovvv7il+6EuLqda3RhI2UHT4g7WaS1huMEWbGVBw55n0jEFdJ2XckkMKhcVJXXf0g XYcGUTcna4oj0j8GudOA2NSZLA6k1Fu1qe430EOR2lo0vNiJyQN3zLrkZwFxtwhBtxk1 t43Eiuw+RNQHC4CAJimZrBjAMAtLhPUaWBaTPdi4EoWKvCzyX30q5XepdUmun/jFEvsw E4J7y0cYgNCxVqiFQRUPS1hql4o3qozxfe9jm31PMgPldBgCS/zjnxvzKn6VKxU8ldjH 6a4EEP3kCYgg24WxjCXWGudWXYFZHPZQJsbbaOvIkWLIOOPB5emVbBLmxhbQbY7hTv9r M2aQ== X-Gm-Message-State: AIVw112AnZx9Vd9bMwLNy/rQXBRe9HH9UNIrSUJBhZ5n4mn4YRc/wpZq Gkp/rZA7wxjeWg== X-Received: by 10.237.37.70 with SMTP id w6mr2464337qtc.215.1500920908397; Mon, 24 Jul 2017 11:28:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Kevin Wolf , Max Reitz Date: Mon, 24 Jul 2017 15:27:22 -0300 Message-Id: <20170724182751.18261-7-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH for 2.10 06/35] qcow2: remove inconsistent check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-block@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 This is equivalent to assert(russian roulette) so better remove it. block/qcow2-bitmap.c:259:29: warning: The left operand of '=3D=3D' is a gar= bage value assert(bitmap_table =3D=3D NULL); ~~~~~~~~~~~~ ^ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- block/qcow2-bitmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c index 3e8735a20d..fe72df5057 100644 --- a/block/qcow2-bitmap.c +++ b/block/qcow2-bitmap.c @@ -254,7 +254,6 @@ static int free_bitmap_clusters(BlockDriverState *bs, Q= cow2BitmapTable *tb) =20 ret =3D bitmap_table_load(bs, tb, &bitmap_table); if (ret < 0) { - assert(bitmap_table =3D=3D NULL); return ret; } =20 --=20 2.13.3