From nobody Thu Oct 30 16:33:18 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921176844827.069391779456; Mon, 24 Jul 2017 11:32:56 -0700 (PDT) Received: from localhost ([::1]:56331 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiA1-0003dZ-UT for importer@patchew.org; Mon, 24 Jul 2017 14:32:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi5b-00089V-0g for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi5a-0004ic-6U for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:19 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:32863) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi5a-0004iV-2N; Mon, 24 Jul 2017 14:28:18 -0400 Received: by mail-qt0-x241.google.com with SMTP id n42so3126732qtn.0; Mon, 24 Jul 2017 11:28:17 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WcqnCQ/ToTRAQymS8Tq8QZzva+ADZC7U5pEV8ND91pE=; b=VisBhtr8JebtWQEJMz0rYus2jqMdY0hSEFzqlTfWVUDtBFnITuzq4dLuz/SR7GjD2x vu2riuLQ078AMmHOA3ZjnZim+eeVhjvz7kjOfh8ptzvL8foeFgCGPBOIC4Br9KxKj7tR 4bpqI4qXqKMN/i39Z5uQBacc7lBX/HVzBIJBlT9G0uKvLZsXylA6Z2gffu+d7Mb8Stur YZ0nh5efihb3ZX4iqiGacB+k2TwP5ojbkzGA4LsOs8bP+YSXfxU73VPPr/HBuyTBRLbK 06n2ZPzcBAfDJwzSDmfZAz9RpzFrVrGICDY2kyobofYEvfTdFrxoUVmReEWorwLkT+aj 9Y8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=WcqnCQ/ToTRAQymS8Tq8QZzva+ADZC7U5pEV8ND91pE=; b=hLv3U1yCJpTYXpDEwR3L2wfiVdDZJo5HbMdZzEENAgceLiviLrNEDYhsjC1NCKAb4z xPMydmoo1wLjzciThDQw3J250E4Ze4N+0stlbdYAXq6fl94O5ONQtOPi6og+WvZoSIKZ p7jEnrFBVJVQT+ISe2YrD7q0VaiVDlSXWVkBYhjujw/427WGKrT9CACtxRI82G2Efzc2 CunyAO6pAj9ImKQzXZQ5i3BAipYNMALTBCUNSGpIwlcTbsJuk8sDQkM2dt771wCX0QdP jb+HKpi203EzlMz7rzeSlgpIm2voYTaOYttgdkvAFDKjtoJVxxCSGZKQMhPvXhNPqTyl nYVA== X-Gm-Message-State: AIVw112z8fDb8+FQKx1riAPpiBu2jRbzgqcAJugQ4+IzpMnSQ8sYZr4+ UmgvjFTn9k1mwg== X-Received: by 10.200.37.206 with SMTP id f14mr20640733qtf.271.1500920897381; Mon, 24 Jul 2017 11:28:17 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Peter Maydell , Alistair Francis Date: Mon, 24 Jul 2017 15:27:18 -0300 Message-Id: <20170724182751.18261-3-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH for 2.10 02/35] loader: check get_image_size() return value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 since a negative value means it errored. hw/core/loader.c:149:9: warning: Loss of sign in implicit conversion if (size > max_sz) { ^~~~ hw/core/loader.c:171:9: warning: Loss of sign in implicit conversion if (size > memory_region_size(mr)) { ^~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Reviewed-by: Eric Blake --- hw/core/loader.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index c17ace0a2e..4bb176f284 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -146,7 +146,7 @@ int load_image_targphys_as(const char *filename, int size; =20 size =3D get_image_size(filename); - if (size > max_sz) { + if (size < 0 || size > max_sz) { return -1; } if (size > 0) { @@ -168,7 +168,7 @@ int load_image_mr(const char *filename, MemoryRegion *m= r) =20 size =3D get_image_size(filename); =20 - if (size > memory_region_size(mr)) { + if (size < 0 || size > memory_region_size(mr)) { return -1; } if (size > 0) { --=20 2.13.3