From nobody Thu Oct 30 16:32:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500922049660986.4494419551374; Mon, 24 Jul 2017 11:47:29 -0700 (PDT) Received: from localhost ([::1]:56420 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiO8-0007bR-7l for importer@patchew.org; Mon, 24 Jul 2017 14:47:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50582) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6S-0000jL-6R for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6Q-0005Mz-0V for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:12 -0400 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:32996) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6P-0005MH-T8; Mon, 24 Jul 2017 14:29:09 -0400 Received: by mail-qk0-x242.google.com with SMTP id d145so8120924qkc.0; Mon, 24 Jul 2017 11:29:09 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.29.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:29:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NTAK9W79+iqAA6Kr5BAWdSwRBWdgv2jcG1b/j7mz1M0=; b=DfZttV65RcmZnlymw4wDiv1zGJN2DVCkmngR/gThJOl7l0CM2jnMgW7mfYhIn73/Bp b8XXVxvgK8LQCtio7bo0QdAJpP5aVvGH7QWmg0e0eFsFG9jtP9oEgQY/Q2Srct8XD8W5 6MKxqOm9pCm6n6NrUm/J2qpprKuK/cmSvK8jNItLtf/dAV/QrYu5dnMtzx3gdR+zx9CF m8+Cql+gCSVWfZyvuAUzhNfJgEHoqliZ4v/gwUVpAazgEA/i6Hy5kv5ReEWvF9xgLng0 w0Sy5R3CE79mNxHcWUidXMvXI34zVFcTB1VsGuavuyV5zOmuDyoCC7Ck291UkdBX/Ydo tmtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=NTAK9W79+iqAA6Kr5BAWdSwRBWdgv2jcG1b/j7mz1M0=; b=ptNfdWPAl5/bea5SNgzp5OnNVquJlmZDtYmiPVCO6O4EtWEll16XLyBId3raOcGBlt 0jkEElnnV05lHcLTKfTdX6hvo8lc7FojKqrSYamcaJAphuoDNdhrikcxZp4BJZFT/T1C 2lfXBiDdWmR8MVI16MtN/ND2lm8Sjc4LSt5/ADWCjd5Nq6Zf1qyr8CMKmZfhZlCwYRgO HfPexxGqSQQspweVqTSk4/fOqz0rLtScv8ZsWniBlhynbYGMAmtS1xbMFDjlJf4wMyl7 HDZ4OD4/kKqlAiDCteOWuWj6OwEjpTpHPeRbv7HTeZPQ/eEF4UgOgtmHYUGMBognSnzI j/4g== X-Gm-Message-State: AIVw112MyLFLHYr4+V2AhplFMPxNEAy/DRAvrrRiXDQGGhkoZ9yDkEKz urGlsuUtuQiH9A== X-Received: by 10.55.183.65 with SMTP id h62mr1113412qkf.35.1500920949426; Mon, 24 Jul 2017 11:29:09 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Peter Maydell Date: Mon, 24 Jul 2017 15:27:37 -0300 Message-Id: <20170724182751.18261-22-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH for 2.10 21/35] arm/sysbus-fdt: fix null pointer dereference X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Use error_report() + exit() instead of error_setg(&error_fatal). hw/arm/sysbus-fdt.c:322:9: warning: Array access (from variable 'node_path'= ) results in a null pointer dereference if (node_path[1]) { ^~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/sysbus-fdt.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/arm/sysbus-fdt.c b/hw/arm/sysbus-fdt.c index d68e3dcdbd..ad0cc49b19 100644 --- a/hw/arm/sysbus-fdt.c +++ b/hw/arm/sysbus-fdt.c @@ -315,15 +315,14 @@ static int add_amd_xgbe_fdt_node(SysBusDevice *sbdev,= void *opaque) node_path =3D qemu_fdt_node_path(host_fdt, dt_name, vdev->compat, &error_fatal); if (!node_path || !node_path[0]) { - error_setg(&error_fatal, "%s unable to retrieve node path for %s/%= s", + error_report("%s unable to retrieve node path for %s/%s", __func__, dt_name, vdev->compat); - } - - if (node_path[1]) { - error_setg(&error_fatal, "%s more than one node matching %s/%s!", + exit(1); + } else if (node_path[1]) { + error_report("%s more than one node matching %s/%s!", __func__, dt_name, vdev->compat); + exit(1); } - g_free(dt_name); =20 if (vbasedev->num_regions !=3D 5) { --=20 2.13.3