From nobody Thu Oct 30 16:40:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921624905293.60888245650654; Mon, 24 Jul 2017 11:40:24 -0700 (PDT) Received: from localhost ([::1]:56371 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiHE-0001NZ-R9 for importer@patchew.org; Mon, 24 Jul 2017 14:40:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6J-0000aT-3s for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6H-00059J-EP for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:03 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:35763) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6H-00058t-An for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:01 -0400 Received: by mail-qk0-x241.google.com with SMTP id k2so3225574qkf.2 for ; Mon, 24 Jul 2017 11:29:01 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5znBpDLmQxYQcAAIDxEmEEl/gxrAOBg/jxawTEPRpN0=; b=sQ47z4GOD5eB5H5gVcpbtipXV4O6rIKaSQs2Ye1bzFOEx3hpc5EilAnz07ZTAwrxNz ff/4bln0VD8mhRPqjSyUJGz5Zn1L/A0n8Uh4HYSNk0FuqPynMzhy5eBQ9MOSFu3sv2YJ MuOfWHfcCm3vVtSnZtz6qW/HLfGrf/fJ0CaEO6AkW9ebjNCqkXfrZhvQ04Ih5dsJOkiZ /q8TbWQiqTM5NZ4JnbH5FEkISTg5BReVeyKug8PHSwqXbSwiJZNF0tBORHOFEFmFWdCk LvXKlUZK+5eVZmyqTl76GWGjil0M3L04SQyopr/kUBOpLJYsa6ABXMi2GIynrcVTWZ2b 8wGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=5znBpDLmQxYQcAAIDxEmEEl/gxrAOBg/jxawTEPRpN0=; b=G0nakNzG5+LBjChrcWAuK1tBE5biwp2Xn3v1/v9pZ07JHaZB3r+U3ixbhMLUVNYz+z aEBzen9DYcCXB7koPxE9dTmU0j0HVHJqCppHfYRp95xeH+yHSZ5oWwv+pBtvCyPvgBQa xz8roz+cXsmbu6htGIgkUS773imSj2UFv2vgig1CyvPBYVDHdzJrZy45z6/eA/l8/wfe yW9SZa7b3YJ7YOmRKm4uF+W+vHM0C5X/Af5ZJbKZRVNoItZMmgo8fUlYU4/2A42HEAnQ ef88wRFAiUM1vVuFxuh26uFrjcJngnYs3F36tSmPdDbuaoMuWFPETasonGxULGl+uEs/ wkxQ== X-Gm-Message-State: AIVw111RsGvv0X1t7hkNN21vrFexAfwRMAjLAn321ZAHk8AKMNbbWZLb zzcaXnzHNU2uxA== X-Received: by 10.55.31.34 with SMTP id f34mr20169100qkf.357.1500920940886; Mon, 24 Jul 2017 11:29:00 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann Date: Mon, 24 Jul 2017 15:27:34 -0300 Message-Id: <20170724182751.18261-19-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH for 2.10 18/35] usb/dev-mtp: fix use of uninitialized values X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 hw/usb/dev-mtp.c:971:5: warning: 4th function call argument is an uninitial= ized value trace_usb_mtp_op_get_partial_object(s->dev.addr, o->handle, o->path, c->argv[1], c->argv[2]); ^~~~~~~~~~ hw/usb/dev-mtp.c:981:12: warning: Assigned value is garbage or undefined offset =3D c->argv[1]; ^ ~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/dev-mtp.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index ad64495f05..b4f0b5dafd 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -965,12 +965,16 @@ static MTPData *usb_mtp_get_object(MTPState *s, MTPCo= ntrol *c, static MTPData *usb_mtp_get_partial_object(MTPState *s, MTPControl *c, MTPObject *o) { - MTPData *d =3D usb_mtp_data_alloc(c); + MTPData *d; off_t offset; =20 + if (c->argc <=3D 2) { + return NULL; + } trace_usb_mtp_op_get_partial_object(s->dev.addr, o->handle, o->path, c->argv[1], c->argv[2]); =20 + d =3D usb_mtp_data_alloc(c); d->fd =3D open(o->path, O_RDONLY); if (d->fd =3D=3D -1) { usb_mtp_data_free(d); --=20 2.13.3