From nobody Thu Oct 30 16:32:10 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921711392959.6217260394696; Mon, 24 Jul 2017 11:41:51 -0700 (PDT) Received: from localhost ([::1]:56384 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiIf-0002cz-U0 for importer@patchew.org; Mon, 24 Jul 2017 14:41:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6D-0000V9-E5 for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6C-0004zz-I6 for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:57 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:37822) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6C-0004zi-Dl for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:56 -0400 Received: by mail-qk0-x241.google.com with SMTP id q130so10664360qka.4 for ; Mon, 24 Jul 2017 11:28:56 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YMdXOeAib3bzA2HPXPSlSv/YuTd8/WrhCV+QHW1/DxI=; b=ODIYCgewhHg9g+Uqnh/Cd36d0aPPc/yBvP3hhCsYpnLeLPnuMLjF1HWl9XiwZ0rnn7 UBmIV+S6sgBb1nq5+jjQcS1X38pr1a3zo29ahpRH1+nHZLHJUXSbgB70WMcqWzI2fK8j NM2Qn4M8ILtHJd9X0FFoKPM+qydzUxFZJdUf7qYywv0dNgCvcCe7+1pQGx+0AhJaz2TD ePcOP333LG99Iw+MivZeM6jRC0MntBeE07ZhkD67QO41I8Upbkzti9AuiVwGQlUTLE5b TvnhxC1MAiMDvIV48/gXh6lsPu52W49Mr3EWEsnmy9X/KQWvoUj6vwc6BG0Q3tb2s6jW lu7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=YMdXOeAib3bzA2HPXPSlSv/YuTd8/WrhCV+QHW1/DxI=; b=SA5LKNegUCkPW3vxxeB3GZGLhHyCqQNF0yh0hEVztk04Q3zfu9gRu/+CFB8dCFY0wE zkrW11gzSH2GuX/UHcJRnXyDS4/fWh5Xa/oPoQcm1VXo9ySv3bOeCMRhj1evS/MHDvE0 MEv6QniDquEuxgb3tZtiBm6r8vzIBmvrKlfbPfsIttmu1K6zQthFhSQeyx1ySyFC8RlJ JG5VB5SAQIM6OyrrLTThDeYV16ufv46v5pSSnOBQjsgvJbIPIb6UrnacOA4kvUGNLqj4 v9QNC+2ZHy0tebR6lsmHJnd270M7wXSHSP/6hU2v/Ck75TZ6R0Qz3sYxQ1b69X73xLlX On5w== X-Gm-Message-State: AIVw111mg9k4nym5/108BYtkV7zcuF20uMGezenVT9vBxyub91kEls+9 GUEIzB7UeEayQOxZcMMlDg== X-Received: by 10.55.38.83 with SMTP id y80mr487056qkg.113.1500920935996; Mon, 24 Jul 2017 11:28:55 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann Date: Mon, 24 Jul 2017 15:27:32 -0300 Message-Id: <20170724182751.18261-17-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH for 2.10 16/35] usb/dev-mtp: fix use of uninitialized values X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 hw/usb/dev-mtp.c:1212:13: warning: 2nd function call argument is an uniniti= alized value o =3D usb_mtp_object_lookup(s, c->argv[0]); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/dev-mtp.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 94c2e94f10..6dfece9ea9 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -1209,7 +1209,9 @@ static void usb_mtp_command(MTPState *s, MTPControl *= c) } break; case CMD_GET_OBJECT_INFO: - o =3D usb_mtp_object_lookup(s, c->argv[0]); + if (c->argc > 0) { + o =3D usb_mtp_object_lookup(s, c->argv[0]); + } if (o =3D=3D NULL) { usb_mtp_queue_result(s, RES_INVALID_OBJECT_HANDLE, c->trans, 0, 0, 0); @@ -1218,7 +1220,9 @@ static void usb_mtp_command(MTPState *s, MTPControl *= c) data_in =3D usb_mtp_get_object_info(s, c, o); break; case CMD_GET_OBJECT: - o =3D usb_mtp_object_lookup(s, c->argv[0]); + if (c->argc > 0) { + o =3D usb_mtp_object_lookup(s, c->argv[0]); + } if (o =3D=3D NULL) { usb_mtp_queue_result(s, RES_INVALID_OBJECT_HANDLE, c->trans, 0, 0, 0); @@ -1237,7 +1241,9 @@ static void usb_mtp_command(MTPState *s, MTPControl *= c) } break; case CMD_GET_PARTIAL_OBJECT: - o =3D usb_mtp_object_lookup(s, c->argv[0]); + if (c->argc > 0) { + o =3D usb_mtp_object_lookup(s, c->argv[0]); + } if (o =3D=3D NULL) { usb_mtp_queue_result(s, RES_INVALID_OBJECT_HANDLE, c->trans, 0, 0, 0); @@ -1281,7 +1287,9 @@ static void usb_mtp_command(MTPState *s, MTPControl *= c) } break; case CMD_GET_OBJECT_PROP_VALUE: - o =3D usb_mtp_object_lookup(s, c->argv[0]); + if (c->argc > 0) { + o =3D usb_mtp_object_lookup(s, c->argv[0]); + } if (o =3D=3D NULL) { usb_mtp_queue_result(s, RES_INVALID_OBJECT_HANDLE, c->trans, 0, 0, 0); --=20 2.13.3