From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500920997655718.8396665028403; Mon, 24 Jul 2017 11:29:57 -0700 (PDT) Received: from localhost ([::1]:56313 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi79-00016d-85 for importer@patchew.org; Mon, 24 Jul 2017 14:29:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi5Y-00088N-C4 for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi5X-0004hg-De for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:16 -0400 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:34273) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi5X-0004hc-9A; Mon, 24 Jul 2017 14:28:15 -0400 Received: by mail-qk0-x242.google.com with SMTP id q66so10660843qki.1; Mon, 24 Jul 2017 11:28:15 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uGyrHEzvy8FqoRMrRUgLWHf217VZM8hapwRVmbqBJY0=; b=Q/U1a0g5vWsV6eMkX3ko9rOzhrSpu6LvbNGbVDi3U8UjBVGQO8lCUy98W1W6nPWRG3 l6L6Yrr+em6oueTyA7rCviKf6qXInkWs7nQVtYR58Hf0k6qQFhS+JFGzmcRth/SYgWFW Wym6aeW1BaQtgKN8sc4Hq9uhNj+HnygfLCf0erG8UMKEMGO5CnkEXq7/Z5xROOBK2+pz +TVvc5kHEe2UzgMDX3Pc9YGp9D8GqRZ65K2zXv3JepTkIbAmMrkPl9xtkrW7cRnjiDLh 26sw89dG7oFBiA73i5LK51Bdooeat2VaT4WgdxU8HyRs21l4mWjVP79tjL11msx/odGH AYKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=uGyrHEzvy8FqoRMrRUgLWHf217VZM8hapwRVmbqBJY0=; b=hO3kmoQg/JBCl8jUqhQEN/4xM81ViYxWoxfp7ui+ydVjxbeigUu9LDsdpBzTVkXmLm Lyj3zxBkoCjSI/xI4kfkuHyemECc9cAMxFHw1Qrnj0PuVxNW40bhpNxdoFL2s6QtAmnF dvnTUGAbrIMlEvPv84mpEBu3SWsa+2nyAFQBW+A7Yp0GTX8epmQmdSINL8H++pzDyjsm H2CSzOT9GuwtrYVuq6z9E/Nwh36UhDEA9INDoQc1g5ksGBWcQrhO7ETWDiLsAvburc3y r2vOFkND+aQO7VW6CYZG9YGSJ1SfrG8wYB8JHmq5BzUKfLcfQnBKGflj+SctBrLgq78/ 6e1g== X-Gm-Message-State: AIVw113d7tqY2taKmDj5jhkENHYuAfqdM/AG4T83i9AkhWIs+1kwLa5k 2cpv/lCefttqYw== X-Received: by 10.55.31.34 with SMTP id f34mr20166510qkf.357.1500920894664; Mon, 24 Jul 2017 11:28:14 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Mon, 24 Jul 2017 15:27:17 -0300 Message-Id: <20170724182751.18261-2-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH for 2.10 01/35] tests: add missing dependency to build QTEST_QEMU_BINARY X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 This allow a one liner from fresh repository clone, i.e.: ./configure && make -j check-qtest-aarch64 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Stefan Hajnoczi Reviewed-by: John Snow --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 7af278db55..b55fe39d94 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -830,7 +830,7 @@ GCOV_OPTIONS =3D -n $(if $(V),-f,) # gtester tests, possibly with verbose output =20 .PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS)) -$(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: $(check-qte= st-y) +$(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: subdir-%-so= ftmmu $(check-qtest-y) $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) $(call quiet-command,QTEST_QEMU_BINARY=3D$*-softmmu/qemu-system-$* \ QTEST_QEMU_IMG=3Dqemu-img$(EXESUF) \ --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921176844827.069391779456; Mon, 24 Jul 2017 11:32:56 -0700 (PDT) Received: from localhost ([::1]:56331 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiA1-0003dZ-UT for importer@patchew.org; Mon, 24 Jul 2017 14:32:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi5b-00089V-0g for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi5a-0004ic-6U for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:19 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:32863) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi5a-0004iV-2N; Mon, 24 Jul 2017 14:28:18 -0400 Received: by mail-qt0-x241.google.com with SMTP id n42so3126732qtn.0; Mon, 24 Jul 2017 11:28:17 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WcqnCQ/ToTRAQymS8Tq8QZzva+ADZC7U5pEV8ND91pE=; b=VisBhtr8JebtWQEJMz0rYus2jqMdY0hSEFzqlTfWVUDtBFnITuzq4dLuz/SR7GjD2x vu2riuLQ078AMmHOA3ZjnZim+eeVhjvz7kjOfh8ptzvL8foeFgCGPBOIC4Br9KxKj7tR 4bpqI4qXqKMN/i39Z5uQBacc7lBX/HVzBIJBlT9G0uKvLZsXylA6Z2gffu+d7Mb8Stur YZ0nh5efihb3ZX4iqiGacB+k2TwP5ojbkzGA4LsOs8bP+YSXfxU73VPPr/HBuyTBRLbK 06n2ZPzcBAfDJwzSDmfZAz9RpzFrVrGICDY2kyobofYEvfTdFrxoUVmReEWorwLkT+aj 9Y8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=WcqnCQ/ToTRAQymS8Tq8QZzva+ADZC7U5pEV8ND91pE=; b=hLv3U1yCJpTYXpDEwR3L2wfiVdDZJo5HbMdZzEENAgceLiviLrNEDYhsjC1NCKAb4z xPMydmoo1wLjzciThDQw3J250E4Ze4N+0stlbdYAXq6fl94O5ONQtOPi6og+WvZoSIKZ p7jEnrFBVJVQT+ISe2YrD7q0VaiVDlSXWVkBYhjujw/427WGKrT9CACtxRI82G2Efzc2 CunyAO6pAj9ImKQzXZQ5i3BAipYNMALTBCUNSGpIwlcTbsJuk8sDQkM2dt771wCX0QdP jb+HKpi203EzlMz7rzeSlgpIm2voYTaOYttgdkvAFDKjtoJVxxCSGZKQMhPvXhNPqTyl nYVA== X-Gm-Message-State: AIVw112z8fDb8+FQKx1riAPpiBu2jRbzgqcAJugQ4+IzpMnSQ8sYZr4+ UmgvjFTn9k1mwg== X-Received: by 10.200.37.206 with SMTP id f14mr20640733qtf.271.1500920897381; Mon, 24 Jul 2017 11:28:17 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Peter Maydell , Alistair Francis Date: Mon, 24 Jul 2017 15:27:18 -0300 Message-Id: <20170724182751.18261-3-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH for 2.10 02/35] loader: check get_image_size() return value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 since a negative value means it errored. hw/core/loader.c:149:9: warning: Loss of sign in implicit conversion if (size > max_sz) { ^~~~ hw/core/loader.c:171:9: warning: Loss of sign in implicit conversion if (size > memory_region_size(mr)) { ^~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Reviewed-by: Eric Blake --- hw/core/loader.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index c17ace0a2e..4bb176f284 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -146,7 +146,7 @@ int load_image_targphys_as(const char *filename, int size; =20 size =3D get_image_size(filename); - if (size > max_sz) { + if (size < 0 || size > max_sz) { return -1; } if (size > 0) { @@ -168,7 +168,7 @@ int load_image_mr(const char *filename, MemoryRegion *m= r) =20 size =3D get_image_size(filename); =20 - if (size > memory_region_size(mr)) { + if (size < 0 || size > memory_region_size(mr)) { return -1; } if (size > 0) { --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921153123860.319861998287; Mon, 24 Jul 2017 11:32:33 -0700 (PDT) Received: from localhost ([::1]:56329 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi9e-0003KU-Oh for importer@patchew.org; Mon, 24 Jul 2017 14:32:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi5d-0008Bt-Fa for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi5c-0004jV-Mq for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:21 -0400 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:35716) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi5c-0004jF-Iv; Mon, 24 Jul 2017 14:28:20 -0400 Received: by mail-qk0-x243.google.com with SMTP id k2so3223996qkf.2; Mon, 24 Jul 2017 11:28:20 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z92FSzG5sTMrFXcT+CgYEM4lFcI+e1+GashOIp7Op2Y=; b=eLKOj044v5dtReEgXjWPEuNyCw9I5Rdy1uWoHatlhviYrEsZ8xUAaHSMBlA5W1hMkz PwGCeYn4cAx6UO83WUFiUvE+VK8SKIksCLPcbiZehHHhG7GEFJ6EtvcZ58heqo4niJJg 934MlLI0Rd4XqSPjkTUdJMPYeJIiUrId/1XbP9LoqEBD9dQmskiaQwit1tpDUyBJe2SR a8dtV53vI1K51C39b/vVzO5EQ8ahf2nMM77/RucdIEy8p3Z6hz6ft9LeZsNmTEZrZhqj K3P8YpFc9U7NeIH3m0KjEYN0mRfhmP+HxYknty2r2+eF3UJ3E1YFJcUdmWH89TjRuBa0 mvjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Z92FSzG5sTMrFXcT+CgYEM4lFcI+e1+GashOIp7Op2Y=; b=IOm9pCa8G0Y4YRnoT6MNGJkr75y0npn9O1sLhjUUMTA9wsHKGadbMdGA9dYUNpSZqu Ixnd1ut2z9LDXoy5qhMUPCx95FCsWPt9zmPu4DWEP6iI8BtCbun+8pusm0H6iHY5K1tr QXDVsRx1u5LCoVf63KGCIshLJKfrIwemAL5xcD18UXNuyDTGl09e7G2jhoX1nwONEclA jgOF61IZh2IyYoSGbfsQRzVlKWujDunSR2w6Nq2MTpNlj9sskZ3dxcbiql9ddw5ApBx6 6RuNvyFFWtrSOHG3rS5K/MXHHtnP+2t7Xi62KRqXDsj1dE1HM9M70pDPg2RyurjLOj/q KaTg== X-Gm-Message-State: AIVw113xkmfC6Qw1g57d80Mvd7rULOqXGKhRRp3UZwmztSXYXNC46quE o0CN7VJHvNreN5suqfM= X-Received: by 10.55.209.86 with SMTP id s83mr20149414qki.171.1500920900010; Mon, 24 Jul 2017 11:28:20 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Riku Voipio Date: Mon, 24 Jul 2017 15:27:19 -0300 Message-Id: <20170724182751.18261-4-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::243 Subject: [Qemu-devel] [PATCH for 2.10 03/35] thunk: check nb_fields is valid before continuing X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 thunk.c:91:32: warning: Call to 'malloc' has an allocation size of 0 bytes se->field_offsets[i] =3D malloc(nb_fields * sizeof(int)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- thunk.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/thunk.c b/thunk.c index 2dac36666d..d1c5e221f5 100644 --- a/thunk.c +++ b/thunk.c @@ -67,7 +67,6 @@ void thunk_register_struct(int id, const char *name, cons= t argtype *types) int nb_fields, offset, max_align, align, size, i, j; =20 assert(id < max_struct_entries); - se =3D struct_entries + id; =20 /* first we count the number of fields */ type_ptr =3D types; @@ -76,6 +75,10 @@ void thunk_register_struct(int id, const char *name, con= st argtype *types) type_ptr =3D thunk_type_next(type_ptr); nb_fields++; } + if (!nb_fields) { + return; + } + se =3D struct_entries + id; se->field_types =3D types; se->nb_fields =3D nb_fields; se->name =3D name; --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921385177411.3256654618382; Mon, 24 Jul 2017 11:36:25 -0700 (PDT) Received: from localhost ([::1]:56350 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiDP-0006Yh-Cb for importer@patchew.org; Mon, 24 Jul 2017 14:36:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi5i-0008Fz-7w for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi5f-0004kF-JC for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:26 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:37786) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi5f-0004kB-F0 for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:23 -0400 Received: by mail-qk0-x241.google.com with SMTP id q130so10663079qka.4 for ; Mon, 24 Jul 2017 11:28:23 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pn7pRvylXYhKX6t+EBhaRllaOiqBouTfIdKVHpTt5z4=; b=S8tpEV9Mc32DFcx8OuMrQ11cblvIGANuQYBnbyYe0cvLy8XM1MttFltCwDMFQ/WGxq pu0AN65xkzH2qenAVeVUwlHX2De973B2+P88XSUzl6AINm3ZtjaRGGtOoYn9O1awU76y kK7vxfDfhHQpN0ZLAgUR69fv4oyCv7xC9aN3z0iwJinhZlkkqBKsDtAsgvhe3yoZ7LuQ sG510uQtAMpk8SasjdeOFmWXOyQZO/+L6iTMRrUWGNOzTJ92lshfFMGyojAvbv9Yqdm7 fMh+53U7LGa+WqJolRymqf10voSqlXnpr9FPFlVEk7Yx/VgmHqOSI5DUlSrFcHk5z0R9 U84A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=pn7pRvylXYhKX6t+EBhaRllaOiqBouTfIdKVHpTt5z4=; b=JrI2hgEpd3CecXzKaG2KYbo/ZOiU6XHUFjx/uNSe2g5jkq4CZW+J0X4Z6rK4JudT9a PSxDPaRSCLtGFNnpB1MMMsJWoxmSPEXfDBGaFwD9bqksXKA1OdYOpelbz+cvrsfFFto1 c9DCRuBK76TfWMf3lSI9w6uz5SJQnx78TyA6l0320gAgb7a7dYM+hBHpcM3dlMg8FtYN TJmRFTa72LUSYbA/toeg5uub6P1e0poBzvP48a2tvly9SWGeBHKCEKin6ykgSyPA9W54 gFcBz/naHvRYlNzPayXobTP/Vl5Z80KPNUpj3XWhDa7oBXfXMDNK2OYMx5qJxMEdbdvt 6Mbw== X-Gm-Message-State: AIVw110otEWKzNWWynGlUOMtN1u5UAnHYL5UUGD/xfUA2dfGMNuUDsJ1 g6v+glkK2UZzvA== X-Received: by 10.55.198.4 with SMTP id b4mr21993869qkj.200.1500920902903; Mon, 24 Jul 2017 11:28:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Markus Armbruster Date: Mon, 24 Jul 2017 15:27:20 -0300 Message-Id: <20170724182751.18261-5-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH for 2.10 04/35] ivshmem: fix incorrect error handling in ivshmem_recv_msg() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 If qemu_chr_fe_read_all() returns -EINTR the do {} statement continues and = the n accumulator used to complete reads upto sizeof(msg) is decremented by 4 (= the value of EINTR on Linux). To avoid that, use simpler if() statements and continue if EINTR occured. hw/misc/ivshmem.c:650:14: warning: Loss of sign in implicit conversion } while (n < sizeof(msg)); ^ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Markus Armbruster --- get_maintainer.pl: No maintainers found! hw/misc/ivshmem.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index a58f9ee579..47a015f072 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -642,7 +642,10 @@ static int64_t ivshmem_recv_msg(IVShmemState *s, int *= pfd, Error **errp) do { ret =3D qemu_chr_fe_read_all(&s->server_chr, (uint8_t *)&msg + n, sizeof(msg) - n); - if (ret < 0 && ret !=3D -EINTR) { + if (ret < 0) { + if (ret =3D=3D -EINTR) { + continue; + } error_setg_errno(errp, -ret, "read from server failed"); return INT64_MIN; } --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921012275103.85966567124524; Mon, 24 Jul 2017 11:30:12 -0700 (PDT) Received: from localhost ([::1]:56316 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi7O-0001NK-LX for importer@patchew.org; Mon, 24 Jul 2017 14:30:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi5i-0008Gw-UP for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi5i-0004l3-4Z for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:26 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:35759) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi5i-0004kw-02; Mon, 24 Jul 2017 14:28:26 -0400 Received: by mail-qt0-x241.google.com with SMTP id 21so5054782qtx.2; Mon, 24 Jul 2017 11:28:25 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qnqayY1OfO+/Z508AN/ruOaC+dXZeWF4ND8GXK1J/7M=; b=MybyyFKdvs7o/2QBBDxMqA7YL5+aBXRIfNYwigsfmKQb4IvjL/hRzJtEXWhrI73EQO rBfmGAwX9AeWYlz1a5h0gi21eVxMMFlLSy7O7JPrIUs5N7D6SSrFfbE1ilILuva9zu14 G/n+CI7pwsOOVNZwn6w2lTdklziuXCpio4GYfwJBXqdq0VAML7J/flzrGnNZHaRynXsL 20kacQRccL+AXt6pTJFLTwZH0lPN1LgDXe31ZrVmputXkGTHEdklCFyem0PvXSkKFQd1 7b9MiPiefJa0qSXhdlGw4uGxUgctIk7880XoT8f52FENmsydVytS2xRuA/b7MjIB8hs9 b3gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=qnqayY1OfO+/Z508AN/ruOaC+dXZeWF4ND8GXK1J/7M=; b=ZDWU3rOUnS1MfuH4zCGPDipyh3OgWHAwEGI8WhTn3jrwucQLNyJpW5A/170HmuCETh 1XvwzrwfZ7VZBaODomiC8dD1gysqNlgpHHcnFG8YlH3mLDGiou04pR5y578DkmijzhGJ ONjMzJLRibnNz0zu/awFOTSS4EFgl+CeuLVWXUN2ffeHVX/8497EtmvHfX2Lm3z/pkuH hyZO/iOnz0VCs9PJ0TwB/wf3OhQdD2CYi2vDhZxdaJYq2oTFLQwi00Yiy7tM/db6t1/w DIX4pP2ZCtYLW8JUD4BNSyJ+fnpT+XrGV8dw7ukLiNt6MQxjdqcF1uFsBgZVqyjTDsWC ui6A== X-Gm-Message-State: AIVw113raHc3R8Qcbv5xOcoD5fRK3Cpw5gmZ+m3Rwwcdiu8lBVKVYqFA 4MdXfUUkM5MTD5mimDU= X-Received: by 10.200.34.43 with SMTP id o40mr6687914qto.131.1500920905572; Mon, 24 Jul 2017 11:28:25 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Mon, 24 Jul 2017 15:27:21 -0300 Message-Id: <20170724182751.18261-6-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH for 2.10 05/35] nbd: fix memory leak in nbd_opt_go() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-block@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 nbd/client.c:385:12: warning: Potential leak of memory pointed to by 'buf' Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Eric Blake --- nbd/client.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/nbd/client.c b/nbd/client.c index 509ed5e4ba..0a17de80b5 100644 --- a/nbd/client.c +++ b/nbd/client.c @@ -376,9 +376,11 @@ static int nbd_opt_go(QIOChannel *ioc, const char *wan= tname, if (info->request_sizes) { stw_be_p(buf + 4 + len + 2, NBD_INFO_BLOCK_SIZE); } - if (nbd_send_option_request(ioc, NBD_OPT_GO, - 4 + len + 2 + 2 * info->request_sizes, buf, - errp) < 0) { + error =3D nbd_send_option_request(ioc, NBD_OPT_GO, + 4 + len + 2 + 2 * info->request_sizes, + buf, errp); + g_free(buf); + if (error < 0) { return -1; } =20 --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 150092131830472.60417455037816; Mon, 24 Jul 2017 11:35:18 -0700 (PDT) Received: from localhost ([::1]:56339 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiCJ-0005cX-9J for importer@patchew.org; Mon, 24 Jul 2017 14:35:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi5l-0008JV-NK for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi5l-0004m3-2x for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:29 -0400 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:36227) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi5k-0004lv-Uv; Mon, 24 Jul 2017 14:28:29 -0400 Received: by mail-qt0-x243.google.com with SMTP id l55so12883333qtl.3; Mon, 24 Jul 2017 11:28:28 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oC29Xthh5htKicMmTdacTWVlYUt0HacjYrnWbEybAyU=; b=B1SoFQBIxILsSvlNIlj09hcY4MJWmMXE9KT0po20l0iIgp9xuy42YcjGluHqsH0OHb HFuAJyPR2iotNmPTKXb0t7z4Yw82VMux+ERNHS+8tSwaqGmA+7QMynSFM/raKf3/Tduz 0X5Gr+KqgmCffgKaYaZR5NZ1tVtKrmQt5H45ls8oeYq7i0sRJN5Xap+WtgtdV/GrJVHK riPz8IzImNOmm+FlzIL8o6p0PZFMIpzEIcpK1pxbWF79f+i00RIK76aN8ldswIbwUv9Y fRQlN3Pwn5HW3ucNgHpwIRfeu0raADBLZWlFKNSFeQyr7ydrP6gY4bn4wtrzE25aqmMz 6bqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=oC29Xthh5htKicMmTdacTWVlYUt0HacjYrnWbEybAyU=; b=tovvv7il+6EuLqda3RhI2UHT4g7WaS1huMEWbGVBw55n0jEFdJ2XckkMKhcVJXXf0g XYcGUTcna4oj0j8GudOA2NSZLA6k1Fu1qe430EOR2lo0vNiJyQN3zLrkZwFxtwhBtxk1 t43Eiuw+RNQHC4CAJimZrBjAMAtLhPUaWBaTPdi4EoWKvCzyX30q5XepdUmun/jFEvsw E4J7y0cYgNCxVqiFQRUPS1hql4o3qozxfe9jm31PMgPldBgCS/zjnxvzKn6VKxU8ldjH 6a4EEP3kCYgg24WxjCXWGudWXYFZHPZQJsbbaOvIkWLIOOPB5emVbBLmxhbQbY7hTv9r M2aQ== X-Gm-Message-State: AIVw112AnZx9Vd9bMwLNy/rQXBRe9HH9UNIrSUJBhZ5n4mn4YRc/wpZq Gkp/rZA7wxjeWg== X-Received: by 10.237.37.70 with SMTP id w6mr2464337qtc.215.1500920908397; Mon, 24 Jul 2017 11:28:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Kevin Wolf , Max Reitz Date: Mon, 24 Jul 2017 15:27:22 -0300 Message-Id: <20170724182751.18261-7-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH for 2.10 06/35] qcow2: remove inconsistent check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-block@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 This is equivalent to assert(russian roulette) so better remove it. block/qcow2-bitmap.c:259:29: warning: The left operand of '=3D=3D' is a gar= bage value assert(bitmap_table =3D=3D NULL); ~~~~~~~~~~~~ ^ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- block/qcow2-bitmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c index 3e8735a20d..fe72df5057 100644 --- a/block/qcow2-bitmap.c +++ b/block/qcow2-bitmap.c @@ -254,7 +254,6 @@ static int free_bitmap_clusters(BlockDriverState *bs, Q= cow2BitmapTable *tb) =20 ret =3D bitmap_table_load(bs, tb, &bitmap_table); if (ret < 0) { - assert(bitmap_table =3D=3D NULL); return ret; } =20 --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921170912117.46676594031783; Mon, 24 Jul 2017 11:32:50 -0700 (PDT) Received: from localhost ([::1]:56330 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi9w-0003ZU-CJ for importer@patchew.org; Mon, 24 Jul 2017 14:32:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi5r-0008RF-7N for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi5o-0004nA-2O for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:35 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:37438) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi5n-0004mt-UB; Mon, 24 Jul 2017 14:28:31 -0400 Received: by mail-qt0-x244.google.com with SMTP id d10so1058825qtb.4; Mon, 24 Jul 2017 11:28:31 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vPG4/DR3PkvmHSx+GehJ9J4lEg0BZ/0dnKyPC4P7YvU=; b=fVzKGmTfkYTWTHig7J3ZpHX9siB6X8g2HZALQ7puS9YhQEfdcw/oTd2GGqYNvplmE9 syREaHtf/EB4q4wYYdRxUPGEFwzImSU5esU5KHcLwDYWVkcwA0nr+AN6Gq16DFATrkl1 zhpY4AwkMCIdg+dYlJlEsnHO+z5WvYiT3kh3XiLkCpz2D3tMxBWAz7B94/2USuMwSgc2 EmyqnaH/BL9rApE9mYOIF8eghHSO81N/ni9xMXgf58JnMRExt5p+3E4WDC+dgrFLLo6q c8HGtU7OKwyPIVJ8ExPyfRnxOT9yS1SUbqWczNqxGfMQMt8TTPSQVs9SxNbUwK+cZnrG HoGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=vPG4/DR3PkvmHSx+GehJ9J4lEg0BZ/0dnKyPC4P7YvU=; b=V8I47JMVnGiuV3pX9Nz4eqpZY5opz1/WISLavZgDETsXF15RuBofl6KU2mb3wM56u6 adAMnVmz8oaleQHNwueMhk7hO25rl/YJKc54IEsbT5GYf3qimtHO5yVs4Xr7zkQ5P/nE SDHmn9Qfp4xVXnEwUPNiJ2GupawVk4sGqj3Hb7pk/1fSvI9MVWM18NKVv92wEkd9LoDu 1zyqb0hiAL0LGrSLO1iQXvIEiGA0jCKfGIJF+d2+zA7qTmsVTXm+9QgAJ3hNSuVuu01G LuYqhq2SMcGicdvwQ3MFUMhR+1kJHQHXU4QxZZuTb74HpEsvw3ysKixbjqi2NMsDs0UE puFA== X-Gm-Message-State: AIVw113oiRR88UOZC+qsK8+c9czNTST4k3o/4q6eG6RRAw+WRUAMAi9C 5Fim2rb2Fl1tKg== X-Received: by 10.200.35.47 with SMTP id a44mr20554367qta.262.1500920911374; Mon, 24 Jul 2017 11:28:31 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Kevin Wolf , Max Reitz Date: Mon, 24 Jul 2017 15:27:23 -0300 Message-Id: <20170724182751.18261-8-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH for 2.10 07/35] qcow2: fix null pointer dereference X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-block@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 If find_bitmap_by_name() fails we have bm=3DNULL and go to the 'fail' label= , then call bitmap_free(bm) which does g_free(bm->name) with bm=3DNULL... Clang's scan-build-5.0 output: block/qcow2-bitmap.c:492:12: warning: Access to field 'name' results in a d= ereference of a null pointer (loaded from variable 'bm') g_free(bm->name); ^~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- block/qcow2-bitmap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c index fe72df5057..2fd75781ce 100644 --- a/block/qcow2-bitmap.c +++ b/block/qcow2-bitmap.c @@ -1259,7 +1259,7 @@ void qcow2_remove_persistent_dirty_bitmap(BlockDriver= State *bs, =20 bm =3D find_bitmap_by_name(bm_list, name); if (bm =3D=3D NULL) { - goto fail; + goto fail_list; } =20 QSIMPLEQ_REMOVE(bm_list, bm, Qcow2Bitmap, entry); @@ -1274,6 +1274,7 @@ void qcow2_remove_persistent_dirty_bitmap(BlockDriver= State *bs, =20 fail: bitmap_free(bm); +fail_list: bitmap_list_free(bm_list); } =20 --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921335832122.71739830553418; Mon, 24 Jul 2017 11:35:35 -0700 (PDT) Received: from localhost ([::1]:56347 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiCb-0005tD-5Q for importer@patchew.org; Mon, 24 Jul 2017 14:35:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi5s-0008SF-1i for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi5r-0004nt-9A for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:36 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:37797) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi5r-0004nj-40; Mon, 24 Jul 2017 14:28:35 -0400 Received: by mail-qk0-x244.google.com with SMTP id q130so10663473qka.4; Mon, 24 Jul 2017 11:28:35 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1YRdkNwqoguRAYwqKV9yS5uo8kBBb/VJVwiVO0tuvzo=; b=LaPnFQ+IIzOChHfwgsNXDslKFzp6P6jNQcVWyjAx/OHCYm4vZW0XdBXq9RRHX/Y7To cl9qP+PbIvexP5wvhTWjwuAe4YMZBkBWY26049LFimFZJtN29ttIlSzmYhx6Ts0Q3jFx atN882cN2OKn1kGG9T8+K5+SbaFYqrCQn03Tocd98ugp8w4lCln0qO5XMQh3b6CUgjuw hlYNhnwmLBXhydo3+UJlAucNXPQL3melkcyR/wggLw75seonQJPZBAraP0Dux6GU/Bzt 0WErYdL6oAaN80KzW0HBQLuycXLYRtlXavBsduFTolwrWrA4LijWPw0B80M7kJaOBMbd U9yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=1YRdkNwqoguRAYwqKV9yS5uo8kBBb/VJVwiVO0tuvzo=; b=o3J7gdRHpqA2KcCLAD3MQaPTlv+A3JcghshvQLJuM0Kvl3RMeMfNBNzJutpUusbfv6 0e5FGt+g1WISgxlMgrTMj0En2HJs6/3g3UwWFpXvDUU5NDKokG2fcKHaAiPHQcLHL7i8 o9wqeGxcWV138xkM2Pr0Phqow2a/1nJJQEPPt2Vklha999BI9XD2FvIU5PjXg4dpGUQy 4Fsw1gsW4B/p2covdXqoNgJpSj5GcagiFGEWbPXob4A8tosruq270Dl3le6QF9uQSaml DPf3JeCRT4z3iL8UilGrtu1e5BE7dgNwedyDVKyFnCn50OCBZB4CGXvy5vD0Hopzh/04 2qHw== X-Gm-Message-State: AIVw112VIpRihycgh0RuI03u9rG9ikKTyeEDowILydAH1VvwKcgYuXsC ROwXQgkU3bJ/2A== X-Received: by 10.55.64.81 with SMTP id n78mr20321939qka.36.1500920914476; Mon, 24 Jul 2017 11:28:34 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Kevin Wolf , Max Reitz Date: Mon, 24 Jul 2017 15:27:24 -0300 Message-Id: <20170724182751.18261-9-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH for 2.10 08/35] qcow2: fix null pointer dereference X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-block@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 It seems this assert() was somehow misplaced. block/qcow2-refcount.c:2193:42: warning: Array access (from variable 'on_di= sk_reftable') results in a null pointer dereference on_disk_reftable[refblock_index] =3D refblock_offset; ~~~~~~~~~~~~~~~~ ^ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Eric Blake --- block/qcow2-refcount.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index c9b0dcb4f3..168fc32e7b 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -2189,6 +2189,8 @@ write_refblocks: * this will leak that range, but we can easily fix that by ru= nning * a leak-fixing check after this rebuild operation */ reftable_offset =3D -1; + } else { + assert(on_disk_reftable); } on_disk_reftable[refblock_index] =3D refblock_offset; =20 @@ -2258,8 +2260,6 @@ write_refblocks: goto write_refblocks; } =20 - assert(on_disk_reftable); - for (refblock_index =3D 0; refblock_index < reftable_size; refblock_in= dex++) { cpu_to_be64s(&on_disk_reftable[refblock_index]); } --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921526779566.3223259978238; Mon, 24 Jul 2017 11:38:46 -0700 (PDT) Received: from localhost ([::1]:56364 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiFg-0008Ks-1C for importer@patchew.org; Mon, 24 Jul 2017 14:38:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi5u-0008V8-Ik for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi5t-0004oy-Ko for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:38 -0400 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:35924) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi5t-0004on-H8; Mon, 24 Jul 2017 14:28:37 -0400 Received: by mail-qk0-x243.google.com with SMTP id d136so10665960qkg.3; Mon, 24 Jul 2017 11:28:37 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2VCA6ci3zhhoe80qtBC1tJlOXxnuy9ZJf6/QUBn12bw=; b=i3fkuV8Rp7Rli7v2Bcf1vblnI8bGjyAjajDiaTCVaLuKKmECMG1nefcD0Pjm4gu7uQ 7LfDgyKKvUL5F4SIv8TOOmTlqmLlfdTWrmxGZYWB1Nq/to+U345IpVC4pA0kw4UlWT4A eAMhEh0gRB4QI5DKjCFpLdfwvoU+OvxPRpjeO6pYSfSAsfiSBInH+iaquHC+KCBys9ky Ux5ZbTT4Td88yuQbOL2DiyrnB8m7Ex4tO5Fof4VGpAgR6STojH9UmuRih8vnS0/0pDUN dZmJFL7norn5nJaz/B1QiyD6Pjo9grYbYYRVx2ygPF32lzQuIp1O9354PaRj79FZNcka 1llw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=2VCA6ci3zhhoe80qtBC1tJlOXxnuy9ZJf6/QUBn12bw=; b=Wa4wWJJhuTTRtpuSwHF+fHLFhhOg8M6MgbXJvhWkz6G1ElMPiCRv6qO+HO4LGfU+83 GuwVmqWavWJNn5zxlDqFyShRJgrVxBOzg+6Qd8wHgEx11J/E1Ae0/GsdIBpls6xLbN33 9w8afTZRE+kPWcpZ0fmUnPfoAn49XGYm9klrsWi6WA5FUX6t1/Z9Hetu3hU6t2PZS0jv Wf7U+ZG1fRVlUKP8/9LPQV0N/kbwg7yESGiVvoernDwyx/Ni7HAaBOI/f++0PkYd50pE qPsShbylbhGt5yJG/+rlY/DvysUD9UsOB0w7qpdROFSEWw2A19T7+5a+tmBg+W3b0OIK oHaQ== X-Gm-Message-State: AIVw113utoXcKWZlev3fsreGgkFk9WDEdBCbUq2CxWlv0C2a+qaShiuO 0WrfuKiyevzwKw== X-Received: by 10.55.33.77 with SMTP id h74mr22980670qkh.353.1500920917080; Mon, 24 Jul 2017 11:28:37 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann Date: Mon, 24 Jul 2017 15:27:25 -0300 Message-Id: <20170724182751.18261-10-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::243 Subject: [Qemu-devel] [PATCH for 2.10 09/35] ui/vnc: fix leak of SocketAddress ** X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Extract the (correct) cleaning code as a new function vnc_free_addresses() = then use it to remove the memory leaks. Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrange --- ui/vnc.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index eb91559b6b..651cbb8606 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3521,6 +3521,20 @@ static int vnc_display_get_address(const char *addrs= tr, return ret; } =20 +static void vnc_free_addresses(SocketAddress ***retsaddr, + size_t *retnsaddr) +{ + size_t i; + + for (i =3D 0; i < *retnsaddr; i++) { + qapi_free_SocketAddress((*retsaddr)[i]); + } + g_free(*retsaddr); + + *retsaddr =3D NULL; + *retnsaddr =3D 0; +} + static int vnc_display_get_addresses(QemuOpts *opts, bool reverse, SocketAddress ***retsaddr, @@ -3538,7 +3552,6 @@ static int vnc_display_get_addresses(QemuOpts *opts, bool has_ipv6 =3D qemu_opt_get(opts, "ipv6"); bool ipv4 =3D qemu_opt_get_bool(opts, "ipv4", false); bool ipv6 =3D qemu_opt_get_bool(opts, "ipv6", false); - size_t i; int displaynum =3D -1; int ret =3D -1; =20 @@ -3614,16 +3627,8 @@ static int vnc_display_get_addresses(QemuOpts *opts, ret =3D 0; cleanup: if (ret < 0) { - for (i =3D 0; i < *retnsaddr; i++) { - qapi_free_SocketAddress((*retsaddr)[i]); - } - g_free(*retsaddr); - for (i =3D 0; i < *retnwsaddr; i++) { - qapi_free_SocketAddress((*retwsaddr)[i]); - } - g_free(*retwsaddr); - *retsaddr =3D *retwsaddr =3D NULL; - *retnsaddr =3D *retnwsaddr =3D 0; + vnc_free_addresses(retsaddr, retnsaddr); + vnc_free_addresses(retwsaddr, retnwsaddr); } return ret; } @@ -3772,7 +3777,6 @@ void vnc_display_open(const char *id, Error **errp) int acl =3D 0; int lock_key_sync =3D 1; int key_delay_ms; - size_t i; =20 if (!vd) { error_setg(errp, "VNC display not active"); @@ -3993,12 +3997,8 @@ void vnc_display_open(const char *id, Error **errp) } =20 cleanup: - for (i =3D 0; i < nsaddr; i++) { - qapi_free_SocketAddress(saddr[i]); - } - for (i =3D 0; i < nwsaddr; i++) { - qapi_free_SocketAddress(wsaddr[i]); - } + vnc_free_addresses(&saddr, &nsaddr); + vnc_free_addresses(&wsaddr, &nwsaddr); return; =20 fail: --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921694249372.0742391446315; Mon, 24 Jul 2017 11:41:34 -0700 (PDT) Received: from localhost ([::1]:56380 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiIO-0002OX-IW for importer@patchew.org; Mon, 24 Jul 2017 14:41:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi5x-00006e-DA for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi5w-0004q7-Gd for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:41 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:34194) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi5w-0004pz-Cy; Mon, 24 Jul 2017 14:28:40 -0400 Received: by mail-qt0-x244.google.com with SMTP id i19so2260718qte.1; Mon, 24 Jul 2017 11:28:40 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HeLvrmgwsCLM/mAlPUrAzgq/PIseiLcehgwY5T3ei10=; b=KK12STfJDh+fBiPb1g3m6jlBPdFKv6Vs86cbGSzhi9toc1Pj+hAsE+F5igYxtEczkO eb7b9QQ4skcH5TH1jlCgenYdAuvz8BT2ejQ2qAsWOeyDK+MS57oIS/RdrJj/ChgtQHs5 9u697kY6OrhVnjlqaZtKLDvf6WU/XuNSAF1WvGsLiNwFf9jo/p024Ojjoqg1IFvWJ8lL tzzn1jKQcM8i/JGofROWj5ymRbcQ3Nd6iCDwPYltyVWUELBjgeQjCsxBeHLoY6Z4gFTv NDWrfz0nKKg6zprouebim7ddatGoicnanpu3nh0LBgge+DooLEcnKAEFseSrPX0Kf4cF pkQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=HeLvrmgwsCLM/mAlPUrAzgq/PIseiLcehgwY5T3ei10=; b=ZDuZaDZtwqsShlbnKBoL8v8bXKqYvFv9PaKD5D4Xl3WLbAsuTzbkGu72/De0yRjhil L7V1WxlfTZo3dvLzPhB/Y0U/VYLTVv5LhA3XfJgObQ7z8NkYGhlN5y+TyCDYXO2uCLPN msT8Y7GWk5NiSWY4IhG8J5T8VePHYwsjhikxvNUhOYaC0zTALbNl69Lt/lhYYx8ZwjAZ nK5XyOCgCCGwTpjW1+1i5Eo/9Q0kuRPrsl01LFziM8ZvqQ821b6yo9ZC+Kk7lyNmOk17 pyo/+jxHoq85k5lhUl4Y64H1pP1nh79up9gL/wLSLoh+cdoodoG0FQWIiGZLvhguqnNV LRuQ== X-Gm-Message-State: AIVw112tf+QUAVjNoDaMYrvGZ4RQ39qLqJnNlolPpsWct/3I1ZzM2WeA asDBphDvIDLglQlVE5I= X-Received: by 10.237.53.44 with SMTP id a41mr11358227qte.231.1500920919969; Mon, 24 Jul 2017 11:28:39 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Dmitry Fleytman , Jason Wang Date: Mon, 24 Jul 2017 15:27:26 -0300 Message-Id: <20170724182751.18261-11-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH for 2.10 10/35] net/eth: fix incorrect check of iov_to_buf() return value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 So we have sizeof(struct in6_address) !=3D sizeof(uintptr_t) and Clang > Coverity on this, see 4555ca6816c :) net/eth.c:426:30: warning: The code calls sizeof() on a pointer type. This = can produce an unexpected result return bytes_read =3D=3D sizeof(dst_addr); ^ ~~~~~~~~~~ net/eth.c:475:34: warning: The code calls sizeof() on a pointer type. This = can produce an unexpected result return bytes_read =3D=3D sizeof(src_addr); ^ ~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Dmitry Fleytman --- net/eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/eth.c b/net/eth.c index 5b9ba26a56..ae5d881aae 100644 --- a/net/eth.c +++ b/net/eth.c @@ -423,7 +423,7 @@ _eth_get_rss_ex_dst_addr(const struct iovec *pkt, int p= kt_frags, rthdr_offset + sizeof(*ext_hdr), dst_addr, sizeof(*dst_addr)); =20 - return bytes_read =3D=3D sizeof(dst_addr); + return bytes_read =3D=3D sizeof(*dst_addr); } =20 return false; @@ -472,7 +472,7 @@ _eth_get_rss_ex_src_addr(const struct iovec *pkt, int p= kt_frags, opt_offset + sizeof(opthdr), src_addr, sizeof(*src_addr)); =20 - return bytes_read =3D=3D sizeof(src_addr); + return bytes_read =3D=3D sizeof(*src_addr); } =20 opt_offset +=3D optlen; --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921105578957.869360551544; Mon, 24 Jul 2017 11:31:45 -0700 (PDT) Received: from localhost ([::1]:56328 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi8t-0002k3-Rw for importer@patchew.org; Mon, 24 Jul 2017 14:31:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi60-0000A8-KO for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi5z-0004rL-Dg for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:44 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:34302) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi5z-0004rA-9Z; Mon, 24 Jul 2017 14:28:43 -0400 Received: by mail-qk0-x241.google.com with SMTP id q66so10661855qki.1; Mon, 24 Jul 2017 11:28:43 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DJN8oVzpVUYcYtkQuxilHKkP87gLKQFAVwc7SRaL0pI=; b=cJGKwlC+mMBkGvKcoZVR2OCV95oel7GvNcwTaVXI9inW9UC/hLe8BwGogCV4fjhX8l c3EJmp80lnn6K/uFRG6EaY6Im6JYLut7+q5oP234ka3oOR5+Vx+nJtbinbDx6dHZdV3f xGdaLc0RssKrss1D3Q33l+guwk3waNVM2Y1j+nAHjSLeUUgkK8uPncBoDZ5Uw1knBikM ITXfks6r5dN4AmqVnvj4JjNhDsDaT3gmJNAgBE0OxiftzbpJZj5p3pQZXVPuFYEzdgQO mXpxf4ejoFRf7ncgXePrIGJLnRthR0dvJS4QAZIyq0R60aCTE4Gp4WxZdRhFvG+27KTT 6eVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=DJN8oVzpVUYcYtkQuxilHKkP87gLKQFAVwc7SRaL0pI=; b=WqPKrCU+NozPHa8rZklf9568B9bwQ9zBWDMpnfXOlMfh1jprz649BlXqyPAl8s2Xi3 VPOkisyVM5bTAb3jmdS/7NaUDKlhnPUP3U+7MQlw6mbF/LxKZj1Ze6q8QpkB0FWweFtE hubhx6AYww/yEBoldasa3gbVlB1F9X4YjbJPIGrHIpUxak13OLDkwA4ukYGGT9gBEc3m 1ihsYdu0DUH9QtAcNjz5C6wVsrBLn4EPuROUXTwA31K5hp7D4Un0Uxbs0pNv1GhyGeWV TQ/fEPEoYvShIE+qrMjq7ZspXSTCGFxVEnZ8ymcmnbu4S3URx+qrou28lNKYVpMLblZW 9ADQ== X-Gm-Message-State: AIVw113WzllN8jOq9E2XwlERWGB7/g8dze9QpEXMvzTlmHswiAxsNNxB MsVRFK/OeoLFsWF2t4M= X-Received: by 10.55.40.194 with SMTP id o63mr19675839qko.310.1500920922864; Mon, 24 Jul 2017 11:28:42 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Igor Mitsyanko Date: Mon, 24 Jul 2017 15:27:27 -0300 Message-Id: <20170724182751.18261-12-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH for 2.10 11/35] i2c/exynos4210: correctly check i2c_recv() return value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 i2c_recv() returns -1 on error, if the I2CCON_ACK_GEN bit was not set this = code was setting i2cds =3D -1. i2c/exynos4210_i2c.c:117:20: warning: Loss of sign in implicit conversion s->i2cds =3D ret; ^~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/i2c/exynos4210_i2c.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/i2c/exynos4210_i2c.c b/hw/i2c/exynos4210_i2c.c index c96fa7d7be..4424dbd233 100644 --- a/hw/i2c/exynos4210_i2c.c +++ b/hw/i2c/exynos4210_i2c.c @@ -111,10 +111,12 @@ static void exynos4210_i2c_data_receive(void *opaque) s->i2cstat &=3D ~I2CSTAT_LAST_BIT; s->scl_free =3D false; ret =3D i2c_recv(s->bus); - if (ret < 0 && (s->i2ccon & I2CCON_ACK_GEN)) { - s->i2cstat |=3D I2CSTAT_LAST_BIT; /* Data is not acknowledged */ - } else { + if (ret >=3D 0) { s->i2cds =3D ret; + } else { + if (s->i2ccon & I2CCON_ACK_GEN) { + s->i2cstat |=3D I2CSTAT_LAST_BIT; /* Data is not acknowledged= */ + } } exynos4210_i2c_raise_interrupt(s); } --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921271528939.289141075308; Mon, 24 Jul 2017 11:34:31 -0700 (PDT) Received: from localhost ([::1]:56336 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiBY-0004zi-5g for importer@patchew.org; Mon, 24 Jul 2017 14:34:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi63-0000D5-DU for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi62-0004tE-Is for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:47 -0400 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:37455) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi62-0004sv-ES; Mon, 24 Jul 2017 14:28:46 -0400 Received: by mail-qt0-x242.google.com with SMTP id d10so1059506qtb.4; Mon, 24 Jul 2017 11:28:46 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5OpfPPEOYzhm/3tPM2HzXllTxulVPNmJ+4qRtkXYT18=; b=LH1LyckG0thoj7kk1jByhH65uJaTFa/dd5yM04+yckzcIzd7bbnQP0/P8t15DJ1XpZ hb9i8eLB5u8O1MukSyIdqyZOh/SdfMm8wV46fXPzRSbuOnC4nQ8vc5NMwgPUwzFo+hCI zvPphIxQMQkoELrbPF3PACwjvlLkPXIvIYbuiO8xnhzXurHdaTDAoNJroxwwr3ixdqYu FA9VOQxPP4+bZjdTEvSSLd7QdD/qPMpNArieqTjwsdlngE2Jn0dPm2ACIVA/viU4ba4g DQyj2V/uKRFmqfB003YiCM8ataX1nzc+9g1L930Srkmh3P01Z1ZYa4Erea3KGb+GVL8m gEsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=5OpfPPEOYzhm/3tPM2HzXllTxulVPNmJ+4qRtkXYT18=; b=YN91gQjpaLUc0Zx+YBkUc8xBANWL6bSSZVAKSlC2dDEH5qorKX6DS2QvPNAYkZEjRB 16PChFDNuBW/30l4B/4IZ1pHgy98AfwWt9aYAVs6Pem0/59Gp9ODLkIT7cgBQgoZArzs sIjcksnv6UmrjTZrkeiuOyHy12gaKh7boryz6JoJ66fvvD8qEY2f1ipfO6XWpmOeHFGc a5x8eGmRNXYuP37dBbqn6WW1WnPSdj1SjZeoglqHdhGs2WQuvjnahyQqKK7SUtjcvSnJ 0fR/kniYlPtktvCZbDtG1UjWqLSD4B0tZdCwZ2QeRXGqjGiMALURml00pMb6yN0TBanw rKBQ== X-Gm-Message-State: AIVw113Ub1BIKsklcJbiQjexCjhmjJLTRqoCxhdaXZ68wvc5diuRYu8D dE/JOrOTvNJMxA== X-Received: by 10.200.52.138 with SMTP id w10mr21720259qtb.77.1500920925897; Mon, 24 Jul 2017 11:28:45 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Alex Williamson Date: Mon, 24 Jul 2017 15:27:28 -0300 Message-Id: <20170724182751.18261-13-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::242 Subject: [Qemu-devel] [PATCH for 2.10 12/35] vfio/platform: fix use of freed memory X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 free the data _after_ using it. hw/vfio/platform.c:126:29: warning: Use of memory after it is freed qemu_set_fd_handler(*pfd, NULL, NULL, NULL); ^~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Paolo Bonzini --- hw/vfio/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c index 7c09deda61..da84abf4fc 100644 --- a/hw/vfio/platform.c +++ b/hw/vfio/platform.c @@ -120,11 +120,11 @@ static int vfio_set_trigger_eventfd(VFIOINTp *intp, *pfd =3D event_notifier_get_fd(intp->interrupt); qemu_set_fd_handler(*pfd, (IOHandler *)handler, NULL, intp); ret =3D ioctl(vbasedev->fd, VFIO_DEVICE_SET_IRQS, irq_set); - g_free(irq_set); if (ret < 0) { error_report("vfio: Failed to set trigger eventfd: %m"); qemu_set_fd_handler(*pfd, NULL, NULL, NULL); } + g_free(irq_set); return ret; } =20 --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921533080397.9387686204682; Mon, 24 Jul 2017 11:38:53 -0700 (PDT) Received: from localhost ([::1]:56365 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiFm-0008QD-GM for importer@patchew.org; Mon, 24 Jul 2017 14:38:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi65-0000Gm-Px for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi65-0004uu-1Z for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:49 -0400 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:34205) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi64-0004uf-TO; Mon, 24 Jul 2017 14:28:48 -0400 Received: by mail-qt0-x243.google.com with SMTP id i19so2261220qte.1; Mon, 24 Jul 2017 11:28:48 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6db8O8rUvq+dHdRRjGRWbj4pl1d1APVvxTg8Ajne3GE=; b=U+TPXkImdmSSfweG9kANIqTE50nC0VAiaUJkNJG/AgFJWwq+rurNyr7qTq3doUIakR Rh3sUsXPywO4UmPGrEYIniSgfvmLmVq2v9B0oQkeYQh2VH1CmlGNjB4BPwb8cJ2DwocX rnIzpIsrDOhO0Y4HiFI6b2mziFuj+HM84LJkIE9EJ6YF/fjjY/O05gnKFWbTrV8v6aEf VsLUCPqEMHs3GH9xbBTFzTYIOqhl6BkZC1AwUs01qaOMsGoXy/6VA0kB+xOkzxPQhu6i dYw15d3r2RE62G03HiiVsY/Y+5ojvUboDM4USr4Cq+gpAt7RD4OaQUVWr09WQtgbTe4r Iz7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=6db8O8rUvq+dHdRRjGRWbj4pl1d1APVvxTg8Ajne3GE=; b=MH7py7pbKMSA1v1b+8Uu+GF4Jz1V/STpGXa/wImLNAF45khOCdei6oijPjGNhmVrzG bK7CFoZ79TlS2rr181LgQr0ekYWv6dejdSbUvULM9zax4oR9y9DBuQGwDg66Yx8IYjuW tRsi2ER0Ya2W7H2HEC4MhqUiOi+eAekvzEMpSO6edXcZuYcOhT1Q+fnQ0rFo26WxwM4N 6bnl2FaEcypjCDxzKECQYw5xAGe88EP7JozZt3SsRDviP5/baiLwRJpz6sChdbmrywMZ KQUnZQTExQRJH/K/9rkbID1TP8oj+OQq/ixPJ7D2iZXe5fgjNhCySPQHTwbrg/RDluH/ YKeg== X-Gm-Message-State: AIVw111g1G2EZgt5UJQ0Y/+v/yAGpoPlwOhVoXL5pxThrKtATyazxii2 FSnPVEFZFwqY4Q== X-Received: by 10.237.63.162 with SMTP id s31mr17926589qth.206.1500920928449; Mon, 24 Jul 2017 11:28:48 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Alex Williamson Date: Mon, 24 Jul 2017 15:27:29 -0300 Message-Id: <20170724182751.18261-14-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH for 2.10 13/35] vfio/pci: fix use of freed memory X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 hw/vfio/pci.c:308:29: warning: Use of memory after it is freed qemu_set_fd_handler(*pfd, NULL, NULL, vdev); ^~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Paolo Bonzini --- hw/vfio/pci.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index d4051cb951..31e1edf447 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -257,7 +257,7 @@ static void vfio_intx_update(PCIDevice *pdev) static int vfio_intx_enable(VFIOPCIDevice *vdev, Error **errp) { uint8_t pin =3D vfio_pci_read_config(&vdev->pdev, PCI_INTERRUPT_PIN, 1= ); - int ret, argsz; + int ret, argsz, retval =3D 0; struct vfio_irq_set *irq_set; int32_t *pfd; Error *err =3D NULL; @@ -302,12 +302,12 @@ static int vfio_intx_enable(VFIOPCIDevice *vdev, Erro= r **errp) qemu_set_fd_handler(*pfd, vfio_intx_interrupt, NULL, vdev); =20 ret =3D ioctl(vdev->vbasedev.fd, VFIO_DEVICE_SET_IRQS, irq_set); - g_free(irq_set); if (ret) { error_setg_errno(errp, -ret, "failed to setup INTx fd"); qemu_set_fd_handler(*pfd, NULL, NULL, vdev); event_notifier_cleanup(&vdev->intx.interrupt); - return -errno; + retval =3D -errno; + goto cleanup; } =20 vfio_intx_enable_kvm(vdev, &err); @@ -319,7 +319,10 @@ static int vfio_intx_enable(VFIOPCIDevice *vdev, Error= **errp) =20 trace_vfio_intx_enable(vdev->vbasedev.name); =20 - return 0; +cleanup: + g_free(irq_set); + + return retval; } =20 static void vfio_intx_disable(VFIOPCIDevice *vdev) --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 150092160247250.33466552831999; Mon, 24 Jul 2017 11:40:02 -0700 (PDT) Received: from localhost ([::1]:56367 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiGv-00017M-1s for importer@patchew.org; Mon, 24 Jul 2017 14:40:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi69-0000Ro-Tn for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi67-0004wS-Oj for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:53 -0400 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:35752) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi67-0004wI-LM; Mon, 24 Jul 2017 14:28:51 -0400 Received: by mail-qk0-x243.google.com with SMTP id k2so3225250qkf.2; Mon, 24 Jul 2017 11:28:51 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D0eU/e1OvdEUWI9GKpUGvB63Pm/ycvAQCEHQZFTxTPo=; b=L+VQc3Og5nCDQFxkgi5btjuIGT1qBAVsrXUxlarz8TQV8IJT2BzjSqT3wzwEIp/emy /j+TtuAoOJ1jWwLNYAOxtoSqQJJelVJOqTnf08uOtrzF73c5JxqSFJYnhiKjXOcX9jxe 9mKQ+crlp8QHNqFG1ZToKknsmiP28HkbWokjF/hUuFSFigX2X/75bNC5Rb4xJmaw9G8S lhoq/Cvk90yLXDchyPtQWEuXgyE8mHNn90F15RuqjFh5IYNe13EB3leXSdaXkMKcytZ3 Gu79iVkr6AgZ2BcekQmNahTFOlKuViMOwmD2bEqxEbvf+dTob3RgCJ0Q00p5aZJINx3Z 8TFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=D0eU/e1OvdEUWI9GKpUGvB63Pm/ycvAQCEHQZFTxTPo=; b=NjgI/58yF508lycrFc+1QspSwKdqKPbodKW4ilZpzbjHw0A7riHj36qOl/T7vJ25md mvO/CxRtENKOY42/d8h/Kyda9Vs0GQ/3c5x8mhLpk852pT8XgOHkYXwUoL6/MMtVyZpi McCZknBLwwjERtAOZc9CH2NanQRsUgEx/qnYOtGeqH059z0o3eI/9Fqiy6N4MR/F+AcZ acsX4p0KcGurQriRHo/n09F9GEZIjO7HkEc6ve1v0mlei2mQHmIeZ8ncdVMvDRXg26Vh IJv1eBddVjF0eqbjCE7K83tE27zr4nlqsOQYbdj0XI8KdTMK4BsBfbn3jex30m70uO6L vx5w== X-Gm-Message-State: AIVw111pIV16BYupPvym0bbIY8u9EhDPhSrJ+M/E/f6cdtzrUrpZI/6d wf36tFthhRDy7w== X-Received: by 10.55.20.144 with SMTP id 16mr20124607qku.51.1500920931218; Mon, 24 Jul 2017 11:28:51 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Alex Williamson , Cornelia Huck Date: Mon, 24 Jul 2017 15:27:30 -0300 Message-Id: <20170724182751.18261-15-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::243 Subject: [Qemu-devel] [PATCH for 2.10 14/35] vfio/ccw: fix incorrect malloc() size X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Since sizeof(struct vfio_irq_info) < sizeof(struct vfio_irq_set) a heap ove= rflow never occured. Still, let's use the correct size. hw/vfio/ccw.c:170:16: warning: Cast a region whose size is not a multiple o= f the destination type size irq_info =3D g_malloc0(sizeof(*irq_set)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/vfio/ccw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c index 12d0262336..8d97b53e77 100644 --- a/hw/vfio/ccw.c +++ b/hw/vfio/ccw.c @@ -168,7 +168,7 @@ static void vfio_ccw_register_io_notifier(VFIOCCWDevice= *vcdev, Error **errp) return; } =20 - argsz =3D sizeof(*irq_set); + argsz =3D sizeof(*irq_info); irq_info =3D g_malloc0(argsz); irq_info->index =3D VFIO_CCW_IO_IRQ_INDEX; irq_info->argsz =3D argsz; --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921436297328.6166990511789; Mon, 24 Jul 2017 11:37:16 -0700 (PDT) Received: from localhost ([::1]:56355 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiEE-0007EU-SS for importer@patchew.org; Mon, 24 Jul 2017 14:37:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6B-0000Sx-4X for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6A-0004yB-9K for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:55 -0400 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:38092) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6A-0004xp-51; Mon, 24 Jul 2017 14:28:54 -0400 Received: by mail-qk0-x242.google.com with SMTP id t2so10677854qkc.5; Mon, 24 Jul 2017 11:28:54 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pH/WInsFUCmdsdj7T+VRO9OJJrleVPwyIwIK4KP7U10=; b=rYGPJsqpJ0wvjbdxYFrj9b7ZuQoo2OG5iZDhm/Rka3+7G/s1nNs3l+UWHRpBoIhwpc W0fMDIdex7NgMKaNVP08PrpkTYeTJ9DJRd7/luVMTbF0zcbCy71a6vRD3t+M+A5gV76x oOiiOTgwWimFlPOVFv9137l7AyyXwh17CB6ttE1J0cNRJvzV8RdzDQ3B0QDBaGgxrfKJ BDSruSlsz5xSDgHZSBnmfEDFn9AhuYbXLE1wFmdiFU5axsxPfSrozqkVunNgs7lAQPcw PVSFs5itQXlobuyNCzDaHMd73krxp3ldjhbA2lUu4qbQbnUppy2sL7kZfKai2MApgE4e IxMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=pH/WInsFUCmdsdj7T+VRO9OJJrleVPwyIwIK4KP7U10=; b=LbDyHnYV9i/OB9fqM9SKJ/oNeAW8sqJRhESJorsL1kA4w8e7Ksv9lxfWHHyFcCCsZR 9OJU8sz9v8npYuEnZFzNjlayrPAef23M+Sv5tJCA0vdVWDLnv08pdoNseL8uivnUeSnB KcS/GA2oB78bDxwneANaHp3DDbzkokfUyed1xkUqitZ8tMUFd8eZPmz08is/cTlGfrI6 fSKasBt5d/rEuQhUw2XKTUlGgqBPIQinJGzHL6j1+CqZhkAVeD8ZtnrE/TP3eDXPyT7z 1c26fSzBJfW5cd212eJRF6DHlgTeV1xYM+EpewCbMdZE/5YIgTQpF0EHbh4YzuMaoV9i AADQ== X-Gm-Message-State: AIVw110uNQwIlPF8s/UQJT0TrutAHvkikvxnhUFdOmZtOtyo3hKwJboG jwhWGjwU5HNV9Y6MWPJwVQ== X-Received: by 10.55.43.144 with SMTP id r16mr20731626qkr.59.1500920933701; Mon, 24 Jul 2017 11:28:53 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann Date: Mon, 24 Jul 2017 15:27:31 -0300 Message-Id: <20170724182751.18261-16-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH for 2.10 15/35] usb: correctly handle Zero Length Packets X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 USB Specification Revision 2.0, =C2=A75.5.3: The Data stage of a control transfer from an endpoint to the host is comp= lete when the endpoint does one of the following: =E2=80=A2 Has transferred exactly the amount of data specified during the= Setup stage =E2=80=A2 Transfers a packet with a payload size less than wMaxPacketSize= or transfers a zero-length packet" hw/usb/redirect.c:802:9: warning: Declared variable-length array (VLA) has = zero size uint8_t buf[size]; ^~~~~~~~~~~ ~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/redirect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 5e42730449..5b7073d2cd 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -795,7 +795,7 @@ static void usbredir_handle_bulk_data(USBRedirDevice *d= ev, USBPacket *p, usbredirparser_peer_has_cap(dev->parser, usb_redir_cap_32bits_bulk_length)); =20 - if (ep & USB_DIR_IN) { + if (ep & USB_DIR_IN || size =3D=3D 0) { usbredirparser_send_bulk_packet(dev->parser, p->id, &bulk_packet, NULL, 0); } else { --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921711392959.6217260394696; Mon, 24 Jul 2017 11:41:51 -0700 (PDT) Received: from localhost ([::1]:56384 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiIf-0002cz-U0 for importer@patchew.org; Mon, 24 Jul 2017 14:41:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6D-0000V9-E5 for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6C-0004zz-I6 for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:57 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:37822) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6C-0004zi-Dl for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:56 -0400 Received: by mail-qk0-x241.google.com with SMTP id q130so10664360qka.4 for ; Mon, 24 Jul 2017 11:28:56 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YMdXOeAib3bzA2HPXPSlSv/YuTd8/WrhCV+QHW1/DxI=; b=ODIYCgewhHg9g+Uqnh/Cd36d0aPPc/yBvP3hhCsYpnLeLPnuMLjF1HWl9XiwZ0rnn7 UBmIV+S6sgBb1nq5+jjQcS1X38pr1a3zo29ahpRH1+nHZLHJUXSbgB70WMcqWzI2fK8j NM2Qn4M8ILtHJd9X0FFoKPM+qydzUxFZJdUf7qYywv0dNgCvcCe7+1pQGx+0AhJaz2TD ePcOP333LG99Iw+MivZeM6jRC0MntBeE07ZhkD67QO41I8Upbkzti9AuiVwGQlUTLE5b TvnhxC1MAiMDvIV48/gXh6lsPu52W49Mr3EWEsnmy9X/KQWvoUj6vwc6BG0Q3tb2s6jW lu7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=YMdXOeAib3bzA2HPXPSlSv/YuTd8/WrhCV+QHW1/DxI=; b=SA5LKNegUCkPW3vxxeB3GZGLhHyCqQNF0yh0hEVztk04Q3zfu9gRu/+CFB8dCFY0wE zkrW11gzSH2GuX/UHcJRnXyDS4/fWh5Xa/oPoQcm1VXo9ySv3bOeCMRhj1evS/MHDvE0 MEv6QniDquEuxgb3tZtiBm6r8vzIBmvrKlfbPfsIttmu1K6zQthFhSQeyx1ySyFC8RlJ JG5VB5SAQIM6OyrrLTThDeYV16ufv46v5pSSnOBQjsgvJbIPIb6UrnacOA4kvUGNLqj4 v9QNC+2ZHy0tebR6lsmHJnd270M7wXSHSP/6hU2v/Ck75TZ6R0Qz3sYxQ1b69X73xLlX On5w== X-Gm-Message-State: AIVw111mg9k4nym5/108BYtkV7zcuF20uMGezenVT9vBxyub91kEls+9 GUEIzB7UeEayQOxZcMMlDg== X-Received: by 10.55.38.83 with SMTP id y80mr487056qkg.113.1500920935996; Mon, 24 Jul 2017 11:28:55 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann Date: Mon, 24 Jul 2017 15:27:32 -0300 Message-Id: <20170724182751.18261-17-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH for 2.10 16/35] usb/dev-mtp: fix use of uninitialized values X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 hw/usb/dev-mtp.c:1212:13: warning: 2nd function call argument is an uniniti= alized value o =3D usb_mtp_object_lookup(s, c->argv[0]); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/dev-mtp.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 94c2e94f10..6dfece9ea9 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -1209,7 +1209,9 @@ static void usb_mtp_command(MTPState *s, MTPControl *= c) } break; case CMD_GET_OBJECT_INFO: - o =3D usb_mtp_object_lookup(s, c->argv[0]); + if (c->argc > 0) { + o =3D usb_mtp_object_lookup(s, c->argv[0]); + } if (o =3D=3D NULL) { usb_mtp_queue_result(s, RES_INVALID_OBJECT_HANDLE, c->trans, 0, 0, 0); @@ -1218,7 +1220,9 @@ static void usb_mtp_command(MTPState *s, MTPControl *= c) data_in =3D usb_mtp_get_object_info(s, c, o); break; case CMD_GET_OBJECT: - o =3D usb_mtp_object_lookup(s, c->argv[0]); + if (c->argc > 0) { + o =3D usb_mtp_object_lookup(s, c->argv[0]); + } if (o =3D=3D NULL) { usb_mtp_queue_result(s, RES_INVALID_OBJECT_HANDLE, c->trans, 0, 0, 0); @@ -1237,7 +1241,9 @@ static void usb_mtp_command(MTPState *s, MTPControl *= c) } break; case CMD_GET_PARTIAL_OBJECT: - o =3D usb_mtp_object_lookup(s, c->argv[0]); + if (c->argc > 0) { + o =3D usb_mtp_object_lookup(s, c->argv[0]); + } if (o =3D=3D NULL) { usb_mtp_queue_result(s, RES_INVALID_OBJECT_HANDLE, c->trans, 0, 0, 0); @@ -1281,7 +1287,9 @@ static void usb_mtp_command(MTPState *s, MTPControl *= c) } break; case CMD_GET_OBJECT_PROP_VALUE: - o =3D usb_mtp_object_lookup(s, c->argv[0]); + if (c->argc > 0) { + o =3D usb_mtp_object_lookup(s, c->argv[0]); + } if (o =3D=3D NULL) { usb_mtp_queue_result(s, RES_INVALID_OBJECT_HANDLE, c->trans, 0, 0, 0); --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921865253431.9427514611252; Mon, 24 Jul 2017 11:44:25 -0700 (PDT) Received: from localhost ([::1]:56396 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiL7-0004qu-LJ for importer@patchew.org; Mon, 24 Jul 2017 14:44:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6F-0000Xh-TR for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6E-00054w-SP for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:59 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:35947) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6E-000546-Og for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:28:58 -0400 Received: by mail-qk0-x244.google.com with SMTP id d136so10666863qkg.3 for ; Mon, 24 Jul 2017 11:28:58 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eD+h7Tnaf92i6bqvVio/3GhrAwuC9rNOvKnQs/YGhG4=; b=JGGKyeGm6glN4hwg59lucR7XSi+Upj5AbGlzmEtxN2BredxQZ/PaTBDcETp/j1mvX+ tqjUBH/s5sesvRK0CthcXAwZ1ScBWjvqeK+ZwEvitp21jVulZ90N3T12y9roWluy/Z6Z XokikbZemNYGKhXI2A5lzf6PDkfax78LoDxr+Ermt4vh97PtX23n8cTzkkJsMBKE2kLM YOtOAYQwsC76LSCCV4+m+UYUrBuJWTRbLen0CthP/uscmBFEVQ/TMN8sXC1xvvq3H6aT lHQaOlRlubs45ryYVrOgFeTpJ3HP9GBK5CqrN0awn50gecveV/FCUhaeV47flES/siwO QXYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=eD+h7Tnaf92i6bqvVio/3GhrAwuC9rNOvKnQs/YGhG4=; b=q19qJAn72+jji46/nvuw4bS6O3pJylR14lwQdf4YhGmpF8J+W6bZOPEparjA2UmiJM IQnNtOvJpoKxVbne9F6eNPivSHD+S/+3RvLysAvA3Wev1PQT0MMWxe/Mv7If1JRhaq6n Fu7bvs7KhNn/7n/dFSk0IEUqphBXA4hc0NzQr4V0a4Wsp2Ir2sAmVVR/puLX1VR/2Ouy Fk6G+EjTl6BFtaldMQnVjKMiD+5/NwkvTpdoAg6a7HOYV5sorI2CPaELF31fUoxFJ3CP QmEk1Hh1XcHJOQ3DLCGC4nNF3a9MNf4XzQ57gt1v1KrLUxNDwOc/2l33HWs70j2KzJVC ay2A== X-Gm-Message-State: AIVw112P3gvGAR53+RWlJMPcyIsJYwrEB8p649qDxCxY7lvVnMFkiL25 HOMZGlfkhV9uyamcu7tzrg== X-Received: by 10.55.179.133 with SMTP id c127mr22166602qkf.356.1500920938306; Mon, 24 Jul 2017 11:28:58 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann Date: Mon, 24 Jul 2017 15:27:33 -0300 Message-Id: <20170724182751.18261-18-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH for 2.10 17/35] usb/dev-mtp: fix use of uninitialized values X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/dev-mtp.c | 36 +++++++++++++++++++++--------------- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 6dfece9ea9..ad64495f05 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -1134,7 +1134,7 @@ static void usb_mtp_command(MTPState *s, MTPControl *= c) c->trans, 1, s->session, 0); return; } - if (c->argv[0] =3D=3D 0) { + if (c->argc =3D=3D 0 || c->argv[0] =3D=3D 0) { usb_mtp_queue_result(s, RES_INVALID_PARAMETER, c->trans, 0, 0, 0); return; @@ -1162,8 +1162,9 @@ static void usb_mtp_command(MTPState *s, MTPControl *= c) data_in =3D usb_mtp_get_storage_ids(s, c); break; case CMD_GET_STORAGE_INFO: - if (c->argv[0] !=3D QEMU_STORAGE_ID && - c->argv[0] !=3D 0xffffffff) { + if (c->argc =3D=3D 0 || + (c->argv[0] !=3D QEMU_STORAGE_ID && + c->argv[0] !=3D 0xffffffff)) { usb_mtp_queue_result(s, RES_INVALID_STORAGE_ID, c->trans, 0, 0, 0); return; @@ -1172,22 +1173,25 @@ static void usb_mtp_command(MTPState *s, MTPControl= *c) break; case CMD_GET_NUM_OBJECTS: case CMD_GET_OBJECT_HANDLES: - if (c->argv[0] !=3D QEMU_STORAGE_ID && - c->argv[0] !=3D 0xffffffff) { + if (c->argc =3D=3D 0 || + (c->argv[0] !=3D QEMU_STORAGE_ID && + c->argv[0] !=3D 0xffffffff)) { usb_mtp_queue_result(s, RES_INVALID_STORAGE_ID, c->trans, 0, 0, 0); return; } - if (c->argv[1] !=3D 0x00000000) { + if (c->argc > 1 && c->argv[1] !=3D 0x00000000) { usb_mtp_queue_result(s, RES_SPEC_BY_FORMAT_UNSUPPORTED, c->trans, 0, 0, 0); return; } - if (c->argv[2] =3D=3D 0x00000000 || - c->argv[2] =3D=3D 0xffffffff) { - o =3D QTAILQ_FIRST(&s->objects); - } else { - o =3D usb_mtp_object_lookup(s, c->argv[2]); + if (c->argc > 2) { + if (c->argv[2] =3D=3D 0x00000000 || + c->argv[2] =3D=3D 0xffffffff) { + o =3D QTAILQ_FIRST(&s->objects); + } else { + o =3D usb_mtp_object_lookup(s, c->argv[2]); + } } if (o =3D=3D NULL) { usb_mtp_queue_result(s, RES_INVALID_OBJECT_HANDLE, @@ -1264,8 +1268,9 @@ static void usb_mtp_command(MTPState *s, MTPControl *= c) res0 =3D data_in->length; break; case CMD_GET_OBJECT_PROPS_SUPPORTED: - if (c->argv[0] !=3D FMT_UNDEFINED_OBJECT && - c->argv[0] !=3D FMT_ASSOCIATION) { + if (c->argc =3D=3D 0 || + (c->argv[0] !=3D FMT_UNDEFINED_OBJECT && + c->argv[0] !=3D FMT_ASSOCIATION)) { usb_mtp_queue_result(s, RES_INVALID_OBJECT_FORMAT_CODE, c->trans, 0, 0, 0); return; @@ -1273,8 +1278,9 @@ static void usb_mtp_command(MTPState *s, MTPControl *= c) data_in =3D usb_mtp_get_object_props_supported(s, c); break; case CMD_GET_OBJECT_PROP_DESC: - if (c->argv[1] !=3D FMT_UNDEFINED_OBJECT && - c->argv[1] !=3D FMT_ASSOCIATION) { + if (c->argc > 1 && + (c->argv[1] !=3D FMT_UNDEFINED_OBJECT && + c->argv[1] !=3D FMT_ASSOCIATION)) { usb_mtp_queue_result(s, RES_INVALID_OBJECT_FORMAT_CODE, c->trans, 0, 0, 0); return; --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921624905293.60888245650654; Mon, 24 Jul 2017 11:40:24 -0700 (PDT) Received: from localhost ([::1]:56371 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiHE-0001NZ-R9 for importer@patchew.org; Mon, 24 Jul 2017 14:40:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6J-0000aT-3s for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6H-00059J-EP for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:03 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:35763) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6H-00058t-An for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:01 -0400 Received: by mail-qk0-x241.google.com with SMTP id k2so3225574qkf.2 for ; Mon, 24 Jul 2017 11:29:01 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.28.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5znBpDLmQxYQcAAIDxEmEEl/gxrAOBg/jxawTEPRpN0=; b=sQ47z4GOD5eB5H5gVcpbtipXV4O6rIKaSQs2Ye1bzFOEx3hpc5EilAnz07ZTAwrxNz ff/4bln0VD8mhRPqjSyUJGz5Zn1L/A0n8Uh4HYSNk0FuqPynMzhy5eBQ9MOSFu3sv2YJ MuOfWHfcCm3vVtSnZtz6qW/HLfGrf/fJ0CaEO6AkW9ebjNCqkXfrZhvQ04Ih5dsJOkiZ /q8TbWQiqTM5NZ4JnbH5FEkISTg5BReVeyKug8PHSwqXbSwiJZNF0tBORHOFEFmFWdCk LvXKlUZK+5eVZmyqTl76GWGjil0M3L04SQyopr/kUBOpLJYsa6ABXMi2GIynrcVTWZ2b 8wGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=5znBpDLmQxYQcAAIDxEmEEl/gxrAOBg/jxawTEPRpN0=; b=G0nakNzG5+LBjChrcWAuK1tBE5biwp2Xn3v1/v9pZ07JHaZB3r+U3ixbhMLUVNYz+z aEBzen9DYcCXB7koPxE9dTmU0j0HVHJqCppHfYRp95xeH+yHSZ5oWwv+pBtvCyPvgBQa xz8roz+cXsmbu6htGIgkUS773imSj2UFv2vgig1CyvPBYVDHdzJrZy45z6/eA/l8/wfe yW9SZa7b3YJ7YOmRKm4uF+W+vHM0C5X/Af5ZJbKZRVNoItZMmgo8fUlYU4/2A42HEAnQ ef88wRFAiUM1vVuFxuh26uFrjcJngnYs3F36tSmPdDbuaoMuWFPETasonGxULGl+uEs/ wkxQ== X-Gm-Message-State: AIVw111RsGvv0X1t7hkNN21vrFexAfwRMAjLAn321ZAHk8AKMNbbWZLb zzcaXnzHNU2uxA== X-Received: by 10.55.31.34 with SMTP id f34mr20169100qkf.357.1500920940886; Mon, 24 Jul 2017 11:29:00 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann Date: Mon, 24 Jul 2017 15:27:34 -0300 Message-Id: <20170724182751.18261-19-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH for 2.10 18/35] usb/dev-mtp: fix use of uninitialized values X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 hw/usb/dev-mtp.c:971:5: warning: 4th function call argument is an uninitial= ized value trace_usb_mtp_op_get_partial_object(s->dev.addr, o->handle, o->path, c->argv[1], c->argv[2]); ^~~~~~~~~~ hw/usb/dev-mtp.c:981:12: warning: Assigned value is garbage or undefined offset =3D c->argv[1]; ^ ~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/dev-mtp.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index ad64495f05..b4f0b5dafd 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -965,12 +965,16 @@ static MTPData *usb_mtp_get_object(MTPState *s, MTPCo= ntrol *c, static MTPData *usb_mtp_get_partial_object(MTPState *s, MTPControl *c, MTPObject *o) { - MTPData *d =3D usb_mtp_data_alloc(c); + MTPData *d; off_t offset; =20 + if (c->argc <=3D 2) { + return NULL; + } trace_usb_mtp_op_get_partial_object(s->dev.addr, o->handle, o->path, c->argv[1], c->argv[2]); =20 + d =3D usb_mtp_data_alloc(c); d->fd =3D open(o->path, O_RDONLY); if (d->fd =3D=3D -1) { usb_mtp_data_free(d); --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921818339444.0038955828701; Mon, 24 Jul 2017 11:43:38 -0700 (PDT) Received: from localhost ([::1]:56393 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiKP-00047I-1P for importer@patchew.org; Mon, 24 Jul 2017 14:43:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6L-0000cK-2R for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6K-0005EC-9G for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:05 -0400 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:35767) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6K-0005DV-4Z; Mon, 24 Jul 2017 14:29:04 -0400 Received: by mail-qk0-x242.google.com with SMTP id k2so3225645qkf.2; Mon, 24 Jul 2017 11:29:04 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.29.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JF1zCj/a2H3l+jm97v/rsw2Xg+MX/98ug/OteBtS8tQ=; b=SQU5nnGs5/ZwTNnYY7xbTl3S0fxg6N0xS7KBOBXzggGrBlwzAJuKerV1DDWcA3hluS NW/dJsgoZka8XArPJhH1eP775ba8fXcRWHrEVj82vBqVDQXpXP5fO1yQEWfRyJfrAa2w uZofnJ1WF6+srNO4TeZTOnPeC3e2wZn9L1arxWlYgdZgD91tIRuPxMg0PoIHKK7/kHfx cxD6Rt44svnvRvJEC1t7KHsVv7MdCLM3VuzZM4OFf82UzdBA/sLWR/jYNAigd/f2At5t 53JR/RFG1A1XcOCSlZGu3wZEW0aQzJTU+6nfpJmiv2JmJwqYOGjyIkM128/yPZoX96to RmEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=JF1zCj/a2H3l+jm97v/rsw2Xg+MX/98ug/OteBtS8tQ=; b=awLsMcX9Q8MGEKDw22mZK/tg2pfYef79QFND51ubxUaeV9amjQ1k5U26rPvzFxYFjj sGXkaAhS9VA9g2EUGKyqI14b13a1t9zz08jfdpZ+QKhmbjX9Fx1AvYKhsF5cDlw+/HCB pdvov4Qq5wVVDFKXAWBHgbpsuMlG7VdUYKm1IPBE2YcvxZ/UqeNhB2eSdBxf4jJwnSQ4 GUCxu+t79D4Y7Q937Ei9ZUFr1+aqOtVDWfhqNZ2WD4j1cbXXvWO3c+EvOiyJ8mZK+5N2 mvxe7WrP3Wrz2ROrNz4J40nzdu/J+FtbgU/yLXqjjsH9/7h9Te0yTfYuc9lXqzGgRC4a A7BQ== X-Gm-Message-State: AIVw1104IVJyoOWPzvO7f1n32L0OOlqkjNwfNvzrN/qVp4dXmp6EZjeW Z/cS42q95GXpwA== X-Received: by 10.55.43.144 with SMTP id r16mr20732155qkr.59.1500920943718; Mon, 24 Jul 2017 11:29:03 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann Date: Mon, 24 Jul 2017 15:27:35 -0300 Message-Id: <20170724182751.18261-20-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH for 2.10 19/35] usb/dev-mtp: fix use of uninitialized variable X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 hw/usb/dev-mtp.c:1200:15: warning: The left operand of '=3D=3D' is a garbag= e value if (o =3D=3D NULL) { ~ ^ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/dev-mtp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index b4f0b5dafd..5615fb3634 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -1117,7 +1117,7 @@ static MTPData *usb_mtp_get_object_prop_value(MTPStat= e *s, MTPControl *c, static void usb_mtp_command(MTPState *s, MTPControl *c) { MTPData *data_in =3D NULL; - MTPObject *o; + MTPObject *o =3D NULL; uint32_t nres =3D 0, res0 =3D 0; =20 /* sanity checks */ --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921987717419.3430553691404; Mon, 24 Jul 2017 11:46:27 -0700 (PDT) Received: from localhost ([::1]:56415 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiN8-0006mq-1w for importer@patchew.org; Mon, 24 Jul 2017 14:46:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6O-0000fD-2M for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6N-0005Hv-6k for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:08 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:35959) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6N-0005HV-2W; Mon, 24 Jul 2017 14:29:07 -0400 Received: by mail-qk0-x241.google.com with SMTP id d136so10667176qkg.3; Mon, 24 Jul 2017 11:29:06 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.29.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:29:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rS3tqT19YdULv0e9r4PvbAfIJexWBni5G2TDPShS8kQ=; b=W3hijY2HaCvuu7ZY0kc+Kgkegao9kPXej/+NBBom1XsOlgH/hhHUwj94/GGzdT/LJQ fhQxwMuwP12ICPY0396mOKZ7QfP/hnwsHO819ND/1tdiMl5ndV3iRyKfIhW/bN3zGu/d XjY7fKz84m8gOh9ZSbX6Q6iH5lZTztNbHUXS6y72RGnYCq0REpI1WAiLyWVcZGPtXrC3 iHT6qFPempGuAVNGZa7/NUgmoLOMDoverzU2ftT3tOiQX9ulMd56J2tME+t3UPlXVmLy +ltMOyh0WGYakS3UOYPtWgzzo+SBGo+Oos2A+CptB7c3DPR657c1VA2CKVc9Y34usu7X UHZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=rS3tqT19YdULv0e9r4PvbAfIJexWBni5G2TDPShS8kQ=; b=fHdNX2rsKiHMLiBb8acxQ6EmDDwvSfK1BBYYv/JEnyumj9n/1YtukiRw8hfZ7rGSsA EPbGcMWCXa5WYnXWtXt3Dzp/lW/K+5jrQiogat5QdTzlcRuD/ynCV8XJ84q8OEqN29yC pw0h7fYrZx2KemP6d740EdIyLUS1KZU1gsvjrlZbniWYjCHVjfQHXihEeFXTrWth04fh 8yxRmraKzXh1Gom8KdqlHAXrGVrrwLbMbip3xLdNanRrZQBYbEug8a2Tf8gq7saGy+Zp 3HQB8zH3/LD3INV9GibA5CKV8NVofZPG2Ck6YtCV/w3zEbaF4MVgUhfc5/1yOqroOh4D 4mBA== X-Gm-Message-State: AIVw1108kmX2NoGnrmANvTjnH0/At5x371BKPGR/BBBHV0zZUO9MvGK7 Tq3qnjGVUxtbbw== X-Received: by 10.55.42.104 with SMTP id q101mr20383599qkh.84.1500920946594; Mon, 24 Jul 2017 11:29:06 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Peter Maydell Date: Mon, 24 Jul 2017 15:27:36 -0300 Message-Id: <20170724182751.18261-21-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH for 2.10 20/35] arm/boot: fix undefined instruction on secondary smp cpu bootloader X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 In a ARM multicore system, write_secondary_boot() only initializes fixups f= or FIXUP_GIC_CPU_IF and FIXUP_BOOTREG, while smpboot[] also uses FIXUP_DSB. This results in write_bootloader() using uninitialized fixupcontext[FIXUP_D= SB] instruction in the bootloader code... Zero-initialize fixupcontext[] to avoid this issue. hw/arm/boot.c:157:18: warning: Assigned value is garbage or undefined insn =3D fixupcontext[fixup]; ^ ~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index c2720c8046..fb21f113c2 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot.c @@ -170,7 +170,7 @@ static void write_bootloader(const char *name, hwaddr a= ddr, static void default_write_secondary(ARMCPU *cpu, const struct arm_boot_info *info) { - uint32_t fixupcontext[FIXUP_MAX]; + uint32_t fixupcontext[FIXUP_MAX] =3D {}; =20 fixupcontext[FIXUP_GIC_CPU_IF] =3D info->gic_cpu_if_addr; fixupcontext[FIXUP_BOOTREG] =3D info->smp_bootreg_addr; --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500922049660986.4494419551374; Mon, 24 Jul 2017 11:47:29 -0700 (PDT) Received: from localhost ([::1]:56420 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiO8-0007bR-7l for importer@patchew.org; Mon, 24 Jul 2017 14:47:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50582) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6S-0000jL-6R for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6Q-0005Mz-0V for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:12 -0400 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:32996) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6P-0005MH-T8; Mon, 24 Jul 2017 14:29:09 -0400 Received: by mail-qk0-x242.google.com with SMTP id d145so8120924qkc.0; Mon, 24 Jul 2017 11:29:09 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.29.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:29:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NTAK9W79+iqAA6Kr5BAWdSwRBWdgv2jcG1b/j7mz1M0=; b=DfZttV65RcmZnlymw4wDiv1zGJN2DVCkmngR/gThJOl7l0CM2jnMgW7mfYhIn73/Bp b8XXVxvgK8LQCtio7bo0QdAJpP5aVvGH7QWmg0e0eFsFG9jtP9oEgQY/Q2Srct8XD8W5 6MKxqOm9pCm6n6NrUm/J2qpprKuK/cmSvK8jNItLtf/dAV/QrYu5dnMtzx3gdR+zx9CF m8+Cql+gCSVWfZyvuAUzhNfJgEHoqliZ4v/gwUVpAazgEA/i6Hy5kv5ReEWvF9xgLng0 w0Sy5R3CE79mNxHcWUidXMvXI34zVFcTB1VsGuavuyV5zOmuDyoCC7Ck291UkdBX/Ydo tmtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=NTAK9W79+iqAA6Kr5BAWdSwRBWdgv2jcG1b/j7mz1M0=; b=ptNfdWPAl5/bea5SNgzp5OnNVquJlmZDtYmiPVCO6O4EtWEll16XLyBId3raOcGBlt 0jkEElnnV05lHcLTKfTdX6hvo8lc7FojKqrSYamcaJAphuoDNdhrikcxZp4BJZFT/T1C 2lfXBiDdWmR8MVI16MtN/ND2lm8Sjc4LSt5/ADWCjd5Nq6Zf1qyr8CMKmZfhZlCwYRgO HfPexxGqSQQspweVqTSk4/fOqz0rLtScv8ZsWniBlhynbYGMAmtS1xbMFDjlJf4wMyl7 HDZ4OD4/kKqlAiDCteOWuWj6OwEjpTpHPeRbv7HTeZPQ/eEF4UgOgtmHYUGMBognSnzI j/4g== X-Gm-Message-State: AIVw112MyLFLHYr4+V2AhplFMPxNEAy/DRAvrrRiXDQGGhkoZ9yDkEKz urGlsuUtuQiH9A== X-Received: by 10.55.183.65 with SMTP id h62mr1113412qkf.35.1500920949426; Mon, 24 Jul 2017 11:29:09 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Peter Maydell Date: Mon, 24 Jul 2017 15:27:37 -0300 Message-Id: <20170724182751.18261-22-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH for 2.10 21/35] arm/sysbus-fdt: fix null pointer dereference X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Use error_report() + exit() instead of error_setg(&error_fatal). hw/arm/sysbus-fdt.c:322:9: warning: Array access (from variable 'node_path'= ) results in a null pointer dereference if (node_path[1]) { ^~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/sysbus-fdt.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/arm/sysbus-fdt.c b/hw/arm/sysbus-fdt.c index d68e3dcdbd..ad0cc49b19 100644 --- a/hw/arm/sysbus-fdt.c +++ b/hw/arm/sysbus-fdt.c @@ -315,15 +315,14 @@ static int add_amd_xgbe_fdt_node(SysBusDevice *sbdev,= void *opaque) node_path =3D qemu_fdt_node_path(host_fdt, dt_name, vdev->compat, &error_fatal); if (!node_path || !node_path[0]) { - error_setg(&error_fatal, "%s unable to retrieve node path for %s/%= s", + error_report("%s unable to retrieve node path for %s/%s", __func__, dt_name, vdev->compat); - } - - if (node_path[1]) { - error_setg(&error_fatal, "%s more than one node matching %s/%s!", + exit(1); + } else if (node_path[1]) { + error_report("%s more than one node matching %s/%s!", __func__, dt_name, vdev->compat); + exit(1); } - g_free(dt_name); =20 if (vbasedev->num_regions !=3D 5) { --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500922149073288.00512219826703; Mon, 24 Jul 2017 11:49:09 -0700 (PDT) Received: from localhost ([::1]:56426 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiPi-0000f0-F6 for importer@patchew.org; Mon, 24 Jul 2017 14:49:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6T-0000lP-TR for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6T-0005Tr-2x for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:13 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:32928) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6S-0005TF-Vm; Mon, 24 Jul 2017 14:29:13 -0400 Received: by mail-qt0-x244.google.com with SMTP id n42so3129050qtn.0; Mon, 24 Jul 2017 11:29:12 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.29.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:29:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qcszXCoRlLX/kkct26pbv4QF4eJqOyrRFtFi31KytKo=; b=b5/wyXiDWV7ObtUdB5rLBfK4Os1T0C1uex/QvS5zGA+Wx97l22raaJD1z/u8b2E+U9 rTjhcTttThPNSYIIb6XwO5w1sg7y0HwaBBNCeflCqT4C0Rd74j5h5PyfFYSGlB4kr8YN eNljKOTTCUbBfRKbT+FXm2Kp/wZX86zRz9CYcW7gahs5azzi3FZ9AxN0RteuT9aL1hxw 4GzxNgVvvkFg9voyyNBCX9uK9dczfL4DVgYsvu7B8VTkyv229ZCwg+rZVhwhdjaffVNZ 8FRiZU147XW/r1PBMjkE6b5wcGe8btbPdU9sp0dNtHmuNIQVeaImBBIp6D9wwS4Pi9vW Nk4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=qcszXCoRlLX/kkct26pbv4QF4eJqOyrRFtFi31KytKo=; b=da+bVTLUToPM1uZvVYnmK4QOHU0NtkkNbNqUGJHrVtCdff+YCLIoLFb5d8pXrNNkgV ZNZ8QxItGGtOAlyZp5wrBX+yM4DOib2wN0jt72NDkcXq0xKRG99lQDDSgO6eu887lfAE eYcQQD/8p+dfXi7iupKS/c2u/VaexGAT0kgFd6Wr+F3xzbx5fbxsFpaSKX2Esef+wH3s Xkdm7Cms3H8fLdMXbalsBP6fHNfwaTM4R/p4IlTml+B+vB3YZeAxzoYFalYeXy53uuIM KrlpRI9oty3QuO4V4xbn0XZpRfAzBMD5xJl4wVvaWAhfEGojMd/4gxs+TpbE3PW1BsEF 4jBg== X-Gm-Message-State: AIVw113+VZuhQhvINnpcMGR2Q4DIMmoyrlJyeLXkYlWb0OxaNnrTEz2X vd3LcYwx5HgYEQ== X-Received: by 10.237.53.44 with SMTP id a41mr11360004qte.231.1500920952515; Mon, 24 Jul 2017 11:29:12 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Peter Maydell Date: Mon, 24 Jul 2017 15:27:38 -0300 Message-Id: <20170724182751.18261-23-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH for 2.10 22/35] arm/vexpress: fix potential memory leak X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Reorder to only allocate if required. hw/arm/vexpress.c:667:13: warning: Potential leak of memory pointed to by '= flashalias' Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/vexpress.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c index 528c65ddb6..76c4d84482 100644 --- a/hw/arm/vexpress.c +++ b/hw/arm/vexpress.c @@ -553,8 +553,6 @@ static void vexpress_common_init(MachineState *machine) MemoryRegion *sysmem =3D get_system_memory(); MemoryRegion *vram =3D g_new(MemoryRegion, 1); MemoryRegion *sram =3D g_new(MemoryRegion, 1); - MemoryRegion *flashalias =3D g_new(MemoryRegion, 1); - MemoryRegion *flash0mem; const hwaddr *map =3D daughterboard->motherboard_map; int i; =20 @@ -657,6 +655,9 @@ static void vexpress_common_init(MachineState *machine) } =20 if (map[VE_NORFLASHALIAS] !=3D -1) { + MemoryRegion *flashalias =3D g_new(MemoryRegion, 1); + MemoryRegion *flash0mem; + /* Map flash 0 as an alias into low memory */ flash0mem =3D sysbus_mmio_get_region(SYS_BUS_DEVICE(pflash0), 0); memory_region_init_alias(flashalias, NULL, "vexpress.flashalias", --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500922325122502.57259105086473; Mon, 24 Jul 2017 11:52:05 -0700 (PDT) Received: from localhost ([::1]:56447 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiSY-0002yr-E6 for importer@patchew.org; Mon, 24 Jul 2017 14:52:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6X-0000qZ-3Y for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6W-0005Z0-8f for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:17 -0400 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:35823) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6W-0005YU-4P; Mon, 24 Jul 2017 14:29:16 -0400 Received: by mail-qt0-x243.google.com with SMTP id 21so5057382qtx.2; Mon, 24 Jul 2017 11:29:16 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.29.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WFFxs9Ooa+6tnGMZjdkX8R1GjF584z52PtKnRrsI1Co=; b=HcR0L+xniGXi8jHsdAel+6pzGlgyk8QoUt6ur69yL6FKU5WB+CDXRdbyjJEwxyPA5v yWOXURvoycUlmeapnG45pQCaDxQAc7SdRv9Mo8x9Ud7n4riMAAzaY+oRv1ZKoGfbckHX 5pYHdP0fO8m/l9CspKPm9IDlA4luKKsFE0BMs0ZQPnuXoNw2/BJVGuM0QG5a/ViKCKeV aBw6sHCqVWslRE2gW8NQc9oD2mzMiOCEY3eBAvc6vJoihfYOJYpaobgSss9Su6apzr3G nz2+2yy2s4q17Z4gWznw0IuPFfe0pTR1Ntl0xcPUjUPpxnrrTFyvTerwD2wLYY17F/Dp 99cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=WFFxs9Ooa+6tnGMZjdkX8R1GjF584z52PtKnRrsI1Co=; b=g64Ndlan+VUorNpC2tRCk4ep/xKCLDG06qzbdWykTcWjdvd/o/NtS7St/NnT+WKnan 9HCAwBlOSM82ZL0OQU91of7WwHVfJ52HSCRSL60+U+62A8jbljgogTMeBTGVto1ArV4V 7RCAjRTtCqT0JOGteCAL+RzHeWfbu1t5QiOUF0zA4vEtpVEk9dxNsDLdmYa7Jrl3MtVQ DWR7NhckrM7044hLIrT0EtUzZnOI5Z6p6wOoWlJhFkEtQwh612OFVi6uRyO/3gltg79s HCm0wLdouBdJDdjuW+V1G2gdyR4rrxK5rUVS6dTXaEzctN4dEtYfrAlrDFbnYr7P+7wA BqZw== X-Gm-Message-State: AIVw111+8T56MYGJa31LOJXNuWVyJfR//LpQ/2riPekvXpmMlH5i4VOS 6p/sp+/uB7Shxw== X-Received: by 10.200.50.133 with SMTP id z5mr2799674qta.78.1500920955695; Mon, 24 Jul 2017 11:29:15 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Laurent Vivier , Richard Henderson Date: Mon, 24 Jul 2017 15:27:39 -0300 Message-Id: <20170724182751.18261-24-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH for 2.10 23/35] m68k/translate: fix incorrect copy/paste X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 db3d7945ae extended gen_cc_cond() for cond [6, 7, 9, 10] but misswrote [4, = 5] target/m68k/translate.c:1323:70: warning: identical expressions on both sid= es of logical operator if (op =3D=3D CC_OP_ADDB || op =3D=3D CC_OP_ADDW || op =3D=3D CC_OP= _ADDL || op =3D=3D CC_OP_ADDB || op =3D=3D CC_OP_ADDW || op =3D=3D CC_OP= _ADDL) { ~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~ ^ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier --- target/m68k/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index ada2a91b64..1a2f421aab 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -1321,7 +1321,8 @@ static void gen_cc_cond(DisasCompare *c, DisasContext= *s, int cond) case 5: /* CS (C) */ /* Some cases fold C into X. */ if (op =3D=3D CC_OP_ADDB || op =3D=3D CC_OP_ADDW || op =3D=3D CC_O= P_ADDL || - op =3D=3D CC_OP_ADDB || op =3D=3D CC_OP_ADDW || op =3D=3D CC_O= P_ADDL) { + op =3D=3D CC_OP_SUBB || op =3D=3D CC_OP_SUBW || op =3D=3D CC_O= P_SUBL || + op =3D=3D CC_OP_LOGIC) { tcond =3D TCG_COND_NE; c->v1 =3D QREG_CC_X; goto done; --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500922490083953.4857677005652; Mon, 24 Jul 2017 11:54:50 -0700 (PDT) Received: from localhost ([::1]:56459 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiVE-0005Ft-MY for importer@patchew.org; Mon, 24 Jul 2017 14:54:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6b-0000uh-DY for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6Z-0005ab-Cn for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:21 -0400 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:35828) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6Z-0005aS-7Y; Mon, 24 Jul 2017 14:29:19 -0400 Received: by mail-qt0-x243.google.com with SMTP id 21so5057654qtx.2; Mon, 24 Jul 2017 11:29:19 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.29.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X4wci52PlVRWn+r3Us2GufOK1yzkusmERLIOy1SLP6k=; b=pCiWssNExUqWC7NkEb29GpEpX9P2/363R3j2vLTlgbaUVJcYrDT8qCo9yPolann2m+ z4zFpWOUC+yKMLh2/stLJmp2cMje37jXGlZMJJIrewOGv3XV1Xoby5txxceKKWjHieca S7GGROnQlmIrtFkXy32SKFHouMp3mH/YPsoTxDS/eOpy3PvLzJbRVNoB54xHoJ+YInLr 8bghBfJZcq536P191/UU0F1rGddVyS9hmOlg4uPnxRlmtbjZC2JJIF8DjYQHejnqtXBl 6wJ+rf3bPAYk/11XZ3bLGttgNFoj6FEWd1fsqO4XnBt7dszNgJwEU1tOpRHT/sK8zkk3 Qh9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=X4wci52PlVRWn+r3Us2GufOK1yzkusmERLIOy1SLP6k=; b=tS3BiCwdrwF3obr2PQdvYMvECCJ8X9gCgh/5IYlmmyOouXLhcAz6qh3Zc67VWXlGEL EVC/YZ6HFni5vJPD6kPxQNByDVDqTJDTi726IcHcvQNGqKax7VhyBPAgBJe4sU6Luhct o+uj4021Sy+rmHep2ZhKRsSlnECtfiD/lAvxUFk+aGr9f16ctJ8ek8oqOKVWRZVQwKDK 1LEaYc1/jOsfwgwU2uLii9F1tBSYqa5LCs0NMYV3HgmGJhwHe9bmM08dJLf72i2EzJZx vTBrmfMO6ZUtGqRhnSUvIr1jlwIkwiAfKpOYEoSpKqNRXC9dXys7p2MeSjM5JTPQBKG8 ibew== X-Gm-Message-State: AIVw110Fm1Dy7YoqnGJGt9CGPHTdwNwXRABFTZ0Y/I9jTpJW0Dsc3XzG yPFmRHVSqqdl/w== X-Received: by 10.200.54.210 with SMTP id b18mr23441061qtc.145.1500920958786; Mon, 24 Jul 2017 11:29:18 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Riku Voipio , Laurent Vivier Date: Mon, 24 Jul 2017 15:27:40 -0300 Message-Id: <20170724182751.18261-25-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH for 2.10 24/35] linux-user/sh4: fix incorrect memory write X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 not hit since 2009! :) linux-user/elfload.c:1102:20: warning: Out of bound memory access (access e= xceeds upper limit of memory block) (*regs[i]) =3D tswap32(env->gregs[i]); ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier --- linux-user/elfload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 2a902f7806..79062882ba 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -1099,7 +1099,7 @@ static inline void elf_core_copy_regs(target_elf_greg= set_t *regs, int i; =20 for (i =3D 0; i < 16; i++) { - (*regs[i]) =3D tswapreg(env->gregs[i]); + (*regs)[i] =3D tswapreg(env->gregs[i]); } =20 (*regs)[TARGET_REG_PC] =3D tswapreg(env->pc); --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921897411297.9288395693902; Mon, 24 Jul 2017 11:44:57 -0700 (PDT) Received: from localhost ([::1]:56401 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiLg-0005TT-0p for importer@patchew.org; Mon, 24 Jul 2017 14:44:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6c-0000wE-UD for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6c-0005cA-4i for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:22 -0400 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:37496) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6c-0005bs-0g; Mon, 24 Jul 2017 14:29:22 -0400 Received: by mail-qt0-x243.google.com with SMTP id d10so1061665qtb.4; Mon, 24 Jul 2017 11:29:21 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.29.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:29:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eEsb9d9DMMsDb+v07eFkn9KBT980rxhrErx0C5zR0yA=; b=AXCYkYpepPVATDgst+C9tImmyI+CkUinrkAP8RowrpDl6LBVYXs/DM7mINigp8A9Ns 4N98fL+TDoyvYO3gtNRpcTKyhHkgfSAIAOlTDUD9wd58UY45zS3VvxCxSBLN5pzo+pBg Ucgh5tFzAwxTOQvOQNv/+JCOYeTtehIyB3G9bvVaKkhdsZOxOzmng6twEGZSws1inoX2 Hs+UfIBXcrJVPtLu6x0aJ/thAyAnHlKQxucBUgxXh/EXtE+oyOklu6UiG1Jew2cLEC2Y 7l89a+qvOM/2XKuzFpon2eDFTpM188YJgBt70AHpvFo0rASuV5a2THyPH7m9pD71sEmB pNOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=eEsb9d9DMMsDb+v07eFkn9KBT980rxhrErx0C5zR0yA=; b=PyDk6ffD8PumnPpyJ6TGjHaOvu7Gqmo0W28FmhpKWgXaUwBEAFLKCrxuLcNRiJpMbR KKHj/jEyBD2F5Iqn6wPjaoFnlaqG/34FyQ1AA+XZHSEnXgZe0xT5S7dHwn+tFprP1wnd eD0c+h5/1WzlRl9hjdC0ymJyHIYEfGbe0p7Gf2T1bycKJbIeYAR+68tDnaMu3PP3IN/P SAE1MDow320loikJKKQkkDXAnTFReWuihv7MWWBLeCT/YFphw036Rui0bUjkaf0NF8TD J1YwIVByWUqwK2kKKKfYLCR5hsL3FrOYDGGVXncknTi1YSZGTGWakQu0EyW7QZxSaK0Z Rj4w== X-Gm-Message-State: AIVw113P9rlEW9cmCbhbU3TDXsWn6NPnDzsRyp0Jt1ZFDeIZhRuBQf3U PBKLjWW0qMMmdg== X-Received: by 10.200.46.19 with SMTP id r19mr4610684qta.24.1500920961580; Mon, 24 Jul 2017 11:29:21 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Riku Voipio , Laurent Vivier Date: Mon, 24 Jul 2017 15:27:41 -0300 Message-Id: <20170724182751.18261-26-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH for 2.10 25/35] linux-user: extract is_error() out of syscall.c X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- linux-user/qemu.h | 5 +++++ linux-user/syscall.c | 5 ----- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/linux-user/qemu.h b/linux-user/qemu.h index 4edd7d0c08..97b7cfdb63 100644 --- a/linux-user/qemu.h +++ b/linux-user/qemu.h @@ -614,6 +614,11 @@ static inline void *lock_user_string(abi_ulong guest_a= ddr) =20 #include =20 +static inline int is_error(abi_long ret) +{ + return (abi_ulong)ret >=3D (abi_ulong)(-4096); +} + /* Include target-specific struct and function definitions; * they may need access to the target-independent structures * above, so include them last. diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 003943b736..fcd20fa276 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -837,11 +837,6 @@ static inline abi_long get_errno(abi_long ret) return ret; } =20 -static inline int is_error(abi_long ret) -{ - return (abi_ulong)ret >=3D (abi_ulong)(-4096); -} - const char *target_strerror(int err) { if (err =3D=3D TARGET_ERESTARTSYS) { --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500922675681539.6487804265881; Mon, 24 Jul 2017 11:57:55 -0700 (PDT) Received: from localhost ([::1]:56485 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiYD-00086n-VP for importer@patchew.org; Mon, 24 Jul 2017 14:57:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6g-00011R-GE for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6f-0005e7-Gd for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:26 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:35796) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6f-0005dp-BQ; Mon, 24 Jul 2017 14:29:25 -0400 Received: by mail-qk0-x241.google.com with SMTP id k2so3227132qkf.2; Mon, 24 Jul 2017 11:29:25 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.29.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:29:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cTPrwNR5Zh92wu/+TbrpewVtE8VS1FvcmNf5Q9/Fnek=; b=ulC5eaSiukVCEz6zyGNyU60m5eFnbYZCIBQBCRHUeGKCFBx0gv7amgZzBIcUtaMuac w7NkLbuX6R2a+9dMzupcwT37zrs1K2gyn2ZweOtmNYgHuRNiSjOzXKgOi/xFK93I4aam HBb3PwCqolNDJyCeJi4EynrpiSO3JSTRwJsYD1eFD/SO7ut6j36sVtiLGdJ1p9iOxdpr 087D/RqnqinP12HQEyyFHFEQa4SqYgMnjiZ71H7YoILDgFQtE/pLial20s+qNzCOQJCt QgXd/npbeS7c4uFXEp2AUXvjD20gNBqWavhwxrcl5JF+K8nWBfAgjKWao3YIXBMRHLZA AaFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=cTPrwNR5Zh92wu/+TbrpewVtE8VS1FvcmNf5Q9/Fnek=; b=GgSbc84T0clhnGm2n67uKyTMACHTgyBgrojcqZwRokza8pAJIJVFGLJMba6y7NiUK9 /vYZG4nyhR52IbK2ciKsREJOscSK4sLesiIhLsOzZlyfp6Z08buwoVwkTagR9owC/bmn vid5mxkYQXI9qXKBLlLBGpEM/95oJiEymWp1zeQQTeN8ZkhZSbzOBA8TC/AKygT2DGkJ O2+QBAU2aGFAD0UateBaDG5m3W9RirjpG/v65NKwy4VFLEeOQZudyWZXb52+vjiKR1Px RShjmzFP9Gph5mwJuHDiofAZxool1J+L5KbEJeHTclsXCt13StLtyqzwqGoI5wOQR2d5 qrFQ== X-Gm-Message-State: AIVw1106ngCpiRCaxE54lOBP8mnPIhb9rap40SvYNTtcGdCCg2QEaPol IA1QZcb0mGmxOA== X-Received: by 10.55.110.67 with SMTP id j64mr807725qkc.26.1500920964851; Mon, 24 Jul 2017 11:29:24 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Riku Voipio , Laurent Vivier Date: Mon, 24 Jul 2017 15:27:42 -0300 Message-Id: <20170724182751.18261-27-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH for 2.10 26/35] linux-user: use is_error() to avoid warnings and make the code clearer X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 linux-user/flatload.c:740:9: warning: Loss of sign in implicit conversion if (res > (unsigned long)-4096) ^~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier --- linux-user/flatload.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/linux-user/flatload.c b/linux-user/flatload.c index a35a560904..10c529910f 100644 --- a/linux-user/flatload.c +++ b/linux-user/flatload.c @@ -224,8 +224,9 @@ static int decompress_exec( ret =3D bprm->file->f_op->read(bprm->file, buf, LBUFSIZE, &fpos); if (ret <=3D 0) break; - if (ret >=3D (unsigned long) -4096) + if (is_error(ret)) { break; + } len -=3D ret; =20 strm.next_in =3D buf; @@ -283,8 +284,7 @@ calc_reloc(abi_ulong r, struct lib_info *p, int curid, = int internalp) "in same module (%d !=3D %d)\n", (unsigned) r, curid, id); goto failed; - } else if ( ! p[id].loaded && - load_flat_shared_library(id, p) > (unsigned long) -409= 6) { + } else if (!p[id].loaded && is_error(load_flat_shared_library(id, = p))) { fprintf(stderr, "BINFMT_FLAT: failed to load library %d\n", id= ); goto failed; } @@ -523,9 +523,10 @@ static int load_flat_file(struct linux_binprm * bprm, fpos =3D 0; result =3D bprm->file->f_op->read(bprm->file, (char *) textpos, text_len, &fpos); - if (result < (unsigned long) -4096) + if (!is_error(result)) { result =3D decompress_exec(bprm, text_len, (char *= ) datapos, data_len + (relocs * sizeof(unsig= ned long)), 0); + } } else #endif @@ -693,8 +694,9 @@ static int load_flat_shared_library(int id, struct lib_= info *libs) =20 res =3D prepare_binprm(&bprm); =20 - if (res <=3D (unsigned long)-4096) + if (!is_error(res)) { res =3D load_flat_file(&bprm, libs, id, NULL); + } if (bprm.file) { allow_write_access(bprm.file); fput(bprm.file); @@ -737,8 +739,9 @@ int load_flt_binary(struct linux_binprm *bprm, struct i= mage_info *info) =20 =20 res =3D load_flat_file(bprm, libinfo, 0, &stack_len); - if (res > (unsigned long)-4096) + if (is_error(res)) { return res; + } =20 /* Update data segment pointers for all libraries */ for (i=3D0; i Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921784743973.9106035094402; Mon, 24 Jul 2017 11:43:04 -0700 (PDT) Received: from localhost ([::1]:56387 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiJp-0003cQ-1s for importer@patchew.org; Mon, 24 Jul 2017 14:43:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6k-00015l-Nm for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6i-0005fL-BZ for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:30 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:34356) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6i-0005f6-6o; Mon, 24 Jul 2017 14:29:28 -0400 Received: by mail-qk0-x241.google.com with SMTP id q66so10664119qki.1; Mon, 24 Jul 2017 11:29:28 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.29.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:29:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=K2EV1ph+x6Th5Q8AnH30/ZlAelSrWZ4P64n3I0W12cc=; b=FekGyQtLYl8qxAkMTkk80Xm+jjzJGFUCemVDtuTFEMQgDFZpaGHbBm5y5ITi64tfMS dvTydf2374W7+4kPs+iQKSI6GBHNj0xMuInneNO/CvSmFJOz7sPtE9CwJjGncDrJu8i3 5+hPdHa12Cwbnm/WokAcgCOBHPQPWF82coZXPcDR+vMi0sbAzHGuLXbQdUd4JWD7oGTs BQ+LiEa4RgySuEIEQog5rcsU5Kq+ldh05oeZXJhO+XA1UlUQYmz2tcCMGvZuNFgk3Ayv 7jOWH74MQRakqcBW0tR6gKJI27fgQ7xjflHcGain08O0gAv3n4q6BJWUi3+6FZMyO5ar Jzqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=K2EV1ph+x6Th5Q8AnH30/ZlAelSrWZ4P64n3I0W12cc=; b=EfFe+OBvkTuQMoNPQDeS6yjUVEGcM9QbaWFO9u4wXMNbmdEJKhtheaTPbmZO3eZt7U dpUmWevbjxch/iwzbr2uEHbilj6falqX/duZH4XFbKr6S752lVc0A4ymCOGGgoZYPA/9 7FjqnaJsOKhCJm2KsvDSLYSSJTva0YJ0rFivYMuRzn2Css9io6QRtOn8ERZaVnttgydH C3PE/Xv4Rss1yYvcbKZMQnfKy1Q0+HSY5G+NciSQMBHRkjEKgQQX11A/nb1lH0MpIKAb Oa4ezPqToKHRauRimuxWbSvCfpqTVZJBAOTpO7MJlTr+30zM7BCOGmoyoZhP34IKA7t4 SJWA== X-Gm-Message-State: AIVw113UsIhzssGV1xnpfs/IWhXCfci9713BdLWG8Ge6Yg/MwfYLT3En 57ehTfO1R7ei8A== X-Received: by 10.55.33.77 with SMTP id h74mr22983735qkh.353.1500920967749; Mon, 24 Jul 2017 11:29:27 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Riku Voipio , Laurent Vivier Date: Mon, 24 Jul 2017 15:27:43 -0300 Message-Id: <20170724182751.18261-28-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH for 2.10 27/35] syscall: fix dereference of undefined pointer X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Clang's scan-build-5.0 reports: linux-user/syscall.c:5581:9: warning: Dereference of undefined pointer value if (*host_rt_dev_ptr !=3D 0) { ^~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Suggested-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- linux-user/syscall.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index fcd20fa276..e79b5baec4 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -5524,7 +5524,7 @@ static abi_long do_ioctl_rt(const IOCTLEntry *ie, uin= t8_t *buf_temp, int target_size; void *argptr; abi_ulong *target_rt_dev_ptr; - unsigned long *host_rt_dev_ptr; + unsigned long *host_rt_dev_ptr =3D NULL; abi_long ret; int i; =20 @@ -5570,6 +5570,7 @@ static abi_long do_ioctl_rt(const IOCTLEntry *ie, uin= t8_t *buf_temp, unlock_user(argptr, arg, 0); =20 ret =3D get_errno(safe_ioctl(fd, ie->host_cmd, buf_temp)); + assert(host_rt_dev_ptr); if (*host_rt_dev_ptr !=3D 0) { unlock_user((void *)*host_rt_dev_ptr, *target_rt_dev_ptr, 0); --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500922798231567.4289818705774; Mon, 24 Jul 2017 11:59:58 -0700 (PDT) Received: from localhost ([::1]:56493 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiaB-0001J0-Ne for importer@patchew.org; Mon, 24 Jul 2017 14:59:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6m-00016u-1Y for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6l-0005hu-4a for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:32 -0400 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:37863) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6l-0005hj-0t for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:31 -0400 Received: by mail-qk0-x243.google.com with SMTP id q130so10666159qka.4 for ; Mon, 24 Jul 2017 11:29:30 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.29.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KaUgENye2EGjniRWSXD17NdzKeuegYgR5zw6McFyH4o=; b=iNOhI7fmGEwdXfGjL/ZMuF4BPqfo7gUyGh+hegcBlUujU9c0m3CsddKefIpt0rGvqh VBYTJg7Sw3lX/eGpUWb/nUsCkqrfQoK+PF1KdSqwBjhATXdG17GQ5ny/Q6KrWfvyt9uX zx8kzolEr34S2b80iF/671k9peT56xzjRDL/gCaTMgiYg3YHupWQEtZ/bj3xdwdzlBJn /cemSjWJ5AIodcPPQAwiwLSuC9oCHFiB/d5ASuoIFVGyK5oAbkVLt63X6ebNbY+SBG/u CQgc3ebIuTZD0lsTlPm7O5BnZiQtOIVHifMdG2Pomudr2nHlOaiyFbibYUaZSCP12DG8 guwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=KaUgENye2EGjniRWSXD17NdzKeuegYgR5zw6McFyH4o=; b=Q6MCgXN/e3xzYz2rK86NnOYR9vLX2/P/qlkpqraLgCV8F1FHN80xeOw7bQEcqQPhcd AgdFx70FC3xUKg5YywU53etCsCJ2HkoVZHmhbBchGUnj5ho9oKo+AxQCdO+sFMAUQVkp XRUCvdaiwIApClHXgVFjodtXs9C7ViCJYGBuQQKIqStCmsimrzx6U3i0gaoTYNcrPhlA 8TcUigCKUDbJhsOgnC5Pj2KwatU8A1d5SBCOdRo55xZ1f0DZF1NFO8WsjlDXkzWBX83r G6Ew4qaOQpOr2ml74QWyRm0XFRCiKASA/eKnbi7UHEll6CuZ7uXCONBXGc1oeoDHmb6L XUrg== X-Gm-Message-State: AIVw112UkdUxyFtuPrkxS+NeQgK7n8ehMfgJwyTUukTb1MzIRl+z3syx djDWhyPHsjw7raNsFNi4LQ== X-Received: by 10.55.38.83 with SMTP id y80mr488936qkg.113.1500920970583; Mon, 24 Jul 2017 11:29:30 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Riku Voipio , Laurent Vivier Date: Mon, 24 Jul 2017 15:27:44 -0300 Message-Id: <20170724182751.18261-29-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::243 Subject: [Qemu-devel] [PATCH for 2.10 28/35] syscall: check dup/dup2/dup3() errors, return EBADFD/EINVAL if required X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Linux dup(2) manpage: ERRORS EBADF newfd is out of the allowed range for file descriptors (like negative) EINVAL (dup3()) oldfd was equal to newfd Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- linux-user/syscall.c | 32 +++++++++++++++++++++++--------- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index e79b5baec4..637270a02d 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -8336,9 +8336,13 @@ abi_long do_syscall(void *cpu_env, int num, abi_long= arg1, break; #endif case TARGET_NR_dup: - ret =3D get_errno(dup(arg1)); - if (ret >=3D 0) { - fd_trans_dup(arg1, ret); + if (arg1 < 0) { + ret =3D -TARGET_EBADFD; + } else { + ret =3D get_errno(dup(arg1)); + if (ret >=3D 0) { + fd_trans_dup(arg1, ret); + } } break; #ifdef TARGET_NR_pipe @@ -8436,17 +8440,27 @@ abi_long do_syscall(void *cpu_env, int num, abi_lon= g arg1, #endif #ifdef TARGET_NR_dup2 case TARGET_NR_dup2: - ret =3D get_errno(dup2(arg1, arg2)); - if (ret >=3D 0) { - fd_trans_dup(arg1, arg2); + if (arg1 < 0 || arg2 < 0) { + ret =3D -TARGET_EBADFD; + } else { + ret =3D get_errno(dup2(arg1, arg2)); + if (ret >=3D 0) { + fd_trans_dup(arg1, arg2); + } } break; #endif #if defined(CONFIG_DUP3) && defined(TARGET_NR_dup3) case TARGET_NR_dup3: - ret =3D get_errno(dup3(arg1, arg2, arg3)); - if (ret >=3D 0) { - fd_trans_dup(arg1, arg2); + if (arg1 < 0 || arg2 < 0) { + ret =3D -TARGET_EBADFD; + } else if (arg1 =3D=3D arg2) { + ret =3D -TARGET_EINVAL; + } else { + ret =3D get_errno(dup3(arg1, arg2, arg3)); + if (ret >=3D 0) { + fd_trans_dup(arg1, arg2); + } } break; #endif --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500922953266715.6499276305825; Mon, 24 Jul 2017 12:02:33 -0700 (PDT) Received: from localhost ([::1]:56511 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZicg-0003e8-Tf for importer@patchew.org; Mon, 24 Jul 2017 15:02:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50810) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6o-00019e-Nw for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6n-0005jt-U8 for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:34 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:34260) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6n-0005ji-Pj; Mon, 24 Jul 2017 14:29:33 -0400 Received: by mail-qt0-x244.google.com with SMTP id i19so2264078qte.1; Mon, 24 Jul 2017 11:29:33 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.29.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kd4Jew/zJE3yP4ur0TokL0/ky6LGLlhd6inO/dzDM28=; b=famKsP+PO3aWXmIOU62g/LjKDBT64fMK/kUS8vvcEm3dWAtIc8K3N325aRylqKlVQp yii9Xud/krcwisLTpDDejUWuv8WqRSoe2jgqpb4Tf0UNr67g7I8AJq1oDuSXQ4GSlivC XeU+JfDt3lunmASIOUtQ5IFTe4xxUaYda6uwTYoq6ImefkcktTiSSCbpBTRFnud145Lh iJlsFWQ/U3mHsF3fo/tz1orj55PZchd8pu5uR5idkoTcDfcnuTsrOPWSuX8y0uptmMoe X1Zvix437NJO7fwuX4ktRP/uWWue6T5sv9vjOqJJTSNzobve0V4tO40ZQHdArfyifKey K2ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=kd4Jew/zJE3yP4ur0TokL0/ky6LGLlhd6inO/dzDM28=; b=fAkwglibbiqwfr/HNcvUmCTInig+c/ztk9QxQjodd6GA/w9iL2rXSFQbeDFjyguj6v hKG4aLcwVwOAJ9LPUa3Zz2dfZC1JuAjV+T3lMxE9LASj3xs67DyLovp8fdKxCZO6Xqqs M+i8lW9FpBZnwu0PyWl4h0aT5MCEwAotDpWI9lBZTqDDMclmO/0N4wrkOG7hhKMt7nOo TiqRAFlbWw9yFFj7AESl5hOHDtj4mGIYBrnnQZYZe/dy/6wRITUNoUU/dk8FDJ6xbLUy TRhU82H46UVgW3wlNQJpdFbB/QVuQGbmg2jaBQ/e20WFbHVOs1q85g7xotQq1pJOJPzV EV4w== X-Gm-Message-State: AIVw110780E1KRGgSj6WND2N+EwOrV2rHo2VsYA52amjjtYuM9XlvMo1 m3PHqoZItLmU0Q== X-Received: by 10.200.54.210 with SMTP id b18mr23441921qtc.145.1500920973331; Mon, 24 Jul 2017 11:29:33 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Riku Voipio , Laurent Vivier Date: Mon, 24 Jul 2017 15:27:45 -0300 Message-Id: <20170724182751.18261-30-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH for 2.10 29/35] syscall: fix out-of-bound memory access X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 linux-user/syscall.c:555:25: warning: Out of bound memory access (accessed = memory precedes memory block) target_fd_trans[fd] =3D trans; ~~~~~~~~~~~~~~~~~~~~^~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 637270a02d..26450d235f 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -544,6 +544,7 @@ static void fd_trans_register(int fd, TargetFdTrans *tr= ans) { unsigned int oldmax; =20 + assert(fd >=3D 0); if (fd >=3D target_fd_max) { oldmax =3D target_fd_max; target_fd_max =3D ((fd >> 6) + 1) << 6; /* by slice of 64 entries = */ --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 150092228057981.66250607227596; Mon, 24 Jul 2017 11:51:20 -0700 (PDT) Received: from localhost ([::1]:56446 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiRr-0002PX-7j for importer@patchew.org; Mon, 24 Jul 2017 14:51:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6t-0001FT-MM for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6q-0005mo-Om for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:39 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:36307) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6q-0005m6-LB; Mon, 24 Jul 2017 14:29:36 -0400 Received: by mail-qt0-x241.google.com with SMTP id l55so12887240qtl.3; Mon, 24 Jul 2017 11:29:36 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.29.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:29:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qnbYYX+IG7GzYSOGIFhdBZxjwL/rUovFZSD0NbwCE1A=; b=JDyMQrqPvHDomUfbjjEd7QsYfpBQ4yNcl4AZiyOUnk9pQkc/JguXeKdNjw0WNmq9h5 T6P/ywoF96dL+P0l/6+INQ/rlxtwTXOqyYI3442G6j6t/lRSDll3caf7dswFGWmHRP13 EMQkqWJwgYbGs9IQ+W4LmvkjEF4zDVsc3kSbJIhtavo2Zre65Pcq6I9RZcoA3UaWioiV XoAUrz323EPIayJWH6pmX53f38f1w61K7T5x0bJxrSizH0ygS/THUJwdWkGXiibRTwVg ZV89QP7DpwBezmf4uQ3c4l/bdy8NwA5lmOYRsFPee9w8CfY5mcRTTEvpxC/mcqVqXRsO Xh8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=qnbYYX+IG7GzYSOGIFhdBZxjwL/rUovFZSD0NbwCE1A=; b=Ll+oXSVKOCKWjthWNzh6woBDWikkOn+oKuBBICkc09GtIOwOi1WdwNkJQoiw1oKm2S l5p0wZ979IMMgL8qRLq1RY1sAKdGZ56zbokeT6bN34MMyXkxQgVFDoGm+wnedp9ZSxX2 S/8ulpeKCD8qZcghngJ+jahgrWa5f1UORiR0tx/jywd3j26DuiRQkPSJRxPvTl4B71bH fpjxkaH8KBLdeUe4A+UKDd0UapHCBqhqhLMRrl4WJZK1wLyD+oHWfQyV6aTb2ZDx9jUN LZRWFwsXQSyt7f4CAp9aoJ6VUV70DyWR51yaLrhmouWcQupEmW9UNSauEOTJROC4w8H7 n3TA== X-Gm-Message-State: AIVw110JnxyVy8tNlC52691njwIM3RAUHWSMCE9BNzaJxd/JVY8C652F RkTyVh3Ui0B4YQ== X-Received: by 10.200.46.19 with SMTP id r19mr4611467qta.24.1500920976193; Mon, 24 Jul 2017 11:29:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Riku Voipio , Laurent Vivier Date: Mon, 24 Jul 2017 15:27:46 -0300 Message-Id: <20170724182751.18261-31-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH for 2.10 30/35] syscall: fix use of uninitialized values X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 linux-user/syscall.c:1627:35: warning: 1st function call argument is an uni= nitialized value target_saddr->sa_family =3D tswap16(addr->sa_family); ^~~~~~~~~~~~~~~~~~~~~~~~ linux-user/syscall.c:1629:25: warning: The left operand of '=3D=3D' is a ga= rbage value if (addr->sa_family =3D=3D AF_NETLINK && len >=3D sizeof(struct sockadd= r_nl)) { ~~~~~~~~~~~~~~~ ^ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 26450d235f..963b9c8f4b 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -1618,6 +1618,7 @@ static inline abi_long host_to_target_sockaddr(abi_ul= ong target_addr, if (len =3D=3D 0) { return 0; } + assert(addr); =20 target_saddr =3D lock_user(VERIFY_WRITE, target_addr, len, 0); if (!target_saddr) --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500922437199264.2246829232075; Mon, 24 Jul 2017 11:53:57 -0700 (PDT) Received: from localhost ([::1]:56457 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiUN-0004VN-To for importer@patchew.org; Mon, 24 Jul 2017 14:53:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6u-0001GD-Ej for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6t-0005r5-Ir for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:40 -0400 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:35995) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6t-0005qF-ED; Mon, 24 Jul 2017 14:29:39 -0400 Received: by mail-qk0-x242.google.com with SMTP id d136so10669133qkg.3; Mon, 24 Jul 2017 11:29:39 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.29.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=r4SmBG6aqSov+GTkrxTuziSft9NB2/8Kf7Nn7tgWLoA=; b=UETVGAKhedNolinXL22XREVvIGnQMxOJKDak71IWVBXyN5QzHQPpWkve5BXaKA03Zu 6ESTVWbq67TMUnBzBX/x62s/T1du63m/BLYYX8vr7eqqw1V2ZdrNsmDg3E6Y8sjW/yJE sUVVXu9ZQxH+xJcj9dt93iIUe+TNn6RdgdnGktWtHbZdL/aOU90rnJJAxIAukv2rIKXL Qr8DBjDV5H4TeNE8gCjjFWXpFoIKT83ZoU8qLYemeSiyp5WTPOWFRskjB8t05Hq43O60 03W2wiXSsPzROEaucqWcfggAzZzXl85AAFYneq3f82cEO2co/GBBm42TCSosrT589sJ0 GtXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=r4SmBG6aqSov+GTkrxTuziSft9NB2/8Kf7Nn7tgWLoA=; b=ic4T/jf1qEwfQHpoZ9d2R3Ol823oJs2MT9sVSu9aewKgbAEdkrsDAX0SaqniT9XMst ineYe6gNfkPCoiHXfGLDjNRahV6e/5jMmyUxynMVaUGQQtn32NCevdJVv+BYsgrsPefD UfpE25SizGhSWHtSb7G0CNprtIyp1WNCvLXimJSPEkCi2veedvFMS6KdCgO9+x1Oknag TgB4SuoNq64EzuAhkhIWtwagtOPZBPG0xOpJIlz9eA+uR/vLH94VMJ1uh65yAQSPaiGU e9/LDYR1IxhRdvvwjftLlwAX3VH6QgrPmyY3MNu8aw2RBNBgWQsNXl8rmC3FNVOhj4Sq MNyQ== X-Gm-Message-State: AIVw112qzgdyAxki2SJN/+uYtHzkOVXnu3VDDC46zK3qDP4TgSOtIP/M 62xfIc3QQ/WHqA== X-Received: by 10.55.158.12 with SMTP id h12mr20096792qke.258.1500920978927; Mon, 24 Jul 2017 11:29:38 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Riku Voipio , Laurent Vivier Date: Mon, 24 Jul 2017 15:27:47 -0300 Message-Id: <20170724182751.18261-32-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH for 2.10 31/35] syscall: replace strcpy() by g_strlcpy() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 linux-user/syscall.c:9860:17: warning: Call to function 'strcpy' is insecur= e as it does not provide bounding of the memory buffer. Replace unbounded c= opy functions with analogous functions that support length arguments such a= s 'strlcpy'. CWE-119 strcpy (buf->machine, cpu_to_uname_machine(cpu_env)); ^~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier --- linux-user/syscall.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 963b9c8f4b..847f729834 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -9853,7 +9853,8 @@ abi_long do_syscall(void *cpu_env, int num, abi_long = arg1, if (!is_error(ret)) { /* Overwrite the native machine name with whatever is being emulated. */ - strcpy (buf->machine, cpu_to_uname_machine(cpu_env)); + g_strlcpy(buf->machine, cpu_to_uname_machine(cpu_env), + sizeof(buf->machine)); /* Allow the user to override the reported release. */ if (qemu_uname_release && *qemu_uname_release) { g_strlcpy(buf->release, qemu_uname_release, --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500921957251151.6786025474205; Mon, 24 Jul 2017 11:45:57 -0700 (PDT) Received: from localhost ([::1]:56410 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiMc-0006Lv-Bf for importer@patchew.org; Mon, 24 Jul 2017 14:45:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi6x-0001JQ-B5 for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6w-0005uL-Iw for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:43 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:35818) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6w-0005tV-E5; Mon, 24 Jul 2017 14:29:42 -0400 Received: by mail-qk0-x241.google.com with SMTP id k2so3228145qkf.2; Mon, 24 Jul 2017 11:29:42 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.29.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UWSw22TstASCCRnAWr2GpU6Rn4GTeYUkN+RAWv+QDZY=; b=loSK60Ke2HcwAgqEWTQ7pZLTTBkf4FFUadFqC2Z6sHrU4fEJrBNsI+jtUmgVgjKZWt 1ZwLs1PO8n58sI0EHr9W/N4avxmgdVHnImwqbXZgNlc2eVwxnh6hjaj98/chZlEcqdL8 Fkbm6evBvFgS07QeVO5xttDNr5mKh36WNszn4IdLotdnBzGcmu+Xz0Yjao4n/tQlEora kbMIgwgTWfY7p6sOAgYh6vybT5ZlCKYX+oYlAxdq1l4CYBoCD1CKJ3caJctqfCUtWYup ZHGSvFUf7JBy6JgvIz/tRCWQQnagfMY9GMaLhk4BTgVfmngwrkQ7KDb2kzUjj99+N9LI srcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=UWSw22TstASCCRnAWr2GpU6Rn4GTeYUkN+RAWv+QDZY=; b=LQ9m7romUSdnd9CcbwBP/YtBQx4+YRRE73SQSjx881sj8BccY7wQ5jju6+wJVBDeNE u0mJoRfsyD7wz2KSZZrqOXOd3YQjbGBgMzmYbAfUzbe858c/+ZAaUywwLCBeCvupMTbr u4pmlEoWUeAby/4JC+6qPdcAaR/fcQgFH69+KpoZWsSn2qy8NXfvMaRprBqaN7dA2Yjk pQekIaKx/CccnA+wpWPuIx85lnahM4jt/rynGd/t5HYYn2w/5etPETLLxDxWbPwmAhR5 0eVhmNbCKjxBHm6rHu+w50LrSOelHv6Ed57Njalss81nkCNxqdjFzhLVQqJ3nImMuntp DREg== X-Gm-Message-State: AIVw113brsE5SxGm++QZez353XkZ5hKqAg9Puc4mBp2lJ3KvksTaYwsk 09Vv28WGer/Igw== X-Received: by 10.55.27.145 with SMTP id m17mr22091361qkh.298.1500920981978; Mon, 24 Jul 2017 11:29:41 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Andrzej Zaborowski Date: Mon, 24 Jul 2017 15:27:48 -0300 Message-Id: <20170724182751.18261-33-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH for 2.10 32/35] timer/pxa2xx: silent warning about out-of-bound memory access X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Unlikely to happen. hw/timer/pxa2xx_timer.c:145:19: warning: Out of bound memory access (access= ed memory precedes memory block) counter =3D counters[n]; ^~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/timer/pxa2xx_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/timer/pxa2xx_timer.c b/hw/timer/pxa2xx_timer.c index 68ba5a70b3..d47f463636 100644 --- a/hw/timer/pxa2xx_timer.c +++ b/hw/timer/pxa2xx_timer.c @@ -139,7 +139,7 @@ static void pxa2xx_timer_update4(void *opaque, uint64_t= now_qemu, int n) if (s->tm4[n].control & (1 << 7)) counter =3D n; else - counter =3D counters[n]; + counter =3D counters[n & 7]; =20 if (!s->tm4[counter].freq) { timer_del(s->tm4[n].tm.qtimer); --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500922093544779.8610990236134; Mon, 24 Jul 2017 11:48:13 -0700 (PDT) Received: from localhost ([::1]:56424 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiOo-0008Bw-90 for importer@patchew.org; Mon, 24 Jul 2017 14:48:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi72-0001OK-7P for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi6z-0005xY-46 for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:48 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:36318) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi6y-0005xP-W0 for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:45 -0400 Received: by mail-qt0-x241.google.com with SMTP id l55so12887552qtl.3 for ; Mon, 24 Jul 2017 11:29:44 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.29.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:29:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NTQLRQvK34OORLf6ayOZzOi00cllHUTtDxAVpFeB4ng=; b=lKSHdKFFiOdAhQ8NTe8rQzn2hAH1qx/Q7J4LGKua9qTluttJzDUeEAVeuffNZqhA9f uX5GQ6JszSxW19YDvbcjUYj+Cbz7YNJH2yvUeYY6EJS6I+j53M2rO74UEB3t8RNXlnEB NzGe2i68NbYYIc3bDv3QMADq85Ur0AGRThG34PsrMZuTCy3oU5a0QU+5uN59iHd3iz9/ J7541JQK89Sjb4apRg4aAt8EYUIkH+PkC0VpuI0q+4shT1/1I8Hb1o9jMtwHKcq+F3D6 e1VsPgcNu1z2vmNC+5NbFKd7bDgN11YZykjMbirEvnv6+QKBHC9QgbYqe+M8MQmA/9mB W0Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=NTQLRQvK34OORLf6ayOZzOi00cllHUTtDxAVpFeB4ng=; b=PU1tcI8433QCga96Fjc/MjJx3y7Mc40HSdgMVkh1G/hq105nefh4JUTsQu+QSkqanq 1hsY1f+D7pBeYTVDbS1YhD0S6sQD1h6JneWTRdMZDDP2ryYy5LViFWnb2fgIooX95yT4 HqkMyUCnLvo2SYksG0XshJfdkPwoHQhY0kW1aSFx7mnzD80xrH0umJLK/pU3kuQ+696V nAtGwOKH/TzLoHbVd26YjvBz6/kWdXhjiDQUN96sY05oN7116evo83gazCfpol2RmKlo cuZ81WjUMSGGFBKKszrLMLHfupBk/FgyfZE6rU0e3wM6KK24jMlOVR4G6ri4M3EIvkdi woCQ== X-Gm-Message-State: AIVw111YwBJ1fDzNni2xRTHCJeEHHuCX6fbC0cLk5GX6cjUfNs8MYjTl X2xCo8yBQbCr7w== X-Received: by 10.200.48.105 with SMTP id g38mr12040123qte.125.1500920984540; Mon, 24 Jul 2017 11:29:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Peter Maydell , Paolo Bonzini Date: Mon, 24 Jul 2017 15:27:49 -0300 Message-Id: <20170724182751.18261-34-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [RFC PATCH for 2.10 33/35] configure: clang does not support -Wexpansion-to-defined X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- configure | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 6b52e19ee3..48295aa1e6 100755 --- a/configure +++ b/configure @@ -1582,8 +1582,12 @@ gcc_flags=3D"-Wold-style-declaration -Wold-style-def= inition -Wtype-limits" gcc_flags=3D"-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifie= rs $gcc_flags" gcc_flags=3D"-Wno-missing-include-dirs -Wempty-body -Wnested-externs $gcc_= flags" gcc_flags=3D"-Wendif-labels -Wno-shift-negative-value $gcc_flags" -gcc_flags=3D"-Wno-initializer-overrides -Wexpansion-to-defined $gcc_flags" +gcc_flags=3D"-Wno-initializer-overrides $gcc_flags" gcc_flags=3D"-Wno-string-plus-int $gcc_flags" +# clang does not support -Wexpansion-to-defined +if ! echo | $cc -dM -E - | grep __clang__ > /dev/null 2>&1 ; then + gcc_flags=3D"-Wexpansion-to-defined $gcc_flags" +fi # Note that we do not add -Werror to gcc_flags here, because that would # enable it for all configure tests. If a configure test failed due # to -Werror this would just silently disable some features, --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500922257976436.0204520776722; Mon, 24 Jul 2017 11:50:57 -0700 (PDT) Received: from localhost ([::1]:56443 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiRT-00028G-4n for importer@patchew.org; Mon, 24 Jul 2017 14:50:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi73-0001Pc-IR for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi72-000637-D6 for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:49 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:32980) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi72-00062O-9R for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:48 -0400 Received: by mail-qt0-x241.google.com with SMTP id n42so3131636qtn.0 for ; Mon, 24 Jul 2017 11:29:48 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.29.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RUbNA4tly1QlSVcz6TwF1ssoVPb32G5hUsgoi/wPh4o=; b=cqVEMpH+VDnqFUHtTz5T7ZAIFe5FqLVrGNUA1SQAddRKPOOU2BUtdMQuYLLWcwL+wn eeBn4jYts3DFWof0R4RcpJ7oy89sn+uF6/esjBBGRtn0TZO7NjUIOkxCywkYPQ/+ZE6V C4PULZtD+52fFN/cmigEQxlypHkYOZX0fSuXYHfM5P/h1yOSqmyk7gLGE6CdbB+FaKO6 ZTsFHvQg2Yo7ClJ+QaJJQCYJG3K7YF+CcmqRSQtyIQulh3OVDSVK18ipyJMk1wsaYozD 7I+z9T92q/nKrt8DUIoeduVG5nSInGFNF4JAtrhX3xEJqBt6G3mU8GX7VuvREAcjePuJ sz1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=RUbNA4tly1QlSVcz6TwF1ssoVPb32G5hUsgoi/wPh4o=; b=MtHF5Pk3Qxs6SQaOKReAILlhOs+1FhqLboS2imOjakAu/2sYbrDoVTl0u2W4LkrWUr 1FwR3VuiWTEq2AYm6LQRdgwUMHM3SogdINDFTKVLsCT6Fz33Htvr2Zzh1lNLUA+R3UNQ assbHvTbG++WfZBFtBaCncOoKuKnS+GsjMwz+NnyHvY3JhKy7sZuUKReDwjzUTnNPdQF zKit4ipeBP6pcQhYplLQrhbQNDes2zSVkA2C31iHmHvl67Nx9eFJisr7wQVJJoeQR/Q6 Dmx0pPDROgeUPXmNDdpwumF1EsPfiYpCHpqWrcSD85O4bHT3y296l51UZGSNO2lQ0CgM TPmA== X-Gm-Message-State: AIVw112s8abFswnH8hvTMYeUHJfyNkF2yZykHPUCNamNBV562l/I5Gsn Cb13p1dwsQvwhA== X-Received: by 10.237.42.226 with SMTP id t89mr20706935qtd.242.1500920987794; Mon, 24 Jul 2017 11:29:47 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Fam Zheng Date: Mon, 24 Jul 2017 15:27:50 -0300 Message-Id: <20170724182751.18261-35-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [RFC PATCH for 2.10 34/35] docker: add debian 'bleeding' image with gcc7 and clang5 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- .../docker/dockerfiles/debian-bleeding-dev.docker | 94 ++++++++++++++++++= ++++ 1 file changed, 94 insertions(+) create mode 100644 tests/docker/dockerfiles/debian-bleeding-dev.docker diff --git a/tests/docker/dockerfiles/debian-bleeding-dev.docker b/tests/do= cker/dockerfiles/debian-bleeding-dev.docker new file mode 100644 index 0000000000..d6ae20692c --- /dev/null +++ b/tests/docker/dockerfiles/debian-bleeding-dev.docker @@ -0,0 +1,94 @@ +# +# Docker x86_64 bleeding image +# +# This docker target builds on the debian unstable base image. Further +# libraries which are not widely available are installed by hand. +# +FROM debian:unstable + +MAINTAINER Philippe Mathieu-Daud=C3=A9 + +RUN echo 'Acquire::ForceIPv4 "true";' >> /etc/apt/apt.conf.d/01network + +# Duplicate deb line as deb-src +RUN cat /etc/apt/sources.list | sed "s/^deb\ /deb-src /" >> /etc/apt/sourc= es.list + +# Install common build utilities +RUN apt-get update && \ + DEBIAN_FRONTEND=3Dnoninteractive apt-get install -yy eatmydata +RUN DEBIAN_FRONTEND=3Dnoninteractive eatmydata \ + apt-get install -y --no-install-recommends \ + bison \ + build-essential \ + ca-certificates \ + ccache \ + flex \ + git \ + less \ + pkg-config \ + psmisc \ + python \ + texinfo \ + $(apt-get -s build-dep qemu | egrep ^Inst | fgrep '[all]' | cut -d= \ -f2) + +RUN DEBIAN_FRONTEND=3Dnoninteractive eatmydata \ + apt-get install -y --no-install-recommends \ + binutils-multiarch \ + gdb-multiarch \ + libnewlib-dev \ + musl-dev \ + uclibc-source + +##########################################################################= ## +# GCC 7 + +RUN echo deb http://httpredir.debian.org/debian experimental main >> \ + /etc/apt/sources.list.d/experimental.list && apt-get update +RUN DEBIAN_FRONTEND=3Dnoninteractive eatmydata \ + apt-get install -y --no-install-recommends \ + gcc-7 \ + gcc-7-cross-base-ports \ + gcc-7-multilib \ + g++-7 + +##########################################################################= ## +# Clang 5 + +RUN DEBIAN_FRONTEND=3Dnoninteractive eatmydata \ + apt-get install -y --no-install-recommends \ + curl gnupg +RUN curl http://apt.llvm.org/llvm-snapshot.gpg.key | apt-key add - && \ + echo 'deb http://apt.llvm.org/unstable/ llvm-toolchain main' \ + > /etc/apt/sources.list.d/llvm.list && \ + apt-get update +RUN DEBIAN_FRONTEND=3Dnoninteractive eatmydata \ + apt-get install -y --no-install-recommends \ + clang-5.0 \ + lldb-5.0 \ + llvm-5.0 && \ + test -x /usr/bin/clang || ln -s clang-5.0 /usr/bin/clang + +##########################################################################= ## +# QEMU specific starts here + +RUN DEBIAN_FRONTEND=3Dnoninteractive eatmydata \ + apt-get build-dep -yy qemu + +RUN DEBIAN_FRONTEND=3Dnoninteractive eatmydata \ + apt-get install -y --no-install-recommends \ + libbz2-dev \ + liblzo2-dev \ + librdmacm-dev \ + libsnappy-dev \ + libvte-dev + +# virgl +RUN DEBIAN_FRONTEND=3Dnoninteractive eatmydata \ + apt-get install -y --no-install-recommends \ + libegl1-mesa-dev \ + libepoxy-dev \ + libgbm-dev +RUN git clone git://anongit.freedesktop.org/virglrenderer /usr/src/virglre= nderer +RUN cd /usr/src/virglrenderer && ./autogen.sh && ./configure --with-glx --= disable-tests && make install + +ENV QEMU_CONFIGURE_OPTS --host-cc=3Dclang-5.0 --cc=3Dclang-5.0 --cxx=3Dcla= ng++-5.0 --=20 2.13.3 From nobody Wed Oct 29 21:56:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500922148890524.525633893332; Mon, 24 Jul 2017 11:49:08 -0700 (PDT) Received: from localhost ([::1]:56427 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiPj-0000fP-Jc for importer@patchew.org; Mon, 24 Jul 2017 14:49:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZi76-0001SG-Ca for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZi75-000662-KC for qemu-devel@nongnu.org; Mon, 24 Jul 2017 14:29:52 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:36323) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZi75-00065o-GC; Mon, 24 Jul 2017 14:29:51 -0400 Received: by mail-qt0-x244.google.com with SMTP id l55so12887791qtl.3; Mon, 24 Jul 2017 11:29:51 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id t57sm9033799qtt.18.2017.07.24.11.29.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 11:29:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AfCcZSJYqRZF6Ur+KvtsZ+H8mfSHGJUablw83XGMtwE=; b=qeJYMYjv8gBz/6lD5HmHKL8rV7bgDgzhWE5JpnfAvzz4Ov4xwBnm8CGs5yrg5MsIFZ LM2143JKKNo0YTMUgqspdBtd/xCrEP7xguIhDx8mS+919aVgOuxfPpXQGCNPmKWLjG8X pT3ioHug/vjL9NqErNhmyxSMl8yS+yYsFUnpcE4Psf177pDOgdH1FbLY0vKtkK4RaKcQ 8Vli74GfzV5b7GZmU2F9uRKlPkDrYOsfSlIRZ6prh5FSi94DsGeB+Jbv9CHqsTFFdmvL FDXUyl+Fpi/NizMq2aGB0JjnaLMs2s5eiCd6AjDxQttBIqYecf8bd78COZ1QjE8zKMvb UJMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=AfCcZSJYqRZF6Ur+KvtsZ+H8mfSHGJUablw83XGMtwE=; b=H2BplDxLLYEc5lbEyBXRbG3II0UVHKYR4I+B51GixRp2JpVwh9cVfNigGpzZc/gNSo howxTM9y7lWOrKf4SyJbluBYsZ837oe3l71p3O2gmeFKF9ei7SLVlICQOHC/KKc1dD9D XNmuRPJXZZE1K1cxZmpJsahJ5nfvdZVuAZg055jc6Bx9Wr/7H6xEdBpZ4/FP3XJf6f4G iMepvv7FvGWZxLDJwK/7QZYfxlN/gv9HnHF0fx6UNomf5tyGOUu1+ki2vfxnrDy2prKl DBpfrJ6+b4uWC2WxEtDilrrO+27RtAnj2qq2wGJ1B2Wy7D08QYCE8QYi9SYO3W6mYG+k agmw== X-Gm-Message-State: AIVw1132y3lsdwMYDtUgreRktzyX3TMsivE5z4JSylrwa+4MGYtM7UN0 pWBBVHBd72VCGg== X-Received: by 10.200.9.27 with SMTP id t27mr21058235qth.107.1500920991061; Mon, 24 Jul 2017 11:29:51 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Fam Zheng Date: Mon, 24 Jul 2017 15:27:51 -0300 Message-Id: <20170724182751.18261-36-f4bug@amsat.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org> References: <20170724182751.18261-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [RFC PATCH for 2.10 35/35] script to run docker image X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- scripts/dockershell | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100755 scripts/dockershell diff --git a/scripts/dockershell b/scripts/dockershell new file mode 100755 index 0000000000..f6a2276172 --- /dev/null +++ b/scripts/dockershell @@ -0,0 +1,30 @@ +#! /bin/sh + +# This script starts a docker shell with QEMU directory mounted +# +# Copyright (C) 2017 Philippe Mathieu-Daud=C3=A9. GPLv2+. +# +# Usage: +# ./scripts/dockershell qemu:debian-bleeding-dev + +if [ $# -lt 1 ]; then + echo + echo "error: missing image name" + echo + docker images qemu --no-trunc --format=3D"- {{.Repository}}:{{.Tag}}" + exit 1 +fi + +SDIR=3D$(cd "$(dirname "$0")/.." && pwd -P) +CDIR=3D$(pwd -P) + +VOLS=3D"-v /tmp:/tmp" +if [ "${SDIR}" =3D "${CDIR}" ]; then + VOLS=3D"${VOLS} -v ${SDIR}:${SDIR} -w ${SDIR}" +else + VOLS=3D"${VOLS} -v ${SDIR}:${SDIR}:ro -v ${CDIR}:${CDIR} -w ${CDIR}" +fi + +docker run --rm -it ${VOLS} \ + -u $(id -u) \ + $1 --=20 2.13.3