From nobody Wed Nov 5 00:19:32 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500908956508925.3958472416223; Mon, 24 Jul 2017 08:09:16 -0700 (PDT) Received: from localhost ([::1]:55342 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZeyt-00040q-2U for importer@patchew.org; Mon, 24 Jul 2017 11:09:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZexx-0003So-A2 for qemu-devel@nongnu.org; Mon, 24 Jul 2017 11:08:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZext-0004bJ-OX for qemu-devel@nongnu.org; Mon, 24 Jul 2017 11:08:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46492) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dZext-0004bC-I1 for qemu-devel@nongnu.org; Mon, 24 Jul 2017 11:08:09 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1016B624CC; Mon, 24 Jul 2017 15:08:08 +0000 (UTC) Received: from dgilbert-t530.redhat.com (ovpn-117-120.ams2.redhat.com [10.36.117.120]) by smtp.corp.redhat.com (Postfix) with ESMTP id 52A758AC2A; Mon, 24 Jul 2017 15:08:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1016B624CC Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dgilbert@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1016B624CC From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, thuth@redhat.com, armbru@redhat.com, admin@manateeshome.com Date: Mon, 24 Jul 2017 16:08:05 +0100 Message-Id: <20170724150805.19563-1-dgilbert@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 24 Jul 2017 15:08:08 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2] hmp/(p)memsave: Allow >32bit file size X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" memsave and pmemsave only take 32bit size arguments in HMP at the moment; let them take 64bit values. Reported-by: Pierre Kim Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth --- hmp-commands.hx | 4 ++-- hmp.c | 13 +++++++++++-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 1941e19932..ddf77ae7ac 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -829,7 +829,7 @@ ETEXI =20 { .name =3D "memsave", - .args_type =3D "val:l,size:i,filename:s", + .args_type =3D "val:l,size:l,filename:s", .params =3D "addr size file", .help =3D "save to disk virtual memory dump starting at 'add= r' of size 'size'", .cmd =3D hmp_memsave, @@ -843,7 +843,7 @@ ETEXI =20 { .name =3D "pmemsave", - .args_type =3D "val:l,size:i,filename:s", + .args_type =3D "val:l,size:l,filename:s", .params =3D "addr size file", .help =3D "save to disk physical memory dump starting at 'ad= dr' of size 'size'", .cmd =3D hmp_pmemsave, diff --git a/hmp.c b/hmp.c index bf1de747d5..5118896779 100644 --- a/hmp.c +++ b/hmp.c @@ -1066,7 +1066,7 @@ void hmp_cpu(Monitor *mon, const QDict *qdict) =20 void hmp_memsave(Monitor *mon, const QDict *qdict) { - uint32_t size =3D qdict_get_int(qdict, "size"); + int64_t size =3D qdict_get_int(qdict, "size"); const char *filename =3D qdict_get_str(qdict, "filename"); uint64_t addr =3D qdict_get_int(qdict, "val"); Error *err =3D NULL; @@ -1076,6 +1076,10 @@ void hmp_memsave(Monitor *mon, const QDict *qdict) monitor_printf(mon, "No CPU available\n"); return; } + if (size <=3D 0) { + monitor_printf(mon, "Invalid size\n"); + return; + } =20 qmp_memsave(addr, size, filename, true, cpu_index, &err); hmp_handle_error(mon, &err); @@ -1083,11 +1087,16 @@ void hmp_memsave(Monitor *mon, const QDict *qdict) =20 void hmp_pmemsave(Monitor *mon, const QDict *qdict) { - uint32_t size =3D qdict_get_int(qdict, "size"); + int64_t size =3D qdict_get_int(qdict, "size"); const char *filename =3D qdict_get_str(qdict, "filename"); uint64_t addr =3D qdict_get_int(qdict, "val"); Error *err =3D NULL; =20 + if (size <=3D 0) { + monitor_printf(mon, "Invalid size\n"); + return; + } + qmp_pmemsave(addr, size, filename, &err); hmp_handle_error(mon, &err); } --=20 2.13.3