From nobody Wed Nov 5 02:55:35 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500647735404816.3958059303342; Fri, 21 Jul 2017 07:35:35 -0700 (PDT) Received: from localhost ([::1]:43520 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYZ1h-0008SG-UU for importer@patchew.org; Fri, 21 Jul 2017 10:35:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYYyF-00066J-7z for qemu-devel@nongnu.org; Fri, 21 Jul 2017 10:32:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYYyC-0001Z7-6H for qemu-devel@nongnu.org; Fri, 21 Jul 2017 10:31:59 -0400 Received: from mailhub.sw.ru ([195.214.232.25]:45277 helo=relay.sw.ru) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dYYyB-0001Vx-RO for qemu-devel@nongnu.org; Fri, 21 Jul 2017 10:31:56 -0400 Received: from kvm.sw.ru (msk-vpn.virtuozzo.com [195.214.232.6]) by relay.sw.ru (8.13.4/8.13.4) with ESMTP id v6LEVnhA023008; Fri, 21 Jul 2017 17:31:51 +0300 (MSK) From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Date: Fri, 21 Jul 2017 17:31:49 +0300 Message-Id: <20170721143149.43721-3-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.11.1 In-Reply-To: <20170721143149.43721-1-vsementsov@virtuozzo.com> References: <20170721143149.43721-1-vsementsov@virtuozzo.com> X-detected-operating-system: by eggs.gnu.org: OpenBSD 3.x [fuzzy] X-Received-From: 195.214.232.25 Subject: [Qemu-devel] [PATCH 2/2] monitor: improve tracing in handle_qmp_command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: den@openvz.org, vsementsov@virtuozzo.com, dgilbert@redhat.com, stefanha@redhat.com, armbru@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Calculate req_json only if trace_handle_qmp_command enabled. Signed-off-by: Vladimir Sementsov-Ogievskiy --- monitor.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 6d040e620f..3606a7928b 100644 --- a/monitor.c +++ b/monitor.c @@ -3823,7 +3823,7 @@ static void handle_qmp_command(JSONMessageParser *par= ser, GQueue *tokens) QDict *qdict =3D NULL; Monitor *mon =3D cur_mon; Error *err =3D NULL; - QString *req_json; + QString *req_json =3D NULL; =20 req =3D json_parser_parse_err(tokens, NULL, &err); if (!req && !err) { @@ -3841,8 +3841,8 @@ static void handle_qmp_command(JSONMessageParser *par= ser, GQueue *tokens) qdict_del(qdict, "id"); } /* else will fail qmp_dispatch() */ =20 - req_json =3D qobject_to_json(req); - trace_handle_qmp_command(mon, qstring_get_str(req_json)); + trace_handle_qmp_command(mon, + qstring_get_str(req_json =3D qobject_to_json(= req))); QDECREF(req_json); =20 rsp =3D qmp_dispatch(cur_mon->qmp.commands, req); --=20 2.11.1