From nobody Wed Nov 5 02:32:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500641819645712.5691340967182; Fri, 21 Jul 2017 05:56:59 -0700 (PDT) Received: from localhost ([::1]:42980 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYXUI-0003yf-Az for importer@patchew.org; Fri, 21 Jul 2017 08:56:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYXQD-0000rS-1R for qemu-devel@nongnu.org; Fri, 21 Jul 2017 08:52:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYXQB-0000dc-TP for qemu-devel@nongnu.org; Fri, 21 Jul 2017 08:52:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55274) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dYXQB-0000bt-Kb for qemu-devel@nongnu.org; Fri, 21 Jul 2017 08:52:43 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 940B04E33A for ; Fri, 21 Jul 2017 12:52:42 +0000 (UTC) Received: from vader.redhat.com (ovpn-116-236.ams2.redhat.com [10.36.116.236]) by smtp.corp.redhat.com (Postfix) with ESMTP id 004748B30B for ; Fri, 21 Jul 2017 12:52:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 940B04E33A Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=otubo@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 940B04E33A From: Eduardo Otubo To: qemu-devel@nongnu.org Date: Fri, 21 Jul 2017 14:52:33 +0200 Message-Id: <20170721125235.11939-5-otubo@redhat.com> In-Reply-To: <20170721125235.11939-1-otubo@redhat.com> References: <20170721125235.11939-1-otubo@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 21 Jul 2017 12:52:42 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 4/6] seccomp: add spawn argument to command line X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This patch adds [,spawn=3Ddeny] argument to `-sandbox on' option. It blacklists fork and execve system calls, avoiding Qemu to spawn new threads or processes. Signed-off-by: Eduardo Otubo --- include/sysemu/seccomp.h | 1 + qemu-options.hx | 9 ++++++--- qemu-seccomp.c | 19 +++++++++++++++++++ vl.c | 11 +++++++++++ 4 files changed, 37 insertions(+), 3 deletions(-) diff --git a/include/sysemu/seccomp.h b/include/sysemu/seccomp.h index e6e78d85ce..f1614d6514 100644 --- a/include/sysemu/seccomp.h +++ b/include/sysemu/seccomp.h @@ -17,6 +17,7 @@ =20 #define OBSOLETE 0x0001 #define PRIVILEGED 0x0010 +#define SPAWN 0x0100 =20 #include =20 diff --git a/qemu-options.hx b/qemu-options.hx index 34d33a812e..3d612f0fd1 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -4004,12 +4004,13 @@ Old param mode (ARM only). ETEXI =20 DEF("sandbox", HAS_ARG, QEMU_OPTION_sandbox, \ - "-sandbox on[,obsolete=3Dallow][,elevateprivileges=3Dallow|deny|childr= en] Enable seccomp mode 2 system call filter (default 'off').\n" \ + "-sandbox on[,obsolete=3Dallow][,elevateprivileges=3Dallow|deny|childr= en][,spawn=3Ddeny] Enable seccomp mode 2 system call filter (default 'off'= ).\n" \ " obsolete: Allow obsolete system calls\n" - " elevateprivileges: allows or denies Qemu process to e= levate its privileges by blacklisting all set*uid|gid system calls. 'childr= en' will deny set*uid|gid system calls for main Qemu process but will allow= forks and execves to run unprivileged\n", + " elevateprivileges: allows or denies Qemu process to e= levate its privileges by blacklisting all set*uid|gid system calls. 'childr= en' will deny set*uid|gid system calls for main Qemu process but will allow= forks and execves to run unprivileged\n" + " spawn: avoids Qemu to spawn new threads or processes = by blacklisting *fork and execve\n", QEMU_ARCH_ALL) STEXI -@item -sandbox @var{arg}[,obsolete=3D@var{string}][,elevateprivileges=3D@v= ar{string}] +@item -sandbox @var{arg}[,obsolete=3D@var{string}][,elevateprivileges=3D@v= ar{string}][,spawn=3D@var{string}] @findex -sandbox Enable Seccomp mode 2 system call filter. 'on' will enable syscall filteri= ng and 'off' will disable it. The default is 'off'. @@ -4018,6 +4019,8 @@ disable it. The default is 'off'. Enable Obsolete system calls @item elevateprivileges=3D@var{string} Disable set*uid|gid systema calls +@item spawn=3D@var{string} +Disable *fork and execve @end table ETEXI =20 diff --git a/qemu-seccomp.c b/qemu-seccomp.c index 6caa513edd..22a093ca1b 100644 --- a/qemu-seccomp.c +++ b/qemu-seccomp.c @@ -31,6 +31,12 @@ struct QemuSeccompSyscall { uint8_t priority; }; =20 +static const struct QemuSeccompSyscall spawn_syscalls[] =3D { + { SCMP_SYS(fork), 255 }, + { SCMP_SYS(vfork), 255 }, + { SCMP_SYS(execve), 255 }, +}; + static const struct QemuSeccompSyscall privileged_syscalls[] =3D { { SCMP_SYS(setuid), 255 }, { SCMP_SYS(setgid), 255 }, @@ -138,6 +144,19 @@ int seccomp_start(uint8_t seccomp_opts) } } =20 + if (seccomp_opts & SPAWN) { + for (i =3D 0; i < ARRAY_SIZE(spawn_syscalls); i++) { + rc =3D seccomp_rule_add(ctx, SCMP_ACT_KILL, spawn_syscalls[i].= num, 0); + if (rc < 0) { + goto seccomp_return; + } + rc =3D seccomp_syscall_priority(ctx, spawn_syscalls[i].num, + spawn_syscalls[i].priority); + if (rc < 0) { + goto seccomp_return; + } + } + } =20 rc =3D seccomp_load(ctx); =20 diff --git a/vl.c b/vl.c index f2b2f10b7b..ae3fa8b139 100644 --- a/vl.c +++ b/vl.c @@ -280,6 +280,10 @@ static QemuOptsList qemu_sandbox_opts =3D { .name =3D "elevateprivileges", .type =3D QEMU_OPT_STRING, }, + { + .name =3D "spawn", + .type =3D QEMU_OPT_STRING, + }, { /* end of list */ } }, }; @@ -1065,6 +1069,13 @@ static int parse_sandbox(void *opaque, QemuOpts *opt= s, Error **errp) } } =20 + value =3D qemu_opt_get(opts, "spawn"); + if (value) { + if (strcmp(value, "deny") =3D=3D 0) { + seccomp_opts |=3D SPAWN; + } + } + if (seccomp_start(seccomp_opts) < 0) { error_report("failed to install seccomp syscall filter " "in the kernel"); --=20 2.13.3