From nobody Mon Feb 9 17:36:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500440784924234.90368521551773; Tue, 18 Jul 2017 22:06:24 -0700 (PDT) Received: from localhost ([::1]:59927 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXhBn-0002Yz-Mm for importer@patchew.org; Wed, 19 Jul 2017 01:06:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXh3y-0003pK-J3 for qemu-devel@nongnu.org; Wed, 19 Jul 2017 00:58:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXh3v-0002H0-Hm for qemu-devel@nongnu.org; Wed, 19 Jul 2017 00:58:18 -0400 Received: from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]:35929) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXh3v-0002Gf-Bu for qemu-devel@nongnu.org; Wed, 19 Jul 2017 00:58:15 -0400 Received: by mail-pg0-x241.google.com with SMTP id y129so5430215pgy.3 for ; Tue, 18 Jul 2017 21:58:15 -0700 (PDT) Received: from bigtime.twiddle.net (14-203-207-215.tpgi.com.au. [14.203.207.215]) by smtp.gmail.com with ESMTPSA id m196sm9062855pga.33.2017.07.18.21.58.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Jul 2017 21:58:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xmqK69haKV+Y0rr2iV9dgMZIHe5YSUfTFmbRXGL7448=; b=pQdOrsp17UKMCBlcBkKWqBVyJyifGHTYKcZpD4xCX1e/rfUaoHN8uV25KjI4EW8Asc ladfhH/xtTeXncej0n+cDJUSZx51eM8ueSxi5MK8uJhcU+xLNzk+YvPvI8DiaGGEsvp4 DoeMrqvfRcP5Z9nuTcRkvv2nKrjn8fF7MP3uvl45leZnnu5WBBlIeAcZ47wBzCba15Cn OShtENcq9sLh5blr2DhjssBABo82jy1gjmTgQEASYZgk/ZHgslTiWgRy5Bqm/KoVGHyQ +VcwYbywMmnqEx9C5w8FkWtM8IpU8/k6eBBdSVYjkd2hRTMTzC+HPD196XRExXwFZSuX ErDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=xmqK69haKV+Y0rr2iV9dgMZIHe5YSUfTFmbRXGL7448=; b=mtkjILUTBADMEhqrp+gfa7xNyixp8l+9IbdBmp2Vkk7s+Xo+XpDSNKQKxQTfuAF3Cg tya0pp6aAKBlGHGOCBf7dBAoIAuCvtyD+o31zVjg+zjd5kT3OIH8SCP5SYz0NtuOcDTN y8iFX19mAkutJa004bEF/KGHpXTK3D9zeRKYBM7n0Fq2joJubFPQHKZ1Yidv4K5PsDNC hZBGiHeAQJfAELGWEM9KDzsGpKZlclL0Sca668ck3QLQIg1qt8zdwncS+VeqkrSyjChU rJzJiOUezVzng3znpuQS1NqIvRJiUtXgFh9CK/9kjYvOmzQIgsG4bMOPDln4b2ad6B3u kHzg== X-Gm-Message-State: AIVw113cVxfU6V5o+UhCGyZ77xvQuAFL95/nnOsV67xf7hAz8LNu/wij tPl4VdAvHn3mFuZE7FE= X-Received: by 10.84.229.1 with SMTP id b1mr1160338plk.273.1500440294206; Tue, 18 Jul 2017 21:58:14 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 18 Jul 2017 18:57:21 -1000 Message-Id: <20170719045722.25492-14-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170719045722.25492-1-rth@twiddle.net> References: <20170719045722.25492-1-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::241 Subject: [Qemu-devel] [PULL 13/14] tcg/tci: enable bswap16_i64 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jaroslaw Pelczar Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Philippe Mathieu-Daud=C3=A9 Altough correctly implemented, bswap16_i64() never got tested/executed so t= he safety TODO() statement was never removed. Since it got now tested the TODO() can be removed. while running Alex Benn=C3=A9e's image aarch64-linux-3.15rc2-buildroot.img: Trace 0x7fa1904b0890 [0: ffffffc00036cd04] Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Eric Blake Reviewed-by: Stefan Weil ---------------- IN: 0xffffffc00036cd24: 5ac00694 rev16 w20, w20 OP: ---- ffffffc00036cd24 0000000000000000 0000000000000000 ext32u_i64 tmp3,x20 ext16u_i64 tmp2,tmp3 bswap16_i64 x20,tmp2 movi_i64 tmp4,$0x10 shr_i64 tmp2,tmp3,tmp4 ext16u_i64 tmp2,tmp2 bswap16_i64 tmp2,tmp2 deposit_i64 x20,x20,tmp2,$0x10,$0x10 Linking TBs 0x7fa1904b0890 [ffffffc00036cd04] index 0 -> 0x7fa1904b0aa0 [ff= ffffc00036cd24] Trace 0x7fa1904b0aa0 [0: ffffffc00036cd24] TODO qemu/tci.c:1049: tcg_qemu_tb_exec() qemu/tci.c:1049: tcg fatal error Aborted Signed-off-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Jaroslaw Pelczar Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Eric Blake Reviewed-by: Stefan Weil Message-Id: <20170718045540.16322-11-f4bug@amsat.org> Signed-off-by: Richard Henderson --- tcg/tci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tcg/tci.c b/tcg/tci.c index 4bdc645..f39bfb9 100644 --- a/tcg/tci.c +++ b/tcg/tci.c @@ -1046,7 +1046,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t= *tb_ptr) break; #if TCG_TARGET_HAS_bswap16_i64 case INDEX_op_bswap16_i64: - TODO(); t0 =3D *tb_ptr++; t1 =3D tci_read_r16(&tb_ptr); tci_write_reg64(t0, bswap16(t1)); --=20 2.9.4