From nobody Mon Feb 9 16:12:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500408783293279.0707436679535; Tue, 18 Jul 2017 13:13:03 -0700 (PDT) Received: from localhost ([::1]:58388 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXYrb-0006fi-T9 for importer@patchew.org; Tue, 18 Jul 2017 16:12:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXYjE-0006dR-B5 for qemu-devel@nongnu.org; Tue, 18 Jul 2017 16:04:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXYjD-0004rE-H0 for qemu-devel@nongnu.org; Tue, 18 Jul 2017 16:04:20 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:32992) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXYjD-0004r2-D0 for qemu-devel@nongnu.org; Tue, 18 Jul 2017 16:04:19 -0400 Received: by mail-qk0-x244.google.com with SMTP id u126so2856721qka.0 for ; Tue, 18 Jul 2017 13:04:19 -0700 (PDT) Received: from bigtime.com ([101.165.234.197]) by smtp.gmail.com with ESMTPSA id b201sm2339817qkg.5.2017.07.18.13.04.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Jul 2017 13:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jVPdXvZmZFkEzSM0jPXSWMmtwPAZG9yF8483APMDEeU=; b=S1ConisxGUe50b5/QeyJUmWsQLBzGF/WSSnV94R45GDWs6sFEY7Y+AHgFn6sQwBP/I U2GYxvR7I9y4WKUt0xC9DK9e0EaNvL3+f88BphXxBa1c/oP5lUsdCutj1uyL4GG5rueC mWtaDiOE/cBzPyJKfFs/U/xqzjd1OaifVvrn7k8RaqsRNZqNJbQh5umBbQEuxYGAtH0U 2wl9trbucQt35N5KAst3lfVzTM/BkIpV1mmTGX30yj+A5QxpgP6Z807WIgsGmwzvJkhB TTxY+Nckw92WAqTaslRfrhpqBDFZdEmrxwrkp+OzM3eUjF+BdYv+NLi89D7z9an2TlKt iA+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=jVPdXvZmZFkEzSM0jPXSWMmtwPAZG9yF8483APMDEeU=; b=tqhhCUp9k4yCV+hWUiRt3kJLXX8qG5WywYDKdYOTiQCUZ51sAhCGylsxKxFYhg0oqY v8WBEVzmkd/8Yx3ao4z05HAdLLJlBxPxe2169shS9c5EDl+6sXR+DWoO13KxMJ56/cPI F73kgVFYE2wgunte5npnwsI9WRd4mCNAhvoZGRSiMoawL/R/C6FzgHmcehLpQ8Yl0skN k3BBtkqIjPC5jzI35OXLDCNfVvvLGhd5bnICwa6EdsBuQzL8ixookAkDS9e8dNuPKNI+ IRIRbJ+2mSdp4UcnFb0DsdK0q39xPB7OQzwyK/CtQ89BIYqZ7dz+tcbHajZu5N8P3nhk miIA== X-Gm-Message-State: AIVw111hZm2GgPeFp+QNLeFJ8px537q1rIFVlxuMQ7q6fG9Jzo0/1yNk 9K/2ORXJXchgOiuBTgo= X-Received: by 10.55.74.131 with SMTP id x125mr3995575qka.5.1500408258594; Tue, 18 Jul 2017 13:04:18 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 18 Jul 2017 10:02:44 -1000 Message-Id: <20170718200255.31647-20-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170718200255.31647-1-rth@twiddle.net> References: <20170718200255.31647-1-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH v3 19/30] target/sh4: Unify code for CHECK_PRIVILEGED X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aurelien@aurel32.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 We do not need to emit N copies of raising an exception. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/sh4/translate.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index b0a3d79..b40e52b 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -374,16 +374,9 @@ static inline void gen_store_fpr64(DisasContext *ctx, = TCGv_i64 t, int reg) goto do_illegal_slot; \ } =20 -#define CHECK_PRIVILEGED \ - if (IS_USER(ctx)) { \ - gen_save_cpu_state(ctx, true); \ - if (ctx->envflags & DELAY_SLOT_MASK) { \ - gen_helper_raise_slot_illegal_instruction(cpu_env); \ - } else { \ - gen_helper_raise_illegal_instruction(cpu_env); \ - } \ - ctx->bstate =3D BS_EXCP; \ - return; \ +#define CHECK_PRIVILEGED \ + if (IS_USER(ctx)) { \ + goto do_illegal; \ } =20 #define CHECK_FPU_ENABLED \ @@ -1805,6 +1798,7 @@ static void _decode_opc(DisasContext * ctx) ctx->opcode, ctx->pc); fflush(stderr); #endif + do_illegal: if (ctx->envflags & DELAY_SLOT_MASK) { do_illegal_slot: gen_save_cpu_state(ctx, true); --=20 2.9.4