From nobody Tue Feb 10 01:34:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500353897995704.7013491311623; Mon, 17 Jul 2017 21:58:17 -0700 (PDT) Received: from localhost ([::1]:53939 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXKaO-0006CV-O5 for importer@patchew.org; Tue, 18 Jul 2017 00:58:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXKYF-0004dJ-EY for qemu-devel@nongnu.org; Tue, 18 Jul 2017 00:56:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXKYC-0004DB-DK for qemu-devel@nongnu.org; Tue, 18 Jul 2017 00:56:03 -0400 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:33098) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXKYC-0004Cz-8r; Tue, 18 Jul 2017 00:56:00 -0400 Received: by mail-qk0-x243.google.com with SMTP id u126so310134qka.0; Mon, 17 Jul 2017 21:56:00 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id a62sm863698qkd.14.2017.07.17.21.55.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jul 2017 21:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jADw3En3egwY8rm7+Ysl4mFgnXpGilTku4AAI0IBduk=; b=nf0v9yK5oJP40LltdNJUpmvBR6A++UTp4bm7LJNlYsjUYxYmYiaMZAmvfxtytt0oiN erD+YQ8G//rIEL1EKHJo58mNphw5odC+kXn6g2JsRIQeGbfTMJa3kV0S4aqdK5/sCdfe ytYnS8vgJFzFQbay/jLYcLabVU4ZH11V8y+aJWgrqEsdnFGWeFHz+86uSQueZd6IGdMs 2Ufrn1Z9RQXkw9NdxFtJRqEBcXEusYjbwPBNzyAM6kz4TzoFY5aVDUtpkRYLdF+f8y6G hXgRCo8KSz/LvGQiuHKHFFiAQ3xtm0NsEPvEwuu5eNTnZzMAlQmxBzs/WkTDovFLUXKu uabg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=jADw3En3egwY8rm7+Ysl4mFgnXpGilTku4AAI0IBduk=; b=K30KpPLTm1rGL7VuP4bYP+7YHoByJMvg+vCetigYE3ekMTxOqgBErUEai+pumo2BuG tXkbVXd8wkgkRseWOzWw8iFCtdPY3BrbKFgf2rhx2LGZOu7gC/pOhHP/MK+l/jKCUdj8 VnLMzL/6CzulBu1y7TCYgoDLUV75hDCQv9GVuTn+rWfJTptpdBbpjmUKMuLuz9JLKoUs ff/GWLi0KIPDll8PY/MxediRyWxIYzrbzdc7ubzKppXYIgBxs4xCsPJXDIBv3DZUlSI8 kEir5oMcN4fOnfzXFGJR8J6bGBIlqDikquPQXMANLuGPGaPqAfrdle/9AhCQRDZ9wg10 xyMw== X-Gm-Message-State: AIVw110V8iNXvswWscSGHL1sq6JyO0paSnG14y+Zd5kLCS5zGhZuLPnm Y0bsA0mqZ1vATw== X-Received: by 10.55.19.138 with SMTP id 10mr1017189qkt.34.1500353759742; Mon, 17 Jul 2017 21:55:59 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Richard Henderson , Peter Maydell Date: Tue, 18 Jul 2017 01:55:33 -0300 Message-Id: <20170718045540.16322-4-f4bug@amsat.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170718045540.16322-1-f4bug@amsat.org> References: <20170718045540.16322-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::243 Subject: [Qemu-devel] [PATCH v5 03/10] target/arm: optimize aarch64 rev16() using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nikunj A Dadhania , qemu-devel@nongnu.org, Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Aurelien Jarno denoted this function could be implemented more effectively = using the aarch32 rev16() pattern. [http://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg03180.html] Done with the Coccinelle semantic patch from commit 58daf05d07dd (see scripts/coccinelle/tcg_gen_extract.cocci) Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- Richard: maybe you need to update 58daf05d07dd to your commit... target/arm/translate-a64.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index e55547d95d..8ade865481 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -4046,14 +4046,12 @@ static void handle_rev16(DisasContext *s, unsigned = int sf, tcg_gen_andi_i64(tcg_tmp, tcg_rn, 0xffff); tcg_gen_bswap16_i64(tcg_rd, tcg_tmp); =20 - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 16); - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); + tcg_gen_extract_i64(tcg_tmp, tcg_rn, 16, 16); tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 16, 16); =20 if (sf) { - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 32); - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); + tcg_gen_extract_i64(tcg_tmp, tcg_rn, 32, 16); tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 32, 16); =20 --=20 2.13.2