From nobody Tue Feb 10 03:39:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500354005239623.518166753415; Mon, 17 Jul 2017 22:00:05 -0700 (PDT) Received: from localhost ([::1]:53950 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXKc7-0008FT-Np for importer@patchew.org; Tue, 18 Jul 2017 01:00:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXKY9-0004Yz-Vp for qemu-devel@nongnu.org; Tue, 18 Jul 2017 00:55:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXKY8-0004BA-T9 for qemu-devel@nongnu.org; Tue, 18 Jul 2017 00:55:58 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:34650) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXKY8-0004Ab-OT for qemu-devel@nongnu.org; Tue, 18 Jul 2017 00:55:56 -0400 Received: by mail-qk0-x241.google.com with SMTP id q66so1228915qki.1 for ; Mon, 17 Jul 2017 21:55:56 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id a62sm863698qkd.14.2017.07.17.21.55.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jul 2017 21:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LqOJaRSNaJqJxOQPV1CGQlhtulvMvHmCWhcgriZlOTM=; b=rGYbGimXCOspF5CLK9cxlJCDBZDJSk7F6Wka57m5rLnhOYS3FXE4dAIFcOhSlSnaPt ulvyFG0etRUyv0HxPmNpihGcxCqe+PYduYQGzUfL1caeZBlqC+0bPLhWqNAvZGR47nTz ujFRDSajZBGaUkbKySEz5dsWPx8kyhl2Pr42ddSHI54cATz7IpQgOoTHtSPyCwgf64Wk Ldf7gLei+ThfVogjOETWL+m7ZUtBJnCl8mi1M1unthJZhEDa5D6noSGIG7h46PLtKlt+ Pd1F6gVVyEqjM/5van981CLcSfP/FCI7a++PVHO0BP9SGO4oC4MMM3S4UzgItfr97X// Y/PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=LqOJaRSNaJqJxOQPV1CGQlhtulvMvHmCWhcgriZlOTM=; b=P90Bclm+OOSFfzo/VEkwbknWehtGQbsVK2kJV8/OeVMuDhBJXXhGEKnzwgtOpT5TMo 0HSOQH0znj+KNUClaI0w7OAhsRuJrwuXwms1uU/XJROUfvJLMfNZIj8cohwFc7Cw/hq4 HekvYtjynzoKAh8lh+cYY8LXFFeHXmBacOLVGtUm2ZuUMYBdpmIYdWqvvFI4LKc2bm/j mjVmbmPFZm4LPbkYf8myVb2XyclpzXZ4FUG8XZeDVSrOYf7M4xPhGpM5mPFtC1WTAe1u qWY105NNyJU3lFgTZkplK1hiS9o2QYQw4quKjat6yaQVh8qHGyBxwC75FMy477X4goi9 vgkw== X-Gm-Message-State: AIVw110JjvBn0DPd85nnJH2GNJs+HusKgNgBWxC5QucWOHWX+4yW+401 CfUlGcyki3q75Q== X-Received: by 10.55.169.150 with SMTP id s144mr936289qke.115.1500353756068; Mon, 17 Jul 2017 21:55:56 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Richard Henderson Date: Tue, 18 Jul 2017 01:55:32 -0300 Message-Id: <20170718045540.16322-3-f4bug@amsat.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170718045540.16322-1-f4bug@amsat.org> References: <20170718045540.16322-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH v5 02/10] coccinelle: add a script to optimize tcg op using tcg_gen_extract() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Nikunj A Dadhania , qemu-devel@nongnu.org, Markus Armbruster , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 The following thread was helpful while writing this script: https://github.com/coccinelle/coccinelle/issues/86 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- scripts/coccinelle/tcg_gen_extract.cocci | 107 +++++++++++++++++++++++++++= ++++ 1 file changed, 107 insertions(+) create mode 100644 scripts/coccinelle/tcg_gen_extract.cocci diff --git a/scripts/coccinelle/tcg_gen_extract.cocci b/scripts/coccinelle/= tcg_gen_extract.cocci new file mode 100644 index 0000000000..81e66a35ae --- /dev/null +++ b/scripts/coccinelle/tcg_gen_extract.cocci @@ -0,0 +1,107 @@ +// optimize TCG using extract op +// +// Copyright: (C) 2017 Philippe Mathieu-Daud=C3=A9. GPLv2+. +// Confidence: High +// Options: --macro-file scripts/cocci-macro-file.h +// +// Nikunj A Dadhania optimization: +// http://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg05211.html +// Aurelien Jarno optimization: +// http://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg01466.html +// +// This script can be run either using spatch locally or via a docker imag= e: +// +// $ spatch \ +// --macro-file scripts/cocci-macro-file.h \ +// --sp-file scripts/coccinelle/tcg_gen_extract.cocci \ +// --keep-comments --in-place \ +// --use-gitgrep --dir target +// +// $ docker run --rm -v `pwd`:`pwd` -w `pwd` philmd/coccinelle \ +// --macro-file scripts/cocci-macro-file.h \ +// --sp-file scripts/coccinelle/tcg_gen_extract.cocci \ +// --keep-comments --in-place \ +// --use-gitgrep --dir target + +@initialize:python@ +@@ +import sys +fd =3D sys.stderr +def debug(msg=3D"", trailer=3D"\n"): + fd.write("[DBG] " + msg + trailer) +def low_bits_count(value): + bits_count =3D 0 + while (value & (1 << bits_count)): + bits_count +=3D 1 + return bits_count +def Mn(order): # Mersenne number + return (1 << order) - 1 + +@match@ +identifier ret; +metavariable arg; +constant ofs, msk; +position shr_p, and_p; +@@ +( + tcg_gen_shri_i32@shr_p +| + tcg_gen_shri_i64@shr_p +| + tcg_gen_shri_tl@shr_p +)(ret, arg, ofs); +... WHEN !=3D ret +( + tcg_gen_andi_i32@and_p +| + tcg_gen_andi_i64@and_p +| + tcg_gen_andi_tl@and_p +)(ret, ret, msk); + +@script:python verify_len depends on match@ +ret_s << match.ret; +msk_s << match.msk; +shr_p << match.shr_p; +extract_len; +@@ +is_optimizable =3D False +debug("candidate at %s:%s" % (shr_p[0].file, shr_p[0].line)) +try: # only eval integer, no #define like 'SR_M' (cpp did this, else some = headers are missing). + msk_v =3D long(msk_s.strip("UL"), 0) + msk_b =3D low_bits_count(msk_v) + if msk_b =3D=3D 0: + debug(" value: 0x%x low_bits: %d" % (msk_v, msk_b)) + else: + debug(" value: 0x%x low_bits: %d [Mersenne number: 0x%x]" % (msk_= v, msk_b, Mn(msk_b))) + is_optimizable =3D Mn(msk_b) =3D=3D msk_v # check low_bits + coccinelle.extract_len =3D "%d" % msk_b + debug(" candidate %s optimizable" % ("IS" if is_optimizable else "is = NOT")) +except: + debug(" ERROR (check included headers?)") +cocci.include_match(is_optimizable) +debug() + +@replacement depends on verify_len@ +identifier match.ret; +metavariable match.arg; +constant match.ofs, match.msk; +position match.shr_p, match.and_p; +identifier verify_len.extract_len; +@@ +( +-tcg_gen_shri_i32@shr_p(ret, arg, ofs); ++tcg_gen_extract_i32(ret, arg, ofs, extract_len); +... WHEN !=3D ret +-tcg_gen_andi_i32@and_p(ret, ret, msk); +| +-tcg_gen_shri_i64@shr_p(ret, arg, ofs); ++tcg_gen_extract_i64(ret, arg, ofs, extract_len); +... WHEN !=3D ret +-tcg_gen_andi_i64@and_p(ret, ret, msk); +| +-tcg_gen_shri_tl@shr_p(ret, arg, ofs); ++tcg_gen_extract_tl(ret, arg, ofs, extract_len); +... WHEN !=3D ret +-tcg_gen_andi_tl@and_p(ret, ret, msk); +) --=20 2.13.2