From nobody Tue Feb 10 03:40:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500354293888640.4780755315777; Mon, 17 Jul 2017 22:04:53 -0700 (PDT) Received: from localhost ([::1]:53980 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXKgl-0004BX-PU for importer@patchew.org; Tue, 18 Jul 2017 01:04:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXKYc-0004xW-7M for qemu-devel@nongnu.org; Tue, 18 Jul 2017 00:56:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXKYb-0004V1-Be for qemu-devel@nongnu.org; Tue, 18 Jul 2017 00:56:26 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:33402) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXKYb-0004Ud-7H for qemu-devel@nongnu.org; Tue, 18 Jul 2017 00:56:25 -0400 Received: by mail-qt0-x241.google.com with SMTP id 50so156084qtz.0 for ; Mon, 17 Jul 2017 21:56:25 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.223]) by smtp.gmail.com with ESMTPSA id a62sm863698qkd.14.2017.07.17.21.56.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jul 2017 21:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F5RojC8DsaARc76Io7spcgdQjGqwJYIvGyICxDMkYIg=; b=PySfqqaC4aGqiSQTELoHYF52VnynqEcLwrvXOf2jqaGUmkZDGrf3MQ43AB+NkTnO2d Qww5hV62bKw7sy+yTz5KraJSN0uMGn/3e5UJYsFys1R25IZFy86NeYFW6iUm0BRB6sVo HvaQsTWqOiTzYN9T8EKKB+EVDv2OjFuK4YR0D/irDoPl6sT/UtJQZ6RrEDXr9vX/tS1P Mw+BDSqs5CKmsKdbjhNG+WbHymDcLh29/zhGJHG+EvhrarmDJFcMY3YFQOKH1pJ3VwX2 KXhE4oN9c0PkoMWtotvOufnxDZxWT0KMqSknJ0rLdi0+Hce0FMNOtKnsxCnJr8bzdoMs z0yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=F5RojC8DsaARc76Io7spcgdQjGqwJYIvGyICxDMkYIg=; b=gavH3kkZ5h2Fwp12VqtA0mezBrwqIQRqklT5kB7bVmTPD3KJXKcQY5pNpHI112zh36 yLyvNCxQ9LoHh8tcbYhFkaoVk6y1DkcifmTWPbTHXBTFghK4a9+XKf6h4XgrWMr8sdlN U0KY/H828GGYgOuRcif71oYWzbKGqUvJzTP9r421URmijSG11jdUuR+UGNj/u0t8lFNG 34DFxlldRIyfFYqIWA5ahLHyMzI72cZca635BFZoqIM/dDJWzW+r4OMOtpSH3DMNXHai yLtLymyl9Gui4Iv65uNBgIDf1sT1cJzjheQ/o5AOK7U4RWYqfSXQc614Dv/exBp09oGS 4utQ== X-Gm-Message-State: AIVw110cIq9P5BS3jEGIwF3++vRhRtfhabMgXvDKlyVonxsg95pI0c1c eodhszHjIoA0kQ== X-Received: by 10.237.48.65 with SMTP id 59mr1171405qte.10.1500353784703; Mon, 17 Jul 2017 21:56:24 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Richard Henderson , Jaroslaw Pelczar , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Eric Blake , Stefan Weil Date: Tue, 18 Jul 2017 01:55:40 -0300 Message-Id: <20170718045540.16322-11-f4bug@amsat.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170718045540.16322-1-f4bug@amsat.org> References: <20170718045540.16322-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH v5 10/10] tcg/tci: enable bswap16_i64 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Altough correctly implemented, bswap16_i64() never got tested/executed so t= he safety TODO() statement was never removed. Since it got now tested the TODO() can be removed. while running Alex Benn=C3=A9e's image aarch64-linux-3.15rc2-buildroot.img: Trace 0x7fa1904b0890 [0: ffffffc00036cd04] Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Eric Blake Reviewed-by: Stefan Weil ---------------- IN: 0xffffffc00036cd24: 5ac00694 rev16 w20, w20 OP: ---- ffffffc00036cd24 0000000000000000 0000000000000000 ext32u_i64 tmp3,x20 ext16u_i64 tmp2,tmp3 bswap16_i64 x20,tmp2 movi_i64 tmp4,$0x10 shr_i64 tmp2,tmp3,tmp4 ext16u_i64 tmp2,tmp2 bswap16_i64 tmp2,tmp2 deposit_i64 x20,x20,tmp2,$0x10,$0x10 Linking TBs 0x7fa1904b0890 [ffffffc00036cd04] index 0 -> 0x7fa1904b0aa0 [ff= ffffc00036cd24] Trace 0x7fa1904b0aa0 [0: ffffffc00036cd24] TODO qemu/tci.c:1049: tcg_qemu_tb_exec() qemu/tci.c:1049: tcg fatal error Aborted Signed-off-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Jaroslaw Pelczar Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Eric Blake Reviewed-by: Stefan Weil --- tcg/tci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tcg/tci.c b/tcg/tci.c index 4bdc645f2a..f39bfb95c0 100644 --- a/tcg/tci.c +++ b/tcg/tci.c @@ -1046,7 +1046,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t= *tb_ptr) break; #if TCG_TARGET_HAS_bswap16_i64 case INDEX_op_bswap16_i64: - TODO(); t0 =3D *tb_ptr++; t1 =3D tci_read_r16(&tb_ptr); tci_write_reg64(t0, bswap16(t1)); --=20 2.13.2